======================================================
WARNING: possible circular locking dependency detected
6.6.0-rc2-syzkaller-00246-gc070e51db5e2 #0 Not tainted
------------------------------------------------------
syz-executor.2/3837 is trying to acquire lock:
ffff88802af55088 (&priv->active_session_list_lock){+.-.}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:356 [inline]
ffff88802af55088 (&priv->active_session_list_lock){+.-.}-{2:2}, at: j1939_session_list_lock net/can/j1939/transport.c:238 [inline]
ffff88802af55088 (&priv->active_session_list_lock){+.-.}-{2:2}, at: j1939_session_activate+0x4b/0x4a0 net/can/j1939/transport.c:1564

but task is already holding lock:
ffff88814ad675c8 (&jsk->sk_session_queue_lock){+.-.}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:356 [inline]
ffff88814ad675c8 (&jsk->sk_session_queue_lock){+.-.}-{2:2}, at: j1939_sk_queue_activate_next+0x60/0x4d0 net/can/j1939/socket.c:207

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (&jsk->sk_session_queue_lock){+.-.}-{2:2}:
       __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline]
       _raw_spin_lock_bh+0x33/0x40 kernel/locking/spinlock.c:178
       spin_lock_bh include/linux/spinlock.h:356 [inline]
       j1939_sk_queue_drop_all+0x3b/0x2f0 net/can/j1939/socket.c:139
       j1939_sk_netdev_event_netdown+0x7f/0x160 net/can/j1939/socket.c:1282
       j1939_netdev_notify+0x1a2/0x1d0 net/can/j1939/main.c:381
       notifier_call_chain+0xb6/0x3b0 kernel/notifier.c:93
       call_netdevice_notifiers_info+0xb9/0x130 net/core/dev.c:1970
       call_netdevice_notifiers_extack net/core/dev.c:2008 [inline]
       call_netdevice_notifiers net/core/dev.c:2022 [inline]
       __dev_notify_flags+0x1f5/0x2e0 net/core/dev.c:8638
       dev_change_flags+0x122/0x170 net/core/dev.c:8674
       do_setlink+0x1a2a/0x3fa0 net/core/rtnetlink.c:2880
       __rtnl_newlink+0xc1d/0x1940 net/core/rtnetlink.c:3671
       rtnl_newlink+0x67/0xa0 net/core/rtnetlink.c:3718
       rtnetlink_rcv_msg+0x3c4/0xdf0 net/core/rtnetlink.c:6444
       netlink_rcv_skb+0x16b/0x440 net/netlink/af_netlink.c:2545
       netlink_unicast_kernel net/netlink/af_netlink.c:1342 [inline]
       netlink_unicast+0x536/0x810 net/netlink/af_netlink.c:1368
       netlink_sendmsg+0x93c/0xe40 net/netlink/af_netlink.c:1910
       sock_sendmsg_nosec net/socket.c:730 [inline]
       sock_sendmsg+0xd9/0x180 net/socket.c:753
       ____sys_sendmsg+0x6ac/0x940 net/socket.c:2541
       ___sys_sendmsg+0x135/0x1d0 net/socket.c:2595
       __sys_sendmsg+0x117/0x1e0 net/socket.c:2624
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x38/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

-> #1 (&priv->j1939_socks_lock){+.-.}-{2:2}:
       __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline]
       _raw_spin_lock_bh+0x33/0x40 kernel/locking/spinlock.c:178
       spin_lock_bh include/linux/spinlock.h:356 [inline]
       j1939_sk_errqueue+0xaa/0x1a0 net/can/j1939/socket.c:1083
       j1939_session_destroy+0x276/0x4f0 net/can/j1939/transport.c:271
       __j1939_session_release net/can/j1939/transport.c:294 [inline]
       kref_put include/linux/kref.h:65 [inline]
       j1939_session_put net/can/j1939/transport.c:299 [inline]
       j1939_session_deactivate_locked net/can/j1939/transport.c:1086 [inline]
       j1939_session_deactivate_locked+0x28c/0x330 net/can/j1939/transport.c:1074
       j1939_cancel_active_session+0x183/0x360 net/can/j1939/transport.c:2194
       j1939_netdev_notify+0x19a/0x1d0 net/can/j1939/main.c:380
       notifier_call_chain+0xb6/0x3b0 kernel/notifier.c:93
       call_netdevice_notifiers_info+0xb9/0x130 net/core/dev.c:1970
       call_netdevice_notifiers_extack net/core/dev.c:2008 [inline]
       call_netdevice_notifiers net/core/dev.c:2022 [inline]
       __dev_notify_flags+0x1f5/0x2e0 net/core/dev.c:8638
       dev_change_flags+0x122/0x170 net/core/dev.c:8674
       do_setlink+0x1a2a/0x3fa0 net/core/rtnetlink.c:2880
       __rtnl_newlink+0xc1d/0x1940 net/core/rtnetlink.c:3671
       rtnl_newlink+0x67/0xa0 net/core/rtnetlink.c:3718
       rtnetlink_rcv_msg+0x3c4/0xdf0 net/core/rtnetlink.c:6444
       netlink_rcv_skb+0x16b/0x440 net/netlink/af_netlink.c:2545
       netlink_unicast_kernel net/netlink/af_netlink.c:1342 [inline]
       netlink_unicast+0x536/0x810 net/netlink/af_netlink.c:1368
       netlink_sendmsg+0x93c/0xe40 net/netlink/af_netlink.c:1910
       sock_sendmsg_nosec net/socket.c:730 [inline]
       sock_sendmsg+0xd9/0x180 net/socket.c:753
       ____sys_sendmsg+0x6ac/0x940 net/socket.c:2541
       ___sys_sendmsg+0x135/0x1d0 net/socket.c:2595
       __sys_sendmsg+0x117/0x1e0 net/socket.c:2624
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x38/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

-> #0 (&priv->active_session_list_lock){+.-.}-{2:2}:
       check_prev_add kernel/locking/lockdep.c:3134 [inline]
       check_prevs_add kernel/locking/lockdep.c:3253 [inline]
       validate_chain kernel/locking/lockdep.c:3868 [inline]
       __lock_acquire+0x2e3d/0x5de0 kernel/locking/lockdep.c:5136
       lock_acquire kernel/locking/lockdep.c:5753 [inline]
       lock_acquire+0x1ae/0x510 kernel/locking/lockdep.c:5718
       __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline]
       _raw_spin_lock_bh+0x33/0x40 kernel/locking/spinlock.c:178
       spin_lock_bh include/linux/spinlock.h:356 [inline]
       j1939_session_list_lock net/can/j1939/transport.c:238 [inline]
       j1939_session_activate+0x4b/0x4a0 net/can/j1939/transport.c:1564
       j1939_sk_queue_activate_next_locked net/can/j1939/socket.c:181 [inline]
       j1939_sk_queue_activate_next+0x2bc/0x4d0 net/can/j1939/socket.c:208
       j1939_session_deactivate_activate_next net/can/j1939/transport.c:1108 [inline]
       j1939_session_completed+0xb7/0x170 net/can/j1939/transport.c:1222
       j1939_xtp_rx_eoma_one net/can/j1939/transport.c:1395 [inline]
       j1939_xtp_rx_eoma+0x293/0x600 net/can/j1939/transport.c:1410
       j1939_tp_cmd_recv net/can/j1939/transport.c:2099 [inline]
       j1939_tp_recv+0x718/0xf50 net/can/j1939/transport.c:2144
       j1939_can_recv+0x78b/0xa70 net/can/j1939/main.c:112
       deliver net/can/af_can.c:572 [inline]
       can_rcv_filter+0x2a5/0x8e0 net/can/af_can.c:606
       can_receive+0x31b/0x5c0 net/can/af_can.c:663
       can_rcv+0x1dc/0x270 net/can/af_can.c:687
       __netif_receive_skb_one_core+0x115/0x180 net/core/dev.c:5523
       __netif_receive_skb+0x1f/0x1b0 net/core/dev.c:5637
       process_backlog+0x101/0x6b0 net/core/dev.c:5965
       __napi_poll.constprop.0+0xb4/0x530 net/core/dev.c:6527
       napi_poll net/core/dev.c:6594 [inline]
       net_rx_action+0x956/0xe90 net/core/dev.c:6727
       __do_softirq+0x218/0x965 kernel/softirq.c:553
       do_softirq kernel/softirq.c:454 [inline]
       do_softirq+0xaa/0xe0 kernel/softirq.c:441
       __local_bh_enable_ip+0xf8/0x120 kernel/softirq.c:381
       sock_orphan include/net/sock.h:2098 [inline]
       netlink_release+0x923/0x1f90 net/netlink/af_netlink.c:760
       __sock_release+0xae/0x260 net/socket.c:659
       sock_close+0x1c/0x20 net/socket.c:1402
       __fput+0x3f7/0xa70 fs/file_table.c:384
       task_work_run+0x14d/0x240 kernel/task_work.c:179
       exit_task_work include/linux/task_work.h:38 [inline]
       do_exit+0xa92/0x2a20 kernel/exit.c:874
       do_group_exit+0xd4/0x2a0 kernel/exit.c:1024
       get_signal+0x23ba/0x2790 kernel/signal.c:2892
       arch_do_signal_or_restart+0x90/0x7f0 arch/x86/kernel/signal.c:309
       exit_to_user_mode_loop kernel/entry/common.c:168 [inline]
       exit_to_user_mode_prepare+0x11f/0x240 kernel/entry/common.c:204
       __syscall_exit_to_user_mode_work kernel/entry/common.c:285 [inline]
       syscall_exit_to_user_mode+0x1d/0x60 kernel/entry/common.c:296
       do_syscall_64+0x44/0xb0 arch/x86/entry/common.c:86
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

other info that might help us debug this:

Chain exists of:
  &priv->active_session_list_lock --> &priv->j1939_socks_lock --> &jsk->sk_session_queue_lock

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&jsk->sk_session_queue_lock);
                               lock(&priv->j1939_socks_lock);
                               lock(&jsk->sk_session_queue_lock);
  lock(&priv->active_session_list_lock);

 *** DEADLOCK ***

4 locks held by syz-executor.2/3837:
 #0: ffff888032942010 (&sb->s_type->i_mutex_key#10){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:802 [inline]
 #0: ffff888032942010 (&sb->s_type->i_mutex_key#10){+.+.}-{3:3}, at: __sock_release+0x86/0x260 net/socket.c:658
 #1: ffffffff8cbab2e0 (rcu_read_lock){....}-{1:2}, at: rcu_lock_acquire include/linux/rcupdate.h:303 [inline]
 #1: ffffffff8cbab2e0 (rcu_read_lock){....}-{1:2}, at: rcu_read_lock include/linux/rcupdate.h:749 [inline]
 #1: ffffffff8cbab2e0 (rcu_read_lock){....}-{1:2}, at: process_backlog+0x25d/0x6b0 net/core/dev.c:5964
 #2: ffffffff8cbab2e0 (rcu_read_lock){....}-{1:2}, at: rcu_lock_acquire include/linux/rcupdate.h:303 [inline]
 #2: ffffffff8cbab2e0 (rcu_read_lock){....}-{1:2}, at: rcu_read_lock include/linux/rcupdate.h:749 [inline]
 #2: ffffffff8cbab2e0 (rcu_read_lock){....}-{1:2}, at: can_receive+0x216/0x5c0 net/can/af_can.c:656
 #3: ffff88814ad675c8 (&jsk->sk_session_queue_lock){+.-.}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:356 [inline]
 #3: ffff88814ad675c8 (&jsk->sk_session_queue_lock){+.-.}-{2:2}, at: j1939_sk_queue_activate_next+0x60/0x4d0 net/can/j1939/socket.c:207

stack backtrace:
CPU: 1 PID: 3837 Comm: syz-executor.2 Not tainted 6.6.0-rc2-syzkaller-00246-gc070e51db5e2 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/06/2023
Call Trace:
 <IRQ>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0xd9/0x1b0 lib/dump_stack.c:106
 check_noncircular+0x311/0x3f0 kernel/locking/lockdep.c:2187
 check_prev_add kernel/locking/lockdep.c:3134 [inline]
 check_prevs_add kernel/locking/lockdep.c:3253 [inline]
 validate_chain kernel/locking/lockdep.c:3868 [inline]
 __lock_acquire+0x2e3d/0x5de0 kernel/locking/lockdep.c:5136
 lock_acquire kernel/locking/lockdep.c:5753 [inline]
 lock_acquire+0x1ae/0x510 kernel/locking/lockdep.c:5718
 __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline]
 _raw_spin_lock_bh+0x33/0x40 kernel/locking/spinlock.c:178
 spin_lock_bh include/linux/spinlock.h:356 [inline]
 j1939_session_list_lock net/can/j1939/transport.c:238 [inline]
 j1939_session_activate+0x4b/0x4a0 net/can/j1939/transport.c:1564
 j1939_sk_queue_activate_next_locked net/can/j1939/socket.c:181 [inline]
 j1939_sk_queue_activate_next+0x2bc/0x4d0 net/can/j1939/socket.c:208
 j1939_session_deactivate_activate_next net/can/j1939/transport.c:1108 [inline]
 j1939_session_completed+0xb7/0x170 net/can/j1939/transport.c:1222
 j1939_xtp_rx_eoma_one net/can/j1939/transport.c:1395 [inline]
 j1939_xtp_rx_eoma+0x293/0x600 net/can/j1939/transport.c:1410
 j1939_tp_cmd_recv net/can/j1939/transport.c:2099 [inline]
 j1939_tp_recv+0x718/0xf50 net/can/j1939/transport.c:2144
 j1939_can_recv+0x78b/0xa70 net/can/j1939/main.c:112
 deliver net/can/af_can.c:572 [inline]
 can_rcv_filter+0x2a5/0x8e0 net/can/af_can.c:606
 can_receive+0x31b/0x5c0 net/can/af_can.c:663
 can_rcv+0x1dc/0x270 net/can/af_can.c:687
 __netif_receive_skb_one_core+0x115/0x180 net/core/dev.c:5523
 __netif_receive_skb+0x1f/0x1b0 net/core/dev.c:5637
 process_backlog+0x101/0x6b0 net/core/dev.c:5965
 __napi_poll.constprop.0+0xb4/0x530 net/core/dev.c:6527
 napi_poll net/core/dev.c:6594 [inline]
 net_rx_action+0x956/0xe90 net/core/dev.c:6727
 __do_softirq+0x218/0x965 kernel/softirq.c:553
 do_softirq kernel/softirq.c:454 [inline]
 do_softirq+0xaa/0xe0 kernel/softirq.c:441
 </IRQ>
 <TASK>
 __local_bh_enable_ip+0xf8/0x120 kernel/softirq.c:381
 sock_orphan include/net/sock.h:2098 [inline]
 netlink_release+0x923/0x1f90 net/netlink/af_netlink.c:760
 __sock_release+0xae/0x260 net/socket.c:659
 sock_close+0x1c/0x20 net/socket.c:1402
 __fput+0x3f7/0xa70 fs/file_table.c:384
 task_work_run+0x14d/0x240 kernel/task_work.c:179
 exit_task_work include/linux/task_work.h:38 [inline]
 do_exit+0xa92/0x2a20 kernel/exit.c:874
 do_group_exit+0xd4/0x2a0 kernel/exit.c:1024
 get_signal+0x23ba/0x2790 kernel/signal.c:2892
 arch_do_signal_or_restart+0x90/0x7f0 arch/x86/kernel/signal.c:309
 exit_to_user_mode_loop kernel/entry/common.c:168 [inline]
 exit_to_user_mode_prepare+0x11f/0x240 kernel/entry/common.c:204
 __syscall_exit_to_user_mode_work kernel/entry/common.c:285 [inline]
 syscall_exit_to_user_mode+0x1d/0x60 kernel/entry/common.c:296
 do_syscall_64+0x44/0xb0 arch/x86/entry/common.c:86
 entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7f738f87cae9
Code: Unable to access opcode bytes at 0x7f738f87cabf.
RSP: 002b:00007ffdc6866ea8 EFLAGS: 00000246 ORIG_RAX: 00000000000000ca
RAX: fffffffffffffdfc RBX: 0000000000157a0f RCX: 00007f738f87cae9
RDX: 0000000000000000 RSI: 0000000000000080 RDI: 00007f738f99c1fc
RBP: 0000000000000032 R08: 00007f738f99c1fc R09: 00007f738f99c1fc
R10: 00007ffdc6866fe0 R11: 0000000000000246 R12: 00007f738f99c1fc
R13: 0000000000157a41 R14: 00007ffdc6867000 R15: 00007ffdc6866fe0
 </TASK>
vxcan1: j1939_xtp_rx_dat: no tx connection found
vxcan1: j1939_xtp_rx_dat: no rx connection found
vxcan1: j1939_session_tx_dat: 0xffff88807a29cc00: queue data error: -100
vxcan1: j1939_session_tx_dat: 0xffff8880214bd800: queue data error: -100