====================================================== WARNING: possible circular locking dependency detected 6.1.91-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.3/9898 is trying to acquire lock: ffff88814b6383f8 (&journal->j_checkpoint_mutex){+.+.}-{3:3}, at: __jbd2_log_wait_for_space+0x213/0x760 fs/jbd2/checkpoint.c:71 but task is already holding lock: ffff8880558a0400 (&sb->s_type->i_mutex_key#8){++++}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline] ffff8880558a0400 (&sb->s_type->i_mutex_key#8){++++}-{3:3}, at: ext4_dio_write_checks fs/ext4/file.c:439 [inline] ffff8880558a0400 (&sb->s_type->i_mutex_key#8){++++}-{3:3}, at: ext4_dio_write_iter fs/ext4/file.c:507 [inline] ffff8880558a0400 (&sb->s_type->i_mutex_key#8){++++}-{3:3}, at: ext4_file_write_iter+0xba9/0x1880 fs/ext4/file.c:677 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&sb->s_type->i_mutex_key#8){++++}-{3:3}: lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 down_read+0xad/0xa30 kernel/locking/rwsem.c:1520 inode_lock_shared include/linux/fs.h:768 [inline] ext4_bmap+0x4b/0x410 fs/ext4/inode.c:3176 bmap+0xa1/0xd0 fs/inode.c:1842 jbd2_journal_bmap fs/jbd2/journal.c:977 [inline] __jbd2_journal_erase fs/jbd2/journal.c:1794 [inline] jbd2_journal_flush+0x5b5/0xc40 fs/jbd2/journal.c:2496 ext4_ioctl_checkpoint fs/ext4/ioctl.c:1086 [inline] __ext4_ioctl fs/ext4/ioctl.c:1594 [inline] ext4_ioctl+0x3986/0x5f60 fs/ext4/ioctl.c:1614 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:870 [inline] __se_sys_ioctl+0xf1/0x160 fs/ioctl.c:856 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 -> #0 (&journal->j_checkpoint_mutex){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049 lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 __mutex_lock_common kernel/locking/mutex.c:603 [inline] mutex_lock_io_nested+0x134/0xab0 kernel/locking/mutex.c:833 __jbd2_log_wait_for_space+0x213/0x760 fs/jbd2/checkpoint.c:71 add_transaction_credits fs/jbd2/transaction.c:298 [inline] start_this_handle+0x1040/0x21b0 fs/jbd2/transaction.c:422 jbd2__journal_start+0x2d1/0x5c0 fs/jbd2/transaction.c:520 __ext4_journal_start_sb+0x19b/0x410 fs/ext4/ext4_jbd2.c:105 __ext4_journal_start fs/ext4/ext4_jbd2.h:326 [inline] ext4_dirty_inode+0x8b/0x100 fs/ext4/inode.c:6069 __mark_inode_dirty+0x331/0xf80 fs/fs-writeback.c:2433 generic_update_time fs/inode.c:1903 [inline] inode_update_time fs/inode.c:1916 [inline] __file_update_time+0x221/0x240 fs/inode.c:2104 file_modified_flags+0x3e1/0x480 fs/inode.c:2177 ext4_dio_write_checks fs/ext4/file.c:443 [inline] ext4_dio_write_iter fs/ext4/file.c:507 [inline] ext4_file_write_iter+0x117a/0x1880 fs/ext4/file.c:677 do_iter_write+0x6e6/0xc50 fs/read_write.c:861 iter_file_splice_write+0x830/0xfc0 fs/splice.c:685 do_splice_from fs/splice.c:763 [inline] direct_splice_actor+0xe3/0x1c0 fs/splice.c:950 splice_direct_to_actor+0x4c7/0xc30 fs/splice.c:896 do_splice_direct+0x2a5/0x3e0 fs/splice.c:1002 do_sendfile+0x61c/0xff0 fs/read_write.c:1255 __do_sys_sendfile64 fs/read_write.c:1323 [inline] __se_sys_sendfile64+0x178/0x1e0 fs/read_write.c:1309 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&sb->s_type->i_mutex_key#8); lock(&journal->j_checkpoint_mutex); lock(&sb->s_type->i_mutex_key#8); lock(&journal->j_checkpoint_mutex); *** DEADLOCK *** 2 locks held by syz-executor.3/9898: #0: ffff888028034460 (sb_writers#4){.+.+}-{0:0}, at: do_sendfile+0x5f7/0xff0 fs/read_write.c:1254 #1: ffff8880558a0400 (&sb->s_type->i_mutex_key#8){++++}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline] #1: ffff8880558a0400 (&sb->s_type->i_mutex_key#8){++++}-{3:3}, at: ext4_dio_write_checks fs/ext4/file.c:439 [inline] #1: ffff8880558a0400 (&sb->s_type->i_mutex_key#8){++++}-{3:3}, at: ext4_dio_write_iter fs/ext4/file.c:507 [inline] #1: ffff8880558a0400 (&sb->s_type->i_mutex_key#8){++++}-{3:3}, at: ext4_file_write_iter+0xba9/0x1880 fs/ext4/file.c:677 stack backtrace: CPU: 1 PID: 9898 Comm: syz-executor.3 Not tainted 6.1.91-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 04/02/2024 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106 check_noncircular+0x2fa/0x3b0 kernel/locking/lockdep.c:2170 check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049 lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 __mutex_lock_common kernel/locking/mutex.c:603 [inline] mutex_lock_io_nested+0x134/0xab0 kernel/locking/mutex.c:833 __jbd2_log_wait_for_space+0x213/0x760 fs/jbd2/checkpoint.c:71 add_transaction_credits fs/jbd2/transaction.c:298 [inline] start_this_handle+0x1040/0x21b0 fs/jbd2/transaction.c:422 jbd2__journal_start+0x2d1/0x5c0 fs/jbd2/transaction.c:520 __ext4_journal_start_sb+0x19b/0x410 fs/ext4/ext4_jbd2.c:105 __ext4_journal_start fs/ext4/ext4_jbd2.h:326 [inline] ext4_dirty_inode+0x8b/0x100 fs/ext4/inode.c:6069 __mark_inode_dirty+0x331/0xf80 fs/fs-writeback.c:2433 generic_update_time fs/inode.c:1903 [inline] inode_update_time fs/inode.c:1916 [inline] __file_update_time+0x221/0x240 fs/inode.c:2104 file_modified_flags+0x3e1/0x480 fs/inode.c:2177 ext4_dio_write_checks fs/ext4/file.c:443 [inline] ext4_dio_write_iter fs/ext4/file.c:507 [inline] ext4_file_write_iter+0x117a/0x1880 fs/ext4/file.c:677 do_iter_write+0x6e6/0xc50 fs/read_write.c:861 iter_file_splice_write+0x830/0xfc0 fs/splice.c:685 do_splice_from fs/splice.c:763 [inline] direct_splice_actor+0xe3/0x1c0 fs/splice.c:950 splice_direct_to_actor+0x4c7/0xc30 fs/splice.c:896 do_splice_direct+0x2a5/0x3e0 fs/splice.c:1002 do_sendfile+0x61c/0xff0 fs/read_write.c:1255 __do_sys_sendfile64 fs/read_write.c:1323 [inline] __se_sys_sendfile64+0x178/0x1e0 fs/read_write.c:1309 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 RIP: 0033:0x7fb180c7cee9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007fb1819520c8 EFLAGS: 00000246 ORIG_RAX: 0000000000000028 RAX: ffffffffffffffda RBX: 00007fb180dabf80 RCX: 00007fb180c7cee9 RDX: 0000000000000000 RSI: 0000000000000003 RDI: 0000000000000003 RBP: 00007fb180cc949e R08: 0000000000000000 R09: 0000000000000000 R10: 0000000800000009 R11: 0000000000000246 R12: 0000000000000000 R13: 000000000000000b R14: 00007fb180dabf80 R15: 00007ffe605f8078