vxcan1: j1939_xtp_rx_abort_one: 0xffff888079b49000: 0x00000: (8) Duplicate sequence number (and software is not able to recover) ====================================================== WARNING: possible circular locking dependency detected 6.2.0-rc8-syzkaller-00083-g3ac88fa4605e #0 Not tainted ------------------------------------------------------ ksoftirqd/1/21 is trying to acquire lock: ffff888078d59088 (&priv->active_session_list_lock){+.-.}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:355 [inline] ffff888078d59088 (&priv->active_session_list_lock){+.-.}-{2:2}, at: j1939_session_list_lock net/can/j1939/transport.c:238 [inline] ffff888078d59088 (&priv->active_session_list_lock){+.-.}-{2:2}, at: j1939_session_activate+0x47/0x4b0 net/can/j1939/transport.c:1557 but task is already holding lock: ffff88801c64c5c8 (&jsk->sk_session_queue_lock){+.-.}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:355 [inline] ffff88801c64c5c8 (&jsk->sk_session_queue_lock){+.-.}-{2:2}, at: j1939_sk_queue_activate_next+0x5f/0x450 net/can/j1939/socket.c:207 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&jsk->sk_session_queue_lock){+.-.}-{2:2}: __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline] _raw_spin_lock_bh+0x33/0x40 kernel/locking/spinlock.c:178 spin_lock_bh include/linux/spinlock.h:355 [inline] j1939_sk_queue_drop_all+0x3b/0x2f0 net/can/j1939/socket.c:139 j1939_sk_netdev_event_netdown+0x7f/0x160 net/can/j1939/socket.c:1275 j1939_netdev_notify+0x19d/0x1d0 net/can/j1939/main.c:379 notifier_call_chain+0xb5/0x200 kernel/notifier.c:87 call_netdevice_notifiers_info+0xb5/0x130 net/core/dev.c:1936 call_netdevice_notifiers_extack net/core/dev.c:1974 [inline] call_netdevice_notifiers net/core/dev.c:1988 [inline] __dev_notify_flags+0x1ea/0x2d0 net/core/dev.c:8563 dev_change_flags+0x11b/0x170 net/core/dev.c:8599 do_setlink+0x9f1/0x3bb0 net/core/rtnetlink.c:2827 __rtnl_newlink+0xd69/0x1840 net/core/rtnetlink.c:3590 rtnl_newlink+0x68/0xa0 net/core/rtnetlink.c:3637 rtnetlink_rcv_msg+0x43e/0xca0 net/core/rtnetlink.c:6141 netlink_rcv_skb+0x165/0x440 net/netlink/af_netlink.c:2574 netlink_unicast_kernel net/netlink/af_netlink.c:1339 [inline] netlink_unicast+0x547/0x7f0 net/netlink/af_netlink.c:1365 netlink_sendmsg+0x91b/0xe10 net/netlink/af_netlink.c:1942 sock_sendmsg_nosec net/socket.c:714 [inline] sock_sendmsg+0xd3/0x120 net/socket.c:734 ____sys_sendmsg+0x712/0x8c0 net/socket.c:2479 ___sys_sendmsg+0x110/0x1b0 net/socket.c:2533 __sys_sendmsg+0xf7/0x1c0 net/socket.c:2562 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #1 (&priv->j1939_socks_lock){+.-.}-{2:2}: __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline] _raw_spin_lock_bh+0x33/0x40 kernel/locking/spinlock.c:178 spin_lock_bh include/linux/spinlock.h:355 [inline] j1939_sk_errqueue+0xa3/0x1a0 net/can/j1939/socket.c:1081 __j1939_session_cancel+0x3b9/0x460 net/can/j1939/transport.c:1128 j1939_session_cancel net/can/j1939/transport.c:1139 [inline] j1939_xtp_rx_cts_one net/can/j1939/transport.c:1464 [inline] j1939_xtp_rx_cts+0xabc/0x11b0 net/can/j1939/transport.c:1477 j1939_tp_cmd_recv net/can/j1939/transport.c:2062 [inline] j1939_tp_recv+0xae8/0xcd0 net/can/j1939/transport.c:2137 j1939_can_recv net/can/j1939/main.c:112 [inline] j1939_can_recv+0x78e/0xa30 net/can/j1939/main.c:38 deliver net/can/af_can.c:572 [inline] can_rcv_filter+0x5d4/0x8d0 net/can/af_can.c:606 can_receive+0x31d/0x580 net/can/af_can.c:663 can_rcv+0x1e1/0x230 net/can/af_can.c:687 __netif_receive_skb_one_core+0x114/0x180 net/core/dev.c:5474 __netif_receive_skb+0x1f/0x1c0 net/core/dev.c:5588 process_backlog+0x3e4/0x810 net/core/dev.c:5916 __napi_poll+0xb8/0x770 net/core/dev.c:6477 napi_poll net/core/dev.c:6544 [inline] net_rx_action+0xa00/0xde0 net/core/dev.c:6655 __do_softirq+0x1fb/0xadc kernel/softirq.c:571 run_ksoftirqd kernel/softirq.c:934 [inline] run_ksoftirqd+0x31/0x60 kernel/softirq.c:926 smpboot_thread_fn+0x659/0xa20 kernel/smpboot.c:164 kthread+0x2e8/0x3a0 kernel/kthread.c:376 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:308 -> #0 (&priv->active_session_list_lock){+.-.}-{2:2}: check_prev_add kernel/locking/lockdep.c:3097 [inline] check_prevs_add kernel/locking/lockdep.c:3216 [inline] validate_chain kernel/locking/lockdep.c:3831 [inline] __lock_acquire+0x2a43/0x56d0 kernel/locking/lockdep.c:5055 lock_acquire kernel/locking/lockdep.c:5668 [inline] lock_acquire+0x1e3/0x630 kernel/locking/lockdep.c:5633 __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline] _raw_spin_lock_bh+0x33/0x40 kernel/locking/spinlock.c:178 spin_lock_bh include/linux/spinlock.h:355 [inline] j1939_session_list_lock net/can/j1939/transport.c:238 [inline] j1939_session_activate+0x47/0x4b0 net/can/j1939/transport.c:1557 j1939_sk_queue_activate_next_locked net/can/j1939/socket.c:181 [inline] j1939_sk_queue_activate_next+0x1b6/0x450 net/can/j1939/socket.c:208 j1939_session_deactivate_activate_next+0x69/0x72 net/can/j1939/transport.c:1105 j1939_xtp_rx_abort_one.cold+0x301/0x403 net/can/j1939/transport.c:1344 j1939_xtp_rx_abort net/can/j1939/transport.c:1355 [inline] j1939_tp_cmd_recv net/can/j1939/transport.c:2104 [inline] j1939_tp_recv+0xb63/0xcd0 net/can/j1939/transport.c:2137 j1939_can_recv net/can/j1939/main.c:112 [inline] j1939_can_recv+0x78e/0xa30 net/can/j1939/main.c:38 deliver net/can/af_can.c:572 [inline] can_rcv_filter+0x5d4/0x8d0 net/can/af_can.c:606 can_receive+0x31d/0x580 net/can/af_can.c:663 can_rcv+0x1e1/0x230 net/can/af_can.c:687 __netif_receive_skb_one_core+0x114/0x180 net/core/dev.c:5474 __netif_receive_skb+0x1f/0x1c0 net/core/dev.c:5588 process_backlog+0x3e4/0x810 net/core/dev.c:5916 __napi_poll+0xb8/0x770 net/core/dev.c:6477 napi_poll net/core/dev.c:6544 [inline] net_rx_action+0xa00/0xde0 net/core/dev.c:6655 __do_softirq+0x1fb/0xadc kernel/softirq.c:571 run_ksoftirqd kernel/softirq.c:934 [inline] run_ksoftirqd+0x31/0x60 kernel/softirq.c:926 smpboot_thread_fn+0x659/0xa20 kernel/smpboot.c:164 kthread+0x2e8/0x3a0 kernel/kthread.c:376 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:308 other info that might help us debug this: Chain exists of: &priv->active_session_list_lock --> &priv->j1939_socks_lock --> &jsk->sk_session_queue_lock Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&jsk->sk_session_queue_lock); lock(&priv->j1939_socks_lock); lock(&jsk->sk_session_queue_lock); lock(&priv->active_session_list_lock); *** DEADLOCK *** 3 locks held by ksoftirqd/1/21: #0: ffffffff8c7922a0 (rcu_read_lock){....}-{1:2}, at: __skb_unlink include/linux/skbuff.h:2327 [inline] #0: ffffffff8c7922a0 (rcu_read_lock){....}-{1:2}, at: __skb_dequeue include/linux/skbuff.h:2342 [inline] #0: ffffffff8c7922a0 (rcu_read_lock){....}-{1:2}, at: process_backlog+0x38f/0x810 net/core/dev.c:5914 #1: ffffffff8c7922a0 (rcu_read_lock){....}-{1:2}, at: can_receive+0x1ef/0x580 net/can/af_can.c:653 #2: ffff88801c64c5c8 (&jsk->sk_session_queue_lock){+.-.}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:355 [inline] #2: ffff88801c64c5c8 (&jsk->sk_session_queue_lock){+.-.}-{2:2}, at: j1939_sk_queue_activate_next+0x5f/0x450 net/can/j1939/socket.c:207 stack backtrace: CPU: 1 PID: 21 Comm: ksoftirqd/1 Not tainted 6.2.0-rc8-syzkaller-00083-g3ac88fa4605e #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/21/2023 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0xd1/0x138 lib/dump_stack.c:106 check_noncircular+0x25f/0x2e0 kernel/locking/lockdep.c:2177 check_prev_add kernel/locking/lockdep.c:3097 [inline] check_prevs_add kernel/locking/lockdep.c:3216 [inline] validate_chain kernel/locking/lockdep.c:3831 [inline] __lock_acquire+0x2a43/0x56d0 kernel/locking/lockdep.c:5055 lock_acquire kernel/locking/lockdep.c:5668 [inline] lock_acquire+0x1e3/0x630 kernel/locking/lockdep.c:5633 __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline] _raw_spin_lock_bh+0x33/0x40 kernel/locking/spinlock.c:178 spin_lock_bh include/linux/spinlock.h:355 [inline] j1939_session_list_lock net/can/j1939/transport.c:238 [inline] j1939_session_activate+0x47/0x4b0 net/can/j1939/transport.c:1557 j1939_sk_queue_activate_next_locked net/can/j1939/socket.c:181 [inline] j1939_sk_queue_activate_next+0x1b6/0x450 net/can/j1939/socket.c:208 j1939_session_deactivate_activate_next+0x69/0x72 net/can/j1939/transport.c:1105 j1939_xtp_rx_abort_one.cold+0x301/0x403 net/can/j1939/transport.c:1344 j1939_xtp_rx_abort net/can/j1939/transport.c:1355 [inline] j1939_tp_cmd_recv net/can/j1939/transport.c:2104 [inline] j1939_tp_recv+0xb63/0xcd0 net/can/j1939/transport.c:2137 j1939_can_recv net/can/j1939/main.c:112 [inline] j1939_can_recv+0x78e/0xa30 net/can/j1939/main.c:38 deliver net/can/af_can.c:572 [inline] can_rcv_filter+0x5d4/0x8d0 net/can/af_can.c:606 can_receive+0x31d/0x580 net/can/af_can.c:663 can_rcv+0x1e1/0x230 net/can/af_can.c:687 __netif_receive_skb_one_core+0x114/0x180 net/core/dev.c:5474 __netif_receive_skb+0x1f/0x1c0 net/core/dev.c:5588 process_backlog+0x3e4/0x810 net/core/dev.c:5916 __napi_poll+0xb8/0x770 net/core/dev.c:6477 napi_poll net/core/dev.c:6544 [inline] net_rx_action+0xa00/0xde0 net/core/dev.c:6655 __do_softirq+0x1fb/0xadc kernel/softirq.c:571 run_ksoftirqd kernel/softirq.c:934 [inline] run_ksoftirqd+0x31/0x60 kernel/softirq.c:926 smpboot_thread_fn+0x659/0xa20 kernel/smpboot.c:164 kthread+0x2e8/0x3a0 kernel/kthread.c:376 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:308 vxcan1: j1939_xtp_rx_abort_one: 0xffff88804cbb6800: 0x00000: (8) Duplicate sequence number (and software is not able to recover) vxcan0: j1939_tp_rxtimer: 0xffff88804cbb6000: abort rx timeout. Force session deactivation