KASAN: use-after-free Read in l2tp_session_queue_purge

Status: upstream: reported syz repro on 2019/10/22 15:22
Reported-by: syzbot+1b475c743d59e27bc4cc@syzkaller.appspotmail.com
First crash: 2489d, last: 2251d
Fix bisection the fix commit could be any of (bisect log):
  01364dad1d45 Linux 4.14.174
  56dfe6252c68 Linux 4.14.188
   
▶ ▼ Similar bugs (2)
Kernel Title Rank 🛈 Repro Cause bisect Fix bisect Count Last Reported Patched Status
android-49 KASAN: use-after-free Read in l2tp_session_queue_purge 19 syz, C 12204 2908d 2683d 0/3 public: reported C repro on 2019/04/12 00:00
android-44 KASAN: use-after-free Read in l2tp_session_queue_purge 19 syz, C 3245 2908d 2683d 0/2 public: reported C repro on 2019/04/12 00:00
▶ ▼ Last patch testing requests (10)
Created Duration User Patch Repo Result
2023/01/27 11:32 12m retest repro linux-4.14.y report log
2023/01/27 10:32 10m retest repro linux-4.14.y report log
2023/01/27 09:32 9m retest repro linux-4.14.y report log
2023/01/27 00:32 10m retest repro linux-4.14.y report log
2023/01/26 23:32 9m retest repro linux-4.14.y report log
2023/01/26 21:32 13m retest repro linux-4.14.y report log
2022/09/09 02:27 12m retest repro linux-4.14.y report log
2022/09/09 01:27 14m retest repro linux-4.14.y report log
2022/09/08 15:27 12m retest repro linux-4.14.y report log
2022/09/08 14:27 9m retest repro linux-4.14.y report log
▶ ▼ Fix bisection attempts (6)
Created Duration User Patch Repo Result
2020/07/17 10:32 33m bisect fix linux-4.14.y OK (2) job log
2020/06/17 10:05 26m bisect fix linux-4.14.y OK (0) job log log
2020/05/18 09:38 27m bisect fix linux-4.14.y OK (0) job log log
2020/02/16 09:29 27m bisect fix linux-4.14.y OK (0) job log log
2020/01/17 08:32 27m bisect fix linux-4.14.y OK (0) job log log
2019/12/18 08:06 26m bisect fix linux-4.14.y OK (0) job log log

Sample crash report:
batman_adv: batadv0: Interface activated: batadv_slave_1
IPv6: ADDRCONF(NETDEV_CHANGE): batadv_slave_1: link becomes ready
IPv6: ADDRCONF(NETDEV_CHANGE): veth1_to_batadv: link becomes ready
==================================================================
BUG: KASAN: use-after-free in l2tp_session_queue_purge+0xea/0xf0 net/l2tp/l2tp_core.c:879
Read of size 4 at addr ffff88808c73da00 by task syz-executor.0/7641

CPU: 0 PID: 7641 Comm: syz-executor.0 Not tainted 4.14.174-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:17 [inline]
 dump_stack+0x13e/0x194 lib/dump_stack.c:58
 print_address_description.cold+0x7c/0x1e2 mm/kasan/report.c:252
 kasan_report_error mm/kasan/report.c:351 [inline]
 kasan_report mm/kasan/report.c:409 [inline]
 kasan_report.cold+0xa9/0x2ae mm/kasan/report.c:393
 l2tp_session_queue_purge+0xea/0xf0 net/l2tp/l2tp_core.c:879
 l2tp_tunnel_closeall+0x1fe/0x370 net/l2tp/l2tp_core.c:1342
 l2tp_udp_encap_destroy+0x8d/0xf0 net/l2tp/l2tp_core.c:1371
 udpv6_destroy_sock+0xa6/0xd0 net/ipv6/udp.c:1444
 sk_common_release+0x64/0x2f0 net/core/sock.c:2992
 inet_release+0xdf/0x1b0 net/ipv4/af_inet.c:425
 inet6_release+0x4c/0x70 net/ipv6/af_inet6.c:450
 __sock_release+0xcd/0x2b0 net/socket.c:602
 sock_close+0x15/0x20 net/socket.c:1139
 __fput+0x25f/0x790 fs/file_table.c:210
 task_work_run+0x113/0x190 kernel/task_work.c:113
 tracehook_notify_resume include/linux/tracehook.h:191 [inline]
 exit_to_usermode_loop+0x1d6/0x220 arch/x86/entry/common.c:164
 prepare_exit_to_usermode arch/x86/entry/common.c:199 [inline]
 syscall_return_slowpath arch/x86/entry/common.c:270 [inline]
 do_syscall_64+0x4a3/0x640 arch/x86/entry/common.c:297
 entry_SYSCALL_64_after_hwframe+0x42/0xb7
RIP: 0033:0x4163e1
RSP: 002b:00007ffd38e74520 EFLAGS: 00000293 ORIG_RAX: 0000000000000003
RAX: 0000000000000000 RBX: 0000000000000006 RCX: 00000000004163e1
RDX: 0000000000000000 RSI: 0000000000000081 RDI: 0000000000000005
RBP: 0000000000000000 R08: 00000000007703e0 R09: 01ffffffffffffff
R10: 00007ffd38e745f0 R11: 0000000000000293 R12: 000000000076bf00
R13: 00000000007703e8 R14: 0000000000000000 R15: 000000000076bf0c

Allocated by task 7642:
 save_stack+0x32/0xa0 mm/kasan/kasan.c:447
 set_track mm/kasan/kasan.c:459 [inline]
 kasan_kmalloc mm/kasan/kasan.c:551 [inline]
 kasan_kmalloc+0xbf/0xe0 mm/kasan/kasan.c:529
 __do_kmalloc mm/slab.c:3720 [inline]
 __kmalloc+0x15b/0x7c0 mm/slab.c:3729
 kmalloc include/linux/slab.h:493 [inline]
 kzalloc include/linux/slab.h:661 [inline]
 l2tp_session_create+0x35/0x16f0 net/l2tp/l2tp_core.c:1796
 pppol2tp_connect+0x1154/0x17b0 net/l2tp/l2tp_ppp.c:721
 SYSC_connect+0x1c6/0x250 net/socket.c:1655
 do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
 entry_SYSCALL_64_after_hwframe+0x42/0xb7

Freed by task 7642:
 save_stack+0x32/0xa0 mm/kasan/kasan.c:447
 set_track mm/kasan/kasan.c:459 [inline]
 kasan_slab_free+0x75/0xc0 mm/kasan/kasan.c:524
 __cache_free mm/slab.c:3496 [inline]
 kfree+0xcb/0x260 mm/slab.c:3815
 l2tp_session_dec_refcount_1 net/l2tp/l2tp_core.h:300 [inline]
 pppol2tp_session_destruct+0xcd/0x110 net/l2tp/l2tp_ppp.c:460
 __sk_destruct+0x49/0x640 net/core/sock.c:1556
 sk_destruct+0x97/0xc0 net/core/sock.c:1596
 __sk_free+0x4c/0x220 net/core/sock.c:1604
 sk_free+0x2b/0x40 net/core/sock.c:1615
 sock_put include/net/sock.h:1658 [inline]
 pppol2tp_release+0x247/0x2f0 net/l2tp/l2tp_ppp.c:501
 __sock_release+0xcd/0x2b0 net/socket.c:602
 sock_close+0x15/0x20 net/socket.c:1139
 __fput+0x25f/0x790 fs/file_table.c:210
 task_work_run+0x113/0x190 kernel/task_work.c:113
 tracehook_notify_resume include/linux/tracehook.h:191 [inline]
 exit_to_usermode_loop+0x1d6/0x220 arch/x86/entry/common.c:164
 prepare_exit_to_usermode arch/x86/entry/common.c:199 [inline]
 syscall_return_slowpath arch/x86/entry/common.c:270 [inline]
 do_syscall_64+0x4a3/0x640 arch/x86/entry/common.c:297
 entry_SYSCALL_64_after_hwframe+0x42/0xb7

The buggy address belongs to the object at ffff88808c73da00
 which belongs to the cache kmalloc-512 of size 512
The buggy address is located 0 bytes inside of
 512-byte region [ffff88808c73da00, ffff88808c73dc00)
The buggy address belongs to the page:
page:ffffea000231cf40 count:1 mapcount:0 mapping:ffff88808c73d000 index:0x0
flags: 0xfffe0000000100(slab)
raw: 00fffe0000000100 ffff88808c73d000 0000000000000000 0000000100000006
raw: ffffea000231ce60 ffffea000236ca20 ffff88812fe56940 0000000000000000
page dumped because: kasan: bad access detected

Memory state around the buggy address:
 ffff88808c73d900: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
 ffff88808c73d980: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
>ffff88808c73da00: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
                   ^
 ffff88808c73da80: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
 ffff88808c73db00: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
==================================================================

Crashes (8):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2020/03/24 03:10 linux-4.14.y 01364dad1d45 84f999d6 .config console log report syz ci2-linux-4-14
2020/03/11 14:31 linux-4.14.y 78d697fc93f9 e103bc9e .config console log report syz ci2-linux-4-14
2020/03/05 00:53 linux-4.14.y 78d697fc93f9 576fb9bc .config console log report syz ci2-linux-4-14
2020/03/04 06:58 linux-4.14.y 78d697fc93f9 1f73b64b .config console log report syz ci2-linux-4-14
2019/11/02 20:32 linux-4.14.y ddef1e8e3f6e 997ccc67 .config console log report syz ci2-linux-4-14
2019/10/28 07:14 linux-4.14.y b98aebd29824 25bb509e .config console log report syz ci2-linux-4-14
2020/04/18 09:25 linux-4.14.y c10b57a567e4 435c6d53 .config console log report ci2-linux-4-14
2019/10/22 14:21 linux-4.14.y b98aebd29824 4ee855e7 .config console log report ci2-linux-4-14
* Struck through repros no longer work on HEAD.