syzbot

ocfs2: Mounting device (7,2) on (node local, slot 0) with writeback data mode.
======================================================
WARNING: possible circular locking dependency detected
6.6.94-syzkaller #0 Not tainted
------------------------------------------------------
syz.2.68/6212 is trying to acquire lock:
ffff88805c9ba2e0 (&ocfs2_file_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_try_remove_refcount_tree+0xb7/0x320 fs/ocfs2/refcounttree.c:932

but task is already holding lock:
ffff88805c9ba378 (&oi->ip_xattr_sem){++++}-{3:3}, at: ocfs2_try_remove_refcount_tree+0xa5/0x320 fs/ocfs2/refcounttree.c:931

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #4 (&oi->ip_xattr_sem){++++}-{3:3}:
       down_read+0x46/0x2e0 kernel/locking/rwsem.c:1520
       ocfs2_init_acl+0x2fa/0x720 fs/ocfs2/acl.c:366
       ocfs2_mknod+0x12e5/0x20f0 fs/ocfs2/namei.c:410
       ocfs2_mkdir+0x196/0x410 fs/ocfs2/namei.c:657
       vfs_mkdir+0x296/0x440 fs/namei.c:4113
       do_mkdirat+0x1d4/0x440 fs/namei.c:4136
       __do_sys_mkdirat fs/namei.c:4151 [inline]
       __se_sys_mkdirat fs/namei.c:4149 [inline]
       __x64_sys_mkdirat+0x89/0xa0 fs/namei.c:4149
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #3 (jbd2_handle){++++}-{0:0}:
       start_this_handle+0x1e9d/0x20c0 fs/jbd2/transaction.c:448
       jbd2__journal_start+0x2bb/0x5b0 fs/jbd2/transaction.c:505
       jbd2_journal_start+0x2a/0x40 fs/jbd2/transaction.c:544
       ocfs2_start_trans+0x376/0x6c0 fs/ocfs2/journal.c:374
       ocfs2_modify_bh+0xe9/0x470 fs/ocfs2/quota_local.c:101
       ocfs2_local_read_info+0x13fd/0x1770 fs/ocfs2/quota_local.c:764
       dquot_load_quota_sb+0x757/0xb80 fs/quota/dquot.c:2468
       dquot_load_quota_inode+0x2dc/0x5d0 fs/quota/dquot.c:2505
       ocfs2_enable_quotas+0x1c7/0x440 fs/ocfs2/super.c:926
       ocfs2_fill_super+0x3f6d/0x4d90 fs/ocfs2/super.c:1141
       mount_bdev+0x22b/0x2d0 fs/super.c:1643
       legacy_get_tree+0xea/0x180 fs/fs_context.c:662
       vfs_get_tree+0x8c/0x280 fs/super.c:1764
       do_new_mount+0x24b/0xa40 fs/namespace.c:3366
       do_mount fs/namespace.c:3706 [inline]
       __do_sys_mount fs/namespace.c:3915 [inline]
       __se_sys_mount+0x2da/0x3c0 fs/namespace.c:3892
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #2 (&journal->j_trans_barrier){.+.+}-{3:3}:
       down_read+0x46/0x2e0 kernel/locking/rwsem.c:1520
       ocfs2_start_trans+0x36a/0x6c0 fs/ocfs2/journal.c:372
       ocfs2_modify_bh+0xe9/0x470 fs/ocfs2/quota_local.c:101
       ocfs2_local_read_info+0x13fd/0x1770 fs/ocfs2/quota_local.c:764
       dquot_load_quota_sb+0x757/0xb80 fs/quota/dquot.c:2468
       dquot_load_quota_inode+0x2dc/0x5d0 fs/quota/dquot.c:2505
       ocfs2_enable_quotas+0x1c7/0x440 fs/ocfs2/super.c:926
       ocfs2_fill_super+0x3f6d/0x4d90 fs/ocfs2/super.c:1141
       mount_bdev+0x22b/0x2d0 fs/super.c:1643
       legacy_get_tree+0xea/0x180 fs/fs_context.c:662
       vfs_get_tree+0x8c/0x280 fs/super.c:1764
       do_new_mount+0x24b/0xa40 fs/namespace.c:3366
       do_mount fs/namespace.c:3706 [inline]
       __do_sys_mount fs/namespace.c:3915 [inline]
       __se_sys_mount+0x2da/0x3c0 fs/namespace.c:3892
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #1 (
sb_internal#2){.+.+}-{0:0}:
       percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
       __sb_start_write include/linux/fs.h:1633 [inline]
       sb_start_intwrite include/linux/fs.h:1755 [inline]
       ocfs2_start_trans+0x26b/0x6c0 fs/ocfs2/journal.c:370
       ocfs2_orphan_for_truncate fs/ocfs2/file.c:396 [inline]
       ocfs2_truncate_file+0x611/0x13a0 fs/ocfs2/file.c:500
       ocfs2_setattr+0x150d/0x1b20 fs/ocfs2/file.c:1211
       notify_change+0xb0d/0xe10 fs/attr.c:499
       do_truncate+0x19b/0x220 fs/open.c:66
       handle_truncate fs/namei.c:3291 [inline]
       do_open fs/namei.c:3636 [inline]
       path_openat+0x298c/0x3190 fs/namei.c:3789
       do_filp_open+0x1c5/0x3d0 fs/namei.c:3816
       do_sys_openat2+0x12c/0x1c0 fs/open.c:1419
       do_sys_open fs/open.c:1434 [inline]
       __do_sys_openat fs/open.c:1450 [inline]
       __se_sys_openat fs/open.c:1445 [inline]
       __x64_sys_openat+0x139/0x160 fs/open.c:1445
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #0 (
&ocfs2_file_ip_alloc_sem_key){++++}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3134 [inline]
       check_prevs_add kernel/locking/lockdep.c:3253 [inline]
       validate_chain kernel/locking/lockdep.c:3869 [inline]
       __lock_acquire+0x2ddb/0x7c80 kernel/locking/lockdep.c:5137
       lock_acquire+0x197/0x410 kernel/locking/lockdep.c:5754
       down_write+0x97/0x1f0 kernel/locking/rwsem.c:1573
       ocfs2_try_remove_refcount_tree+0xb7/0x320 fs/ocfs2/refcounttree.c:932
       ocfs2_truncate_file+0xd84/0x13a0 fs/ocfs2/file.c:521
       ocfs2_setattr+0x150d/0x1b20 fs/ocfs2/file.c:1211
       notify_change+0xb0d/0xe10 fs/attr.c:499
       do_truncate+0x19b/0x220 fs/open.c:66
       handle_truncate fs/namei.c:3291 [inline]
       do_open fs/namei.c:3636 [inline]
       path_openat+0x298c/0x3190 fs/namei.c:3789
       do_filp_open+0x1c5/0x3d0 fs/namei.c:3816
       do_sys_openat2+0x12c/0x1c0 fs/open.c:1419
       do_sys_open fs/open.c:1434 [inline]
       __do_sys_openat fs/open.c:1450 [inline]
       __se_sys_openat fs/open.c:1445 [inline]
       __x64_sys_openat+0x139/0x160 fs/open.c:1445
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

other info that might help us debug this:

Chain exists of:
  &ocfs2_file_ip_alloc_sem_key --> jbd2_handle --> &oi->ip_xattr_sem

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&oi->ip_xattr_sem);
                               lock(jbd2_handle);
                               lock(&oi->ip_xattr_sem);
  lock(&ocfs2_file_ip_alloc_sem_key);

 *** DEADLOCK ***

3 locks held by syz.2.68/6212:
 #0: ffff88807c400418 (sb_writers#13){.+.+}-{0:0}, at: mnt_want_write+0x41/0x90 fs/namespace.c:403
 #1: ffff88805c9ba658 (&sb->s_type->i_mutex_key#23){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:804 [inline]
 #1: ffff88805c9ba658 (&sb->s_type->i_mutex_key#23){+.+.}-{3:3}, at: do_truncate+0x187/0x220 fs/open.c:64
 #2: ffff88805c9ba378 (&oi->ip_xattr_sem){++++}-{3:3}, at: ocfs2_try_remove_refcount_tree+0xa5/0x320 fs/ocfs2/refcounttree.c:931

stack backtrace:
CPU: 0 PID: 6212 Comm: syz.2.68 Not tainted 6.6.94-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/07/2025
Call Trace:
 <TASK>
 dump_stack_lvl+0x16c/0x230 lib/dump_stack.c:106
 check_noncircular+0x2bd/0x3c0 kernel/locking/lockdep.c:2187
 check_prev_add kernel/locking/lockdep.c:3134 [inline]
 check_prevs_add kernel/locking/lockdep.c:3253 [inline]
 validate_chain kernel/locking/lockdep.c:3869 [inline]
 __lock_acquire+0x2ddb/0x7c80 kernel/locking/lockdep.c:5137
 lock_acquire+0x197/0x410 kernel/locking/lockdep.c:5754
 down_write+0x97/0x1f0 kernel/locking/rwsem.c:1573
 ocfs2_try_remove_refcount_tree+0xb7/0x320 fs/ocfs2/refcounttree.c:932
 ocfs2_truncate_file+0xd84/0x13a0 fs/ocfs2/file.c:521
 ocfs2_setattr+0x150d/0x1b20 fs/ocfs2/file.c:1211
 notify_change+0xb0d/0xe10 fs/attr.c:499
 do_truncate+0x19b/0x220 fs/open.c:66
 handle_truncate fs/namei.c:3291 [inline]
 do_open fs/namei.c:3636 [inline]
 path_openat+0x298c/0x3190 fs/namei.c:3789
 do_filp_open+0x1c5/0x3d0 fs/namei.c:3816
 do_sys_openat2+0x12c/0x1c0 fs/open.c:1419
 do_sys_open fs/open.c:1434 [inline]
 __do_sys_openat fs/open.c:1450 [inline]
 __se_sys_openat fs/open.c:1445 [inline]
 __x64_sys_openat+0x139/0x160 fs/open.c:1445
 do_syscall_x64 arch/x86/entry/common.c:51 [inline]
 do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:81
 entry_SYSCALL_64_after_hwframe+0x68/0xd2
RIP: 0033:0x7f4407f8e929
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f4408e33038 EFLAGS: 00000246 ORIG_RAX: 0000000000000101
RAX: ffffffffffffffda RBX: 00007f44081b5fa0 RCX: 00007f4407f8e929
RDX: 000000000000275a RSI: 0000200000000140 RDI: ffffffffffffff9c
RBP: 00007f4408010b39 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007f44081b5fa0 R15: 00007fff3b9fe9b8
 </TASK>
ocfs2: Unmounting device (7,2) on (node local)