syzbot

(syz.0.17,5921,1):ocfs2_block_check_validate:402 ERROR: CRC32 failed: stored: 0xb3775c19, computed 0x2dd1c265. Applying ECC.
JBD2: Ignoring recovery information on journal
ocfs2: Mounting device (7,0) on (node local, slot 0) with ordered data mode.
======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.0.17/5921 is trying to acquire lock:
ffff88805d5f0660 (&oi->ip_alloc_sem){+.+.}-{3:3}, at: ocfs2_try_remove_refcount_tree+0xb7/0x340 fs/ocfs2/refcounttree.c:932

but task is already holding lock:
ffff88805d5f06f8 (&oi->ip_xattr_sem){++++}-{3:3}, at: ocfs2_try_remove_refcount_tree+0xa5/0x340 fs/ocfs2/refcounttree.c:931

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (&oi->ip_xattr_sem){++++}-{3:3}:
       down_read+0x46/0x2e0 kernel/locking/rwsem.c:1520
       ocfs2_init_acl+0x30a/0x770 fs/ocfs2/acl.c:366
       ocfs2_mknod+0x140f/0x2300 fs/ocfs2/namei.c:410
       ocfs2_create+0x196/0x430 fs/ocfs2/namei.c:674
       lookup_open fs/namei.c:3496 [inline]
       open_last_lookups fs/namei.c:3564 [inline]
       path_openat+0x12a0/0x3230 fs/namei.c:3794
       do_filp_open+0x1f5/0x430 fs/namei.c:3824
       do_sys_openat2+0x134/0x1d0 fs/open.c:1421
       do_sys_open fs/open.c:1436 [inline]
       __do_sys_openat fs/open.c:1452 [inline]
       __se_sys_openat fs/open.c:1447 [inline]
       __x64_sys_openat+0x139/0x160 fs/open.c:1447
       do_syscall_x64 arch/x86/entry/common.c:46 [inline]
       do_syscall_64+0x55/0xa0 arch/x86/entry/common.c:76
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #2 (&journal->j_trans_barrier){.+.+}-{3:3}:
       down_read+0x46/0x2e0 kernel/locking/rwsem.c:1520
       ocfs2_start_trans+0x3a8/0x6f0 fs/ocfs2/journal.c:372
       ocfs2_modify_bh+0xe4/0x4c0 fs/ocfs2/quota_local.c:101
       ocfs2_local_read_info+0x1445/0x1800 fs/ocfs2/quota_local.c:764
       dquot_load_quota_sb+0x757/0xb80 fs/quota/dquot.c:2470
       dquot_load_quota_inode+0x2dc/0x5d0 fs/quota/dquot.c:2507
       ocfs2_enable_quotas+0x1c9/0x490 fs/ocfs2/super.c:926
       ocfs2_fill_super+0x417d/0x5010 fs/ocfs2/super.c:1141
       mount_bdev+0x221/0x2d0 fs/super.c:1643
       legacy_get_tree+0xea/0x180 fs/fs_context.c:662
       vfs_get_tree+0x8c/0x280 fs/super.c:1764
       do_new_mount+0x24b/0xa40 fs/namespace.c:3386
       do_mount fs/namespace.c:3726 [inline]
       __do_sys_mount fs/namespace.c:3935 [inline]
       __se_sys_mount+0x2e7/0x3d0 fs/namespace.c:3912
       do_syscall_x64 arch/x86/entry/common.c:46 [inline]
       do_syscall_64+0x55/0xa0 arch/x86/entry/common.c:76
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #1 (sb_internal#2){.+.+}-{0:0}:
       percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
       __sb_start_write include/linux/fs.h:1633 [inline]
       sb_start_intwrite include/linux/fs.h:1755 [inline]
       ocfs2_start_trans+0x2a9/0x6f0 fs/ocfs2/journal.c:370
       ocfs2_orphan_for_truncate fs/ocfs2/file.c:396 [inline]
       ocfs2_truncate_file+0x631/0x1440 fs/ocfs2/file.c:500
       ocfs2_setattr+0x158d/0x1bc0 fs/ocfs2/file.c:1211
       notify_change+0xb0d/0xe10 fs/attr.c:499
       do_truncate+0x1b0/0x240 fs/open.c:66
       handle_truncate fs/namei.c:3299 [inline]
       do_open fs/namei.c:3644 [inline]
       path_openat+0x2a32/0x3230 fs/namei.c:3797
       do_filp_open+0x1f5/0x430 fs/namei.c:3824
       do_sys_openat2+0x134/0x1d0 fs/open.c:1421
       do_sys_open fs/open.c:1436 [inline]
       __do_sys_creat fs/open.c:1514 [inline]
       __se_sys_creat fs/open.c:1508 [inline]
       __x64_sys_creat+0x90/0xb0 fs/open.c:1508
       do_syscall_x64 arch/x86/entry/common.c:46 [inline]
       do_syscall_64+0x55/0xa0 arch/x86/entry/common.c:76
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #0 (&oi->ip_alloc_sem){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3134 [inline]
       check_prevs_add kernel/locking/lockdep.c:3253 [inline]
       validate_chain kernel/locking/lockdep.c:3869 [inline]
       __lock_acquire+0x2df1/0x7d40 kernel/locking/lockdep.c:5137
       lock_acquire+0x19e/0x420 kernel/locking/lockdep.c:5754
       down_write+0x97/0x200 kernel/locking/rwsem.c:1573
       ocfs2_try_remove_refcount_tree+0xb7/0x340 fs/ocfs2/refcounttree.c:932
       ocfs2_truncate_file+0xde5/0x1440 fs/ocfs2/file.c:521
       ocfs2_setattr+0x158d/0x1bc0 fs/ocfs2/file.c:1211
       notify_change+0xb0d/0xe10 fs/attr.c:499
       do_truncate+0x1b0/0x240 fs/open.c:66
       handle_truncate fs/namei.c:3299 [inline]
       do_open fs/namei.c:3644 [inline]
       path_openat+0x2a32/0x3230 fs/namei.c:3797
       do_filp_open+0x1f5/0x430 fs/namei.c:3824
       do_sys_openat2+0x134/0x1d0 fs/open.c:1421
       do_sys_open fs/open.c:1436 [inline]
       __do_sys_creat fs/open.c:1514 [inline]
       __se_sys_creat fs/open.c:1508 [inline]
       __x64_sys_creat+0x90/0xb0 fs/open.c:1508
       do_syscall_x64 arch/x86/entry/common.c:46 [inline]
       do_syscall_64+0x55/0xa0 arch/x86/entry/common.c:76
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

other info that might help us debug this:

Chain exists of:
  &oi->ip_alloc_sem --> &journal->j_trans_barrier --> &oi->ip_xattr_sem

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&oi->ip_xattr_sem);
                               lock(&journal->j_trans_barrier);
                               lock(&oi->ip_xattr_sem);
  lock(&oi->ip_alloc_sem);

 *** DEADLOCK ***

3 locks held by syz.0.17/5921:
 #0: ffff88802cb6c418 (sb_writers#13){.+.+}-{0:0}, at: mnt_want_write+0x41/0x90 fs/namespace.c:412
 #1: ffff88805d5f09d8 (&sb->s_type->i_mutex_key#20){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:804 [inline]
 #1: ffff88805d5f09d8 (&sb->s_type->i_mutex_key#20){+.+.}-{3:3}, at: do_truncate+0x19c/0x240 fs/open.c:64
 #2: ffff88805d5f06f8 (&oi->ip_xattr_sem){++++}-{3:3}, at: ocfs2_try_remove_refcount_tree+0xa5/0x340 fs/ocfs2/refcounttree.c:931

stack backtrace:
CPU: 0 PID: 5921 Comm: syz.0.17 Not tainted syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/12/2026
Call Trace:
 <TASK>
 dump_stack_lvl+0x18c/0x250 lib/dump_stack.c:106
 check_noncircular+0x2fc/0x400 kernel/locking/lockdep.c:2187
 check_prev_add kernel/locking/lockdep.c:3134 [inline]
 check_prevs_add kernel/locking/lockdep.c:3253 [inline]
 validate_chain kernel/locking/lockdep.c:3869 [inline]
 __lock_acquire+0x2df1/0x7d40 kernel/locking/lockdep.c:5137
 lock_acquire+0x19e/0x420 kernel/locking/lockdep.c:5754
 down_write+0x97/0x200 kernel/locking/rwsem.c:1573
 ocfs2_try_remove_refcount_tree+0xb7/0x340 fs/ocfs2/refcounttree.c:932
 ocfs2_truncate_file+0xde5/0x1440 fs/ocfs2/file.c:521
 ocfs2_setattr+0x158d/0x1bc0 fs/ocfs2/file.c:1211
 notify_change+0xb0d/0xe10 fs/attr.c:499
 do_truncate+0x1b0/0x240 fs/open.c:66
 handle_truncate fs/namei.c:3299 [inline]
 do_open fs/namei.c:3644 [inline]
 path_openat+0x2a32/0x3230 fs/namei.c:3797
 do_filp_open+0x1f5/0x430 fs/namei.c:3824
 do_sys_openat2+0x134/0x1d0 fs/open.c:1421
 do_sys_open fs/open.c:1436 [inline]
 __do_sys_creat fs/open.c:1514 [inline]
 __se_sys_creat fs/open.c:1508 [inline]
 __x64_sys_creat+0x90/0xb0 fs/open.c:1508
 do_syscall_x64 arch/x86/entry/common.c:46 [inline]
 do_syscall_64+0x55/0xa0 arch/x86/entry/common.c:76
 entry_SYSCALL_64_after_hwframe+0x68/0xd2
RIP: 0033:0x7f630b99c629
Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fffd89dc1a8 EFLAGS: 00000246 ORIG_RAX: 0000000000000055
RAX: ffffffffffffffda RBX: 00007f630bc15fa0 RCX: 00007f630b99c629
RDX: 0000000000000000 RSI: 0000000000000100 RDI: 00002000000001c0
RBP: 00007f630ba32b39 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007f630bc15fac R14: 00007f630bc15fa0 R15: 00007f630bc15fa0
 </TASK>