KASAN: use-after-free Read in bcm_can_tx

Status: fixed on 2022/01/29 10:00
Reported-by: syzbot+5ca851459ed04c778d1d@syzkaller.appspotmail.com
Fix commit: 632881680ba0 can: bcm: fix UAF of bcm op
First crash: 2142d, last: 1686d
▶ ▼ Discussions (6)
Title Replies (including bot) Last reply
[PATCH 4.9 00/48] 4.9.300-rc1 review 57 (57) 2022/06/04 10:54
[PATCH 4.14 0/2] 4.14.264-rc1 review 7 (7) 2022/02/04 06:59
[PATCH 4.4 00/25] 4.4.302-rc1 review 33 (33) 2022/02/02 12:18
[PATCH 4.9] can: bcm: fix UAF of bcm op 2 (2) 2022/01/29 11:41
[PATCH 4.4] can: bcm: fix UAF of bcm op 1 (1) 2022/01/28 04:16
[PATCH 4.14] can: bcm: fix UAF of bcm op 4 (4) 2022/01/27 14:49
▶ ▼ Similar bugs (2)
Kernel Title Rank 🛈 Repro Cause bisect Fix bisect Count Last Reported Patched Status
linux-4.19 KASAN: use-after-free Read in bcm_can_tx 19 1 2220d 2220d 0/1 auto-closed as invalid on 2020/11/22 07:42
linux-4.19 KASAN: use-after-free Read in bcm_can_tx (2) 19 syz, C error 94 1265d 1829d 0/1 upstream: reported C repro on 2021/08/20 03:44
▶ ▼ Fix bisection attempts (16)
Created Duration User Patch Repo Result
2022/01/10 18:32 32m bisect fix linux-4.14.y OK (0) job log log
2021/12/11 17:49 34m bisect fix linux-4.14.y OK (0) job log log
2021/11/11 17:18 30m bisect fix linux-4.14.y OK (0) job log log
2021/10/12 15:55 33m bisect fix linux-4.14.y OK (0) job log log
2021/09/12 11:11 29m bisect fix linux-4.14.y OK (0) job log log
2021/08/13 10:34 36m bisect fix linux-4.14.y OK (0) job log log
2021/07/14 10:08 26m bisect fix linux-4.14.y OK (0) job log log
2021/06/14 09:41 26m bisect fix linux-4.14.y OK (0) job log log
2021/05/15 09:00 36m bisect fix linux-4.14.y OK (0) job log log
2021/03/23 21:08 33m bisect fix linux-4.14.y OK (0) job log log
2021/02/21 19:07 36m bisect fix linux-4.14.y OK (0) job log log
2021/02/18 08:58 19m bisect fix linux-4.14.y error job log
2021/02/08 14:51 0m bisect fix linux-4.14.y error job log
2021/01/09 14:13 38m bisect fix linux-4.14.y OK (0) job log log
2020/12/10 13:38 34m bisect fix linux-4.14.y OK (0) job log log
2020/11/10 13:05 33m bisect fix linux-4.14.y OK (0) job log log

Sample crash report:
==================================================================
BUG: KASAN: use-after-free in bcm_can_tx+0x5c1/0x680 net/can/bcm.c:304
Read of size 4 at addr ffff8880aa316f04 by task ksoftirqd/1/17

CPU: 1 PID: 17 Comm: ksoftirqd/1 Not tainted 4.14.230-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:17 [inline]
 dump_stack+0x1b2/0x281 lib/dump_stack.c:58
 print_address_description.cold+0x54/0x1d3 mm/kasan/report.c:252
 kasan_report_error.cold+0x8a/0x191 mm/kasan/report.c:351
 kasan_report mm/kasan/report.c:409 [inline]
 __asan_report_load4_noabort+0x68/0x70 mm/kasan/report.c:429
 bcm_can_tx+0x5c1/0x680 net/can/bcm.c:304
 bcm_tx_timeout_tsklet+0x174/0x2a0 net/can/bcm.c:422
 tasklet_action+0x195/0x340 kernel/softirq.c:513
 __do_softirq+0x24d/0x9ff kernel/softirq.c:288
 run_ksoftirqd+0x50/0x1a0 kernel/softirq.c:670
 smpboot_thread_fn+0x5c1/0x920 kernel/smpboot.c:164
 kthread+0x30d/0x420 kernel/kthread.c:232
 ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:404

Allocated by task 5895:
 save_stack mm/kasan/kasan.c:447 [inline]
 set_track mm/kasan/kasan.c:459 [inline]
 kasan_kmalloc+0xeb/0x160 mm/kasan/kasan.c:551
 kmem_cache_alloc_trace+0x131/0x3d0 mm/slab.c:3618
 kmalloc include/linux/slab.h:488 [inline]
 kzalloc include/linux/slab.h:661 [inline]
 bcm_tx_setup net/can/bcm.c:952 [inline]
 bcm_sendmsg+0x20b6/0x3ae0 net/can/bcm.c:1388
 sock_sendmsg_nosec net/socket.c:646 [inline]
 sock_sendmsg+0xb5/0x100 net/socket.c:656
 ___sys_sendmsg+0x6c8/0x800 net/socket.c:2062
 __sys_sendmsg+0xa3/0x120 net/socket.c:2096
 SYSC_sendmsg net/socket.c:2107 [inline]
 SyS_sendmsg+0x27/0x40 net/socket.c:2103
 do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
 entry_SYSCALL_64_after_hwframe+0x46/0xbb

Freed by task 5895:
 save_stack mm/kasan/kasan.c:447 [inline]
 set_track mm/kasan/kasan.c:459 [inline]
 kasan_slab_free+0xc3/0x1a0 mm/kasan/kasan.c:524
 __cache_free mm/slab.c:3496 [inline]
 kfree+0xc9/0x250 mm/slab.c:3815
 bcm_release+0xff/0x6c0 net/can/bcm.c:1540
 __sock_release+0xcd/0x2b0 net/socket.c:602
 sock_close+0x15/0x20 net/socket.c:1139
 __fput+0x25f/0x7a0 fs/file_table.c:210
 task_work_run+0x11f/0x190 kernel/task_work.c:113
 tracehook_notify_resume include/linux/tracehook.h:191 [inline]
 exit_to_usermode_loop+0x1ad/0x200 arch/x86/entry/common.c:164
 prepare_exit_to_usermode arch/x86/entry/common.c:199 [inline]
 syscall_return_slowpath arch/x86/entry/common.c:270 [inline]
 do_syscall_64+0x4a3/0x640 arch/x86/entry/common.c:297
 entry_SYSCALL_64_after_hwframe+0x46/0xbb

The buggy address belongs to the object at ffff8880aa316dc0
 which belongs to the cache kmalloc-1024 of size 1024
The buggy address is located 324 bytes inside of
 1024-byte region [ffff8880aa316dc0, ffff8880aa3171c0)
The buggy address belongs to the page:
page:ffffea0002a8c580 count:1 mapcount:0 mapping:ffff8880aa316040 index:0xffff8880aa316040 compound_mapcount: 0
flags: 0xfff00000008100(slab|head)
raw: 00fff00000008100 ffff8880aa316040 ffff8880aa316040 0000000100000006
raw: ffffea00024d4420 ffffea0002acbf20 ffff88813fe80ac0 0000000000000000
page dumped because: kasan: bad access detected

Memory state around the buggy address:
 ffff8880aa316e00: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
 ffff8880aa316e80: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
>ffff8880aa316f00: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
                   ^
 ffff8880aa316f80: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
 ffff8880aa317000: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
==================================================================

Crashes (2):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2021/04/15 09:00 linux-4.14.y 958e517f4e16 fcdb12ba .config console log report syz C ci2-linux-4-14 KASAN: use-after-free Read in bcm_can_tx
2020/10/11 13:05 linux-4.14.y cbfa1702aaf6 4a77ae0b .config console log report syz C ci2-linux-4-14
* Struck through repros no longer work on HEAD.