possible deadlock in proc_pid_personality

Status: upstream: reported C repro on 2020/08/16 11:43
Reported-by: syzbot+6f522f64016c297f716c@syzkaller.appspotmail.com
First crash: 2169d, last: 1416d
Fix bisection: failed (error log, bisect log)
  
▶ ▼ Similar bugs (3)
Kernel Title Rank 🛈 Repro Cause bisect Fix bisect Count Last Reported Patched Status
linux-4.19 possible deadlock in proc_pid_personality (2) 4 111 1317d 1854d 0/1 auto-obsoleted due to no activity on 2023/04/16 03:13
upstream possible deadlock in proc_pid_personality fs 4 syz inconclusive done 3 2322d 2332d 15/29 fixed on 2020/08/18 22:40
linux-4.19 possible deadlock in proc_pid_personality 4 10 1989d 2222d 0/1 auto-closed as invalid on 2021/06/12 14:46
▶ ▼ Fix bisection attempts (24)
Created Duration User Patch Repo Result
2022/10/13 02:21 0m bisect fix linux-4.14.y error job log
2022/09/08 14:39 26m bisect fix linux-4.14.y OK (0) job log log
2022/08/09 11:43 21m bisect fix linux-4.14.y OK (0) job log log
2022/07/10 11:23 19m bisect fix linux-4.14.y OK (0) job log log
2022/06/10 10:57 25m bisect fix linux-4.14.y OK (0) job log log
2022/05/11 09:43 21m bisect fix linux-4.14.y OK (0) job log log
2022/04/10 01:35 25m bisect fix linux-4.14.y OK (0) job log log
2022/03/11 01:06 28m bisect fix linux-4.14.y OK (0) job log log
2022/02/09 00:23 28m bisect fix linux-4.14.y OK (0) job log log
2022/01/09 23:56 25m bisect fix linux-4.14.y OK (0) job log log
2021/12/10 23:33 23m bisect fix linux-4.14.y OK (0) job log log
2021/11/10 23:12 21m bisect fix linux-4.14.y OK (0) job log log
2021/09/05 23:12 31m bisect fix linux-4.14.y OK (0) job log log
2021/08/06 22:20 28m bisect fix linux-4.14.y OK (0) job log log
2021/07/07 21:57 23m bisect fix linux-4.14.y OK (0) job log log
2021/06/07 21:35 21m bisect fix linux-4.14.y OK (0) job log log
2021/05/08 21:06 28m bisect fix linux-4.14.y OK (0) job log log
2021/03/23 06:26 22m bisect fix linux-4.14.y OK (0) job log log
2021/02/21 06:04 22m bisect fix linux-4.14.y OK (0) job log log
2021/02/18 03:00 18m bisect fix linux-4.14.y error job log
2021/02/05 08:32 0m bisect fix linux-4.14.y error job log
2021/01/06 07:46 23m bisect fix linux-4.14.y OK (0) job log log
2020/11/27 09:46 27m bisect fix linux-4.14.y OK (0) job log log
2020/09/28 18:27 25m bisect fix linux-4.14.y OK (0) job log log

Sample crash report:
======================================================
WARNING: possible circular locking dependency detected
4.14.249-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor862/7986 is trying to acquire lock:
 (&sig->cred_guard_mutex){+.+.}, at: [<ffffffff81a0b1a8>] lock_trace fs/proc/base.c:407 [inline]
 (&sig->cred_guard_mutex){+.+.}, at: [<ffffffff81a0b1a8>] proc_pid_personality+0x48/0x160 fs/proc/base.c:2926

but task is already holding lock:
 (&p->lock){+.+.}, at: [<ffffffff818edd5a>] seq_read+0xba/0x1180 fs/seq_file.c:168

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (&p->lock){+.+.}:
       __mutex_lock_common kernel/locking/mutex.c:756 [inline]
       __mutex_lock+0xc4/0x1310 kernel/locking/mutex.c:893
       seq_read+0xba/0x1180 fs/seq_file.c:168
       proc_reg_read+0xee/0x1a0 fs/proc/inode.c:217
       do_loop_readv_writev fs/read_write.c:695 [inline]
       do_loop_readv_writev fs/read_write.c:682 [inline]
       do_iter_read+0x3eb/0x5b0 fs/read_write.c:919
       vfs_readv+0xc8/0x120 fs/read_write.c:981
       kernel_readv fs/splice.c:361 [inline]
       default_file_splice_read+0x418/0x910 fs/splice.c:416
       do_splice_to+0xfb/0x140 fs/splice.c:880
       splice_direct_to_actor+0x207/0x730 fs/splice.c:952
       do_splice_direct+0x164/0x210 fs/splice.c:1061
       do_sendfile+0x47f/0xb30 fs/read_write.c:1441
       SYSC_sendfile64 fs/read_write.c:1502 [inline]
       SyS_sendfile64+0xff/0x110 fs/read_write.c:1488
       do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
       entry_SYSCALL_64_after_hwframe+0x46/0xbb

-> #2 (sb_writers#3){.+.+}:
       percpu_down_read_preempt_disable include/linux/percpu-rwsem.h:36 [inline]
       percpu_down_read include/linux/percpu-rwsem.h:59 [inline]
       __sb_start_write+0x64/0x260 fs/super.c:1342
       sb_start_write include/linux/fs.h:1549 [inline]
       mnt_want_write+0x3a/0xb0 fs/namespace.c:386
       ovl_create_object+0x75/0x1d0 fs/overlayfs/dir.c:538
       lookup_open+0x77a/0x1750 fs/namei.c:3241
       do_last fs/namei.c:3334 [inline]
       path_openat+0xe08/0x2970 fs/namei.c:3569
       do_filp_open+0x179/0x3c0 fs/namei.c:3603
       do_sys_open+0x296/0x410 fs/open.c:1081
       do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
       entry_SYSCALL_64_after_hwframe+0x46/0xbb

-> #1 (&ovl_i_mutex_dir_key[depth]){++++}:
       down_read+0x36/0x80 kernel/locking/rwsem.c:24
       inode_lock_shared include/linux/fs.h:729 [inline]
       do_last fs/namei.c:3333 [inline]
       path_openat+0x149b/0x2970 fs/namei.c:3569
       do_filp_open+0x179/0x3c0 fs/namei.c:3603
       do_open_execat+0xd3/0x450 fs/exec.c:849
       do_execveat_common+0x711/0x1f30 fs/exec.c:1755
       do_execve fs/exec.c:1860 [inline]
       SYSC_execve fs/exec.c:1941 [inline]
       SyS_execve+0x3b/0x50 fs/exec.c:1936
       do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
       entry_SYSCALL_64_after_hwframe+0x46/0xbb

-> #0 (&sig->cred_guard_mutex){+.+.}:
       lock_acquire+0x170/0x3f0 kernel/locking/lockdep.c:3998
       __mutex_lock_common kernel/locking/mutex.c:756 [inline]
       __mutex_lock+0xc4/0x1310 kernel/locking/mutex.c:893
       lock_trace fs/proc/base.c:407 [inline]
       proc_pid_personality+0x48/0x160 fs/proc/base.c:2926
       proc_single_show+0xe7/0x150 fs/proc/base.c:761
       seq_read+0x4e4/0x1180 fs/seq_file.c:240
       do_loop_readv_writev fs/read_write.c:695 [inline]
       do_loop_readv_writev fs/read_write.c:682 [inline]
       do_iter_read+0x3eb/0x5b0 fs/read_write.c:919
       vfs_readv+0xc8/0x120 fs/read_write.c:981
       do_preadv fs/read_write.c:1065 [inline]
       SYSC_preadv fs/read_write.c:1115 [inline]
       SyS_preadv+0x15a/0x200 fs/read_write.c:1110
       do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
       entry_SYSCALL_64_after_hwframe+0x46/0xbb

other info that might help us debug this:

Chain exists of:
  &sig->cred_guard_mutex --> sb_writers#3 --> &p->lock

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&p->lock);
                               lock(sb_writers#3);
                               lock(&p->lock);
  lock(&sig->cred_guard_mutex);

 *** DEADLOCK ***

1 lock held by syz-executor862/7986:
 #0:  (&p->lock){+.+.}, at: [<ffffffff818edd5a>] seq_read+0xba/0x1180 fs/seq_file.c:168

stack backtrace:
CPU: 1 PID: 7986 Comm: syz-executor862 Not tainted 4.14.249-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:17 [inline]
 dump_stack+0x1b2/0x281 lib/dump_stack.c:58
 print_circular_bug.constprop.0.cold+0x2d7/0x41e kernel/locking/lockdep.c:1258
 check_prev_add kernel/locking/lockdep.c:1905 [inline]
 check_prevs_add kernel/locking/lockdep.c:2022 [inline]
 validate_chain kernel/locking/lockdep.c:2464 [inline]
 __lock_acquire+0x2e0e/0x3f20 kernel/locking/lockdep.c:3491
 lock_acquire+0x170/0x3f0 kernel/locking/lockdep.c:3998
 __mutex_lock_common kernel/locking/mutex.c:756 [inline]
 __mutex_lock+0xc4/0x1310 kernel/locking/mutex.c:893
 lock_trace fs/proc/base.c:407 [inline]
 proc_pid_personality+0x48/0x160 fs/proc/base.c:2926
 proc_single_show+0xe7/0x150 fs/proc/base.c:761
 seq_read+0x4e4/0x1180 fs/seq_file.c:240
 do_loop_readv_writev fs/read_write.c:695 [inline]
 do_loop_readv_writev fs/read_write.c:682 [inline]
 do_iter_read+0x3eb/0x5b0 fs/read_write.c:919
 vfs_readv+0xc8/0x120 fs/read_write.c:981
 do_preadv fs/read_write.c:1065 [inline]
 SYSC_preadv fs/read_write.c:1115 [inline]
 SyS_preadv+0x15a/0x200 fs/read_write.c:1110
 do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
 entry_SYSCALL_64_after_hwframe+0x46/0xbb
RIP: 0033:0x7fb72844a459
RSP: 002b:00007ffd8d24e368 EFLAGS: 00000246 ORIG_RAX: 0000000000000127
RAX: ffffffffffffffda RBX: 0030656c69662f2e RCX: 00007fb72844a459
RDX: 0000000000000001 RSI: 0000000020000280

Crashes (11):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2021/10/11 23:04 linux-4.14.y 756db2ba8bde 838e7e2c .config console log report syz C ci2-linux-4-14 possible deadlock in proc_pid_personality
2021/09/15 13:55 linux-4.14.y f96eb53cbd76 07e953c1 .config console log report syz C ci2-linux-4-14 possible deadlock in proc_pid_personality
2020/08/29 13:57 linux-4.14.y d7e78d08fa77 d5a3ae1f .config console log report syz C ci2-linux-4-14
2021/04/08 21:06 linux-4.14.y 0cc244011f40 6a81331a .config console log report info ci2-linux-4-14 possible deadlock in proc_pid_personality
2021/04/03 03:01 linux-4.14.y bd634aa64163 6a81331a .config console log report info ci2-linux-4-14 possible deadlock in proc_pid_personality
2021/03/31 17:25 linux-4.14.y bd634aa64163 6a81331a .config console log report info ci2-linux-4-14 possible deadlock in proc_pid_personality
2020/12/07 07:21 linux-4.14.y c196b3a9c83a c521566d .config console log report info ci2-linux-4-14
2020/10/28 09:46 linux-4.14.y 5b7a52cd2eef 96e03c1c .config console log report info ci2-linux-4-14
2020/10/28 07:55 linux-4.14.y 5b7a52cd2eef 96e03c1c .config console log report info ci2-linux-4-14
2020/08/29 13:03 linux-4.14.y d7e78d08fa77 d5a3ae1f .config console log report ci2-linux-4-14
2020/08/16 11:43 linux-4.14.y 14b58326976d 5ce13532 .config console log report ci2-linux-4-14
* Struck through repros no longer work on HEAD.