syzbot

syz.0.17[5952]: memfd_create() called without MFD_EXEC or MFD_NOEXEC_SEAL set
loop0: detected capacity change from 0 to 512
======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.0.17/5952 is trying to acquire lock:
ffff88807a622bd8 (&sbi->s_writepages_rwsem){++++}-{0:0}, at: ext4_writepages_down_read fs/ext4/ext4.h:1767 [inline]
ffff88807a622bd8 (&sbi->s_writepages_rwsem){++++}-{0:0}, at: ext4_writepages+0x170/0x2f0 fs/ext4/inode.c:2806

but task is already holding lock:
ffff88807260e4c8 (&ei->xattr_sem){++++}-{3:3}, at: ext4_write_trylock_xattr fs/ext4/xattr.h:162 [inline]
ffff88807260e4c8 (&ei->xattr_sem){++++}-{3:3}, at: ext4_try_to_expand_extra_isize fs/ext4/inode.c:6007 [inline]
ffff88807260e4c8 (&ei->xattr_sem){++++}-{3:3}, at: __ext4_mark_inode_dirty+0x3dc/0x6e0 fs/ext4/inode.c:6088

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (&ei->xattr_sem){++++}-{3:3}:
       down_read+0x46/0x2e0 kernel/locking/rwsem.c:1520
       ext4_setattr+0x86b/0x1c90 fs/ext4/inode.c:5490
       notify_change+0xb0d/0xe10 fs/attr.c:499
       chown_common+0x3f9/0x5a0 fs/open.c:783
       do_fchownat+0x168/0x270 fs/open.c:814
       __do_sys_chown fs/open.c:834 [inline]
       __se_sys_chown fs/open.c:832 [inline]
       __x64_sys_chown+0x82/0x90 fs/open.c:832
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #1 (jbd2_handle){.+.+}-{0:0}:
       start_this_handle+0x1e9d/0x20c0 fs/jbd2/transaction.c:448
       jbd2__journal_start+0x2bb/0x5b0 fs/jbd2/transaction.c:505
       __ext4_journal_start_sb+0x203/0x570 fs/ext4/ext4_jbd2.c:112
       __ext4_journal_start fs/ext4/ext4_jbd2.h:326 [inline]
       ext4_do_writepages+0xf92/0x38d0 fs/ext4/inode.c:2701
       ext4_writepages+0x1a8/0x2f0 fs/ext4/inode.c:2807
       do_writepages+0x3a2/0x600 mm/page-writeback.c:2575
       __writeback_single_inode+0x153/0xee0 fs/fs-writeback.c:1635
       writeback_sb_inodes+0x77c/0xef0 fs/fs-writeback.c:1926
       __writeback_inodes_wb+0x111/0x240 fs/fs-writeback.c:1997
       wb_writeback+0x464/0xba0 fs/fs-writeback.c:2107
       wb_check_background_flush fs/fs-writeback.c:2177 [inline]
       wb_do_writeback fs/fs-writeback.c:2265 [inline]
       wb_workfn+0xb32/0xe20 fs/fs-writeback.c:2292
       process_one_work kernel/workqueue.c:2634 [inline]
       process_scheduled_works+0xa45/0x15b0 kernel/workqueue.c:2711
       worker_thread+0xa55/0xfc0 kernel/workqueue.c:2792
       kthread+0x2fa/0x390 kernel/kthread.c:388
       ret_from_fork+0x48/0x80 arch/x86/kernel/process.c:152
       ret_from_fork_asm+0x11/0x20 arch/x86/entry/entry_64.S:293

-> #0 (&sbi->s_writepages_rwsem){++++}-{0:0}:
       check_prev_add kernel/locking/lockdep.c:3134 [inline]
       check_prevs_add kernel/locking/lockdep.c:3253 [inline]
       validate_chain kernel/locking/lockdep.c:3869 [inline]
       __lock_acquire+0x2ddb/0x7c80 kernel/locking/lockdep.c:5137
       lock_acquire+0x197/0x410 kernel/locking/lockdep.c:5754
       percpu_down_read+0x44/0x1a0 include/linux/percpu-rwsem.h:51
       ext4_writepages_down_read fs/ext4/ext4.h:1767 [inline]
       ext4_writepages+0x170/0x2f0 fs/ext4/inode.c:2806
       do_writepages+0x3a2/0x600 mm/page-writeback.c:2575
       __writeback_single_inode+0x153/0xee0 fs/fs-writeback.c:1635
       writeback_single_inode+0x211/0x720 fs/fs-writeback.c:1756
       write_inode_now+0x161/0x1e0 fs/fs-writeback.c:2802
       iput_final fs/inode.c:1807 [inline]
       iput+0x5b2/0x920 fs/inode.c:1846
       ext4_xattr_block_set+0x273a/0x32a0 fs/ext4/xattr.c:2211
       ext4_xattr_move_to_block fs/ext4/xattr.c:2679 [inline]
       ext4_xattr_make_inode_space fs/ext4/xattr.c:2754 [inline]
       ext4_expand_extra_isize_ea+0x10ea/0x19e0 fs/ext4/xattr.c:2846
       __ext4_expand_extra_isize+0x306/0x400 fs/ext4/inode.c:5967
       ext4_try_to_expand_extra_isize fs/ext4/inode.c:6010 [inline]
       __ext4_mark_inode_dirty+0x45d/0x6e0 fs/ext4/inode.c:6088
       ext4_evict_inode+0x7ed/0xea0 fs/ext4/inode.c:252
       evict+0x486/0x870 fs/inode.c:705
       ext4_orphan_cleanup+0xbd4/0x1400 fs/ext4/orphan.c:470
       __ext4_fill_super fs/ext4/super.c:5601 [inline]
       ext4_fill_super+0x5de4/0x66c0 fs/ext4/super.c:5724
       get_tree_bdev+0x3e4/0x510 fs/super.c:1591
       vfs_get_tree+0x8c/0x280 fs/super.c:1764
       do_new_mount+0x24b/0xa40 fs/namespace.c:3386
       do_mount fs/namespace.c:3726 [inline]
       __do_sys_mount fs/namespace.c:3935 [inline]
       __se_sys_mount+0x2da/0x3c0 fs/namespace.c:3912
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

other info that might help us debug this:

Chain exists of:
  &sbi->s_writepages_rwsem --> jbd2_handle --> &ei->xattr_sem

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ei->xattr_sem);
                               lock(jbd2_handle);
                               lock(&ei->xattr_sem);
  rlock(&sbi->s_writepages_rwsem);

 *** DEADLOCK ***

3 locks held by syz.0.17/5952:
 #0: ffff88807a6200e0 (&type->s_umount_key#31){++++}-{3:3}, at: __super_lock fs/super.c:56 [inline]
 #0: ffff88807a6200e0 (&type->s_umount_key#31){++++}-{3:3}, at: __super_lock_excl fs/super.c:71 [inline]
 #0: ffff88807a6200e0 (&type->s_umount_key#31){++++}-{3:3}, at: get_tree_bdev+0x344/0x510 fs/super.c:1589
 #1: ffff88807a620608 (sb_internal){.+.+}-{0:0}, at: __sb_start_write include/linux/fs.h:1633 [inline]
 #1: ffff88807a620608 (sb_internal){.+.+}-{0:0}, at: sb_start_intwrite include/linux/fs.h:1755 [inline]
 #1: ffff88807a620608 (sb_internal){.+.+}-{0:0}, at: ext4_evict_inode+0x2b9/0xea0 fs/ext4/inode.c:213
 #2: ffff88807260e4c8 (&ei->xattr_sem){++++}-{3:3}, at: ext4_write_trylock_xattr fs/ext4/xattr.h:162 [inline]
 #2: ffff88807260e4c8 (&ei->xattr_sem){++++}-{3:3}, at: ext4_try_to_expand_extra_isize fs/ext4/inode.c:6007 [inline]
 #2: ffff88807260e4c8 (&ei->xattr_sem){++++}-{3:3}, at: __ext4_mark_inode_dirty+0x3dc/0x6e0 fs/ext4/inode.c:6088

stack backtrace:
CPU: 1 PID: 5952 Comm: syz.0.17 Not tainted syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/02/2025
Call Trace:
 <TASK>
 dump_stack_lvl+0x16c/0x230 lib/dump_stack.c:106
 check_noncircular+0x2bd/0x3c0 kernel/locking/lockdep.c:2187
 check_prev_add kernel/locking/lockdep.c:3134 [inline]
 check_prevs_add kernel/locking/lockdep.c:3253 [inline]
 validate_chain kernel/locking/lockdep.c:3869 [inline]
 __lock_acquire+0x2ddb/0x7c80 kernel/locking/lockdep.c:5137
 lock_acquire+0x197/0x410 kernel/locking/lockdep.c:5754
 percpu_down_read+0x44/0x1a0 include/linux/percpu-rwsem.h:51
 ext4_writepages_down_read fs/ext4/ext4.h:1767 [inline]
 ext4_writepages+0x170/0x2f0 fs/ext4/inode.c:2806
 do_writepages+0x3a2/0x600 mm/page-writeback.c:2575
 __writeback_single_inode+0x153/0xee0 fs/fs-writeback.c:1635
 writeback_single_inode+0x211/0x720 fs/fs-writeback.c:1756
 write_inode_now+0x161/0x1e0 fs/fs-writeback.c:2802
 iput_final fs/inode.c:1807 [inline]
 iput+0x5b2/0x920 fs/inode.c:1846
 ext4_xattr_block_set+0x273a/0x32a0 fs/ext4/xattr.c:2211
 ext4_xattr_move_to_block fs/ext4/xattr.c:2679 [inline]
 ext4_xattr_make_inode_space fs/ext4/xattr.c:2754 [inline]
 ext4_expand_extra_isize_ea+0x10ea/0x19e0 fs/ext4/xattr.c:2846
 __ext4_expand_extra_isize+0x306/0x400 fs/ext4/inode.c:5967
 ext4_try_to_expand_extra_isize fs/ext4/inode.c:6010 [inline]
 __ext4_mark_inode_dirty+0x45d/0x6e0 fs/ext4/inode.c:6088
 ext4_evict_inode+0x7ed/0xea0 fs/ext4/inode.c:252
 evict+0x486/0x870 fs/inode.c:705
 ext4_orphan_cleanup+0xbd4/0x1400 fs/ext4/orphan.c:470
 __ext4_fill_super fs/ext4/super.c:5601 [inline]
 ext4_fill_super+0x5de4/0x66c0 fs/ext4/super.c:5724
 get_tree_bdev+0x3e4/0x510 fs/super.c:1591
 vfs_get_tree+0x8c/0x280 fs/super.c:1764
 do_new_mount+0x24b/0xa40 fs/namespace.c:3386
 do_mount fs/namespace.c:3726 [inline]
 __do_sys_mount fs/namespace.c:3935 [inline]
 __se_sys_mount+0x2da/0x3c0 fs/namespace.c:3912
 do_syscall_x64 arch/x86/entry/common.c:51 [inline]
 do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:81
 entry_SYSCALL_64_after_hwframe+0x68/0xd2
RIP: 0033:0x7fe20ff90e6a
Code: d8 64 89 02 48 c7 c0 ff ff ff ff eb a6 e8 de 1a 00 00 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 49 89 ca b8 a5 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffe7b72c378 EFLAGS: 00000246 ORIG_RAX: 00000000000000a5
RAX: ffffffffffffffda RBX: 00007ffe7b72c400 RCX: 00007fe20ff90e6a
RDX: 00002000000000c0 RSI: 00002000000001c0 RDI: 00007ffe7b72c3c0
RBP: 00002000000000c0 R08: 00007ffe7b72c400 R09: 0000000000000012
R10: 0000000000000012 R11: 0000000000000246 R12: 00002000000001c0
R13: 00007ffe7b72c3c0 R14: 000000000000046f R15: 0000200000000300
 </TASK>
------------[ cut here ]------------
EA inode 11 i_nlink=2
WARNING: CPU: 1 PID: 5952 at fs/ext4/xattr.c:1075 ext4_xattr_inode_update_ref+0x4fb/0x550 fs/ext4/xattr.c:1073
Modules linked in:
CPU: 1 PID: 5952 Comm: syz.0.17 Not tainted syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/02/2025
RIP: 0010:ext4_xattr_inode_update_ref+0x4fb/0x550 fs/ext4/xattr.c:1073
Code: 8d 7e 50 4c 89 f8 48 c1 e8 03 42 80 3c 20 00 74 08 4c 89 ff e8 c6 3b 9a ff 49 8b 37 48 c7 c7 a0 c3 be 8a 89 da e8 c5 5d 0d ff <0f> 0b 4c 8b 74 24 08 4c 8b 7c 24 10 e9 b9 fe ff ff e8 6f 1d 2c 08
RSP: 0018:ffffc900032671c0 EFLAGS: 00010246
RAX: f499856801076a00 RBX: 0000000000000002 RCX: ffff88802c069e00
RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000002
RBP: ffffc900032672b8 R08: ffffc90003266dc7 R09: 1ffff9200064cdb8
R10: dffffc0000000000 R11: fffff5200064cdb9 R12: dffffc0000000000
R13: ffff88805e44d4a8 R14: ffff88805e44d2b0 R15: ffff88805e44d300
FS:  000055557e809500(0000) GS:ffff8880b8f00000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007ffe7b72d000 CR3: 000000002ea79000 CR4: 00000000003506e0
Call Trace:
 <TASK>
 ext4_xattr_inode_dec_ref fs/ext4/xattr.c:1098 [inline]
 ext4_xattr_set_entry+0xcda/0x1e90 fs/ext4/xattr.c:1736
 ext4_xattr_ibody_set+0x254/0x6a0 fs/ext4/xattr.c:2283
 ext4_xattr_move_to_block fs/ext4/xattr.c:2686 [inline]
 ext4_xattr_make_inode_space fs/ext4/xattr.c:2754 [inline]
 ext4_expand_extra_isize_ea+0x113a/0x19e0 fs/ext4/xattr.c:2846
 __ext4_expand_extra_isize+0x306/0x400 fs/ext4/inode.c:5967
 ext4_try_to_expand_extra_isize fs/ext4/inode.c:6010 [inline]
 __ext4_mark_inode_dirty+0x45d/0x6e0 fs/ext4/inode.c:6088
 ext4_evict_inode+0x7ed/0xea0 fs/ext4/inode.c:252
 evict+0x486/0x870 fs/inode.c:705
 ext4_orphan_cleanup+0xbd4/0x1400 fs/ext4/orphan.c:470
 __ext4_fill_super fs/ext4/super.c:5601 [inline]
 ext4_fill_super+0x5de4/0x66c0 fs/ext4/super.c:5724
 get_tree_bdev+0x3e4/0x510 fs/super.c:1591
 vfs_get_tree+0x8c/0x280 fs/super.c:1764
 do_new_mount+0x24b/0xa40 fs/namespace.c:3386
 do_mount fs/namespace.c:3726 [inline]
 __do_sys_mount fs/namespace.c:3935 [inline]
 __se_sys_mount+0x2da/0x3c0 fs/namespace.c:3912
 do_syscall_x64 arch/x86/entry/common.c:51 [inline]
 do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:81
 entry_SYSCALL_64_after_hwframe+0x68/0xd2
RIP: 0033:0x7fe20ff90e6a
Code: d8 64 89 02 48 c7 c0 ff ff ff ff eb a6 e8 de 1a 00 00 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 49 89 ca b8 a5 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffe7b72c378 EFLAGS: 00000246 ORIG_RAX: 00000000000000a5
RAX: ffffffffffffffda RBX: 00007ffe7b72c400 RCX: 00007fe20ff90e6a
RDX: 00002000000000c0 RSI: 00002000000001c0 RDI: 00007ffe7b72c3c0
RBP: 00002000000000c0 R08: 00007ffe7b72c400 R09: 0000000000000012
R10: 0000000000000012 R11: 0000000000000246 R12: 00002000000001c0
R13: 00007ffe7b72c3c0 R14: 000000000000046f R15: 0000200000000300
 </TASK>