syzbot


possible deadlock in ocfs2_acquire_dquot

Status: upstream: reported on 2025/09/02 13:27
Reported-by: syzbot+c65952575aa91f3e8533@syzkaller.appspotmail.com
First crash: 64d, last: 18d
Similar bugs (3)
Kernel Title Rank 🛈 Repro Cause bisect Fix bisect Count Last Reported Patched Status
linux-6.1 possible deadlock in ocfs2_acquire_dquot origin:lts-only 4 C inconclusive 13531 5h26m 405d 0/3 upstream: reported C repro on 2024/09/26 09:48
upstream possible deadlock in ocfs2_acquire_dquot ocfs2 4 C 65688 17m 401d 0/29 upstream: reported C repro on 2024/09/30 01:47
linux-5.15 possible deadlock in ocfs2_acquire_dquot origin:lts-only 4 C error 12123 2h54m 405d 0/3 upstream: reported C repro on 2024/09/26 06:26

Sample crash report:
ocfs2: Mounting device (7,2) on (node local, slot 0) with ordered data mode.
======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.2.8987/26613 is trying to acquire lock:
ffff88807ab0e608 (sb_internal#2){.+.+}-{0:0}, at: ocfs2_acquire_dquot+0x67b/0xaf0 fs/ocfs2/quota_global.c:848

but task is already holding lock:
ffff88806b94cda0 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_lock_global_qf+0x1e9/0x270 fs/ocfs2/quota_global.c:314

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #6 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}:
       down_write+0x97/0x1f0 kernel/locking/rwsem.c:1573
       ocfs2_lock_global_qf+0x1e9/0x270 fs/ocfs2/quota_global.c:314
       ocfs2_acquire_dquot+0x2a1/0xaf0 fs/ocfs2/quota_global.c:816
       dqget+0x77c/0xeb0 fs/quota/dquot.c:988
       dquot_set_dqblk+0x2b/0xf90 fs/quota/dquot.c:2831
       quota_setquota+0x4b0/0x530 fs/quota/quota.c:310
       __do_sys_quotactl fs/quota/quota.c:961 [inline]
       __se_sys_quotactl+0x27b/0x950 fs/quota/quota.c:917
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #5 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6){+.+.}-{3:3}:
       down_write+0x97/0x1f0 kernel/locking/rwsem.c:1573
       inode_lock include/linux/fs.h:804 [inline]
       ocfs2_lock_global_qf+0x1cb/0x270 fs/ocfs2/quota_global.c:313
       ocfs2_acquire_dquot+0x2a1/0xaf0 fs/ocfs2/quota_global.c:816
       dqget+0x77c/0xeb0 fs/quota/dquot.c:988
       dquot_set_dqblk+0x2b/0xf90 fs/quota/dquot.c:2831
       quota_setquota+0x4b0/0x530 fs/quota/quota.c:310
       __do_sys_quotactl fs/quota/quota.c:961 [inline]
       __se_sys_quotactl+0x27b/0x950 fs/quota/quota.c:917
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #4 (&dquot->dq_lock){+.+.}-{3:3}:
       __mutex_lock_common kernel/locking/mutex.c:603 [inline]
       __mutex_lock+0x129/0xcc0 kernel/locking/mutex.c:747
       wait_on_dquot fs/quota/dquot.c:356 [inline]
       dqget+0x6fc/0xeb0 fs/quota/dquot.c:983
       dquot_transfer+0x2f9/0x6d0 fs/quota/dquot.c:2149
       ext4_setattr+0x87d/0x1c90 fs/ext4/inode.c:5477
       notify_change+0xb0d/0xe10 fs/attr.c:499
       chown_common+0x3f9/0x5a0 fs/open.c:783
       do_fchownat+0x168/0x270 fs/open.c:814
       __do_sys_fchownat fs/open.c:829 [inline]
       __se_sys_fchownat fs/open.c:826 [inline]
       __x64_sys_fchownat+0xb5/0xd0 fs/open.c:826
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #3 (&ei->xattr_sem){++++}-{3:3}:
       down_read+0x46/0x2e0 kernel/locking/rwsem.c:1520
       ext4_setattr+0x86b/0x1c90 fs/ext4/inode.c:5476
       notify_change+0xb0d/0xe10 fs/attr.c:499
       chown_common+0x3f9/0x5a0 fs/open.c:783
       do_fchownat+0x168/0x270 fs/open.c:814
       __do_sys_chown fs/open.c:834 [inline]
       __se_sys_chown fs/open.c:832 [inline]
       __x64_sys_chown+0x82/0x90 fs/open.c:832
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #2 (jbd2_handle){++++}-{0:0}:
       start_this_handle+0x1e9d/0x20c0 fs/jbd2/transaction.c:448
       jbd2__journal_start+0x2bb/0x5b0 fs/jbd2/transaction.c:505
       jbd2_journal_start+0x2a/0x40 fs/jbd2/transaction.c:544
       ocfs2_start_trans+0x376/0x6c0 fs/ocfs2/journal.c:374
       ocfs2_shutdown_local_alloc+0x201/0xa10 fs/ocfs2/localalloc.c:416
       ocfs2_dismount_volume+0x1e2/0x890 fs/ocfs2/super.c:1883
       generic_shutdown_super+0x134/0x2b0 fs/super.c:693
       kill_block_super+0x44/0x90 fs/super.c:1660
       deactivate_locked_super+0x97/0x100 fs/super.c:481
       cleanup_mnt+0x429/0x4c0 fs/namespace.c:1250
       task_work_run+0x1ce/0x250 kernel/task_work.c:239
       resume_user_mode_work include/linux/resume_user_mode.h:49 [inline]
       exit_to_user_mode_loop+0xe6/0x110 kernel/entry/common.c:177
       exit_to_user_mode_prepare+0xf6/0x180 kernel/entry/common.c:210
       __syscall_exit_to_user_mode_work kernel/entry/common.c:291 [inline]
       syscall_exit_to_user_mode+0x1a/0x50 kernel/entry/common.c:302
       do_syscall_64+0x61/0xb0 arch/x86/entry/common.c:87
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #1 (&journal->j_trans_barrier){.+.+}-{3:3}:
       down_read+0x46/0x2e0 kernel/locking/rwsem.c:1520
       ocfs2_start_trans+0x36a/0x6c0 fs/ocfs2/journal.c:372
       ocfs2_shutdown_local_alloc+0x201/0xa10 fs/ocfs2/localalloc.c:416
       ocfs2_dismount_volume+0x1e2/0x890 fs/ocfs2/super.c:1883
       generic_shutdown_super+0x134/0x2b0 fs/super.c:693
       kill_block_super+0x44/0x90 fs/super.c:1660
       deactivate_locked_super+0x97/0x100 fs/super.c:481
       cleanup_mnt+0x429/0x4c0 fs/namespace.c:1250
       task_work_run+0x1ce/0x250 kernel/task_work.c:239
       resume_user_mode_work include/linux/resume_user_mode.h:49 [inline]
       exit_to_user_mode_loop+0xe6/0x110 kernel/entry/common.c:177
       exit_to_user_mode_prepare+0xf6/0x180 kernel/entry/common.c:210
       __syscall_exit_to_user_mode_work kernel/entry/common.c:291 [inline]
       syscall_exit_to_user_mode+0x1a/0x50 kernel/entry/common.c:302
       do_syscall_64+0x61/0xb0 arch/x86/entry/common.c:87
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #0 (sb_internal#2){.+.+}-{0:0}:
       check_prev_add kernel/locking/lockdep.c:3134 [inline]
       check_prevs_add kernel/locking/lockdep.c:3253 [inline]
       validate_chain kernel/locking/lockdep.c:3869 [inline]
       __lock_acquire+0x2ddb/0x7c80 kernel/locking/lockdep.c:5137
       lock_acquire+0x197/0x410 kernel/locking/lockdep.c:5754
       percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
       __sb_start_write include/linux/fs.h:1633 [inline]
       sb_start_intwrite include/linux/fs.h:1755 [inline]
       ocfs2_start_trans+0x26b/0x6c0 fs/ocfs2/journal.c:370
       ocfs2_acquire_dquot+0x67b/0xaf0 fs/ocfs2/quota_global.c:848
       dqget+0x77c/0xeb0 fs/quota/dquot.c:988
       dquot_set_dqblk+0x2b/0xf90 fs/quota/dquot.c:2831
       quota_setquota+0x4b0/0x530 fs/quota/quota.c:310
       __do_sys_quotactl fs/quota/quota.c:961 [inline]
       __se_sys_quotactl+0x27b/0x950 fs/quota/quota.c:917
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

other info that might help us debug this:

Chain exists of:
  sb_internal#2 --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6 --> &ocfs2_quota_ip_alloc_sem_key

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ocfs2_quota_ip_alloc_sem_key);
                               lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6);
                               lock(&ocfs2_quota_ip_alloc_sem_key);
  rlock(sb_internal#2);

 *** DEADLOCK ***

4 locks held by syz.2.8987/26613:
 #0: ffff88807ab0e0e0 (&type->s_umount_key#74){++++}-{3:3}, at: __super_lock fs/super.c:58 [inline]
 #0: ffff88807ab0e0e0 (&type->s_umount_key#74){++++}-{3:3}, at: super_lock+0x167/0x360 fs/super.c:117
 #1: ffff8880480600a8 (&dquot->dq_lock){+.+.}-{3:3}, at: ocfs2_acquire_dquot+0x294/0xaf0 fs/ocfs2/quota_global.c:811
 #2: ffff88806b94d118 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:804 [inline]
 #2: ffff88806b94d118 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6){+.+.}-{3:3}, at: ocfs2_lock_global_qf+0x1cb/0x270 fs/ocfs2/quota_global.c:313
 #3: ffff88806b94cda0 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_lock_global_qf+0x1e9/0x270 fs/ocfs2/quota_global.c:314

stack backtrace:
CPU: 0 PID: 26613 Comm: syz.2.8987 Not tainted syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/02/2025
Call Trace:
 <TASK>
 dump_stack_lvl+0x16c/0x230 lib/dump_stack.c:106
 check_noncircular+0x2bd/0x3c0 kernel/locking/lockdep.c:2187
 check_prev_add kernel/locking/lockdep.c:3134 [inline]
 check_prevs_add kernel/locking/lockdep.c:3253 [inline]
 validate_chain kernel/locking/lockdep.c:3869 [inline]
 __lock_acquire+0x2ddb/0x7c80 kernel/locking/lockdep.c:5137
 lock_acquire+0x197/0x410 kernel/locking/lockdep.c:5754
 percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
 __sb_start_write include/linux/fs.h:1633 [inline]
 sb_start_intwrite include/linux/fs.h:1755 [inline]
 ocfs2_start_trans+0x26b/0x6c0 fs/ocfs2/journal.c:370
 ocfs2_acquire_dquot+0x67b/0xaf0 fs/ocfs2/quota_global.c:848
 dqget+0x77c/0xeb0 fs/quota/dquot.c:988
 dquot_set_dqblk+0x2b/0xf90 fs/quota/dquot.c:2831
 quota_setquota+0x4b0/0x530 fs/quota/quota.c:310
 __do_sys_quotactl fs/quota/quota.c:961 [inline]
 __se_sys_quotactl+0x27b/0x950 fs/quota/quota.c:917
 do_syscall_x64 arch/x86/entry/common.c:51 [inline]
 do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:81
 entry_SYSCALL_64_after_hwframe+0x68/0xd2
RIP: 0033:0x7f8525d8efc9
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f8526c69038 EFLAGS: 00000246 ORIG_RAX: 00000000000000b3
RAX: ffffffffffffffda RBX: 00007f8525fe5fa0 RCX: 00007f8525d8efc9
RDX: 0000000000000000 RSI: 0000200000000100 RDI: ffffffff80000801
RBP: 00007f8525e11f91 R08: 0000000000000000 R09: 0000000000000000
R10: 0000200000000200 R11: 0000000000000246 R12: 0000000000000000
R13: 00007f8525fe6038 R14: 00007f8525fe5fa0 R15: 00007ffd99749768
 </TASK>

Crashes (8):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2025/10/17 22:00 linux-6.6.y 0bbbd97a442d 1c8c8cd8 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-6-kasan possible deadlock in ocfs2_acquire_dquot
2025/10/15 16:45 linux-6.6.y 0bbbd97a442d 19568248 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-6-kasan possible deadlock in ocfs2_acquire_dquot
2025/10/07 22:19 linux-6.6.y e617101e5626 7e2882b3 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-6-kasan possible deadlock in ocfs2_acquire_dquot
2025/10/01 10:59 linux-6.6.y 147338df3487 a1859138 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-6-kasan possible deadlock in ocfs2_acquire_dquot
2025/09/29 11:19 linux-6.6.y 147338df3487 86341da6 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-6-kasan possible deadlock in ocfs2_acquire_dquot
2025/09/24 04:59 linux-6.6.y af1544b5d072 0abd0691 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-6-kasan possible deadlock in ocfs2_acquire_dquot
2025/09/10 00:34 linux-6.6.y fe9731e10004 fdeaa69b .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-6-kasan possible deadlock in ocfs2_acquire_dquot
2025/09/02 13:26 linux-6.6.y cc1a1c5b404a 96a211bc .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-6-kasan possible deadlock in ocfs2_acquire_dquot
* Struck through repros no longer work on HEAD.