syzbot


possible deadlock in xt_find_revision

Status: upstream: reported C repro on 2020/01/06 20:11
Reported-by: syzbot+ed933a328f896a227a7a@syzkaller.appspotmail.com
First crash: 1625d, last: 648d
Fix bisection: failed (error log, bisect log)
  
Similar bugs (1)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
upstream possible deadlock in xt_find_revision netfilter 2 2333d 2333d 0/27 closed as dup on 2018/01/30 09:08
Fix bisection attempts (19)
Created Duration User Patch Repo Result
2022/10/13 02:23 0m bisect fix linux-4.14.y error job log (0)
2022/09/10 01:38 24m bisect fix linux-4.14.y job log (0) log
2022/08/11 00:44 30m bisect fix linux-4.14.y job log (0) log
2022/07/12 00:17 27m bisect fix linux-4.14.y job log (0) log
2022/06/11 23:37 24m bisect fix linux-4.14.y job log (0) log
2022/05/12 23:10 26m bisect fix linux-4.14.y job log (0) log
2022/04/12 22:43 25m bisect fix linux-4.14.y job log (0) log
2022/03/13 22:20 22m bisect fix linux-4.14.y job log (0) log
2022/02/11 02:12 21m bisect fix linux-4.14.y job log (0) log
2022/01/12 01:39 33m bisect fix linux-4.14.y job log (0) log
2021/12/13 01:13 25m bisect fix linux-4.14.y job log (0) log
2021/11/13 00:47 26m bisect fix linux-4.14.y job log (0) log
2021/10/14 00:20 27m bisect fix linux-4.14.y job log (0) log
2021/09/13 23:52 26m bisect fix linux-4.14.y job log (0) log
2021/08/14 23:22 27m bisect fix linux-4.14.y job log (0) log
2021/07/15 22:55 22m bisect fix linux-4.14.y job log (0) log
2021/06/15 22:32 21m bisect fix linux-4.14.y job log (0) log
2021/05/16 21:24 28m bisect fix linux-4.14.y job log (0) log
2021/04/16 19:08 22m bisect fix linux-4.14.y job log (0) log

Sample crash report:
ip_tables: iptables: counters copy to user failed while replacing table
IPVS: ftp: loaded support on port[0] = 21
ip_tables: iptables: counters copy to user failed while replacing table
IPVS: ftp: loaded support on port[0] = 21
======================================================
WARNING: possible circular locking dependency detected
4.14.195-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor412/6569 is trying to acquire lock:
 (&xt[i].mutex){+.+.}, at: [<ffffffff85407908>] xt_find_revision+0x88/0x200 net/netfilter/x_tables.c:373

but task is already holding lock:
 (&table[i].mutex){+.+.}, at: [<ffffffff85337306>] nfnl_lock net/netfilter/nfnetlink.c:61 [inline]
 (&table[i].mutex){+.+.}, at: [<ffffffff85337306>] nfnetlink_rcv_msg+0x726/0xc00 net/netfilter/nfnetlink.c:209

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (&table[i].mutex){+.+.}:
       __mutex_lock_common kernel/locking/mutex.c:756 [inline]
       __mutex_lock+0xc4/0x1310 kernel/locking/mutex.c:893
       nf_tables_netdev_event+0x10d/0x4d0 net/netfilter/nf_tables_netdev.c:122
       notifier_call_chain+0x108/0x1a0 kernel/notifier.c:93
       call_netdevice_notifiers_info net/core/dev.c:1667 [inline]
       call_netdevice_notifiers net/core/dev.c:1683 [inline]
       rollback_registered_many+0x70b/0xb30 net/core/dev.c:7202
       unregister_netdevice_many.part.0+0x18/0x2e0 net/core/dev.c:8284
       unregister_netdevice_many+0x36/0x50 net/core/dev.c:8283
       ip6gre_exit_net+0x41e/0x570 net/ipv6/ip6_gre.c:1212
       ops_exit_list+0xa5/0x150 net/core/net_namespace.c:142
       cleanup_net+0x3b3/0x840 net/core/net_namespace.c:484
       process_one_work+0x793/0x14a0 kernel/workqueue.c:2116
       worker_thread+0x5cc/0xff0 kernel/workqueue.c:2250
       kthread+0x30d/0x420 kernel/kthread.c:232
       ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:404

-> #1 (rtnl_mutex){+.+.}:
       __mutex_lock_common kernel/locking/mutex.c:756 [inline]
       __mutex_lock+0xc4/0x1310 kernel/locking/mutex.c:893
       unregister_netdevice_notifier+0x5e/0x2b0 net/core/dev.c:1630
       tee_tg_destroy+0x5c/0xb0 net/netfilter/xt_TEE.c:123
       cleanup_entry+0x1fd/0x2d0 net/ipv4/netfilter/ip_tables.c:666
       __do_replace+0x38d/0x570 net/ipv4/netfilter/ip_tables.c:1086
       do_replace net/ipv4/netfilter/ip_tables.c:1142 [inline]
       do_ipt_set_ctl+0x256/0x39e net/ipv4/netfilter/ip_tables.c:1674
       nf_sockopt net/netfilter/nf_sockopt.c:106 [inline]
       nf_setsockopt+0x5f/0xb0 net/netfilter/nf_sockopt.c:115
       ip_setsockopt net/ipv4/ip_sockglue.c:1255 [inline]
       ip_setsockopt+0x94/0xb0 net/ipv4/ip_sockglue.c:1240
       udp_setsockopt+0x45/0x80 net/ipv4/udp.c:2451
       SYSC_setsockopt net/socket.c:1865 [inline]
       SyS_setsockopt+0x110/0x1e0 net/socket.c:1844
       do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
       entry_SYSCALL_64_after_hwframe+0x46/0xbb

-> #0 (&xt[i].mutex){+.+.}:
       lock_acquire+0x170/0x3f0 kernel/locking/lockdep.c:3998
       __mutex_lock_common kernel/locking/mutex.c:756 [inline]
       __mutex_lock+0xc4/0x1310 kernel/locking/mutex.c:893
       xt_find_revision+0x88/0x200 net/netfilter/x_tables.c:373
       nfnl_compat_get+0x1f7/0x870 net/netfilter/nft_compat.c:678
       nfnetlink_rcv_msg+0x9bb/0xc00 net/netfilter/nfnetlink.c:214
       netlink_rcv_skb+0x125/0x390 net/netlink/af_netlink.c:2433
       nfnetlink_rcv+0x1ab/0x1da0 net/netfilter/nfnetlink.c:515
       netlink_unicast_kernel net/netlink/af_netlink.c:1287 [inline]
       netlink_unicast+0x437/0x610 net/netlink/af_netlink.c:1313
       netlink_sendmsg+0x62e/0xb80 net/netlink/af_netlink.c:1878
       sock_sendmsg_nosec net/socket.c:646 [inline]
       sock_sendmsg+0xb5/0x100 net/socket.c:656
       ___sys_sendmsg+0x6c8/0x800 net/socket.c:2062
       __sys_sendmsg+0xa3/0x120 net/socket.c:2096
       SYSC_sendmsg net/socket.c:2107 [inline]
       SyS_sendmsg+0x27/0x40 net/socket.c:2103
       do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
       entry_SYSCALL_64_after_hwframe+0x46/0xbb

other info that might help us debug this:

Chain exists of:
  &xt[i].mutex --> rtnl_mutex --> &table[i].mutex

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&table[i].mutex);
                               lock(rtnl_mutex);
                               lock(&table[i].mutex);
  lock(&xt[i].mutex);

 *** DEADLOCK ***

1 lock held by syz-executor412/6569:
 #0:  (&table[i].mutex){+.+.}, at: [<ffffffff85337306>] nfnl_lock net/netfilter/nfnetlink.c:61 [inline]
 #0:  (&table[i].mutex){+.+.}, at: [<ffffffff85337306>] nfnetlink_rcv_msg+0x726/0xc00 net/netfilter/nfnetlink.c:209

stack backtrace:
CPU: 0 PID: 6569 Comm: syz-executor412 Not tainted 4.14.195-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:17 [inline]
 dump_stack+0x1b2/0x283 lib/dump_stack.c:58
 print_circular_bug.constprop.0.cold+0x2d7/0x41e kernel/locking/lockdep.c:1258
 check_prev_add kernel/locking/lockdep.c:1905 [inline]
 check_prevs_add kernel/locking/lockdep.c:2022 [inline]
 validate_chain kernel/locking/lockdep.c:2464 [inline]
 __lock_acquire+0x2e0e/0x3f20 kernel/locking/lockdep.c:3491
 lock_acquire+0x170/0x3f0 kernel/locking/lockdep.c:3998
 __mutex_lock_common kernel/locking/mutex.c:756 [inline]
 __mutex_lock+0xc4/0x1310 kernel/locking/mutex.c:893
 xt_find_revision+0x88/0x200 net/netfilter/x_tables.c:373
 nfnl_compat_get+0x1f7/0x870 net/netfilter/nft_compat.c:678
 nfnetlink_rcv_msg+0x9bb/0xc00 net/netfilter/nfnetlink.c:214
 netlink_rcv_skb+0x125/0x390 net/netlink/af_netlink.c:2433
 nfnetlink_rcv+0x1ab/0x1da0 net/netfilter/nfnetlink.c:515
 netlink_unicast_kernel net/netlink/af_netlink.c:1287 [inline]
 netlink_unicast+0x437/0x610 net/netlink/af_netlink.c:1313
 netlink_sendmsg+0x62e/0xb80 net/netlink/af_netlink.c:1878
 sock_sendmsg_nosec net/socket.c:646 [inline]
 sock_sendmsg+0xb5/0x100 net/socket.c:656
 ___sys_sendmsg+0x6c8/0x800 net/socket.c:2062
 __sys_sendmsg+0xa3/0x120 net/socket.c:2096
 SYSC_sendmsg net/socket.c:2107 [inline]
 SyS_sendmsg+0x27/0x40 net/socket.c:2103
 do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
 entry_SYSCALL_64_after_hwframe+0x46/0xbb
RIP: 0033:0x441dd9
RSP: 002b:00007ffc84d94038 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 0000000000441dd9
RDX: 0000000000000000 RSI: 0000000020000100 RDI: 0000000000000004
RBP: 000000000000d785 R08: 0000000b004002c8 R09: 0000000b004002c8
R10: 0000000b004002c8 R11: 0000000000000246 R12: 0000000000402b80
R13: 0000000000402c10 R14: 0000000000000000 R15: 0000000000000000
ip_tables: iptables: counters copy to user failed while replacing table
IPVS: ftp: loaded support on port[0] = 21
ip_tables: iptables: counters copy to user failed while replacing table
IPVS: ftp: loaded support on port[0] = 21
ip_tables: iptables: counters copy to user failed while replacing table
IPVS: ftp: loaded support on port[0] = 21
ip_tables: iptables: counters copy to user failed while replacing table
IPVS: ftp: loaded support on port[0] = 21
ip_tables: iptables: counters copy to user failed while replacing table
IPVS: ftp: loaded support on port[0] = 21
ip_tables: iptables: counters copy to user failed while replacing table
IPVS: ftp: loaded support on port[0] = 21
ip_tables: iptables: counters copy to user failed while replacing table
IPVS: ftp: loaded support on port[0] = 21
ip_tables: iptables: counters copy to user failed while replacing table
IPVS: ftp: loaded support on port[0] = 21
ip_tables: iptables: counters copy to user failed while replacing table
IPVS: ftp: loaded support on port[0] = 21
ip_tables: iptables: counters copy to user failed while replacing table
IPVS: ftp: loaded support on port[0] = 21
ip_tables: iptables: counters copy to user failed while replacing table
IPVS: ftp: loaded support on port[0] = 21
ip_tables: iptables: counters copy to user failed while replacing table
IPVS: ftp: loaded support on port[0] = 21
ip_tables: iptables: counters copy to user failed while replacing table
IPVS: ftp: loaded support on port[0] = 21
ip_tables: iptables: counters copy to user failed while replacing table
IPVS: ftp: loaded support on port[0] = 21
ip_tables: iptables: counters copy to user failed while replacing table

Crashes (4117):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2020/09/03 02:08 linux-4.14.y d7e78d08fa77 abf9ba4f .config console log report syz C ci2-linux-4-14
2021/03/17 14:56 linux-4.14.y c7150cd2fa8c fdb2bb2c .config console log report info ci2-linux-4-14 possible deadlock in xt_find_revision
2021/03/17 09:41 linux-4.14.y c7150cd2fa8c fdb2bb2c .config console log report info ci2-linux-4-14 possible deadlock in xt_find_revision
2021/03/17 06:52 linux-4.14.y c7150cd2fa8c fdb2bb2c .config console log report info ci2-linux-4-14 possible deadlock in xt_find_revision
2021/03/16 20:42 linux-4.14.y c7150cd2fa8c fdb2bb2c .config console log report info ci2-linux-4-14 possible deadlock in xt_find_revision
2021/03/16 07:43 linux-4.14.y c7150cd2fa8c fdb2bb2c .config console log report info ci2-linux-4-14 possible deadlock in xt_find_revision
2021/03/16 01:02 linux-4.14.y c7150cd2fa8c fdb2bb2c .config console log report info ci2-linux-4-14 possible deadlock in xt_find_revision
2021/03/15 23:29 linux-4.14.y c7150cd2fa8c fdb2bb2c .config console log report info ci2-linux-4-14 possible deadlock in xt_find_revision
2021/03/15 17:15 linux-4.14.y c7150cd2fa8c fdb2bb2c .config console log report info ci2-linux-4-14 possible deadlock in xt_find_revision
2021/03/15 15:56 linux-4.14.y c7150cd2fa8c fdb2bb2c .config console log report info ci2-linux-4-14 possible deadlock in xt_find_revision
2021/03/15 14:42 linux-4.14.y c7150cd2fa8c fdb2bb2c .config console log report info ci2-linux-4-14 possible deadlock in xt_find_revision
2021/03/15 13:37 linux-4.14.y c7150cd2fa8c cc1cff8f .config console log report info ci2-linux-4-14 possible deadlock in xt_find_revision
2021/03/15 11:05 linux-4.14.y c7150cd2fa8c cc1cff8f .config console log report info ci2-linux-4-14 possible deadlock in xt_find_revision
2021/03/15 08:40 linux-4.14.y c7150cd2fa8c cc1cff8f .config console log report info ci2-linux-4-14 possible deadlock in xt_find_revision
2021/03/14 23:58 linux-4.14.y c7150cd2fa8c cc1cff8f .config console log report info ci2-linux-4-14 possible deadlock in xt_find_revision
2021/03/14 21:24 linux-4.14.y c7150cd2fa8c cc1cff8f .config console log report info ci2-linux-4-14 possible deadlock in xt_find_revision
2021/03/14 20:15 linux-4.14.y c7150cd2fa8c cc1cff8f .config console log report info ci2-linux-4-14 possible deadlock in xt_find_revision
2021/03/14 13:00 linux-4.14.y c7150cd2fa8c 4a003785 .config console log report info ci2-linux-4-14 possible deadlock in xt_find_revision
2021/03/14 05:52 linux-4.14.y c7150cd2fa8c 4a003785 .config console log report info ci2-linux-4-14 possible deadlock in xt_find_revision
2021/03/14 01:30 linux-4.14.y c7150cd2fa8c 4a003785 .config console log report info ci2-linux-4-14 possible deadlock in xt_find_revision
2021/03/13 23:35 linux-4.14.y c7150cd2fa8c 4a003785 .config console log report info ci2-linux-4-14 possible deadlock in xt_find_revision
2021/03/13 18:31 linux-4.14.y c7150cd2fa8c 4a003785 .config console log report info ci2-linux-4-14 possible deadlock in xt_find_revision
2021/03/13 15:35 linux-4.14.y c7150cd2fa8c 4a003785 .config console log report info ci2-linux-4-14 possible deadlock in xt_find_revision
2021/03/13 08:52 linux-4.14.y c7150cd2fa8c 4a003785 .config console log report info ci2-linux-4-14 possible deadlock in xt_find_revision
2021/03/13 07:27 linux-4.14.y c7150cd2fa8c 4a003785 .config console log report info ci2-linux-4-14 possible deadlock in xt_find_revision
2021/03/13 03:46 linux-4.14.y c7150cd2fa8c 429d8a6b .config console log report info ci2-linux-4-14 possible deadlock in xt_find_revision
2021/03/13 02:09 linux-4.14.y c7150cd2fa8c 429d8a6b .config console log report info ci2-linux-4-14 possible deadlock in xt_find_revision
2021/03/13 00:46 linux-4.14.y c7150cd2fa8c 429d8a6b .config console log report info ci2-linux-4-14 possible deadlock in xt_find_revision
2021/03/12 15:01 linux-4.14.y c7150cd2fa8c 429d8a6b .config console log report info ci2-linux-4-14 possible deadlock in xt_find_revision
2021/03/12 10:49 linux-4.14.y c7150cd2fa8c 429d8a6b .config console log report info ci2-linux-4-14 possible deadlock in xt_find_revision
2021/03/12 09:30 linux-4.14.y c7150cd2fa8c 429d8a6b .config console log report info ci2-linux-4-14 possible deadlock in xt_find_revision
2021/03/12 07:54 linux-4.14.y c7150cd2fa8c 429d8a6b .config console log report info ci2-linux-4-14 possible deadlock in xt_find_revision
2021/03/12 00:49 linux-4.14.y c7150cd2fa8c 429d8a6b .config console log report info ci2-linux-4-14 possible deadlock in xt_find_revision
2021/03/11 21:54 linux-4.14.y c7150cd2fa8c 429d8a6b .config console log report info ci2-linux-4-14 possible deadlock in xt_find_revision
2021/03/11 18:00 linux-4.14.y c7150cd2fa8c c2ca1f2a .config console log report info ci2-linux-4-14 possible deadlock in xt_find_revision
2021/03/11 15:30 linux-4.14.y c7150cd2fa8c c2ca1f2a .config console log report info ci2-linux-4-14 possible deadlock in xt_find_revision
2021/03/11 15:01 linux-4.14.y c7150cd2fa8c c2ca1f2a .config console log report info ci2-linux-4-14 possible deadlock in xt_find_revision
2021/03/11 13:53 linux-4.14.y c7150cd2fa8c c2ca1f2a .config console log report info ci2-linux-4-14 possible deadlock in xt_find_revision
2021/03/11 10:59 linux-4.14.y 1d177c0872ab c2ca1f2a .config console log report info ci2-linux-4-14 possible deadlock in xt_find_revision
2021/03/11 06:13 linux-4.14.y 1d177c0872ab c2ca1f2a .config console log report info ci2-linux-4-14 possible deadlock in xt_find_revision
2021/03/11 05:04 linux-4.14.y 1d177c0872ab c2ca1f2a .config console log report info ci2-linux-4-14 possible deadlock in xt_find_revision
2021/03/11 03:57 linux-4.14.y 1d177c0872ab c2ca1f2a .config console log report info ci2-linux-4-14 possible deadlock in xt_find_revision
2021/03/10 21:42 linux-4.14.y 1d177c0872ab 764067f3 .config console log report info ci2-linux-4-14 possible deadlock in xt_find_revision
2021/03/10 16:57 linux-4.14.y 1d177c0872ab 764067f3 .config console log report info ci2-linux-4-14 possible deadlock in xt_find_revision
2021/03/10 15:56 linux-4.14.y 1d177c0872ab 764067f3 .config console log report info ci2-linux-4-14 possible deadlock in xt_find_revision
2021/03/10 10:08 linux-4.14.y 1d177c0872ab 26967e35 .config console log report info ci2-linux-4-14 possible deadlock in xt_find_revision
2021/03/10 09:01 linux-4.14.y 1d177c0872ab 26967e35 .config console log report info ci2-linux-4-14 possible deadlock in xt_find_revision
2021/01/17 14:22 linux-4.14.y 2762b48e9611 813be542 .config console log report info ci2-linux-4-14
2020/01/06 20:10 linux-4.14.y 84f5ad468100 53430d97 .config console log report ci2-linux-4-14
* Struck through repros no longer work on HEAD.