general protection fault in scsi_queue

general protection fault in scsi_queue_rq
Status: upstream: reported C repro on 2020/10/12 14:51
Reported-by: syzbot+0796b72dc61f223d8cc5@syzkaller.appspotmail.com
First crash: 213d, last: 5h26m

Cause bisection: introduced by (bisect log) :
commit 2ceda20f0a99a74a82b78870f3b3e5fa93087a7f
Author: Christoph Hellwig <hch@lst.de>
Date: Mon Oct 5 08:41:23 2020 +0000

scsi: core: Move command size detection out of the fast path

Crash: BUG: unable to handle kernel NULL pointer dereference in scsi_queue_rq (log)
Repro: C syz .config

Patch testing requests:
Created	Duration	User	Repo	Result
2020/10/13 23:19	16m	jejb@linux.ibm.com	git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-misc	OK
2020/10/13 23:10	17m	jejb@linux.ibm.com	git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-misc	OK
2020/10/12 23:27	17m	anmol.karan123@gmail.com	upstream	OK

Sample crash report:

general protection fault, probably for non-canonical address 0xdffffc0000000000: 0000 [#1] PREEMPT SMP KASAN
KASAN: null-ptr-deref in range [0x0000000000000000-0x0000000000000007]
CPU: 1 PID: 8446 Comm: syz-executor215 Not tainted 5.11.0-rc7-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
RIP: 0010:scsi_command_size include/scsi/scsi_common.h:24 [inline]
RIP: 0010:scsi_setup_scsi_cmnd drivers/scsi/scsi_lib.c:1199 [inline]
RIP: 0010:scsi_prepare_cmd drivers/scsi/scsi_lib.c:1583 [inline]
RIP: 0010:scsi_queue_rq+0x243c/0x31e0 drivers/scsi/scsi_lib.c:1672
Code: 00 fc ff df 48 c1 ea 03 80 3c 02 00 0f 85 ca 0b 00 00 48 8b 8b 58 02 00 00 48 b8 00 00 00 00 00 fc ff df 48 89 ca 48 c1 ea 03 <0f> b6 04 02 48 89 ca 83 e2 07 38 d0 7f 08 84 c0 0f 85 85 0b 00 00
RSP: 0018:ffffc90001287590 EFLAGS: 00010246
RAX: dffffc0000000000 RBX: ffff88801dc82800 RCX: 0000000000000000
RDX: 0000000000000000 RSI: ffffffff8468dac9 RDI: 0000000000000003
RBP: ffff888013a0c000 R08: 0000000000000000 R09: 0000000000000000
R10: ffffffff8468dab3 R11: 0000000000000000 R12: 0000000000000000
R13: ffff88801dc82a58 R14: ffff8881443a0000 R15: 0000000000000000
FS:  00007f56a69bc700(0000) GS:ffff8880b9d00000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007fbe1f023740 CR3: 000000001496f000 CR4: 00000000001506e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 blk_mq_dispatch_rq_list+0x3a1/0x1ea0 block/blk-mq.c:1396
 __blk_mq_sched_dispatch_requests+0x263/0x490 block/blk-mq-sched.c:308
 blk_mq_sched_dispatch_requests+0xfb/0x180 block/blk-mq-sched.c:341
 __blk_mq_run_hw_queue+0xd8/0x150 block/blk-mq.c:1515
 __blk_mq_delay_run_hw_queue+0x522/0x5f0 block/blk-mq.c:1592
 blk_mq_run_hw_queue+0x16c/0x2f0 block/blk-mq.c:1645
 blk_mq_sched_insert_request+0x3f4/0x4d0 block/blk-mq-sched.c:467
 blk_execute_rq+0xd4/0x1b0 block/blk-exec.c:86
 sg_io+0x609/0xf50 block/scsi_ioctl.c:360
 scsi_cmd_ioctl+0x519/0x580 block/scsi_ioctl.c:809
 scsi_cmd_blk_ioctl block/scsi_ioctl.c:867 [inline]
 scsi_cmd_blk_ioctl+0xdb/0x120 block/scsi_ioctl.c:858
 sd_ioctl_common+0x178/0x280 drivers/scsi/sd.c:1575
 sd_ioctl+0x26/0xf0 drivers/scsi/sd.c:1763
 blkdev_ioctl+0x29b/0x6c0 block/ioctl.c:576
 block_ioctl+0xf9/0x140 fs/block_dev.c:1658
 vfs_ioctl fs/ioctl.c:48 [inline]
 __do_sys_ioctl fs/ioctl.c:753 [inline]
 __se_sys_ioctl fs/ioctl.c:739 [inline]
 __x64_sys_ioctl+0x193/0x200 fs/ioctl.c:739
 do_syscall_64+0x2d/0x70 arch/x86/entry/common.c:46
 entry_SYSCALL_64_after_hwframe+0x44/0xa9
RIP: 0033:0x445569
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 81 14 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f56a69bc2f8 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 00000000004cc4e0 RCX: 0000000000445569
RDX: 00000000200046c0 RSI: 0000000000002285 RDI: 0000000000000004
RBP: 000000000049c03c R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000003
R13: 000000000049c060 R14: 2f30656c69662f2e R15: 00000000004cc4e8
Modules linked in:
---[ end trace ff2c96f3a0b35c0c ]---
RIP: 0010:scsi_command_size include/scsi/scsi_common.h:24 [inline]
RIP: 0010:scsi_setup_scsi_cmnd drivers/scsi/scsi_lib.c:1199 [inline]
RIP: 0010:scsi_prepare_cmd drivers/scsi/scsi_lib.c:1583 [inline]
RIP: 0010:scsi_queue_rq+0x243c/0x31e0 drivers/scsi/scsi_lib.c:1672
Code: 00 fc ff df 48 c1 ea 03 80 3c 02 00 0f 85 ca 0b 00 00 48 8b 8b 58 02 00 00 48 b8 00 00 00 00 00 fc ff df 48 89 ca 48 c1 ea 03 <0f> b6 04 02 48 89 ca 83 e2 07 38 d0 7f 08 84 c0 0f 85 85 0b 00 00
RSP: 0018:ffffc90001287590 EFLAGS: 00010246
RAX: dffffc0000000000 RBX: ffff88801dc82800 RCX: 0000000000000000
RDX: 0000000000000000 RSI: ffffffff8468dac9 RDI: 0000000000000003
RBP: ffff888013a0c000 R08: 0000000000000000 R09: 0000000000000000
R10: ffffffff8468dab3 R11: 0000000000000000 R12: 0000000000000000
R13: ffff88801dc82a58 R14: ffff8881443a0000 R15: 0000000000000000
FS:  00007f56a69bc700(0000) GS:ffff8880b9d00000(0000) knlGS:0000000000000000
CR2: 00007fbe1f023740 CR3: 000000001496f000 CR4: 00000000001506e0
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400

Crashes (2806):
Manager	Time	Kernel	Commit	Syzkaller	Config	Log	Report	Syz repro	C repro	VM info	Title
ci-upstream-kasan-gce-selinux-root	2021/02/12 02:59	upstream	291009f6	a5f86b15	.config	log	report	syz	C		general protection fault in scsi_queue_rq
ci-upstream-kasan-gce-root	2021/02/01 01:33	upstream	6642d600	fc9fd31e	.config	log	report	syz	C		general protection fault in scsi_queue_rq
ci-upstream-linux-next-kasan-gce-root	2021/03/29 02:59	linux-next	93129492	a8529b82	.config	log	report	syz	C		general protection fault in scsi_queue_rq
ci-upstream-linux-next-kasan-gce-root	2020/10/08 21:42	linux-next	e4fb79c7	92390980	.config	log	report	syz	C
ci-upstream-kasan-gce-selinux-root	2021/05/09 15:08	upstream	b7415964	bc5434be	.config	log	report			info	general protection fault in scsi_queue_rq
ci-upstream-kasan-gce-selinux-root	2021/05/08 23:49	upstream	ab159ac5	bc5434be	.config	log	report			info	general protection fault in scsi_queue_rq
ci-upstream-kasan-gce-root	2021/05/08 22:27	upstream	ab159ac5	bc5434be	.config	log	report			info	general protection fault in scsi_queue_rq
ci-upstream-kasan-gce-root	2021/05/08 18:08	upstream	ab159ac5	bc5434be	.config	log	report			info	general protection fault in scsi_queue_rq
ci-qemu-upstream	2021/05/08 16:43	upstream	18a3c5f7	bc5434be	.config	log	report			info	general protection fault in scsi_queue_rq
ci-upstream-kasan-gce-smack-root	2021/05/08 14:10	upstream	d2b6f8a1	bc5434be	.config	log	report			info	general protection fault in scsi_queue_rq
ci-upstream-kasan-gce-selinux-root	2021/05/08 13:10	upstream	d2b6f8a1	bc5434be	.config	log	report			info	general protection fault in scsi_queue_rq
ci-upstream-kasan-gce-smack-root	2021/05/08 08:31	upstream	d2b6f8a1	bc5434be	.config	log	report			info	general protection fault in scsi_queue_rq
ci-upstream-kasan-gce-selinux-root	2021/05/08 07:24	upstream	d2b6f8a1	bc5434be	.config	log	report			info	general protection fault in scsi_queue_rq
ci-upstream-kasan-gce-root	2021/05/08 07:24	upstream	d2b6f8a1	bc5434be	.config	log	report			info	general protection fault in scsi_queue_rq
ci-upstream-kasan-gce-smack-root	2021/05/07 16:24	upstream	d2b6f8a1	f6da8120	.config	log	report			info	general protection fault in scsi_queue_rq
ci-upstream-kasan-gce-root	2021/05/07 14:42	upstream	d2b6f8a1	f6da8120	.config	log	report			info	general protection fault in scsi_queue_rq
ci-upstream-kasan-gce-smack-root	2021/05/07 05:00	upstream	d2b6f8a1	06585184	.config	log	report			info	general protection fault in scsi_queue_rq
ci-upstream-kasan-gce-selinux-root	2021/05/06 23:39	upstream	d2b6f8a1	06585184	.config	log	report			info	general protection fault in scsi_queue_rq
ci-upstream-kasan-gce-root	2021/05/06 11:30	upstream	d2b6f8a1	06c27ff5	.config	log	report			info	general protection fault in scsi_queue_rq
ci-upstream-kasan-gce-selinux-root	2021/05/04 13:55	upstream	d2b6f8a1	09efdd63	.config	log	report			info	general protection fault in scsi_queue_rq
ci-upstream-kasan-gce-root	2021/05/04 10:32	upstream	d2b6f8a1	09efdd63	.config	log	report			info	general protection fault in scsi_queue_rq
ci-upstream-kasan-gce-selinux-root	2021/05/03 13:24	upstream	d2b6f8a1	77e2b668	.config	log	report			info	general protection fault in scsi_queue_rq
ci-upstream-kasan-gce-smack-root	2021/05/03 13:11	upstream	d2b6f8a1	77e2b668	.config	log	report			info	general protection fault in scsi_queue_rq
ci-upstream-kasan-gce-root	2021/05/03 08:50	upstream	d2b6f8a1	77e2b668	.config	log	report			info	general protection fault in scsi_queue_rq
ci-upstream-kasan-gce-root	2021/05/03 06:19	upstream	d2b6f8a1	77e2b668	.config	log	report			info	general protection fault in scsi_queue_rq
ci-upstream-kasan-gce-root	2021/05/02 07:00	upstream	d2b6f8a1	77e2b668	.config	log	report			info	general protection fault in scsi_queue_rq
ci-upstream-kasan-gce-root	2021/05/02 01:27	upstream	d2b6f8a1	77e2b668	.config	log	report			info	general protection fault in scsi_queue_rq
ci-upstream-kasan-gce-root	2021/05/01 20:49	upstream	d2b6f8a1	77e2b668	.config	log	report			info	general protection fault in scsi_queue_rq
ci-upstream-kasan-gce-root	2021/04/30 23:37	upstream	d2b6f8a1	77e2b668	.config	log	report			info	general protection fault in scsi_queue_rq
ci-upstream-kasan-gce-selinux-root	2021/04/30 16:13	upstream	d2b6f8a1	77e2b668	.config	log	report			info	general protection fault in scsi_queue_rq
ci-upstream-kasan-gce-root	2021/04/30 06:12	upstream	d2b6f8a1	77e2b668	.config	log	report			info	general protection fault in scsi_queue_rq
ci-upstream-kasan-gce-smack-root	2021/04/29 18:51	upstream	d72cd4ad	77e2b668	.config	log	report			info	general protection fault in scsi_queue_rq
ci-upstream-kasan-gce-selinux-root	2021/04/29 18:49	upstream	d72cd4ad	77e2b668	.config	log	report			info	general protection fault in scsi_queue_rq
ci-upstream-kasan-gce-root	2021/04/29 16:43	upstream	d72cd4ad	77e2b668	.config	log	report			info	general protection fault in scsi_queue_rq
ci-upstream-kasan-gce-root	2021/04/29 12:53	upstream	d72cd4ad	77e2b668	.config	log	report			info	general protection fault in scsi_queue_rq
ci-upstream-kasan-gce-selinux-root	2021/04/28 00:49	upstream	57fa2369	805b5003	.config	log	report			info	general protection fault in scsi_queue_rq
ci-upstream-kasan-gce-root	2021/04/27 21:48	upstream	57fa2369	805b5003	.config	log	report			info	general protection fault in scsi_queue_rq
ci-upstream-kasan-gce-root	2021/04/26 18:55	upstream	9f4ad9e4	e60b7df1	.config	log	report			info	general protection fault in scsi_queue_rq
ci-upstream-kasan-gce-root	2021/04/25 16:08	upstream	2a1d7946	36c88236	.config	log	report			info	general protection fault in scsi_queue_rq
ci-upstream-kasan-gce-root	2021/04/24 16:17	upstream	e77a830c	17f0b706	.config	log	report			info	general protection fault in scsi_queue_rq
ci-upstream-kasan-gce-selinux-root	2021/04/24 10:45	upstream	e77a830c	17f0b706	.config	log	report			info	general protection fault in scsi_queue_rq
ci-upstream-kasan-gce-selinux-root	2021/04/24 07:49	upstream	e77a830c	17f0b706	.config	log	report			info	general protection fault in scsi_queue_rq
ci-upstream-kasan-gce-selinux-root	2021/04/24 06:37	upstream	e77a830c	17f0b706	.config	log	report			info	general protection fault in scsi_queue_rq
ci-upstream-kasan-gce-root	2021/04/24 05:32	upstream	e77a830c	17f0b706	.config	log	report			info	general protection fault in scsi_queue_rq
ci-upstream-kasan-gce-root	2021/04/24 04:26	upstream	e77a830c	17f0b706	.config	log	report			info	general protection fault in scsi_queue_rq
ci-upstream-kasan-gce-selinux-root	2021/04/22 05:55	upstream	16fc44d6	2bc8999a	.config	log	report			info	general protection fault in scsi_queue_rq
ci-upstream-kasan-gce-root	2021/04/22 04:17	upstream	16fc44d6	2bc8999a	.config	log	report			info	general protection fault in scsi_queue_rq
ci-upstream-kasan-gce-smack-root	2021/04/21 16:54	upstream	1fe5501b	95777977	.config	log	report			info	general protection fault in scsi_queue_rq
ci-upstream-kasan-gce-selinux-root	2021/04/20 09:23	upstream	7af08140	4285c989	.config	log	report			info	general protection fault in scsi_queue_rq
ci-upstream-kasan-gce-smack-root	2021/04/20 08:49	upstream	7af08140	4285c989	.config	log	report			info	general protection fault in scsi_queue_rq
ci-qemu-upstream-386	2021/04/20 16:52	upstream	7af08140	c0ced557	.config	log	report			info	general protection fault in scsi_queue_rq
ci-upstream-linux-next-kasan-gce-root	2021/05/08 22:33	linux-next	869a85b9	bc5434be	.config	log	report			info	general protection fault in scsi_queue_rq
ci-upstream-linux-next-kasan-gce-root	2021/04/20 02:32	linux-next	1216f02e	4285c989	.config	log	report			info	general protection fault in scsi_queue_rq
ci-upstream-kasan-gce-selinux-root	2021/01/17 10:23	upstream	0da0a8a0	65a7a854	.config	log	report			info
ci-upstream-linux-next-kasan-gce-root	2020/10/08 14:44	linux-next	e4fb79c7	92390980	.config	log	report			info