syzbot


KASAN: use-after-free Read in usblp_bulk_read (2)

Status: auto-closed as invalid on 2020/11/18 22:11
Subsystems: usb
[Documentation on labels]
Reported-by: syzbot+2a0b15f48e551d23ad70@syzkaller.appspotmail.com
First crash: 1375d, last: 1342d
Similar bugs (1)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
upstream KASAN: use-after-free Read in usblp_bulk_read usb 7 1386d 1464d 15/26 fixed on 2020/07/17 17:58

Sample crash report:
usblp0: nonzero read bulk status received: -71
==================================================================
BUG: KASAN: use-after-free in __lock_acquire+0x94/0x2ab0 kernel/locking/lockdep.c:4296
Read of size 8 at addr ffff88809ef08940 by task syz-executor.2/6833

CPU: 1 PID: 6833 Comm: syz-executor.2 Not tainted 5.9.0-rc1-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 <IRQ>
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x1f0/0x31e lib/dump_stack.c:118
 print_address_description+0x66/0x620 mm/kasan/report.c:383
 __kasan_report mm/kasan/report.c:513 [inline]
 kasan_report+0x132/0x1d0 mm/kasan/report.c:530
 __lock_acquire+0x94/0x2ab0 kernel/locking/lockdep.c:4296
 lock_acquire+0x160/0x730 kernel/locking/lockdep.c:5005
 __raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline]
 _raw_spin_lock_irqsave+0x9e/0xc0 kernel/locking/spinlock.c:159
 usblp_bulk_read+0xe0/0x2a0 drivers/usb/class/usblp.c:303
 __usb_hcd_giveback_urb+0x333/0x4b0 drivers/usb/core/hcd.c:1650
 dummy_timer+0x71b/0x3e10 drivers/usb/gadget/udc/dummy_hcd.c:1967
 call_timer_fn+0x91/0x160 kernel/time/timer.c:1413
 expire_timers kernel/time/timer.c:1458 [inline]
 __run_timers+0x65e/0x830 kernel/time/timer.c:1755
 run_timer_softirq+0x46/0x80 kernel/time/timer.c:1768
 __do_softirq+0x236/0x66c kernel/softirq.c:298
 asm_call_on_stack+0xf/0x20 arch/x86/entry/entry_64.S:706
 </IRQ>
 __run_on_irqstack arch/x86/include/asm/irq_stack.h:22 [inline]
 run_on_irqstack_cond arch/x86/include/asm/irq_stack.h:48 [inline]
 do_softirq_own_stack+0x91/0xe0 arch/x86/kernel/irq_64.c:77
 invoke_softirq kernel/softirq.c:393 [inline]
 __irq_exit_rcu+0x1e1/0x1f0 kernel/softirq.c:423
 irq_exit_rcu+0x5/0x10 kernel/softirq.c:435
 sysvec_apic_timer_interrupt+0xd5/0xf0 arch/x86/kernel/apic/apic.c:1091
 asm_sysvec_apic_timer_interrupt+0x12/0x20 arch/x86/include/asm/idtentry.h:581
RIP: 0010:__raw_spin_unlock_irq include/linux/spinlock_api_smp.h:169 [inline]
RIP: 0010:_raw_spin_unlock_irq+0x57/0x80 kernel/locking/spinlock.c:199
Code: 00 00 00 00 fc ff df 80 3c 08 00 74 0c 48 c7 c7 08 15 4d 89 e8 8a 52 88 f9 48 83 3d 7a 98 20 01 00 74 25 fb 66 0f 1f 44 00 00 <bf> 01 00 00 00 e8 ef 55 24 f9 65 8b 05 64 81 d5 77 85 c0 74 02 5b
RSP: 0018:ffffc90005647cc8 EFLAGS: 00000286
RAX: 1ffffffff129a2a1 RBX: ffff8880ae9358c0 RCX: dffffc0000000000
RDX: 0000000040000000 RSI: 0000000000000000 RDI: ffffffff882c7c5f
RBP: ffffc90005647d28 R08: ffffffff817abaa0 R09: ffffed1015d26b19
R10: ffffed1015d26b19 R11: 0000000000000000 R12: ffff8880ae9358c0
R13: ffff88806e4145c0 R14: ffff8880ae936308 R15: dffffc0000000000
 finish_task_switch+0x24f/0x550 kernel/sched/core.c:3617
 context_switch kernel/sched/core.c:3781 [inline]
 __schedule+0x981/0xce0 kernel/sched/core.c:4527
 schedule+0x188/0x220 kernel/sched/core.c:4602
 freezable_schedule include/linux/freezer.h:172 [inline]
 do_nanosleep+0x1ae/0x680 kernel/time/hrtimer.c:1883
 hrtimer_nanosleep kernel/time/hrtimer.c:1936 [inline]
 __do_sys_nanosleep kernel/time/hrtimer.c:1970 [inline]
 __se_sys_nanosleep+0x3d5/0x5c0 kernel/time/hrtimer.c:1957
 do_syscall_64+0x31/0x70 arch/x86/entry/common.c:46
 entry_SYSCALL_64_after_hwframe+0x44/0xa9
RIP: 0033:0x45b9a1
Code: 75 14 b8 23 00 00 00 0f 05 48 3d 01 f0 ff ff 0f 83 84 cf fb ff c3 48 83 ec 08 e8 ea 46 00 00 48 89 04 24 b8 23 00 00 00 0f 05 <48> 8b 3c 24 48 89 c2 e8 33 47 00 00 48 89 d0 48 83 c4 08 48 3d 01
RSP: 002b:00007ffec5f57fd0 EFLAGS: 00000293 ORIG_RAX: 0000000000000023
RAX: ffffffffffffffda RBX: 000000000008c374 RCX: 000000000045b9a1
RDX: 0000000000000000 RSI: 0000000000000000 RDI: 00007ffec5f57fe0
RBP: 000000000000077e R08: 0000000000000000 R09: 0000000002db5940
R10: 0000000000000000 R11: 0000000000000293 R12: 0000000000000005
R13: 00007ffec5f58030 R14: 000000000008be05 R15: 00007ffec5f58040

Allocated by task 24063:
 kasan_save_stack mm/kasan/common.c:48 [inline]
 kasan_set_track mm/kasan/common.c:56 [inline]
 __kasan_kmalloc+0x100/0x130 mm/kasan/common.c:461
 kmem_cache_alloc_trace+0x1f6/0x2f0 mm/slab.c:3550
 kmalloc include/linux/slab.h:554 [inline]
 kzalloc include/linux/slab.h:666 [inline]
 usblp_probe+0x85/0x19a0 drivers/usb/class/usblp.c:1105
 usb_probe_interface+0x614/0xac0 drivers/usb/core/driver.c:374
 really_probe+0x753/0x1110 drivers/base/dd.c:557
 driver_probe_device+0x106/0x1a0 drivers/base/dd.c:738
 bus_for_each_drv+0x108/0x170 drivers/base/bus.c:431
 __device_attach+0x262/0x3f0 drivers/base/dd.c:912
 bus_probe_device+0xb8/0x1f0 drivers/base/bus.c:491
 device_add+0x1630/0x19b0 drivers/base/core.c:2930
 usb_set_configuration+0x19d2/0x1f20 drivers/usb/core/message.c:2032
 usb_generic_driver_probe+0x82/0x140 drivers/usb/core/generic.c:239
 usb_probe_device+0x12d/0x1d0 drivers/usb/core/driver.c:272
 really_probe+0x753/0x1110 drivers/base/dd.c:557
 driver_probe_device+0x106/0x1a0 drivers/base/dd.c:738
 bus_for_each_drv+0x108/0x170 drivers/base/bus.c:431
 __device_attach+0x262/0x3f0 drivers/base/dd.c:912
 bus_probe_device+0xb8/0x1f0 drivers/base/bus.c:491
 device_add+0x1630/0x19b0 drivers/base/core.c:2930
 usb_new_device+0xcc3/0x1650 drivers/usb/core/hub.c:2554
 hub_port_connect drivers/usb/core/hub.c:5208 [inline]
 hub_port_connect_change drivers/usb/core/hub.c:5348 [inline]
 port_event drivers/usb/core/hub.c:5494 [inline]
 hub_event+0x2823/0x4cb0 drivers/usb/core/hub.c:5576
 process_one_work+0x789/0xfc0 kernel/workqueue.c:2269
 worker_thread+0xaa4/0x1460 kernel/workqueue.c:2415
 kthread+0x37e/0x3a0 drivers/block/aoe/aoecmd.c:1234
 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:294

Freed by task 7806:
 kasan_save_stack mm/kasan/common.c:48 [inline]
 kasan_set_track+0x3d/0x70 mm/kasan/common.c:56
 kasan_set_free_info+0x17/0x30 mm/kasan/generic.c:355
 __kasan_slab_free+0xdd/0x110 mm/kasan/common.c:422
 __cache_free mm/slab.c:3418 [inline]
 kfree+0x10a/0x220 mm/slab.c:3756
 usblp_cleanup drivers/usb/class/usblp.c:449 [inline]
 usblp_disconnect+0x24b/0x2c0 drivers/usb/class/usblp.c:1382
 usb_unbind_interface+0x1d2/0x840 drivers/usb/core/driver.c:436
 __device_release_driver drivers/base/dd.c:1153 [inline]
 device_release_driver_internal+0x516/0x7b0 drivers/base/dd.c:1184
 bus_remove_device+0x2eb/0x360 drivers/base/bus.c:533
 device_del+0x7b9/0x1280 drivers/base/core.c:3107
 usb_disable_device+0x3ee/0xc80 drivers/usb/core/message.c:1245
 usb_disconnect+0x346/0x880 drivers/usb/core/hub.c:2217
 hub_port_connect drivers/usb/core/hub.c:5059 [inline]
 hub_port_connect_change drivers/usb/core/hub.c:5348 [inline]
 port_event drivers/usb/core/hub.c:5494 [inline]
 hub_event+0x1c18/0x4cb0 drivers/usb/core/hub.c:5576
 process_one_work+0x789/0xfc0 kernel/workqueue.c:2269
 worker_thread+0xaa4/0x1460 kernel/workqueue.c:2415
 kthread+0x37e/0x3a0 drivers/block/aoe/aoecmd.c:1234
 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:294

Last call_rcu():
 kasan_save_stack+0x27/0x50 mm/kasan/common.c:48
 kasan_record_aux_stack+0x7b/0xb0 mm/kasan/generic.c:346
 __call_rcu kernel/rcu/tree.c:2894 [inline]
 call_rcu+0x139/0x840 kernel/rcu/tree.c:2968
 sctp_association_free+0x640/0x780 net/sctp/associola.c:379
 sctp_cmd_delete_tcb net/sctp/sm_sideeffect.c:930 [inline]
 sctp_cmd_interpreter net/sctp/sm_sideeffect.c:1318 [inline]
 sctp_side_effects net/sctp/sm_sideeffect.c:1185 [inline]
 sctp_do_sm+0x3c3a/0x55a0 net/sctp/sm_sideeffect.c:1156
 sctp_assoc_bh_rcv+0x458/0x720 net/sctp/associola.c:1044
 sctp_backlog_rcv+0x16e/0x4c0 net/sctp/input.c:344
 sk_backlog_rcv include/net/sock.h:1011 [inline]
 __release_sock+0x1b2/0x480 net/core/sock.c:2542
 release_sock+0x5d/0x1c0 net/core/sock.c:3065
 sctp_wait_for_connect+0x2e1/0x560 net/sctp/socket.c:9065
 __sctp_connect+0xe93/0x11e0 net/sctp/socket.c:1230
 sctp_connect net/sctp/socket.c:4678 [inline]
 sctp_inet_connect+0x11b/0x190 net/sctp/socket.c:4693
 __sys_connect_file net/socket.c:1852 [inline]
 __sys_connect+0x2d8/0x350 net/socket.c:1869
 __do_sys_connect net/socket.c:1879 [inline]
 __se_sys_connect net/socket.c:1876 [inline]
 __x64_sys_connect+0x76/0x80 net/socket.c:1876
 do_syscall_64+0x31/0x70 arch/x86/entry/common.c:46
 entry_SYSCALL_64_after_hwframe+0x44/0xa9

Second to last call_rcu():
 kasan_save_stack+0x27/0x50 mm/kasan/common.c:48
 kasan_record_aux_stack+0x7b/0xb0 mm/kasan/generic.c:346
 __call_rcu kernel/rcu/tree.c:2894 [inline]
 call_rcu+0x139/0x840 kernel/rcu/tree.c:2968
 process_one_work+0x789/0xfc0 kernel/workqueue.c:2269
 worker_thread+0xaa4/0x1460 kernel/workqueue.c:2415
 kthread+0x37e/0x3a0 drivers/block/aoe/aoecmd.c:1234
 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:294

The buggy address belongs to the object at ffff88809ef08800
 which belongs to the cache kmalloc-1k of size 1024
The buggy address is located 320 bytes inside of
 1024-byte region [ffff88809ef08800, ffff88809ef08c00)
The buggy address belongs to the page:
page:00000000b7ac151d refcount:1 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x9ef08
flags: 0xfffe0000000200(slab)
raw: 00fffe0000000200 ffffea000188a788 ffffea00029dc948 ffff8880aa440700
raw: 0000000000000000 ffff88809ef08000 0000000100000002 0000000000000000
page dumped because: kasan: bad access detected

Memory state around the buggy address:
 ffff88809ef08800: fa fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
 ffff88809ef08880: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
>ffff88809ef08900: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
                                           ^
 ffff88809ef08980: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
 ffff88809ef08a00: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
==================================================================

Crashes (2):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2020/08/20 22:11 upstream da2968ff879b 1d75fe45 .config console log report ci-upstream-kasan-gce-smack-root
2020/07/19 14:38 upstream f932d58abc38 9c812472 .config console log report ci-qemu-upstream
* Struck through repros no longer work on HEAD.