syzbot


WARNING in unlock_new_inode

Status: fixed on 2020/11/29 00:01
Reported-by: syzbot+ededc75bae0e3473bc3d@syzkaller.appspotmail.com
Fix commit: 7a1e074bc18d reiserfs: only call unlock_new_inode() if I_NEW
First crash: 650d, last: 611d

Fix bisection: fixed by (bisect log) :
commit 7a1e074bc18d32718edcde0a0ad75fff262a4410
Author: Eric Biggers <ebiggers@google.com>
Date: Sun Jun 28 07:00:57 2020 +0000

  reiserfs: only call unlock_new_inode() if I_NEW

similar bugs (2):
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
linux-4.14 WARNING in unlock_new_inode C done 55 614d 651d 1/1 fixed on 2020/11/26 11:14
upstream WARNING in unlock_new_inode C done 76 631d 1535d 17/22 fixed on 2020/11/16 12:12

Sample crash report:
reiserfs: using flush barriers
REISERFS (device loop0): journal params: device loop0, size 8195, journal first block 18, max trans len 1024, max batch 900, max commit age 30, max trans age 30
REISERFS (device loop0): checking transaction log (loop0)
REISERFS (device loop0): Using rupasov hash to sort names
------------[ cut here ]------------
WARNING: CPU: 1 PID: 6500 at fs/inode.c:979 unlock_new_inode.cold+0x11/0x3f fs/inode.c:979
Kernel panic - not syncing: panic_on_warn set ...

CPU: 1 PID: 6500 Comm: syz-executor982 Not tainted 4.19.150-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x22c/0x33e lib/dump_stack.c:118
 panic+0x2ac/0x565 kernel/panic.c:186
 __warn.cold+0x20/0x5a kernel/panic.c:541
 report_bug+0x262/0x2b0 lib/bug.c:186
 fixup_bug arch/x86/kernel/traps.c:178 [inline]
 fixup_bug arch/x86/kernel/traps.c:173 [inline]
 do_error_trap+0x1e1/0x330 arch/x86/kernel/traps.c:296
 invalid_op+0x14/0x20 arch/x86/entry/entry_64.S:1038
RIP: 0010:unlock_new_inode.cold+0x11/0x3f fs/inode.c:979
Code: ee e8 21 d7 b4 ff 48 c7 c7 80 0f 16 88 e8 c4 52 9e ff 0f 0b e9 a7 76 ff ff e8 09 d7 b4 ff 48 c7 c7 80 0f 16 88 e8 ac 52 9e ff <0f> 0b b8 ff ff 37 00 4c 89 e2 48 c1 ea 03 48 c1 e0 2a 80 3c 02 00
RSP: 0018:ffff88809553f600 EFLAGS: 00010282
RAX: 0000000000000024 RBX: ffff88807fd581a8 RCX: 0000000000000000
RDX: 0000000000000000 RSI: ffffffff815b623f RDI: ffffed1012aa7eb2
RBP: 0000000000000000 R08: 0000000000000024 R09: 0000000000000000
R10: 0000000000000005 R11: 0000000000000000 R12: ffff88807fd58278
R13: ffff88807fd58230 R14: 0000000000000000 R15: 00000000fffffff4
 reiserfs_new_inode+0x3b8/0x2150 fs/reiserfs/inode.c:2168
 reiserfs_mkdir+0x4ad/0x980 fs/reiserfs/namei.c:841
 create_privroot fs/reiserfs/xattr.c:873 [inline]
 reiserfs_xattr_init+0x406/0xae0 fs/reiserfs/xattr.c:995
 reiserfs_fill_super+0x222a/0x2e60 fs/reiserfs/super.c:2180
 mount_bdev+0x2fc/0x3b0 fs/super.c:1158
 mount_fs+0xa3/0x318 fs/super.c:1261
 vfs_kern_mount.part.0+0x68/0x470 fs/namespace.c:961
 vfs_kern_mount fs/namespace.c:951 [inline]
 do_new_mount fs/namespace.c:2469 [inline]
 do_mount+0x51c/0x2f10 fs/namespace.c:2799
 ksys_mount+0xcf/0x130 fs/namespace.c:3015
 __do_sys_mount fs/namespace.c:3029 [inline]
 __se_sys_mount fs/namespace.c:3026 [inline]
 __x64_sys_mount+0xba/0x150 fs/namespace.c:3026
 do_syscall_64+0xf9/0x670 arch/x86/entry/common.c:293
 entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x447daa
Code: b8 08 00 00 00 0f 05 48 3d 01 f0 ff ff 0f 83 7d a3 fb ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 49 89 ca b8 a5 00 00 00 0f 05 <48> 3d 01 f0 ff ff 0f 83 5a a3 fb ff c3 66 0f 1f 84 00 00 00 00 00
RSP: 002b:00007fffa865b558 EFLAGS: 00000297 ORIG_RAX: 00000000000000a5
RAX: ffffffffffffffda RBX: 00007fffa865b5b0 RCX: 0000000000447daa
RDX: 0000000020000000 RSI: 0000000020000100 RDI: 00007fffa865b570
RBP: 00007fffa865b570 R08: 00007fffa865b5b0 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000297 R12: 0000000000000007
R13: 0000000000000004 R14: 0000000000000003 R15: 0000000000000003
Kernel Offset: disabled
Rebooting in 86400 seconds..

Crashes (66):
Manager Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Title
ci2-linux-4-19 2020/10/07 17:07 linux-4.19.y a1b977b49b66 1880b4a9 .config log report syz C
ci2-linux-4-19 2020/10/06 02:42 linux-4.19.y b09c34517e1a 1880b4a9 .config log report syz C
ci2-linux-4-19 2020/10/04 20:01 linux-4.19.y b09c34517e1a 5ef9c291 .config log report syz C
ci2-linux-4-19 2020/10/04 17:38 linux-4.19.y b09c34517e1a 5ef9c291 .config log report syz C
ci2-linux-4-19 2020/09/30 00:40 linux-4.19.y 10ad6cfd5736 5abc3f1a .config log report syz C
ci2-linux-4-19 2020/09/21 06:43 linux-4.19.y 015e94d0e37b 9564d2e9 .config log report syz C
ci2-linux-4-19 2020/10/29 18:00 linux-4.19.y 79524e8c64bd a0c7169a .config log report info
ci2-linux-4-19 2020/10/21 02:06 linux-4.19.y ad326970d25c ff4a3345 .config log report info
ci2-linux-4-19 2020/10/19 13:01 linux-4.19.y ad326970d25c ff4a3345 .config log report info
ci2-linux-4-19 2020/10/17 06:02 linux-4.19.y a1b977b49b66 6e262c73 .config log report info
ci2-linux-4-19 2020/10/03 20:44 linux-4.19.y b09c34517e1a 1a3f9408 .config log report info
ci2-linux-4-19 2020/10/01 07:47 linux-4.19.y 10ad6cfd5736 a9767fb2 .config log report info
ci2-linux-4-19 2020/10/01 06:46 linux-4.19.y 10ad6cfd5736 a9767fb2 .config log report info
ci2-linux-4-19 2020/09/30 14:29 linux-4.19.y 10ad6cfd5736 8516f6d3 .config log report info
ci2-linux-4-19 2020/09/30 10:18 linux-4.19.y 10ad6cfd5736 8516f6d3 .config log report info
ci2-linux-4-19 2020/09/30 10:15 linux-4.19.y 10ad6cfd5736 8516f6d3 .config log report info
ci2-linux-4-19 2020/09/30 10:11 linux-4.19.y 10ad6cfd5736 8516f6d3 .config log report info
ci2-linux-4-19 2020/09/30 10:07 linux-4.19.y 10ad6cfd5736 8516f6d3 .config log report info
ci2-linux-4-19 2020/09/29 13:26 linux-4.19.y 10ad6cfd5736 1b88c6d5 .config log report info
ci2-linux-4-19 2020/09/29 02:29 linux-4.19.y 10ad6cfd5736 1b88c6d5 .config log report info
ci2-linux-4-19 2020/09/27 22:06 linux-4.19.y 10ad6cfd5736 5dd8aee8 .config log report info
ci2-linux-4-19 2020/09/27 22:05 linux-4.19.y 10ad6cfd5736 5dd8aee8 .config log report info
ci2-linux-4-19 2020/09/27 22:01 linux-4.19.y 10ad6cfd5736 5dd8aee8 .config log report info
ci2-linux-4-19 2020/09/27 21:52 linux-4.19.y 10ad6cfd5736 5dd8aee8 .config log report info
ci2-linux-4-19 2020/09/27 21:39 linux-4.19.y 10ad6cfd5736 5dd8aee8 .config log report info
ci2-linux-4-19 2020/09/27 21:32 linux-4.19.y 10ad6cfd5736 5dd8aee8 .config log report info
ci2-linux-4-19 2020/09/27 21:18 linux-4.19.y 10ad6cfd5736 5dd8aee8 .config log report info
ci2-linux-4-19 2020/09/27 21:10 linux-4.19.y 10ad6cfd5736 5dd8aee8 .config log report info
ci2-linux-4-19 2020/09/27 20:52 linux-4.19.y 10ad6cfd5736 5dd8aee8 .config log report info
ci2-linux-4-19 2020/09/27 20:25 linux-4.19.y 10ad6cfd5736 5dd8aee8 .config log report info
ci2-linux-4-19 2020/09/24 06:22 linux-4.19.y d09b80172c22 54289b08 .config log report info
ci2-linux-4-19 2020/09/24 06:12 linux-4.19.y d09b80172c22 54289b08 .config log report info
ci2-linux-4-19 2020/09/24 06:12 linux-4.19.y d09b80172c22 54289b08 .config log report info
ci2-linux-4-19 2020/09/23 20:51 linux-4.19.y d09b80172c22 54289b08 .config log report info
ci2-linux-4-19 2020/09/23 16:14 linux-4.19.y d09b80172c22 287cd75a .config log report info
ci2-linux-4-19 2020/09/23 15:46 linux-4.19.y d09b80172c22 287cd75a .config log report info
ci2-linux-4-19 2020/09/23 15:14 linux-4.19.y d09b80172c22 287cd75a .config log report info
ci2-linux-4-19 2020/09/23 15:04 linux-4.19.y d09b80172c22 287cd75a .config log report info
ci2-linux-4-19 2020/09/23 12:22 linux-4.19.y d09b80172c22 287cd75a .config log report info
ci2-linux-4-19 2020/09/23 12:22 linux-4.19.y d09b80172c22 287cd75a .config log report info
ci2-linux-4-19 2020/09/23 12:21 linux-4.19.y d09b80172c22 287cd75a .config log report info
ci2-linux-4-19 2020/09/22 17:23 linux-4.19.y 015e94d0e37b 3e8f6c27 .config log report info
ci2-linux-4-19 2020/09/22 11:10 linux-4.19.y 015e94d0e37b 3e8f6c27 .config log report info
ci2-linux-4-19 2020/09/22 06:09 linux-4.19.y 015e94d0e37b 9e1fa68e .config log report info
ci2-linux-4-19 2020/09/21 18:32 linux-4.19.y 015e94d0e37b c81d99c8 .config log report info
ci2-linux-4-19 2020/09/21 18:32 linux-4.19.y 015e94d0e37b c81d99c8 .config log report info
ci2-linux-4-19 2020/09/21 14:57 linux-4.19.y 015e94d0e37b c81d99c8 .config log report info
ci2-linux-4-19 2020/09/21 11:15 linux-4.19.y 015e94d0e37b c81d99c8 .config log report info
ci2-linux-4-19 2020/09/21 07:16 linux-4.19.y 015e94d0e37b 9564d2e9 .config log report info
ci2-linux-4-19 2020/09/21 07:15 linux-4.19.y 015e94d0e37b 9564d2e9 .config log report info
ci2-linux-4-19 2020/09/21 07:15 linux-4.19.y 015e94d0e37b 9564d2e9 .config log report info
ci2-linux-4-19 2020/09/21 06:22 linux-4.19.y 015e94d0e37b 9564d2e9 .config log report info
ci2-linux-4-19 2020/09/21 05:46 linux-4.19.y 015e94d0e37b 9564d2e9 .config log report info