syzbot

(syz.5.81,6509,0):ocfs2_block_check_validate:402 ERROR: CRC32 failed: stored: 0xb3775c19, computed 0x2dd1c265. Applying ECC.
JBD2: Ignoring recovery information on journal
ocfs2: Mounting device (7,5) on (node local, slot 0) with ordered data mode.
======================================================
WARNING: possible circular locking dependency detected
6.6.99-syzkaller #0 Not tainted
------------------------------------------------------
syz.5.81/6509 is trying to acquire lock:
ffff88805f68eab8 (&oi->ip_xattr_sem){++++}-{3:3}, at: ocfs2_init_acl+0x2fa/0x720 fs/ocfs2/acl.c:366

but task is already holding lock:
ffff888056f60990 (jbd2_handle){++++}-{0:0}, at: start_this_handle+0x1e7d/0x20c0 fs/jbd2/transaction.c:448

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #4 (jbd2_handle){++++}-{0:0}:
       start_this_handle+0x1e9d/0x20c0 fs/jbd2/transaction.c:448
       jbd2__journal_start+0x2bb/0x5b0 fs/jbd2/transaction.c:505
       jbd2_journal_start+0x2a/0x40 fs/jbd2/transaction.c:544
       ocfs2_start_trans+0x376/0x6c0 fs/ocfs2/journal.c:374
       ocfs2_mknod+0xe47/0x20f0 fs/ocfs2/namei.c:361
       ocfs2_create+0x196/0x410 fs/ocfs2/namei.c:674
       lookup_open fs/namei.c:3488 [inline]
       open_last_lookups fs/namei.c:3556 [inline]
       path_openat+0x1277/0x3190 fs/namei.c:3786
       do_filp_open+0x1c5/0x3d0 fs/namei.c:3816
       do_sys_openat2+0x12c/0x1c0 fs/open.c:1419
       do_sys_open fs/open.c:1434 [inline]
       __do_sys_open fs/open.c:1442 [inline]
       __se_sys_open fs/open.c:1438 [inline]
       __x64_sys_open+0x11f/0x140 fs/open.c:1438
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #3 (&journal->j_trans_barrier){.+.+}-{3:3}:
       down_read+0x46/0x2e0 kernel/locking/rwsem.c:1520
       ocfs2_start_trans+0x36a/0x6c0 fs/ocfs2/journal.c:372
       ocfs2_mknod+0xe47/0x20f0 fs/ocfs2/namei.c:361
       ocfs2_create+0x196/0x410 fs/ocfs2/namei.c:674
       lookup_open fs/namei.c:3488 [inline]
       open_last_lookups fs/namei.c:3556 [inline]
       path_openat+0x1277/0x3190 fs/namei.c:3786
       do_filp_open+0x1c5/0x3d0 fs/namei.c:3816
       do_sys_openat2+0x12c/0x1c0 fs/open.c:1419
       do_sys_open fs/open.c:1434 [inline]
       __do_sys_open fs/open.c:1442 [inline]
       __se_sys_open fs/open.c:1438 [inline]
       __x64_sys_open+0x11f/0x140 fs/open.c:1438
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #2 (sb_internal#3){.+.+}-{0:0}:
       percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
       __sb_start_write include/linux/fs.h:1633 [inline]
       sb_start_intwrite include/linux/fs.h:1755 [inline]
       ocfs2_start_trans+0x26b/0x6c0 fs/ocfs2/journal.c:370
       ocfs2_orphan_for_truncate fs/ocfs2/file.c:396 [inline]
       ocfs2_truncate_file+0x611/0x13a0 fs/ocfs2/file.c:500
       ocfs2_setattr+0x150d/0x1b20 fs/ocfs2/file.c:1211
       notify_change+0xb0d/0xe10 fs/attr.c:499
       do_truncate+0x19b/0x220 fs/open.c:66
       handle_truncate fs/namei.c:3291 [inline]
       do_open fs/namei.c:3636 [inline]
       path_openat+0x298c/0x3190 fs/namei.c:3789
       do_filp_open+0x1c5/0x3d0 fs/namei.c:3816
       do_sys_openat2+0x12c/0x1c0 fs/open.c:1419
       do_sys_open fs/open.c:1434 [inline]
       __do_sys_openat fs/open.c:1450 [inline]
       __se_sys_openat fs/open.c:1445 [inline]
       __x64_sys_openat+0x139/0x160 fs/open.c:1445
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #1 (&ocfs2_file_ip_alloc_sem_key){++++}-{3:3}:
       down_write+0x97/0x1f0 kernel/locking/rwsem.c:1573
       ocfs2_try_remove_refcount_tree+0xb7/0x320 fs/ocfs2/refcounttree.c:932
       ocfs2_truncate_file+0xd84/0x13a0 fs/ocfs2/file.c:521
       ocfs2_setattr+0x150d/0x1b20 fs/ocfs2/file.c:1211
       notify_change+0xb0d/0xe10 fs/attr.c:499
       do_truncate+0x19b/0x220 fs/open.c:66
       handle_truncate fs/namei.c:3291 [inline]
       do_open fs/namei.c:3636 [inline]
       path_openat+0x298c/0x3190 fs/namei.c:3789
       do_filp_open+0x1c5/0x3d0 fs/namei.c:3816
       do_sys_openat2+0x12c/0x1c0 fs/open.c:1419
       do_sys_open fs/open.c:1434 [inline]
       __do_sys_openat fs/open.c:1450 [inline]
       __se_sys_openat fs/open.c:1445 [inline]
       __x64_sys_openat+0x139/0x160 fs/open.c:1445
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #0 (&oi->ip_xattr_sem){++++}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3134 [inline]
       check_prevs_add kernel/locking/lockdep.c:3253 [inline]
       validate_chain kernel/locking/lockdep.c:3869 [inline]
       __lock_acquire+0x2ddb/0x7c80 kernel/locking/lockdep.c:5137
       lock_acquire+0x197/0x410 kernel/locking/lockdep.c:5754
       down_read+0x46/0x2e0 kernel/locking/rwsem.c:1520
       ocfs2_init_acl+0x2fa/0x720 fs/ocfs2/acl.c:366
       ocfs2_mknod+0x12e5/0x20f0 fs/ocfs2/namei.c:410
       ocfs2_create+0x196/0x410 fs/ocfs2/namei.c:674
       lookup_open fs/namei.c:3488 [inline]
       open_last_lookups fs/namei.c:3556 [inline]
       path_openat+0x1277/0x3190 fs/namei.c:3786
       do_filp_open+0x1c5/0x3d0 fs/namei.c:3816
       do_sys_openat2+0x12c/0x1c0 fs/open.c:1419
       do_sys_open fs/open.c:1434 [inline]
       __do_sys_creat fs/open.c:1512 [inline]
       __se_sys_creat fs/open.c:1506 [inline]
       __x64_sys_creat+0x90/0xb0 fs/open.c:1506
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

other info that might help us debug this:

Chain exists of:
  &oi->ip_xattr_sem --> &journal->j_trans_barrier --> jbd2_handle

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  rlock(jbd2_handle);
                               lock(&journal->j_trans_barrier);
                               lock(jbd2_handle);
  rlock(&oi->ip_xattr_sem);

 *** DEADLOCK ***

8 locks held by syz.5.81/6509:
 #0: ffff888062aa4418 (sb_writers#17){.+.+}-{0:0}, at: mnt_want_write+0x41/0x90 fs/namespace.c:403
 #1: ffff88805f68ed98 (&type->i_mutex_dir_key#10){++++}-{3:3}, at: inode_lock include/linux/fs.h:804 [inline]
 #1: ffff88805f68ed98 (&type->i_mutex_dir_key#10){++++}-{3:3}, at: open_last_lookups fs/namei.c:3553 [inline]
 #1: ffff88805f68ed98 (&type->i_mutex_dir_key#10){++++}-{3:3}, at: path_openat+0x7c6/0x3190 fs/namei.c:3786
 #2: ffff888076fcb498 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:804 [inline]
 #2: ffff888076fcb498 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}, at: ocfs2_reserve_suballoc_bits+0x165/0x4360 fs/ocfs2/suballoc.c:782
 #3: ffff888076fcdf58 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:804 [inline]
 #3: ffff888076fcdf58 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{3:3}, at: ocfs2_reserve_suballoc_bits+0x165/0x4360 fs/ocfs2/suballoc.c:782
 #4: ffff888076fc9818 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:804 [inline]
 #4: ffff888076fc9818 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6){+.+.}-{3:3}, at: ocfs2_reserve_local_alloc_bits+0x126/0x24b0 fs/ocfs2/localalloc.c:635
 #5: ffff888062aa4608 (sb_internal#3){.+.+}-{0:0}, at: ocfs2_mknod+0xe47/0x20f0 fs/ocfs2/namei.c:361
 #6: ffff888067dde0e8 (&journal->j_trans_barrier){.+.+}-{3:3}, at: ocfs2_start_trans+0x36a/0x6c0 fs/ocfs2/journal.c:372
 #7: ffff888056f60990 (jbd2_handle){++++}-{0:0}, at: start_this_handle+0x1e7d/0x20c0 fs/jbd2/transaction.c:448

stack backtrace:
CPU: 1 PID: 6509 Comm: syz.5.81 Not tainted 6.6.99-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/07/2025
Call Trace:
 <TASK>
 dump_stack_lvl+0x16c/0x230 lib/dump_stack.c:106
 check_noncircular+0x2bd/0x3c0 kernel/locking/lockdep.c:2187
 check_prev_add kernel/locking/lockdep.c:3134 [inline]
 check_prevs_add kernel/locking/lockdep.c:3253 [inline]
 validate_chain kernel/locking/lockdep.c:3869 [inline]
 __lock_acquire+0x2ddb/0x7c80 kernel/locking/lockdep.c:5137
 lock_acquire+0x197/0x410 kernel/locking/lockdep.c:5754
 down_read+0x46/0x2e0 kernel/locking/rwsem.c:1520
 ocfs2_init_acl+0x2fa/0x720 fs/ocfs2/acl.c:366
 ocfs2_mknod+0x12e5/0x20f0 fs/ocfs2/namei.c:410
 ocfs2_create+0x196/0x410 fs/ocfs2/namei.c:674
 lookup_open fs/namei.c:3488 [inline]
 open_last_lookups fs/namei.c:3556 [inline]
 path_openat+0x1277/0x3190 fs/namei.c:3786
 do_filp_open+0x1c5/0x3d0 fs/namei.c:3816
 do_sys_openat2+0x12c/0x1c0 fs/open.c:1419
 do_sys_open fs/open.c:1434 [inline]
 __do_sys_creat fs/open.c:1512 [inline]
 __se_sys_creat fs/open.c:1506 [inline]
 __x64_sys_creat+0x90/0xb0 fs/open.c:1506
 do_syscall_x64 arch/x86/entry/common.c:51 [inline]
 do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:81
 entry_SYSCALL_64_after_hwframe+0x68/0xd2
RIP: 0033:0x7f05bf58e9a9
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f05c04ab038 EFLAGS: 00000246 ORIG_RAX: 0000000000000055
RAX: ffffffffffffffda RBX: 00007f05bf7b5fa0 RCX: 00007f05bf58e9a9
RDX: 0000000000000000 RSI: 0000000000000001 RDI: 0000200000001680
RBP: 00007f05bf610d69 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007f05bf7b5fa0 R15: 00007ffe1d31d818
 </TASK>
ocfs2: Unmounting device (7,5) on (node local)
syz.5.81 (6509) used greatest stack depth: 17712 bytes left