syzbot


possible deadlock in siw_create_listen

Status: closed as dup on 2020/03/09 17:20
Reported-by: syzbot+3fbea977bd382a4e6140@syzkaller.appspotmail.com
First crash: 932d, last: 900d

Cause bisection: introduced by (bisect log) :
commit bfcccfe78b361f5f6ef48554aed5bcd30c72f67f
Author: Jakub Kicinski <jakub.kicinski@netronome.com>
Date: Tue Nov 5 21:26:11 2019 +0000

  netdevsim: drop code duplicated by a merge

Crash: possible deadlock in rtnl_lock (log)
Repro: C syz .config
Duplicate of (1):
Title Repro Cause bisect Fix bisect Count Last Reported
possible deadlock in cma_netdev_callback C done 1399 900d 942d
Patch testing requests:
Created Duration User Patch Repo Result
2020/03/09 12:57 18m jgg@ziepe.ca git://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git for-next OK

Sample crash report:
iwpm_register_pid: Unable to send a nlmsg (client = 2)
======================================================
WARNING: possible circular locking dependency detected
5.6.0-rc7-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor437/10445 is trying to acquire lock:
ffffffff8a34eb00 (rtnl_mutex){+.+.}, at: siw_create_listen+0x329/0xed0 drivers/infiniband/sw/siw/siw_cm.c:1951

but task is already holding lock:
ffffffff8a1d39e0 (lock#3){+.+.}, at: cma_add_one+0x5dc/0xb60 drivers/infiniband/core/cma.c:4670

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (lock#3){+.+.}:
       __mutex_lock_common kernel/locking/mutex.c:956 [inline]
       __mutex_lock+0x156/0x13c0 kernel/locking/mutex.c:1103
       cma_netdev_callback+0xc5/0x380 drivers/infiniband/core/cma.c:4612
       notifier_call_chain+0xc0/0x230 kernel/notifier.c:83
       call_netdevice_notifiers_info net/core/dev.c:1948 [inline]
       call_netdevice_notifiers_info+0xb5/0x130 net/core/dev.c:1933
       call_netdevice_notifiers_extack net/core/dev.c:1960 [inline]
       call_netdevice_notifiers+0x79/0xa0 net/core/dev.c:1974
       bond_change_active_slave+0x80e/0x1d90 drivers/net/bonding/bond_main.c:944
       bond_select_active_slave+0x250/0xa60 drivers/net/bonding/bond_main.c:986
       bond_enslave+0x4281/0x4800 drivers/net/bonding/bond_main.c:1823
       do_set_master net/core/rtnetlink.c:2468 [inline]
       do_set_master+0x1d7/0x230 net/core/rtnetlink.c:2441
       __rtnl_newlink+0x11d4/0x1590 net/core/rtnetlink.c:3346
       rtnl_newlink+0x64/0xa0 net/core/rtnetlink.c:3377
       rtnetlink_rcv_msg+0x44e/0xad0 net/core/rtnetlink.c:5436
       netlink_rcv_skb+0x15a/0x410 net/netlink/af_netlink.c:2478
       netlink_unicast_kernel net/netlink/af_netlink.c:1303 [inline]
       netlink_unicast+0x537/0x740 net/netlink/af_netlink.c:1329
       netlink_sendmsg+0x882/0xe10 net/netlink/af_netlink.c:1918
       sock_sendmsg_nosec net/socket.c:652 [inline]
       sock_sendmsg+0xcf/0x120 net/socket.c:672
       ____sys_sendmsg+0x6b9/0x7d0 net/socket.c:2345
       ___sys_sendmsg+0x100/0x170 net/socket.c:2399
       __sys_sendmsg+0xec/0x1b0 net/socket.c:2432
       do_syscall_64+0xf6/0x7d0 arch/x86/entry/common.c:294
       entry_SYSCALL_64_after_hwframe+0x49/0xbe

-> #0 (rtnl_mutex){+.+.}:
       check_prev_add kernel/locking/lockdep.c:2475 [inline]
       check_prevs_add kernel/locking/lockdep.c:2580 [inline]
       validate_chain kernel/locking/lockdep.c:2970 [inline]
       __lock_acquire+0x201b/0x3ca0 kernel/locking/lockdep.c:3954
       lock_acquire+0x197/0x420 kernel/locking/lockdep.c:4484
       __mutex_lock_common kernel/locking/mutex.c:956 [inline]
       __mutex_lock+0x156/0x13c0 kernel/locking/mutex.c:1103
       siw_create_listen+0x329/0xed0 drivers/infiniband/sw/siw/siw_cm.c:1951
       iw_cm_listen+0x166/0x1e0 drivers/infiniband/core/iwcm.c:584
       cma_iw_listen drivers/infiniband/core/cma.c:2450 [inline]
       rdma_listen+0x5e2/0x910 drivers/infiniband/core/cma.c:3621
       cma_listen_on_dev+0x512/0x650 drivers/infiniband/core/cma.c:2501
       cma_add_one+0x6aa/0xb60 drivers/infiniband/core/cma.c:4673
       add_client_context+0x3b4/0x520 drivers/infiniband/core/device.c:681
       enable_device_and_get+0x1cd/0x3b0 drivers/infiniband/core/device.c:1316
       ib_register_device drivers/infiniband/core/device.c:1382 [inline]
       ib_register_device+0xa12/0xda0 drivers/infiniband/core/device.c:1343
       siw_device_register drivers/infiniband/sw/siw/siw_main.c:70 [inline]
       siw_newlink drivers/infiniband/sw/siw/siw_main.c:565 [inline]
       siw_newlink+0xdef/0x1310 drivers/infiniband/sw/siw/siw_main.c:542
       nldev_newlink+0x27f/0x400 drivers/infiniband/core/nldev.c:1538
       rdma_nl_rcv_msg drivers/infiniband/core/netlink.c:195 [inline]
       rdma_nl_rcv_skb drivers/infiniband/core/netlink.c:239 [inline]
       rdma_nl_rcv+0x586/0x900 drivers/infiniband/core/netlink.c:259
       netlink_unicast_kernel net/netlink/af_netlink.c:1303 [inline]
       netlink_unicast+0x537/0x740 net/netlink/af_netlink.c:1329
       netlink_sendmsg+0x882/0xe10 net/netlink/af_netlink.c:1918
       sock_sendmsg_nosec net/socket.c:652 [inline]
       sock_sendmsg+0xcf/0x120 net/socket.c:672
       ____sys_sendmsg+0x6b9/0x7d0 net/socket.c:2345
       ___sys_sendmsg+0x100/0x170 net/socket.c:2399
       __sys_sendmsg+0xec/0x1b0 net/socket.c:2432
       do_syscall_64+0xf6/0x7d0 arch/x86/entry/common.c:294
       entry_SYSCALL_64_after_hwframe+0x49/0xbe

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(lock#3);
                               lock(rtnl_mutex);
                               lock(lock#3);
  lock(rtnl_mutex);

 *** DEADLOCK ***

6 locks held by syz-executor437/10445:
 #0: ffffffff8cf2b700 (&rdma_nl_types[idx].sem){.+.+}, at: rdma_nl_rcv_msg drivers/infiniband/core/netlink.c:164 [inline]
 #0: ffffffff8cf2b700 (&rdma_nl_types[idx].sem){.+.+}, at: rdma_nl_rcv_skb drivers/infiniband/core/netlink.c:239 [inline]
 #0: ffffffff8cf2b700 (&rdma_nl_types[idx].sem){.+.+}, at: rdma_nl_rcv+0x3ba/0x900 drivers/infiniband/core/netlink.c:259
 #1: ffffffff8a1c93a8 (link_ops_rwsem){++++}, at: nldev_newlink+0x23b/0x400 drivers/infiniband/core/nldev.c:1528
 #2: ffffffff8a1bcec8 (devices_rwsem){++++}, at: enable_device_and_get+0xfc/0x3b0 drivers/infiniband/core/device.c:1306
 #3: ffffffff8a1bcd88 (clients_rwsem){++++}, at: enable_device_and_get+0x15b/0x3b0 drivers/infiniband/core/device.c:1314
 #4: ffff88809392c538 (&device->client_data_rwsem){++++}, at: add_client_context+0x382/0x520 drivers/infiniband/core/device.c:679
 #5: ffffffff8a1d39e0 (lock#3){+.+.}, at: cma_add_one+0x5dc/0xb60 drivers/infiniband/core/cma.c:4670

stack backtrace:
CPU: 0 PID: 10445 Comm: syz-executor437 Not tainted 5.6.0-rc7-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x188/0x20d lib/dump_stack.c:118
 check_noncircular+0x32e/0x3e0 kernel/locking/lockdep.c:1808
 check_prev_add kernel/locking/lockdep.c:2475 [inline]
 check_prevs_add kernel/locking/lockdep.c:2580 [inline]
 validate_chain kernel/locking/lockdep.c:2970 [inline]
 __lock_acquire+0x201b/0x3ca0 kernel/locking/lockdep.c:3954
 lock_acquire+0x197/0x420 kernel/locking/lockdep.c:4484
 __mutex_lock_common kernel/locking/mutex.c:956 [inline]
 __mutex_lock+0x156/0x13c0 kernel/locking/mutex.c:1103
 siw_create_listen+0x329/0xed0 drivers/infiniband/sw/siw/siw_cm.c:1951
 iw_cm_listen+0x166/0x1e0 drivers/infiniband/core/iwcm.c:584
 cma_iw_listen drivers/infiniband/core/cma.c:2450 [inline]
 rdma_listen+0x5e2/0x910 drivers/infiniband/core/cma.c:3621
 cma_listen_on_dev+0x512/0x650 drivers/infiniband/core/cma.c:2501
 cma_add_one+0x6aa/0xb60 drivers/infiniband/core/cma.c:4673
 add_client_context+0x3b4/0x520 drivers/infiniband/core/device.c:681
 enable_device_and_get+0x1cd/0x3b0 drivers/infiniband/core/device.c:1316
 ib_register_device drivers/infiniband/core/device.c:1382 [inline]
 ib_register_device+0xa12/0xda0 drivers/infiniband/core/device.c:1343
 siw_device_register drivers/infiniband/sw/siw/siw_main.c:70 [inline]
 siw_newlink drivers/infiniband/sw/siw/siw_main.c:565 [inline]
 siw_newlink+0xdef/0x1310 drivers/infiniband/sw/siw/siw_main.c:542
 nldev_newlink+0x27f/0x400 drivers/infiniband/core/nldev.c:1538
 rdma_nl_rcv_msg drivers/infiniband/core/netlink.c:195 [inline]
 rdma_nl_rcv_skb drivers/infiniband/core/netlink.c:239 [inline]
 rdma_nl_rcv+0x586/0x900 drivers/infiniband/core/netlink.c:259
 netlink_unicast_kernel net/netlink/af_netlink.c:1303 [inline]
 netlink_unicast+0x537/0x740 net/netlink/af_netlink.c:1329
 netlink_sendmsg+0x882/0xe10 net/netlink/af_netlink.c:1918
 sock_sendmsg_nosec net/socket.c:652 [inline]
 sock_sendmsg+0xcf/0x120 net/socket.c:672
 ____sys_sendmsg+0x6b9/0x7d0 net/socket.c:2345
 ___sys_sendmsg+0x100/0x170 net/socket.c:2399
 __sys_sendmsg+0xec/0x1b0 net/socket.c:2432
 do_syscall_64+0xf6/0x7d0 arch/x86/entry/common.c:294
 entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x4435f9
Code: 18 89 d0 c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 7b 10 fc ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007fff29d8cb68 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 0000000000000003 RCX: 00000000004435f9
RDX: 0000000000000000 RSI: 00000000200031c0 RDI: 0000000000000005
RBP: 00007fff29d8cb70 R08: 0000000001bbbbbb R09: 0000000001bbbbbb
R10: 0000000001bbbbbb R11: 0000000000000246 R12: 00007fff29d8cb80
R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000

Crashes (1320):
Manager Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Title
ci-upstream-kasan-gce-selinux-root 2020/03/24 08:50 upstream 979e52ca0469 33e14df3 .config log report syz C
ci-upstream-kasan-gce-root 2020/03/22 05:54 upstream b74b991fb8b9 78267cec .config log report syz C
ci-upstream-net-this-kasan-gce 2020/03/12 15:16 net e1f550dc44a4 d850e9d0 .config log report syz C
ci-upstream-net-kasan-gce 2020/03/08 23:12 net-next 425c075dcbb2 2e9971bb .config log report syz C
ci-upstream-linux-next-kasan-gce-root 2020/04/01 04:23 linux-next 770fbb32d34e a34e2c33 .config log report syz C
ci-upstream-kasan-gce-root 2020/04/01 02:31 upstream 56a451b78067 a34e2c33 .config log report
ci-upstream-kasan-gce-smack-root 2020/03/31 03:21 upstream 673b41e04a03 c8d1cc20 .config log report
ci-upstream-net-this-kasan-gce 2020/04/08 03:58 net aa81700cf232 db9bcd4b .config log report
ci-upstream-net-this-kasan-gce 2020/04/08 02:46 net aa81700cf232 db9bcd4b .config log report
ci-upstream-net-this-kasan-gce 2020/04/08 00:48 net aa81700cf232 db9bcd4b .config log report
ci-upstream-net-this-kasan-gce 2020/04/07 23:22 net aa81700cf232 db9bcd4b .config log report
ci-upstream-net-this-kasan-gce 2020/04/07 21:18 net aa81700cf232 db9bcd4b .config log report
ci-upstream-net-this-kasan-gce 2020/04/07 19:22 net aa81700cf232 db9bcd4b .config log report
ci-upstream-net-this-kasan-gce 2020/04/07 18:45 net aa81700cf232 db9bcd4b .config log report
ci-upstream-net-this-kasan-gce 2020/04/07 17:00 net aa81700cf232 99a96044 .config log report
ci-upstream-net-this-kasan-gce 2020/04/07 15:54 net aa81700cf232 99a96044 .config log report
ci-upstream-net-this-kasan-gce 2020/04/07 15:00 net aa81700cf232 99a96044 .config log report
ci-upstream-net-this-kasan-gce 2020/04/07 10:34 net aa81700cf232 99a96044 .config log report
ci-upstream-net-this-kasan-gce 2020/04/07 08:14 net aa81700cf232 99a96044 .config log report
ci-upstream-net-this-kasan-gce 2020/04/07 07:24 net aa81700cf232 99a96044 .config log report
ci-upstream-net-this-kasan-gce 2020/04/07 06:23 net aa81700cf232 99a96044 .config log report
ci-upstream-net-this-kasan-gce 2020/04/07 04:02 net aa81700cf232 99a96044 .config log report
ci-upstream-net-this-kasan-gce 2020/04/07 02:57 net aa81700cf232 99a96044 .config log report
ci-upstream-net-this-kasan-gce 2020/04/07 01:36 net aa81700cf232 99a96044 .config log report
ci-upstream-net-this-kasan-gce 2020/04/06 19:37 net aa81700cf232 99a96044 .config log report
ci-upstream-net-this-kasan-gce 2020/04/06 19:12 net aa81700cf232 99a96044 .config log report
ci-upstream-net-this-kasan-gce 2020/04/04 00:44 net 468c2a100208 5ed396e6 .config log report
ci-upstream-net-this-kasan-gce 2020/04/03 23:43 net 468c2a100208 5ed396e6 .config log report
ci-upstream-net-this-kasan-gce 2020/04/03 13:40 net 468c2a100208 5ed396e6 .config log report
ci-upstream-net-this-kasan-gce 2020/04/03 12:13 net 468c2a100208 5ed396e6 .config log report
ci-upstream-net-this-kasan-gce 2020/04/03 12:08 net 468c2a100208 5ed396e6 .config log report
ci-upstream-net-kasan-gce 2020/04/07 17:39 net-next 1a323ea5356e 99a96044 .config log report
ci-upstream-net-kasan-gce 2020/04/07 13:47 net-next 1a323ea5356e 99a96044 .config log report
ci-upstream-net-kasan-gce 2020/04/07 13:40 net-next 1a323ea5356e 99a96044 .config log report
ci-upstream-net-kasan-gce 2020/04/07 12:10 net-next 1a323ea5356e 99a96044 .config log report
ci-upstream-net-kasan-gce 2020/04/07 11:08 net-next 1a323ea5356e 99a96044 .config log report
ci-upstream-net-kasan-gce 2020/04/07 09:24 net-next 1a323ea5356e 99a96044 .config log report
ci-upstream-net-kasan-gce 2020/04/07 05:11 net-next 1a323ea5356e 99a96044 .config log report
ci-upstream-net-kasan-gce 2020/04/06 23:39 net-next 1a323ea5356e 99a96044 .config log report
ci-upstream-net-kasan-gce 2020/04/03 23:34 net-next 1a323ea5356e 5ed396e6 .config log report
ci-upstream-net-kasan-gce 2020/04/03 22:33 net-next 1a323ea5356e 5ed396e6 .config log report
ci-upstream-net-kasan-gce 2020/04/03 21:08 net-next 1a323ea5356e 5ed396e6 .config log report
ci-upstream-net-kasan-gce 2020/04/03 20:14 net-next 1a323ea5356e 5ed396e6 .config log report
ci-upstream-net-kasan-gce 2020/04/03 19:08 net-next 1a323ea5356e 5ed396e6 .config log report
ci-upstream-net-kasan-gce 2020/04/03 17:41 net-next 1a323ea5356e 5ed396e6 .config log report
ci-upstream-net-kasan-gce 2020/04/03 16:29 net-next 1a323ea5356e 5ed396e6 .config log report
ci-upstream-net-kasan-gce 2020/04/03 15:12 net-next 1a323ea5356e 5ed396e6 .config log report
ci-upstream-net-kasan-gce 2020/04/03 11:02 net-next 1a323ea5356e 5ed396e6 .config log report
ci-upstream-net-kasan-gce 2020/04/03 09:42 net-next 1a323ea5356e a34e2c33 .config log report
ci-upstream-net-kasan-gce 2020/04/03 09:13 net-next 1a323ea5356e a34e2c33 .config log report
ci-upstream-net-kasan-gce 2020/04/03 08:11 net-next 1a323ea5356e a34e2c33 .config log report
ci-upstream-net-kasan-gce 2020/04/03 07:18 net-next 1a323ea5356e a34e2c33 .config log report
ci-upstream-net-kasan-gce 2020/04/03 06:14 net-next 1a323ea5356e a34e2c33 .config log report
ci-upstream-net-kasan-gce 2020/04/03 05:17 net-next 1a323ea5356e a34e2c33 .config log report
ci-upstream-net-kasan-gce 2020/03/06 23:32 net-next 68e2c37690b0 fd2a5f28 .config log report
ci-upstream-net-kasan-gce 2020/03/06 23:30 net-next 68e2c37690b0 fd2a5f28 .config log report
ci-upstream-linux-next-kasan-gce-root 2020/04/02 08:12 linux-next 770fbb32d34e a34e2c33 .config log report
* Struck through repros no longer work on HEAD.