KASAN: slab-out-of-bounds Read in firmware_fallback_sysfs

Status: auto-closed as invalid on 2021/01/03 04:24
Reported-by: syzbot+ab6013550cb5f94f6509@syzkaller.appspotmail.com
First crash: 2308d, last: 2198d
▶ ▼ Similar bugs (2)
Kernel Title Rank 🛈 Repro Cause bisect Fix bisect Count Last Reported Patched Status
upstream KASAN: use-after-free Read in firmware_fallback_sysfs kernel 19 syz, C error 16514 1849d 2049d 20/29 fixed on 2021/11/10 00:50
android-54 BUG: corrupted list in firmware_fallback_sysfs 17 70 1788d 2335d 0/2 auto-closed as invalid on 2022/02/17 06:30

Sample crash report:
platform regulatory.0: Direct firmware load for regulatory.db failed with error -2
platform regulatory.0: Falling back to sysfs fallback for: regulatory.db
==================================================================
BUG: KASAN: slab-out-of-bounds in __list_add_valid+0x36/0xc0 lib/list_debug.c:23
Read of size 8 at addr ffff8881874fa388 by task syz-executor.0/8160

CPU: 1 PID: 8160 Comm: syz-executor.0 Tainted: G        W         5.4.62-syzkaller-01109-g3f20ba7d5d1d #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x1b0/0x21e lib/dump_stack.c:118
 print_address_description+0x96/0x5d0 mm/kasan/report.c:374
 __kasan_report+0x14b/0x1c0 mm/kasan/report.c:506
 kasan_report+0x27/0x50 mm/kasan/common.c:634
 __list_add_valid+0x36/0xc0 lib/list_debug.c:23
 __list_add include/linux/list.h:60 [inline]
 list_add include/linux/list.h:79 [inline]
 fw_load_sysfs_fallback drivers/base/firmware_loader/fallback.c:515 [inline]
 fw_load_from_user_helper drivers/base/firmware_loader/fallback.c:580 [inline]
 firmware_fallback_sysfs+0x48d/0xb30 drivers/base/firmware_loader/fallback.c:654
 _request_firmware+0xe5f/0x1340 drivers/base/firmware_loader/main.c:783
 request_firmware+0x33/0x50 drivers/base/firmware_loader/main.c:826
 reg_reload_regdb+0x81/0x200 net/wireless/reg.c:1083
 genl_family_rcv_msg net/netlink/genetlink.c:629 [inline]
 genl_rcv_msg+0xe76/0x1330 net/netlink/genetlink.c:654
 netlink_rcv_skb+0x1f0/0x460 net/netlink/af_netlink.c:2478
 genl_rcv+0x24/0x40 net/netlink/genetlink.c:665
 netlink_unicast_kernel net/netlink/af_netlink.c:1303 [inline]
 netlink_unicast+0x87c/0xa20 net/netlink/af_netlink.c:1329
 netlink_sendmsg+0x9a7/0xd40 net/netlink/af_netlink.c:1918
 sock_sendmsg_nosec net/socket.c:638 [inline]
 sock_sendmsg net/socket.c:658 [inline]
 ____sys_sendmsg+0x56f/0x860 net/socket.c:2298
 ___sys_sendmsg net/socket.c:2352 [inline]
 __sys_sendmsg+0x26a/0x350 net/socket.c:2398
 do_syscall_64+0xcb/0x150 arch/x86/entry/common.c:290
 entry_SYSCALL_64_after_hwframe+0x44/0xa9
RIP: 0033:0x45d5b9
Code: 5d b4 fb ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 2b b4 fb ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007f6f34ffac78 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 000000000002ac40 RCX: 000000000045d5b9
RDX: 0000000000000000 RSI: 0000000020000180 RDI: 0000000000000008
RBP: 000000000118d160 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 000000000118d12c
R13: 00007ffd77a1194f R14: 00007f6f34ffb9c0 R15: 000000000118d12c

Allocated by task 8038:
 save_stack mm/kasan/common.c:69 [inline]
 set_track mm/kasan/common.c:77 [inline]
 __kasan_kmalloc+0x117/0x1b0 mm/kasan/common.c:510
 slab_post_alloc_hook mm/slab.h:584 [inline]
 slab_alloc_node mm/slub.c:2793 [inline]
 slab_alloc mm/slub.c:2801 [inline]
 kmem_cache_alloc+0x1d5/0x250 mm/slub.c:2806
 kmem_cache_zalloc include/linux/slab.h:680 [inline]
 __kernfs_new_node+0xdb/0x6e0 fs/kernfs/dir.c:631
 kernfs_new_node+0x95/0x160 fs/kernfs/dir.c:697
 __kernfs_create_file+0x45/0x260 fs/kernfs/file.c:1001
 sysfs_add_file_mode_ns+0x293/0x340 fs/sysfs/file.c:305
 create_files fs/sysfs/group.c:63 [inline]
 internal_create_group+0x511/0xe40 fs/sysfs/group.c:148
 internal_create_groups fs/sysfs/group.c:188 [inline]
 sysfs_create_groups+0x6d/0x140 fs/sysfs/group.c:214
 device_add_groups drivers/base/core.c:1988 [inline]
 device_add_attrs drivers/base/core.c:2136 [inline]
 device_add+0xa5d/0x18a0 drivers/base/core.c:2843
 netdev_register_kobject+0x178/0x310 net/core/net-sysfs.c:1755
 register_netdevice+0xbc3/0x1480 net/core/dev.c:9088
 register_netdev+0x37/0x50 net/core/dev.c:9217
 sit_init_net+0x225/0x480 net/ipv6/sit.c:1868
 ops_init+0x26e/0x340 net/core/net_namespace.c:137
 setup_net+0x21b/0xab0 net/core/net_namespace.c:335
 copy_net_ns+0x2e5/0x4a0 net/core/net_namespace.c:476
 create_new_namespaces+0x57b/0x680 kernel/nsproxy.c:103
 unshare_nsproxy_namespaces+0x11e/0x180 kernel/nsproxy.c:202
 ksys_unshare+0x52f/0xa40 kernel/fork.c:2874
 __do_sys_unshare kernel/fork.c:2942 [inline]
 __se_sys_unshare kernel/fork.c:2940 [inline]
 __x64_sys_unshare+0x34/0x40 kernel/fork.c:2940
 do_syscall_64+0xcb/0x150 arch/x86/entry/common.c:290
 entry_SYSCALL_64_after_hwframe+0x44/0xa9

Freed by task 0:
(stack is not available)

The buggy address belongs to the object at ffff8881874fa300
 which belongs to the cache kernfs_node_cache of size 128
The buggy address is located 8 bytes to the right of
 128-byte region [ffff8881874fa300, ffff8881874fa380)
The buggy address belongs to the page:
page:ffffea00061d3e80 refcount:1 mapcount:0 mapping:ffff8881da8ef180 index:0x0
flags: 0x8000000000000200(slab)
raw: 8000000000000200 ffffea0006712500 0000000500000005 ffff8881da8ef180
raw: 0000000000000000 0000000080150015 00000001ffffffff 0000000000000000
page dumped because: kasan: bad access detected

Memory state around the buggy address:
 ffff8881874fa280: 00 00 00 00 00 00 00 00 fc fc fc fc fc fc fc fc
 ffff8881874fa300: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
>ffff8881874fa380: fc fc fc fc fc fc fc fc 00 00 00 00 00 00 00 00
                      ^
 ffff8881874fa400: 00 00 00 00 00 00 00 00 fc fc fc fc fc fc fc fc
 ffff8881874fa480: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
==================================================================
list_add corruption. next->prev should be prev (ffffffff84cb7210), but was bac000e800001f66. (next=ffff8881874fa380).
------------[ cut here ]------------
kernel BUG at lib/list_debug.c:25!
invalid opcode: 0000 [#1] PREEMPT SMP KASAN
CPU: 1 PID: 8160 Comm: syz-executor.0 Tainted: G    B   W         5.4.62-syzkaller-01109-g3f20ba7d5d1d #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
RIP: 0010:__list_add_valid+0xa0/0xc0 lib/list_debug.c:23
Code: 8f 09 99 84 4c 89 fe 4c 89 e2 4c 89 f1 31 c0 e8 82 d4 30 ff 0f 0b 48 c7 c7 da 08 99 84 4c 89 e6 4c 89 f1 31 c0 e8 6c d4 30 ff <0f> 0b 48 c7 c7 3d 09 99 84 4c 89 f6 4c 89 e1 31 c0 e8 56 d4 30 ff
RSP: 0018:ffff8881ca0c72c8 EFLAGS: 00010246
RAX: 0000000000000075 RBX: ffff8881874fa388 RCX: ee9d5bf917a6d000
RDX: ffffc900084df000 RSI: 000000000003ffff RDI: 0000000000040000
RBP: ffff8881874fa380 R08: ffffffff812b99ce R09: ffffed103b725e00
R10: ffffed103b725e00 R11: 0000000000000000 R12: ffffffff84cb7210
R13: dffffc0000000000 R14: ffff8881874fa380 R15: ffff8881c5e33380
FS:  00007f6f34ffb700(0000) GS:ffff8881db900000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000000020bf9000 CR3: 00000001d0dbf004 CR4: 00000000001606e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000600
Call Trace:
 __list_add include/linux/list.h:60 [inline]
 list_add include/linux/list.h:79 [inline]
 fw_load_sysfs_fallback drivers/base/firmware_loader/fallback.c:515 [inline]
 fw_load_from_user_helper drivers/base/firmware_loader/fallback.c:580 [inline]
 firmware_fallback_sysfs+0x48d/0xb30 drivers/base/firmware_loader/fallback.c:654
 _request_firmware+0xe5f/0x1340 drivers/base/firmware_loader/main.c:783
 request_firmware+0x33/0x50 drivers/base/firmware_loader/main.c:826
 reg_reload_regdb+0x81/0x200 net/wireless/reg.c:1083
 genl_family_rcv_msg net/netlink/genetlink.c:629 [inline]
 genl_rcv_msg+0xe76/0x1330 net/netlink/genetlink.c:654
 netlink_rcv_skb+0x1f0/0x460 net/netlink/af_netlink.c:2478
 genl_rcv+0x24/0x40 net/netlink/genetlink.c:665
 netlink_unicast_kernel net/netlink/af_netlink.c:1303 [inline]
 netlink_unicast+0x87c/0xa20 net/netlink/af_netlink.c:1329
 netlink_sendmsg+0x9a7/0xd40 net/netlink/af_netlink.c:1918
 sock_sendmsg_nosec net/socket.c:638 [inline]
 sock_sendmsg net/socket.c:658 [inline]
 ____sys_sendmsg+0x56f/0x860 net/socket.c:2298
 ___sys_sendmsg net/socket.c:2352 [inline]
 __sys_sendmsg+0x26a/0x350 net/socket.c:2398
 do_syscall_64+0xcb/0x150 arch/x86/entry/common.c:290
 entry_SYSCALL_64_after_hwframe+0x44/0xa9
RIP: 0033:0x45d5b9
Code: 5d b4 fb ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 2b b4 fb ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007f6f34ffac78 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 000000000002ac40 RCX: 000000000045d5b9
RDX: 0000000000000000 RSI: 0000000020000180 RDI: 0000000000000008
RBP: 000000000118d160 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 000000000118d12c
R13: 00007ffd77a1194f R14: 00007f6f34ffb9c0 R15: 000000000118d12c
Modules linked in:
---[ end trace 1fce417c916786c4 ]---
RIP: 0010:__list_add_valid+0xa0/0xc0 lib/list_debug.c:23
Code: 8f 09 99 84 4c 89 fe 4c 89 e2 4c 89 f1 31 c0 e8 82 d4 30 ff 0f 0b 48 c7 c7 da 08 99 84 4c 89 e6 4c 89 f1 31 c0 e8 6c d4 30 ff <0f> 0b 48 c7 c7 3d 09 99 84 4c 89 f6 4c 89 e1 31 c0 e8 56 d4 30 ff
RSP: 0018:ffff8881ca0c72c8 EFLAGS: 00010246
RAX: 0000000000000075 RBX: ffff8881874fa388 RCX: ee9d5bf917a6d000
RDX: ffffc900084df000 RSI: 000000000003ffff RDI: 0000000000040000
RBP: ffff8881874fa380 R08: ffffffff812b99ce R09: ffffed103b725e00
R10: ffffed103b725e00 R11: 0000000000000000 R12: ffffffff84cb7210
R13: dffffc0000000000 R14: ffff8881874fa380 R15: ffff8881c5e33380
FS:  00007f6f34ffb700(0000) GS:ffff8881db800000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000000020ccc000 CR3: 00000001d0dbf002 CR4: 00000000001606f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000600

Crashes (6):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2020/09/05 04:23 https://android.googlesource.com/kernel/common android-5.4 3f20ba7d5d1d abf9ba4f .config console log report ci2-android-5-4-kasan
2020/08/08 23:41 https://android.googlesource.com/kernel/common android-5.4 99256a8c206b f721e4a0 .config console log report ci2-android-5-4-kasan
2020/08/01 04:53 https://android.googlesource.com/kernel/common android-5.4 a6b381772d46 8df85ed9 .config console log report ci2-android-5-4-kasan
2020/07/25 19:50 https://android.googlesource.com/kernel/common android-5.4 5c3841e16e44 1f7cc1ca .config console log report ci2-android-5-4-kasan
2020/05/18 07:14 https://android.googlesource.com/kernel/common android-5.4 b818fc58f06b 37bccd4e .config console log report ci2-android-5-4-kasan
2020/05/18 05:40 https://android.googlesource.com/kernel/common android-5.4 b818fc58f06b 37bccd4e .config console log report ci2-android-5-4-kasan
* Struck through repros no longer work on HEAD.