syzbot

======================================================
WARNING: possible circular locking dependency detected
6.6.99-syzkaller #0 Not tainted
------------------------------------------------------
syz.2.1034/11465 is trying to acquire lock:
ffff888054df9818 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:804 [inline]
ffff888054df9818 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{3:3}, at: ocfs2_del_inode_from_orphan+0x135/0x740 fs/ocfs2/namei.c:2716

but task is already holding lock:
ffff888054e8ea20 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_dio_end_io_write fs/ocfs2/aops.c:2325 [inline]
ffff888054e8ea20 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_dio_end_io+0x38c/0x10f0 fs/ocfs2/aops.c:2431

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}:
       down_write+0x97/0x1f0 kernel/locking/rwsem.c:1573
       ocfs2_create_local_dquot+0x1a4/0x1790 fs/ocfs2/quota_local.c:1224
       ocfs2_acquire_dquot+0x7cf/0xaf0 fs/ocfs2/quota_global.c:871
       dqget+0x77c/0xeb0 fs/quota/dquot.c:988
       __dquot_initialize+0x3ba/0xcb0 fs/quota/dquot.c:1516
       ocfs2_get_init_inode+0x13c/0x1b0 fs/ocfs2/namei.c:202
       ocfs2_mknod+0x867/0x20f0 fs/ocfs2/namei.c:310
       ocfs2_mkdir+0x196/0x410 fs/ocfs2/namei.c:657
       vfs_mkdir+0x296/0x440 fs/namei.c:4113
       do_mkdirat+0x1d4/0x440 fs/namei.c:4136
       __do_sys_mkdirat fs/namei.c:4151 [inline]
       __se_sys_mkdirat fs/namei.c:4149 [inline]
       __x64_sys_mkdirat+0x89/0xa0 fs/namei.c:4149
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #2 (&dquot->dq_lock){+.+.}-{3:3}:
       __mutex_lock_common kernel/locking/mutex.c:603 [inline]
       __mutex_lock+0x129/0xcc0 kernel/locking/mutex.c:747
       wait_on_dquot fs/quota/dquot.c:356 [inline]
       dqget+0x6fc/0xeb0 fs/quota/dquot.c:983
       __dquot_initialize+0x3ba/0xcb0 fs/quota/dquot.c:1516
       ocfs2_get_init_inode+0x13c/0x1b0 fs/ocfs2/namei.c:202
       ocfs2_mknod+0x867/0x20f0 fs/ocfs2/namei.c:310
       ocfs2_mkdir+0x196/0x410 fs/ocfs2/namei.c:657
       vfs_mkdir+0x296/0x440 fs/namei.c:4113
       do_mkdirat+0x1d4/0x440 fs/namei.c:4136
       __do_sys_mkdirat fs/namei.c:4151 [inline]
       __se_sys_mkdirat fs/namei.c:4149 [inline]
       __x64_sys_mkdirat+0x89/0xa0 fs/namei.c:4149
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #1 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{3:3}:
       down_write+0x97/0x1f0 kernel/locking/rwsem.c:1573
       inode_lock include/linux/fs.h:804 [inline]
       ocfs2_remove_inode fs/ocfs2/inode.c:655 [inline]
       ocfs2_wipe_inode fs/ocfs2/inode.c:818 [inline]
       ocfs2_delete_inode fs/ocfs2/inode.c:1079 [inline]
       ocfs2_evict_inode+0x1313/0x3e60 fs/ocfs2/inode.c:1216
       evict+0x486/0x870 fs/inode.c:705
       ocfs2_dentry_iput+0x248/0x370 fs/ocfs2/dcache.c:418
       __dentry_kill+0x431/0x650 fs/dcache.c:611
       dentry_kill+0xb8/0x290 fs/dcache.c:-1
       dput+0xfe/0x1e0 fs/dcache.c:918
       __fput+0x5e5/0x970 fs/file_table.c:392
       task_work_run+0x1ce/0x250 kernel/task_work.c:239
       resume_user_mode_work include/linux/resume_user_mode.h:49 [inline]
       exit_to_user_mode_loop+0xe6/0x110 kernel/entry/common.c:177
       exit_to_user_mode_prepare+0xb1/0x140 kernel/entry/common.c:210
       __syscall_exit_to_user_mode_work kernel/entry/common.c:291 [inline]
       syscall_exit_to_user_mode+0x1a/0x50 kernel/entry/common.c:302
       do_syscall_64+0x61/0xb0 arch/x86/entry/common.c:87
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3134 [inline]
       check_prevs_add kernel/locking/lockdep.c:3253 [inline]
       validate_chain kernel/locking/lockdep.c:3869 [inline]
       __lock_acquire+0x2ddb/0x7c80 kernel/locking/lockdep.c:5137
       lock_acquire+0x197/0x410 kernel/locking/lockdep.c:5754
       down_write+0x97/0x1f0 kernel/locking/rwsem.c:1573
       inode_lock include/linux/fs.h:804 [inline]
       ocfs2_del_inode_from_orphan+0x135/0x740 fs/ocfs2/namei.c:2716
       ocfs2_dio_end_io_write fs/ocfs2/aops.c:2333 [inline]
       ocfs2_dio_end_io+0x47b/0x10f0 fs/ocfs2/aops.c:2431
       dio_complete+0x254/0x710 fs/direct-io.c:282
       __blockdev_direct_IO+0x2dc8/0x3420 fs/direct-io.c:1308
       ocfs2_direct_IO+0x240/0x2b0 fs/ocfs2/aops.c:2468
       generic_file_direct_write+0x1d4/0x3e0 mm/filemap.c:3941
       __generic_file_write_iter+0x11b/0x230 mm/filemap.c:4097
       ocfs2_file_write_iter+0x1582/0x1d00 fs/ocfs2/file.c:2468
       do_iter_readv_writev fs/read_write.c:-1 [inline]
       do_iter_write+0x79a/0xc70 fs/read_write.c:860
       iter_file_splice_write+0x66f/0xc50 fs/splice.c:736
       do_splice_from fs/splice.c:933 [inline]
       direct_splice_actor+0xe8/0x130 fs/splice.c:1142
       splice_direct_to_actor+0x2f0/0x870 fs/splice.c:1088
       do_splice_direct+0x1b7/0x2c0 fs/splice.c:1194
       do_sendfile+0x5dc/0xf70 fs/read_write.c:1254
       __do_sys_sendfile64 fs/read_write.c:1322 [inline]
       __se_sys_sendfile64+0x13f/0x190 fs/read_write.c:1308
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

other info that might help us debug this:

Chain exists of:
  &ocfs2_sysfile_lock_key[args->fi_sysfile_type] --> &dquot->dq_lock --> &ocfs2_quota_ip_alloc_sem_key

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ocfs2_quota_ip_alloc_sem_key);
                               lock(&dquot->dq_lock);
                               lock(&ocfs2_quota_ip_alloc_sem_key);
  lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]);

 *** DEADLOCK ***

3 locks held by syz.2.1034/11465:
 #0: ffff88806397a418 (sb_writers#29){.+.+}-{0:0}, at: do_sendfile+0x5b9/0xf70 fs/read_write.c:1253
 #1: ffff888054e8ed98 (&sb->s_type->i_mutex_key#37){++++}-{3:3}, at: inode_lock include/linux/fs.h:804 [inline]
 #1: ffff888054e8ed98 (&sb->s_type->i_mutex_key#37){++++}-{3:3}, at: ocfs2_file_write_iter+0x40b/0x1d00 fs/ocfs2/file.c:2398
 #2: ffff888054e8ea20 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_dio_end_io_write fs/ocfs2/aops.c:2325 [inline]
 #2: ffff888054e8ea20 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_dio_end_io+0x38c/0x10f0 fs/ocfs2/aops.c:2431

stack backtrace:
CPU: 0 PID: 11465 Comm: syz.2.1034 Not tainted 6.6.99-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/07/2025
Call Trace:
 <TASK>
 dump_stack_lvl+0x16c/0x230 lib/dump_stack.c:106
 check_noncircular+0x2bd/0x3c0 kernel/locking/lockdep.c:2187
 check_prev_add kernel/locking/lockdep.c:3134 [inline]
 check_prevs_add kernel/locking/lockdep.c:3253 [inline]
 validate_chain kernel/locking/lockdep.c:3869 [inline]
 __lock_acquire+0x2ddb/0x7c80 kernel/locking/lockdep.c:5137
 lock_acquire+0x197/0x410 kernel/locking/lockdep.c:5754
 down_write+0x97/0x1f0 kernel/locking/rwsem.c:1573
 inode_lock include/linux/fs.h:804 [inline]
 ocfs2_del_inode_from_orphan+0x135/0x740 fs/ocfs2/namei.c:2716
 ocfs2_dio_end_io_write fs/ocfs2/aops.c:2333 [inline]
 ocfs2_dio_end_io+0x47b/0x10f0 fs/ocfs2/aops.c:2431
 dio_complete+0x254/0x710 fs/direct-io.c:282
 __blockdev_direct_IO+0x2dc8/0x3420 fs/direct-io.c:1308
 ocfs2_direct_IO+0x240/0x2b0 fs/ocfs2/aops.c:2468
 generic_file_direct_write+0x1d4/0x3e0 mm/filemap.c:3941
 __generic_file_write_iter+0x11b/0x230 mm/filemap.c:4097
 ocfs2_file_write_iter+0x1582/0x1d00 fs/ocfs2/file.c:2468
 do_iter_readv_writev fs/read_write.c:-1 [inline]
 do_iter_write+0x79a/0xc70 fs/read_write.c:860
 iter_file_splice_write+0x66f/0xc50 fs/splice.c:736
 do_splice_from fs/splice.c:933 [inline]
 direct_splice_actor+0xe8/0x130 fs/splice.c:1142
 splice_direct_to_actor+0x2f0/0x870 fs/splice.c:1088
 do_splice_direct+0x1b7/0x2c0 fs/splice.c:1194
 do_sendfile+0x5dc/0xf70 fs/read_write.c:1254
 __do_sys_sendfile64 fs/read_write.c:1322 [inline]
 __se_sys_sendfile64+0x13f/0x190 fs/read_write.c:1308
 do_syscall_x64 arch/x86/entry/common.c:51 [inline]
 do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:81
 entry_SYSCALL_64_after_hwframe+0x68/0xd2
RIP: 0033:0x7fa56e78e9a9
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fa56f52c038 EFLAGS: 00000246 ORIG_RAX: 0000000000000028
RAX: ffffffffffffffda RBX: 00007fa56e9b5fa0 RCX: 00007fa56e78e9a9
RDX: 0000000000000000 RSI: 0000000000000006 RDI: 0000000000000005
RBP: 00007fa56e810ca1 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000fffe82 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007fa56e9b5fa0 R15: 00007fffacf90118
 </TASK>