syzbot

ip_tables: iptables: counters copy to user failed while replacing table
ip_tables: iptables: counters copy to user failed while replacing table
ip_tables: iptables: counters copy to user failed while replacing table
ip_tables: iptables: counters copy to user failed while replacing table
======================================================
WARNING: possible circular locking dependency detected
4.14.307-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor779/8238 is trying to acquire lock:
 (&table[i].mutex){+.+.}, at: [<ffffffff85f0bb8d>] nf_tables_netdev_event+0x10d/0x4d0 net/netfilter/nf_tables_netdev.c:122

but task is already holding lock:
 (rtnl_mutex){+.+.}, at: [<ffffffff85c8dcdd>] rtnl_lock net/core/rtnetlink.c:72 [inline]
 (rtnl_mutex){+.+.}, at: [<ffffffff85c8dcdd>] rtnetlink_rcv_msg+0x31d/0xb10 net/core/rtnetlink.c:4317

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (rtnl_mutex){+.+.}:
       __mutex_lock_common kernel/locking/mutex.c:756 [inline]
       __mutex_lock+0xc4/0x1310 kernel/locking/mutex.c:893
       unregister_netdevice_notifier+0x5e/0x2b0 net/core/dev.c:1630
       tee_tg_destroy+0x5c/0xb0 net/netfilter/xt_TEE.c:123
       cleanup_entry+0x1fd/0x2d0 net/ipv4/netfilter/ip_tables.c:666
       __do_replace+0x38d/0x570 net/ipv4/netfilter/ip_tables.c:1086
       do_replace net/ipv4/netfilter/ip_tables.c:1142 [inline]
       do_ipt_set_ctl+0x256/0x3a0 net/ipv4/netfilter/ip_tables.c:1676
       nf_sockopt net/netfilter/nf_sockopt.c:106 [inline]
       nf_setsockopt+0x5f/0xb0 net/netfilter/nf_sockopt.c:115
       ip_setsockopt net/ipv4/ip_sockglue.c:1255 [inline]
       ip_setsockopt+0x94/0xb0 net/ipv4/ip_sockglue.c:1240
       udp_setsockopt+0x45/0x80 net/ipv4/udp.c:2455
       SYSC_setsockopt net/socket.c:1865 [inline]
       SyS_setsockopt+0x110/0x1e0 net/socket.c:1844
       do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
       entry_SYSCALL_64_after_hwframe+0x5e/0xd3

-> #1 (&xt[i].mutex){+.+.}:
       __mutex_lock_common kernel/locking/mutex.c:756 [inline]
       __mutex_lock+0xc4/0x1310 kernel/locking/mutex.c:893
       match_revfn+0x43/0x210 net/netfilter/x_tables.c:332
       xt_find_revision+0x8d/0x1d0 net/netfilter/x_tables.c:380
       nfnl_compat_get+0x1f7/0x870 net/netfilter/nft_compat.c:678
       nfnetlink_rcv_msg+0x9bb/0xc00 net/netfilter/nfnetlink.c:214
       netlink_rcv_skb+0x125/0x390 net/netlink/af_netlink.c:2461
       nfnetlink_rcv+0x1ab/0x1da0 net/netfilter/nfnetlink.c:515
       netlink_unicast_kernel net/netlink/af_netlink.c:1302 [inline]
       netlink_unicast+0x437/0x610 net/netlink/af_netlink.c:1328
       netlink_sendmsg+0x651/0xbc0 net/netlink/af_netlink.c:1900
       sock_sendmsg_nosec net/socket.c:646 [inline]
       sock_sendmsg+0xb5/0x100 net/socket.c:656
       ___sys_sendmsg+0x6c8/0x800 net/socket.c:2062
       __sys_sendmsg+0xa3/0x120 net/socket.c:2096
       SYSC_sendmsg net/socket.c:2107 [inline]
       SyS_sendmsg+0x27/0x40 net/socket.c:2103
       do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
       entry_SYSCALL_64_after_hwframe+0x5e/0xd3

-> #0 (&table[i].mutex){+.+.}:
       lock_acquire+0x170/0x3f0 kernel/locking/lockdep.c:3998
       __mutex_lock_common kernel/locking/mutex.c:756 [inline]
       __mutex_lock+0xc4/0x1310 kernel/locking/mutex.c:893
       nf_tables_netdev_event+0x10d/0x4d0 net/netfilter/nf_tables_netdev.c:122
       notifier_call_chain+0x108/0x1a0 kernel/notifier.c:93
       call_netdevice_notifiers_info net/core/dev.c:1667 [inline]
       call_netdevice_notifiers net/core/dev.c:1683 [inline]
       rollback_registered_many+0x765/0xbb0 net/core/dev.c:7211
       unregister_netdevice_many.part.0+0x18/0x2e0 net/core/dev.c:8293
       unregister_netdevice_many+0x36/0x50 net/core/dev.c:8292
       rtnl_delete_link net/core/rtnetlink.c:2375 [inline]
       rtnl_dellink+0x25b/0x6a0 net/core/rtnetlink.c:2411
       rtnetlink_rcv_msg+0x3be/0xb10 net/core/rtnetlink.c:4322
       netlink_rcv_skb+0x125/0x390 net/netlink/af_netlink.c:2461
       netlink_unicast_kernel net/netlink/af_netlink.c:1302 [inline]
       netlink_unicast+0x437/0x610 net/netlink/af_netlink.c:1328
       netlink_sendmsg+0x651/0xbc0 net/netlink/af_netlink.c:1900
       sock_sendmsg_nosec net/socket.c:646 [inline]
       sock_sendmsg+0xb5/0x100 net/socket.c:656
       ___sys_sendmsg+0x6c8/0x800 net/socket.c:2062
       __sys_sendmsg+0xa3/0x120 net/socket.c:2096
       SYSC_sendmsg net/socket.c:2107 [inline]
       SyS_sendmsg+0x27/0x40 net/socket.c:2103
       do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
       entry_SYSCALL_64_after_hwframe+0x5e/0xd3

other info that might help us debug this:

Chain exists of:
  &table[i].mutex --> &xt[i].mutex --> rtnl_mutex

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(rtnl_mutex);
                               lock(&xt[i].mutex);
                               lock(rtnl_mutex);
  lock(&table[i].mutex);

 *** DEADLOCK ***

1 lock held by syz-executor779/8238:
 #0:  (rtnl_mutex){+.+.}, at: [<ffffffff85c8dcdd>] rtnl_lock net/core/rtnetlink.c:72 [inline]
 #0:  (rtnl_mutex){+.+.}, at: [<ffffffff85c8dcdd>] rtnetlink_rcv_msg+0x31d/0xb10 net/core/rtnetlink.c:4317

stack backtrace:
CPU: 1 PID: 8238 Comm: syz-executor779 Not tainted 4.14.307-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/16/2023
Call Trace:
 __dump_stack lib/dump_stack.c:17 [inline]
 dump_stack+0x1b2/0x281 lib/dump_stack.c:58
 print_circular_bug.constprop.0.cold+0x2d7/0x41e kernel/locking/lockdep.c:1258
 check_prev_add kernel/locking/lockdep.c:1905 [inline]
 check_prevs_add kernel/locking/lockdep.c:2022 [inline]
 validate_chain kernel/locking/lockdep.c:2464 [inline]
 __lock_acquire+0x2e0e/0x3f20 kernel/locking/lockdep.c:3491
 lock_acquire+0x170/0x3f0 kernel/locking/lockdep.c:3998
 __mutex_lock_common kernel/locking/mutex.c:756 [inline]
 __mutex_lock+0xc4/0x1310 kernel/locking/mutex.c:893
 nf_tables_netdev_event+0x10d/0x4d0 net/netfilter/nf_tables_netdev.c:122
 notifier_call_chain+0x108/0x1a0 kernel/notifier.c:93
 call_netdevice_notifiers_info net/core/dev.c:1667 [inline]
 call_netdevice_notifiers net/core/dev.c:1683 [inline]
 rollback_registered_many+0x765/0xbb0 net/core/dev.c:7211
 unregister_netdevice_many.part.0+0x18/0x2e0 net/core/dev.c:8293
 unregister_netdevice_many+0x36/0x50 net/core/dev.c:8292
 rtnl_delete_link net/core/rtnetlink.c:2375 [inline]
 rtnl_dellink+0x25b/0x6a0 net/core/rtnetlink.c:2411
 rtnetlink_rcv_msg+0x3be/0xb10 net/core/rtnetlink.c:4322
 netlink_rcv_skb+0x125/0x390 net/netlink/af_netlink.c:2461
 netlink_unicast_kernel net/netlink/af_netlink.c:1302 [inline]
 netlink_unicast+0x437/0x610 net/netlink/af_netlink.c:1328
 netlink_sendmsg+0x651/0xbc0 net/netlink/af_netlink.c:1900
 sock_sendmsg_nosec net/socket.c:646 [inline]
 sock_sendmsg+0xb5/0x100 net/socket.c:656
 ___sys_sendmsg+0x6c8/0x800 net/socket.c:2062
 __sys_sendmsg+0xa3/0x120 net/socket.c:2096
 SYSC_sendmsg net/socket.c:2107 [inline]
 SyS_sendmsg+0x27/0x40 net/socket.c:2103
 do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
 entry_SYSCALL_64_after_hwframe+0x5e/0xd3
RIP: 0033:0x7febd964c249
RSP: 002b:00007fffe9c6e078 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 00007fffe9c6e0a0 RCX: 00007febd964c249
RDX: 0000000000000000 RSI: 0000000020000400 RDI: 0000000000000003
RBP: 0000000000000000 R08: 000000000000000d R09: 000000000000000d
R10: 0000000000000000 R11: 0000000000000246 R12: 00007fffe9c6e090
R13: 00000000000f4240 R14: 0000000000008b8a R15: 00007fffe9c6e084
ip_tables: iptables: counters copy to user failed while replacing table
device bridge_slave_1 left promiscuous mode
bridge0: port 2(bridge_slave_1) entered disabled state
device bridge_slave_0 left promiscuous mode
bridge0: port 1(bridge_slave_0) entered disabled state
bond0 (unregistering): Releasing backup interface bond_slave_0
bond0 (unregistering): Releasing backup interface bond_slave_1
bond0 (unregistering): Released all slaves
team0 (unregistering): Port device team_slave_0 removed
team0 (unregistering): Port device team_slave_1 removed
batman_adv: batadv0: Interface deactivated: batadv_slave_0
batman_adv: batadv0: Removing interface: batadv_slave_0
batman_adv: batadv0: Interface deactivated: batadv_slave_1
batman_adv: batadv0: Removing interface: batadv_slave_1
device hsr_slave_0 left promiscuous mode
device hsr_slave_1 left promiscuous mode
nla_parse: 888 callbacks suppressed
netlink: 4 bytes leftover after parsing attributes in process `syz-executor779'.
netlink: 4 bytes leftover after parsing attributes in process `syz-executor779'.
net_ratelimit: 439 callbacks suppressed
ip_tables: iptables: counters copy to user failed while replacing table
netlink: 4 bytes leftover after parsing attributes in process `syz-executor779'.
netlink: 4 bytes leftover after parsing attributes in process `syz-executor779'.
ip_tables: iptables: counters copy to user failed while replacing table
netlink: 4 bytes leftover after parsing attributes in process `syz-executor779'.
netlink: 4 bytes leftover after parsing attributes in process `syz-executor779'.
ip_tables: iptables: counters copy to user failed while replacing table
netlink: 4 bytes leftover after parsing attributes in process `syz-executor779'.
netlink: 4 bytes leftover after parsing attributes in process `syz-executor779'.
ip_tables: iptables: counters copy to user failed while replacing table
netlink: 4 bytes leftover after parsing attributes in process `syz-executor779'.
netlink: 4 bytes leftover after parsing attributes in process `syz-executor779'.
ip_tables: iptables: counters copy to user failed while replacing table
ip_tables: iptables: counters copy to user failed while replacing table
ip_tables: iptables: counters copy to user failed while replacing table
ip_tables: iptables: counters copy to user failed while replacing table
ip_tables: iptables: counters copy to user failed while replacing table
ip_tables: iptables: counters copy to user failed while replacing table
nla_parse: 1622 callbacks suppressed
netlink: 4 bytes leftover after parsing attributes in process `syz-executor779'.
netlink: 4 bytes leftover after parsing attributes in process `syz-executor779'.
netlink: 4 bytes leftover after parsing attributes in process `syz-executor779'.
netlink: 4 bytes leftover after parsing attributes in process `syz-executor779'.
net_ratelimit: 807 callbacks suppressed
ip_tables: iptables: counters copy to user failed while replacing table
netlink: 4 bytes leftover after parsing attributes in process `syz-executor779'.
netlink: 4 bytes leftover after parsing attributes in process `syz-executor779'.
ip_tables: iptables: counters copy to user failed while replacing table
netlink: 4 bytes leftover after parsing attributes in process `syz-executor779'.
netlink: 4 bytes leftover after parsing attributes in process `syz-executor779'.
ip_tables: iptables: counters copy to user failed while replacing table
netlink: 4 bytes leftover after parsing attributes in process `syz-executor779'.
netlink: 4 bytes leftover after parsing attributes in process `syz-executor779'.
ip_tables: iptables: counters copy to user failed while replacing table
ip_tables: iptables: counters copy to user failed while replacing table
ip_tables: iptables: counters copy to user failed while replacing table
ip_tables: iptables: counters copy to user failed while replacing table