general protection fault in rds_recv_rcvbuf

general protection fault in rds_recv_rcvbuf_delta
Status: fixed on 2019/12/02 18:09
Reported-by: syzbot+ea5ad148bf8c46332503@syzkaller.appspotmail.com
Fix commit: 3de749d6 net/rds: An rds_sock is added too early to the hash table
First crash: 352d, last: 305d

Fix bisection: fixed by (bisect log):

commit 3de749d6d7cee11bbbe00090f4a285b759a406ab
Author: Ka-Cheong Poon <ka-cheong.poon@oracle.com>
Date: Wed Sep 11 09:58:05 2019 +0000

net/rds: An rds_sock is added too early to the hash table

similar bugs (2):
Kernel	Title	Repro	Bisected	Count	Last	Reported	Patched	Status
linux-4.14	general protection fault in rds_recv_rcvbuf_delta			1	139d	139d	0/1	auto-closed as invalid on 2020/05/10 22:05
upstream	general protection fault in rds_recv_rcvbuf_delta	C	cause	35	337d	565d	14/17	fixed on 2019/10/09 10:54

Sample crash report:

kasan: CONFIG_KASAN_INLINE enabled
kasan: GPF could be caused by NULL-ptr deref or user memory access
general protection fault: 0000 [#1] PREEMPT SMP KASAN
CPU: 1 PID: 13045 Comm: syz-executor971 Not tainted 4.19.50 #22
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
RIP: 0010:rds_recv_rcvbuf_delta.part.0+0x14a/0x3f0 net/rds/recv.c:108
Code: c1 ea 03 80 3c 02 00 0f 85 6e 02 00 00 4c 8b a3 b8 04 00 00 48 b8 00 00 00 00 00 fc ff df 49 8d 7c 24 2c 48 89 fa 48 c1 ea 03 <0f> b6 14 02 48 89 f8 83 e0 07 83 c0 03 38 d0 7c 08 84 d2 0f 85 00
RSP: 0018:ffff888096a276c0 EFLAGS: 00010007
RAX: dffffc0000000000 RBX: ffff888095ff1880 RCX: ffffffff86723d7d
RDX: 0000000000000005 RSI: ffffffff86723d8b RDI: 000000000000002c
RBP: ffff888096a276f8 R08: ffff88808faf00c0 R09: ffffed1012bfe3bc
R10: ffffed1012bfe3bb R11: ffff888095ff1ddb R12: 0000000000000000
R13: ffff888095ff1d9c R14: 000000000002e440 R15: ffff8880946fcf00
FS:  000000000169f880(0000) GS:ffff8880ae900000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000000020000040 CR3: 000000009241e000 CR4: 00000000001406e0
Call Trace:
 rds_recv_rcvbuf_delta net/rds/recv.c:384 [inline]
 rds_recv_incoming+0x789/0x11c0 net/rds/recv.c:384
 rds_loop_xmit+0xf3/0x2a0 net/rds/loop.c:96
 rds_send_xmit+0x10ff/0x2540 net/rds/send.c:355
 rds_sendmsg+0x2a24/0x2f50 net/rds/send.c:1365
 sock_sendmsg_nosec net/socket.c:622 [inline]
 sock_sendmsg+0xd7/0x130 net/socket.c:632
 ___sys_sendmsg+0x803/0x920 net/socket.c:2115
 __sys_sendmsg+0x105/0x1d0 net/socket.c:2153
 __do_sys_sendmsg net/socket.c:2162 [inline]
 __se_sys_sendmsg net/socket.c:2160 [inline]
 __x64_sys_sendmsg+0x78/0xb0 net/socket.c:2160
 do_syscall_64+0xfd/0x620 arch/x86/entry/common.c:293
 entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x442339
Code: e8 6c e8 ff ff 48 83 c4 18 c3 0f 1f 80 00 00 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 cb 09 fc ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007fff88c59e68 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 0000000000000003 RCX: 0000000000442339
RDX: 0000000000000000 RSI: 0000000020000340 RDI: 0000000000000003
RBP: 000000000004c68b R08: 0000000400000000 R09: 0000000400000000
R10: 0000000400000000 R11: 0000000000000246 R12: 0000000000403190
R13: 0000000000403220 R14: 0000000000000000 R15: 0000000000000000
Modules linked in:
---[ end trace bc78184e71349cce ]---
RIP: 0010:rds_recv_rcvbuf_delta.part.0+0x14a/0x3f0 net/rds/recv.c:108
Code: c1 ea 03 80 3c 02 00 0f 85 6e 02 00 00 4c 8b a3 b8 04 00 00 48 b8 00 00 00 00 00 fc ff df 49 8d 7c 24 2c 48 89 fa 48 c1 ea 03 <0f> b6 14 02 48 89 f8 83 e0 07 83 c0 03 38 d0 7c 08 84 d2 0f 85 00
RSP: 0018:ffff888096a276c0 EFLAGS: 00010007
RAX: dffffc0000000000 RBX: ffff888095ff1880 RCX: ffffffff86723d7d
RDX: 0000000000000005 RSI: ffffffff86723d8b RDI: 000000000000002c
RBP: ffff888096a276f8 R08: ffff88808faf00c0 R09: ffffed1012bfe3bc
R10: ffffed1012bfe3bb R11: ffff888095ff1ddb R12: 0000000000000000
R13: ffff888095ff1d9c R14: 000000000002e440 R15: ffff8880946fcf00
FS:  000000000169f880(0000) GS:ffff8880ae900000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000000020000040 CR3: 000000009241e000 CR4: 00000000001406e0

Crashes (7):
Manager	Time	Kernel	Commit	Syzkaller	Config	Log	Report	Syz repro	C repro	Maintainers
ci2-linux-4-19	2019/06/12 16:54	linux-4.19.y	768292d0	794a1ad7	.config	log	report	syz	C	davem@davemloft.net, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, netdev@vger.kernel.org, rds-devel@oss.oracle.com, santosh.shilimkar@oracle.com
ci2-linux-4-19	2019/07/29 12:13	linux-4.19.y	64f46940	c85e1c5b	.config	log	report			davem@davemloft.net, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, netdev@vger.kernel.org, rds-devel@oss.oracle.com, santosh.shilimkar@oracle.com
ci2-linux-4-19	2019/07/21 19:59	linux-4.19.y	be9b6782	1656845f	.config	log	report
ci2-linux-4-19	2019/07/02 22:32	linux-4.19.y	aec3002d	5f175e9c	.config	log	report			davem@davemloft.net, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, netdev@vger.kernel.org, rds-devel@oss.oracle.com, santosh.shilimkar@oracle.com
ci2-linux-4-19	2019/06/23 03:18	linux-4.19.y	78778071	34bf9440	.config	log	report			davem@davemloft.net, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, netdev@vger.kernel.org, rds-devel@oss.oracle.com, santosh.shilimkar@oracle.com
ci2-linux-4-19	2019/06/20 05:05	linux-4.19.y	9f31eb60	34bf9440	.config	log	report			davem@davemloft.net, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, netdev@vger.kernel.org, rds-devel@oss.oracle.com, santosh.shilimkar@oracle.com
ci2-linux-4-19	2019/06/13 23:38	linux-4.19.y	768292d0	d25bb7ad	.config	log	report			davem@davemloft.net, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, netdev@vger.kernel.org, rds-devel@oss.oracle.com, santosh.shilimkar@oracle.com