syzbot


general protection fault in tcf_ife_init

Status: fixed on 2019/12/03 19:05
Reported-by: syzbot+3f1147988fa06c660c34@syzkaller.appspotmail.com
Fix commit: 7fcc60e5f837 ife: error out when nla attributes are empty
First crash: 1298d, last: 1288d

Fix bisection: fixed by (bisect log) :
commit 7fcc60e5f837e7f626e08b486697017953e7e6a0
Author: Cong Wang <xiyou.wangcong@gmail.com>
Date: Tue Jul 23 04:43:00 2019 +0000

  ife: error out when nla attributes are empty

similar bugs (2):
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
linux-4.19 general protection fault in tcf_ife_init C done 15 1281d 1298d 1/1 fixed on 2019/12/03 19:11
upstream general protection fault in tcf_ife_init C done 72 1281d 1295d 13/24 fixed on 2019/08/27 17:15

Sample crash report:
audit: type=1400 audit(1563596013.989:36): avc:  denied  { map } for  pid=7067 comm="syz-executor718" path="/root/syz-executor718647373" dev="sda1" ino=16483 scontext=unconfined_u:system_r:insmod_t:s0-s0:c0.c1023 tcontext=unconfined_u:object_r:user_home_t:s0 tclass=file permissive=1
netlink: 4 bytes leftover after parsing attributes in process `syz-executor718'.
kasan: CONFIG_KASAN_INLINE enabled
kasan: GPF could be caused by NULL-ptr deref or user memory access
general protection fault: 0000 [#1] PREEMPT SMP KASAN
Modules linked in:
CPU: 1 PID: 7067 Comm: syz-executor718 Not tainted 4.14.133 #28
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
task: ffff888077c9c0c0 task.stack: ffff88807b7b0000
RIP: 0010:nla_parse_nested /./include/net/netlink.h:765 [inline]
RIP: 0010:tcf_ife_init+0x1b3/0x1310 /net/sched/act_ife.c:462
RSP: 0018:ffff88807b7b7230 EFLAGS: 00010246
RAX: dffffc0000000000 RBX: 0000000000000000 RCX: 1ffff1100ef93926
RDX: 0000000000000000 RSI: 0000000000000002 RDI: 0000000000000282
RBP: ffff88807b7b7378 R08: ffff888077c9c0c0 R09: 0000000000000001
R10: 0000000000000000 R11: ffff888077c9c0c0 R12: 000000000000001f
R13: ffff888215d4e940 R14: ffff88807b7b7350 R15: 0000000000000000
FS:  000000000216d880(0000) GS:ffff8880aef00000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000555ae52ea500 CR3: 0000000091f53000 CR4: 00000000001406e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 tcf_action_init_1+0x53c/0xaa0 /net/sched/act_api.c:682
 tcf_action_init+0x2ab/0x480 /net/sched/act_api.c:751
 tcf_action_add /net/sched/act_api.c:1078 [inline]
 tc_ctl_action+0x32f/0x556 /net/sched/act_api.c:1126
 rtnetlink_rcv_msg+0x3eb/0xb70 /net/core/rtnetlink.c:4285
 netlink_rcv_skb+0x14f/0x3c0 /net/netlink/af_netlink.c:2432
 rtnetlink_rcv+0x1d/0x30 /net/core/rtnetlink.c:4297
 netlink_unicast_kernel /net/netlink/af_netlink.c:1286 [inline]
 netlink_unicast+0x45d/0x780 /net/netlink/af_netlink.c:1312
 netlink_sendmsg+0x7c4/0xc60 /net/netlink/af_netlink.c:1877
 sock_sendmsg_nosec /net/socket.c:646 [inline]
 sock_sendmsg+0xce/0x110 /net/socket.c:656
 ___sys_sendmsg+0x70a/0x840 /net/socket.c:2062
 __sys_sendmsg+0xb9/0x140 /net/socket.c:2096
 SYSC_sendmsg /net/socket.c:2107 [inline]
 SyS_sendmsg+0x2d/0x50 /net/socket.c:2103
 do_syscall_64+0x1e8/0x640 /arch/x86/entry/common.c:292
 entry_SYSCALL_64_after_hwframe+0x42/0xb7
RIP: 0033:0x4401d9
RSP: 002b:00007ffccbc351a8 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 00000000004002c8 RCX: 00000000004401d9
RDX: 0000000000000000 RSI: 0000000020000180 RDI: 0000000000000003
RBP: 00000000006ca018 R08: 0000000000000000 R09: 00000000004002c8
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000401a60
R13: 0000000000401af0 R14: 0000000000000000 R15: 0000000000000000
Code: 76 fc 48 c7 c2 bb 01 e6 84 be 01 00 00 00 48 c7 c7 60 f5 78 87 e8 de 00 62 fc 48 89 da 48 b8 00 00 00 00 00 fc ff df 48 c1 ea 03 <0f> b6 14 02 48 89 d8 83 e0 07 83 c0 01 38 d0 7c 08 84 d2 0f 85 
RIP: nla_parse_nested /./include/net/netlink.h:765 [inline] RSP: ffff88807b7b7230
RIP: tcf_ife_init+0x1b3/0x1310 /net/sched/act_ife.c:462 RSP: ffff88807b7b7230
---[ end trace 13a5da1a22b58f87 ]---

Crashes (12):
Manager Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets Title
ci2-linux-4-14 2019/07/20 04:16 linux-4.14.y aea8526edf59 1656845f .config console log report syz C
ci2-linux-4-14 2019/07/20 03:59 linux-4.14.y aea8526edf59 1656845f .config console log report syz C
ci2-linux-4-14 2019/07/20 03:42 linux-4.14.y aea8526edf59 1656845f .config console log report syz C
ci2-linux-4-14 2019/07/20 03:25 linux-4.14.y aea8526edf59 1656845f .config console log report syz C
ci2-linux-4-14 2019/07/20 03:09 linux-4.14.y aea8526edf59 1656845f .config console log report syz C
ci2-linux-4-14 2019/07/20 02:53 linux-4.14.y aea8526edf59 1656845f .config console log report syz C
ci2-linux-4-14 2019/07/19 22:11 linux-4.14.y aea8526edf59 1656845f .config console log report syz C
ci2-linux-4-14 2019/07/29 15:38 linux-4.14.y ff33472c282e f67095ee .config console log report
ci2-linux-4-14 2019/07/21 00:23 linux-4.14.y aea8526edf59 1656845f .config console log report
ci2-linux-4-14 2019/07/19 23:30 linux-4.14.y aea8526edf59 1656845f .config console log report
ci2-linux-4-14 2019/07/19 23:29 linux-4.14.y aea8526edf59 1656845f .config console log report
ci2-linux-4-14 2019/07/19 21:53 linux-4.14.y aea8526edf59 1656845f .config console log report
* Struck through repros no longer work on HEAD.