syzbot


panic: spl assertion failure in yield

Status: fixed on 2020/10/21 21:05
Reported-by: syzbot+342fbc4f1750e87c72f6@syzkaller.appspotmail.com
Fix commit: - move NET_LOCK() further down in pf_ioctl.c. Also move memory allocations outside of NET_LOCK()/PF_LOCK() scope in easy spots.
First crash: 912d, last: 894d
duplicates (1):
Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
uvm_fault: db_enter 43 858d 912d 0/3 closed as dup on 2020/05/30 07:36

Sample crash report:
panic: spl assertion failure in yield
Stopped at      db_enter+0x18:  addq    $0x8,%rsp
    TID    PID    UID     PRFLAGS     PFLAGS  CPU  COMMAND
*248729  18514      0         0x2  0x4000000    0  syz-executor7465
db_enter() at db_enter+0x18 sys/arch/amd64/amd64/db_interface.c:398
panic(ffffffff82248b59) at panic+0x15c sys/kern/subr_prf.c:207
splassert_fail(0,1,ffffffff8222174a) at splassert_fail+0x102 sys/kern/subr_prf.c:237
yield() at yield+0x6f sys/kern/sched_bsd.c:304
pool_get(ffffffff82584428,d) at pool_get+0x166 sys/kern/subr_pool.c:588
pfioctl(4900,cd604404,ffff8000006bf000,3,ffff80001d7a8390) at pfioctl+0x305e sys/net/pf_ioctl.c:1216
VOP_IOCTL(fffffd805dc40270,cd604404,ffff8000006bf000,3,fffffd806c3bfd20,ffff80001d7a8390) at VOP_IOCTL+0x88 sys/kern/vfs_vops.c:290
vn_ioctl(fffffd805d8cd4b8,cd604404,ffff8000006bf000,ffff80001d7a8390) at vn_ioctl+0xb5 sys/kern/vfs_vnops.c:531
sys_ioctl(ffff80001d7a8390,ffff80001d7ca668,ffff80001d7ca6b0) at sys_ioctl+0x4a1
syscall(ffff80001d7ca730) at syscall+0x507 sys/arch/amd64/amd64/trap.c:570
Xsyscall() at Xsyscall+0x128
end of kernel
end trace frame: 0x6ab108933d0, count: 4
https://www.openbsd.org/ddb.html describes the minimum info required in bug
reports.  Insufficient info makes it difficult to find and fix bugs.
ddb> 
ddb> set $lines = 0
ddb> set $maxwidth = 0
ddb> show panic
spl assertion failure in yield
ddb> trace
db_enter() at db_enter+0x18 sys/arch/amd64/amd64/db_interface.c:398
panic(ffffffff82248b59) at panic+0x15c sys/kern/subr_prf.c:207
splassert_fail(0,1,ffffffff8222174a) at splassert_fail+0x102 sys/kern/subr_prf.c:237
yield() at yield+0x6f sys/kern/sched_bsd.c:304
pool_get(ffffffff82584428,d) at pool_get+0x166 sys/kern/subr_pool.c:588
pfioctl(4900,cd604404,ffff8000006bf000,3,ffff80001d7a8390) at pfioctl+0x305e sys/net/pf_ioctl.c:1216
VOP_IOCTL(fffffd805dc40270,cd604404,ffff8000006bf000,3,fffffd806c3bfd20,ffff80001d7a8390) at VOP_IOCTL+0x88 sys/kern/vfs_vops.c:290
vn_ioctl(fffffd805d8cd4b8,cd604404,ffff8000006bf000,ffff80001d7a8390) at vn_ioctl+0xb5 sys/kern/vfs_vnops.c:531
sys_ioctl(ffff80001d7a8390,ffff80001d7ca668,ffff80001d7ca6b0) at sys_ioctl+0x4a1
syscall(ffff80001d7ca730) at syscall+0x507 sys/arch/amd64/amd64/trap.c:570
Xsyscall() at Xsyscall+0x128
end of kernel
end trace frame: 0x6ab108933d0, count: -11
ddb> show registers
rdi                                0
rsi                              0x1
rbp               0xffff80001d7ca050
rbx               0xffff80001d7ca100
rdx                              0x2
rcx                                0
rax                              0x1
r8                0xffffffff8101c2ef    kprintf+0x15f
r9                               0x1
r10                              0x2
r11               0xd20f713237f58bcc
r12                     0x3000000008
r13               0xffff80001d7ca060
r14                            0x100
r15                              0x1
rip               0xffffffff81294578    db_enter+0x18
cs                               0x8
rflags                         0x246
rsp               0xffff80001d7ca040
ss                              0x10
db_enter+0x18:  addq    $0x8,%rsp
ddb> show proc
PROC (syz-executor7465) pid=248729 stat=onproc
    flags process=2<EXEC,8ORPHAN> proc=4000000<THREAD>
    pri=54, usrpri=54, nice=20
    forw=0xffffffffffffffff, list=0xffff80001d7a8600,0xffffffff825ec610
    process=0xffff8000ffff9210 user=0xffff80001d7c5000, vmspace=0xfffffd806bc09660
    estcpu=4, cpticks=0, pctcpu=0.0
    user=0, sys=0, intr=0
ddb> ps
   PID     TID   PPID    UID  S       FLAGS  WAIT          COMMAND
 18514  133009   7834      0  2         0x2                syz-executor7465
*18514  248729   7834      0  7   0x4000002                syz-executor7465
  7834  327965  50174      0  3    0x10008a  pause         ksh
 50174  127670  88922      0  3        0x92  select        sshd
 24463  388494      1      0  3    0x100083  ttyin         getty
 88922  200262      1      0  3        0x80  select        sshd
 47592  212659  49766     73  3    0x100090  kqread        syslogd
 49766  486763      1      0  3    0x100082  netio         syslogd
 36180  205403      1     77  3    0x100090  poll          dhclient
 23480  175064      1      0  3        0x80  poll          dhclient
 76411  120503      0      0  3     0x14200  bored         smr
 78952  132584      0      0  3     0x14200  pgzero        zerothread
 92208   97701      0      0  3     0x14200  aiodoned      aiodoned
 73149   24946      0      0  3     0x14200  syncer        update
 14046  209907      0      0  3     0x14200  cleaner       cleaner
 38172  517899      0      0  3     0x14200  reaper        reaper
 46570  323948      0      0  3     0x14200  pgdaemon      pagedaemon
 10908  169556      0      0  3     0x14200  bored         crynlk
  7262    4801      0      0  3     0x14200  bored         crypto
 26334  261102      0      0  3  0x40014200  acpi0         acpi0
 55731   24277      0      0  3     0x14200  bored         softnet
 76728   98254      0      0  3     0x14200  bored         systqmp
 88990   70580      0      0  3     0x14200  bored         systq
 54317  352746      0      0  3  0x40014200  bored         softclock
 67666  367841      0      0  3  0x40014200                idle0
     1  229656      0      0  3        0x82  wait          init
     0       0     -1      0  3     0x10200  scheduler     swapper
ddb> show all locks
No such command
ddb> show malloc
           Type InUse  MemUse  HighUse   Limit  Requests Type Lim
         devbuf  9440   6319K    6320K  78643K     10539        0
            pcb    13      8K       8K  78643K        13        0
         rtable    61      1K       2K  78643K       117        0
         ifaddr    24      7K       7K  78643K        24        0
       counters    19     16K      16K  78643K        19        0
       ioctlops     1      4K       4K  78643K        15        0
          mount     1      1K       1K  78643K         1        0
         vnodes  1182     74K      74K  78643K      1187        0
      UFS quota     1     32K      32K  78643K         1        0
      UFS mount     5     36K      36K  78643K         5        0
            shm     2      1K       1K  78643K         2        0
         VM map     2      0K       0K  78643K         2        0
            sem     2      0K       0K  78643K         2        0
        dirhash    12      2K       2K  78643K        12        0
           ACPI  1809    195K     288K  78643K     12938        0
      file desc     1      0K       0K  78643K         1        0
           proc    47     38K      46K  78643K       278        0
    NFS srvsock     1      0K       0K  78643K         1        0
     NFS daemon     1     16K      16K  78643K         1        0
       in_multi    11      0K       0K  78643K        11        0
    ether_multi     1      0K       0K  78643K         1        0
    ISOFS mount     1     32K      32K  78643K         1        0
  MSDOSFS mount     1     16K      16K  78643K         1        0
           ttys    19     95K      95K  78643K        19        0
           exec     0      0K       1K  78643K       151        0
        pagedep     1      8K       8K  78643K         1        0
       inodedep     1     32K      32K  78643K         1        0
         newblk     1      0K       0K  78643K         1        0
        VM swap     7     26K      26K  78643K         7        0
       UVM amap    56      2K       3K  78643K       690        0
       UVM aobj     2      2K       2K  78643K         2        0
        memdesc     1      4K       4K  78643K         1        0
    crypto data     1      1K       1K  78643K         1        0
            NDP     3      0K       0K  78643K         3        0
           temp    18   3025K    3089K  78643K      1425        0
         kqueue     2      2K       2K  78643K         2        0
      SYN cache     2     16K      16K  78643K         2        0
ddb> show all pools
Name      Size Requests Fail Releases Pgreq Pgrel Npage Hiwat Minpg Maxpg Idle
arp         64        2    0        0     1     0     1     1     0     8    0
rtpcb       80       15    0       13     1     0     1     1     0     8    0
rtentry    112       23    0        1     1     0     1     1     0     8    0
unpcb      120       27    0       19     1     0     1     1     0     8    0
syncache   264        5    0        5     2     2     0     1     0     8    0
tcpcb      544        8    0        5     1     0     1     1     0     8    0
inpcb      280       22    0       16     1     0     1     1     0     8    0
pfrule     1360       2    0        0     1     0     1     1     0     8    0
art_heap8  4096       1    0        0     1     0     1     1     0     8    0
art_heap4  256       96    0        0     6     0     6     6     0     8    0
art_table   32       97    0        0     1     0     1     1     0     8    0
art_node    16       22    0        2     1     0     1     1     0     8    0
dirhash    1024      17    0        0     3     0     3     3     0     8    0
dino2pl    256     1391    0       15    86     0    86    86     0     8    0
ffsino     240     1391    0       15    81     0    81    81     0     8    0
nchpl      144     1565    0       30    57     0    57    57     0     8    0
uvmvnodes   72     1400    0        0    26     0    26    26     0     8    0
vnodes     208     1400    0        0    74     0    74    74     0     8    0
namei      1024    3488    0     3488     3     2     1     1     0     8    1
scxspl     192     2816    0     2816     3     3     0     1     0     8    0
plimitpl   152       13    0        8     1     0     1     1     0     8    0
sigapl     424      191    0      166     4     0     4     4     0     8    0
futexpl     56        8    0        8     2     1     1     1     0     8    1
knotepl    112        5    0        0     1     0     1     1     0     8    0
kqueuepl   144        1    0        0     1     0     1     1     0     8    0
pipelkpl    16       57    0       53     2     1     1     1     0     8    0
pipepl     120      114    0      107     2     1     1     1     0     8    0
fdescpl    432      177    0      166     2     0     2     2     0     8    0
filepl     120      826    0      781     2     0     2     2     0     8    0
lockfpl    104        5    0        4     1     0     1     1     0     8    0
lockfspl    48        3    0        2     1     0     1     1     0     8    0
sessionpl  112       17    0        9     1     0     1     1     0     8    0
pgrppl      48       17    0        9     1     0     1     1     0     8    0
ucredpl     96       57    0       50     1     0     1     1     0     8    0
zombiepl   144      166    0      166     2     2     0     1     0     8    0
processpl  920      191    0      166     4     0     4     4     0     8    0
procpl     624      192    0      166     3     0     3     3     0     8    0
sockpl     400       64    0       48     2     0     2     2     0     8    0
mcl4k      4096      10    0       10     2     2     0     1     0     8    0
mcl2k      2048    5944    0     5912     9     4     5     8     0     8    0
mtagpl      80        2    0        2     1     1     0     1     0     8    0
mbufpl     256    10169    0    10125     5     1     4     5     0     8    0
bufpl      280     1812    0       84   124     0   124   124     0     8    0
anonpl      16    17283    0    16137     7     2     5     7     0   107    0
amapchunkpl 152     468    0      430     2     0     2     2     0   158    0
amappl16   192       68    0       64     1     0     1     1     0     8    0
amappl15   184        1    0        0     1     0     1     1     0     8    0
amappl14   176       22    0       19     1     0     1     1     0     8    0
amappl13   168       12    0       11     2     1     1     1     0     8    0
amappl12   160        6    0        6     1     1     0     1     0     8    0
amappl11   152       38    0       29     1     0     1     1     0     8    0
amappl10   144        5    0        3     1     0     1     1     0     8    0
amappl9    136      198    0      197     1     0     1     1     0     8    0
amappl8    128      202    0      200     1     0     1     1     0     8    0
amappl7    120       81    0       72     1     0     1     1     0     8    0
amappl6    112       11    0       11     2     2     0     1     0     8    0
amappl5    104      190    0      181     1     0     1     1     0     8    0
amappl4     96      399    0      376     1     0     1     1     0     8    0
amappl3     88       97    0       91     1     0     1     1     0     8    0
amappl2     80      664    0      609     3     1     2     2     0     8    0
amappl1     72    12205    0    11810    16     7     9    16     0     8    0
amappl      80      355    0      335     1     0     1     1     0    84    0
dma4096    4096       1    0        1     1     1     0     1     0     8    0
dma256     256        6    0        6     1     1     0     1     0     8    0
dma128     128      253    0      253     1     1     0     1     0     8    0
dma64       64        6    0        6     1     1     0     1     0     8    0
dma32       32        7    0        7     1     1     0     1     0     8    0
dma16       16       18    0       17     1     0     1     1     0     8    0
aobjpl      64        1    0        0     1     0     1     1     0     8    0
uaddrrnd    24      177    0      166     1     0     1     1     0     8    0
uaddrbest   32        2    0        0     1     0     1     1     0     8    0
uaddr       24      177    0      166     1     0     1     1     0     8    0
vmmpekpl   168     5285    0     5268     1     0     1     1     0     8    0
vmmpepl    168    25723    0    24933    54    19    35    48     0   357    0
vmsppl     272      176    0      166     1     0     1     1     0     8    0
pdppl      4096     360    0      332     5     0     5     5     0     8    0
pvpl        32    70572    0    67814    31     8    23    26     0   265    0
pmappl     200      176    0      166     1     0     1     1     0     8    0
extentpl    40       53    0       36     1     0     1     1     0     8    0
phpool     112      211    0       11     6     0     6     6     0     8    0
ddb> machine ddbcpu 0
No such command
ddb> trace
db_enter() at db_enter+0x18 sys/arch/amd64/amd64/db_interface.c:398
panic(ffffffff82248b59) at panic+0x15c sys/kern/subr_prf.c:207
splassert_fail(0,1,ffffffff8222174a) at splassert_fail+0x102 sys/kern/subr_prf.c:237
yield() at yield+0x6f sys/kern/sched_bsd.c:304
pool_get(ffffffff82584428,d) at pool_get+0x166 sys/kern/subr_pool.c:588
pfioctl(4900,cd604404,ffff8000006bf000,3,ffff80001d7a8390) at pfioctl+0x305e sys/net/pf_ioctl.c:1216
VOP_IOCTL(fffffd805dc40270,cd604404,ffff8000006bf000,3,fffffd806c3bfd20,ffff80001d7a8390) at VOP_IOCTL+0x88 sys/kern/vfs_vops.c:290
vn_ioctl(fffffd805d8cd4b8,cd604404,ffff8000006bf000,ffff80001d7a8390) at vn_ioctl+0xb5 sys/kern/vfs_vnops.c:531
sys_ioctl(ffff80001d7a8390,ffff80001d7ca668,ffff80001d7ca6b0) at sys_ioctl+0x4a1
syscall(ffff80001d7ca730) at syscall+0x507 sys/arch/amd64/amd64/trap.c:570
Xsyscall() at Xsyscall+0x128
end of kernel
end trace frame: 0x6ab108933d0, count: -11
ddb> machine ddbcpu 1
No such command
ddb> trace
db_enter() at db_enter+0x18 sys/arch/amd64/amd64/db_interface.c:398
panic(ffffffff82248b59) at panic+0x15c sys/kern/subr_prf.c:207
splassert_fail(0,1,ffffffff8222174a) at splassert_fail+0x102 sys/kern/subr_prf.c:237
yield() at yield+0x6f sys/kern/sched_bsd.c:304
pool_get(ffffffff82584428,d) at pool_get+0x166 sys/kern/subr_pool.c:588
pfioctl(4900,cd604404,ffff8000006bf000,3,ffff80001d7a8390) at pfioctl+0x305e sys/net/pf_ioctl.c:1216
VOP_IOCTL(fffffd805dc40270,cd604404,ffff8000006bf000,3,fffffd806c3bfd20,ffff80001d7a8390) at VOP_IOCTL+0x88 sys/kern/vfs_vops.c:290
vn_ioctl(fffffd805d8cd4b8,cd604404,ffff8000006bf000,ffff80001d7a8390) at vn_ioctl+0xb5 sys/kern/vfs_vnops.c:531
sys_ioctl(ffff80001d7a8390,ffff80001d7ca668,ffff80001d7ca6b0) at sys_ioctl+0x4a1
syscall(ffff80001d7ca730) at syscall+0x507 sys/arch/amd64/amd64/trap.c:570
Xsyscall() at Xsyscall+0x128
end of kernel
end trace frame: 0x6ab108933d0, count: -11

Crashes (12):
Manager Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Title
ci-openbsd-main 2020/05/30 11:52 openbsd d0e5c0ea53c9 954bd312 .config log report syz C
ci-openbsd-multicore 2020/06/16 07:14 openbsd f32c3515e400 baca2611 .config log report
ci-openbsd-multicore 2020/06/13 12:06 openbsd fe9bb68285b7 f4724dd3 .config log report
ci-openbsd-main 2020/06/09 11:55 openbsd 324b9c791e90 0d60b78a .config log report
ci-openbsd-multicore 2020/06/09 04:07 openbsd 324b9c791e90 0d60b78a .config log report
ci-openbsd-main 2020/06/07 03:34 openbsd dfe2a24332fd e6b89e4e .config log report
ci-openbsd-main 2020/06/06 14:42 openbsd d3d7dc897d09 e6b89e4e .config log report
ci-openbsd-main 2020/06/03 11:05 openbsd a49f5513a0e5 f3ba1b5b .config log report
ci-openbsd-multicore 2020/06/02 05:12 openbsd 0cd4ba86ab5d a0331e89 .config log report
ci-openbsd-main 2020/05/30 13:23 openbsd 2ffcc9827297 6f3e1c7c .config log report
ci-openbsd-main 2020/05/30 09:52 openbsd d0e5c0ea53c9 954bd312 .config log report
ci-openbsd-main 2020/05/29 22:01 openbsd 151ba632fd9d cdc5f8a2 .config log report
* Struck through repros no longer work on HEAD.