syzbot


KASAN: use-after-free Read in release_sock

Status: fixed on 2019/08/27 17:15
Subsystems: hams
[Documentation on labels]
Reported-by: syzbot+107429d62fb1d293602f@syzkaller.appspotmail.com
Fix commit: 4638faac0327 netrom: hold sock when setting skb->destructor
First crash: 1730d, last: 1721d
Cause bisection: introduced by (bisect log) :
commit c8c8218ec5af5d2598381883acbefbf604e56b5e
Author: Cong Wang <xiyou.wangcong@gmail.com>
Date: Thu Jun 27 21:30:58 2019 +0000

  netrom: fix a memory leak in nr_rx_frame()

Crash: WARNING: held lock freed in nr_release (log)
Repro: C syz .config
  
Discussions (1)
Title Replies (including bot) Last reply
KASAN: use-after-free Read in release_sock 0 (3) 2019/07/31 13:58

Sample crash report:
==================================================================
BUG: KASAN: use-after-free in debug_spin_lock_before kernel/locking/spinlock_debug.c:83 [inline]
BUG: KASAN: use-after-free in do_raw_spin_lock+0x28a/0x2e0 kernel/locking/spinlock_debug.c:112
Read of size 4 at addr ffff88809741928c by task syz-executor498/10959

CPU: 1 PID: 10959 Comm: syz-executor498 Not tainted 5.3.0-rc2+ #83
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x172/0x1f0 lib/dump_stack.c:113
 print_address_description.cold+0xd4/0x306 mm/kasan/report.c:351
 __kasan_report.cold+0x1b/0x36 mm/kasan/report.c:482
 kasan_report+0x12/0x17 mm/kasan/common.c:612
 __asan_report_load4_noabort+0x14/0x20 mm/kasan/generic_report.c:131
 debug_spin_lock_before kernel/locking/spinlock_debug.c:83 [inline]
 do_raw_spin_lock+0x28a/0x2e0 kernel/locking/spinlock_debug.c:112
 __raw_spin_lock_bh include/linux/spinlock_api_smp.h:136 [inline]
 _raw_spin_lock_bh+0x3b/0x50 kernel/locking/spinlock.c:175
 spin_lock_bh include/linux/spinlock.h:343 [inline]
 release_sock+0x20/0x1c0 net/core/sock.c:2932
 nr_release+0x303/0x3e0 net/netrom/af_netrom.c:553
 __sock_release+0xce/0x280 net/socket.c:590
 sock_close+0x1e/0x30 net/socket.c:1268
 __fput+0x2ff/0x890 fs/file_table.c:280
 ____fput+0x16/0x20 fs/file_table.c:313
 task_work_run+0x145/0x1c0 kernel/task_work.c:113
 exit_task_work include/linux/task_work.h:22 [inline]
 do_exit+0x92f/0x2e50 kernel/exit.c:879
 do_group_exit+0x135/0x360 kernel/exit.c:983
 get_signal+0x47c/0x2500 kernel/signal.c:2729
 do_signal+0x87/0x1700 arch/x86/kernel/signal.c:815
 exit_to_usermode_loop+0x286/0x380 arch/x86/entry/common.c:159
 prepare_exit_to_usermode arch/x86/entry/common.c:194 [inline]
 syscall_return_slowpath arch/x86/entry/common.c:274 [inline]
 do_syscall_64+0x5a9/0x6a0 arch/x86/entry/common.c:299
 entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x447d09
Code: Bad RIP value.
RSP: 002b:00007f2a183b8db8 EFLAGS: 00000246 ORIG_RAX: 00000000000000ca
RAX: fffffffffffffe00 RBX: 00000000006ddc48 RCX: 0000000000447d09
RDX: 0000000000000000 RSI: 0000000000000080 RDI: 00000000006ddc48
RBP: 00000000006ddc40 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 00000000006ddc4c
R13: 00007ffd227e7f8f R14: 00007f2a183b99c0 R15: 0000000000000000

Allocated by task 7:
 save_stack+0x23/0x90 mm/kasan/common.c:69
 set_track mm/kasan/common.c:77 [inline]
 __kasan_kmalloc mm/kasan/common.c:487 [inline]
 __kasan_kmalloc.constprop.0+0xcf/0xe0 mm/kasan/common.c:460
 kasan_kmalloc+0x9/0x10 mm/kasan/common.c:501
 __do_kmalloc mm/slab.c:3655 [inline]
 __kmalloc+0x163/0x770 mm/slab.c:3664
 kmalloc include/linux/slab.h:557 [inline]
 sk_prot_alloc+0x23a/0x310 net/core/sock.c:1603
 sk_alloc+0x39/0xf70 net/core/sock.c:1657
 nr_make_new net/netrom/af_netrom.c:476 [inline]
 nr_rx_frame+0x733/0x1e73 net/netrom/af_netrom.c:959
 nr_loopback_timer+0x7b/0x170 net/netrom/nr_loopback.c:59
 call_timer_fn+0x1ac/0x780 kernel/time/timer.c:1322
 expire_timers kernel/time/timer.c:1366 [inline]
 __run_timers kernel/time/timer.c:1685 [inline]
 __run_timers kernel/time/timer.c:1653 [inline]
 run_timer_softirq+0x697/0x17a0 kernel/time/timer.c:1698
 __do_softirq+0x262/0x98c kernel/softirq.c:292

Freed by task 10959:
 save_stack+0x23/0x90 mm/kasan/common.c:69
 set_track mm/kasan/common.c:77 [inline]
 __kasan_slab_free+0x102/0x150 mm/kasan/common.c:449
 kasan_slab_free+0xe/0x10 mm/kasan/common.c:457
 __cache_free mm/slab.c:3425 [inline]
 kfree+0x10a/0x2c0 mm/slab.c:3756
 sk_prot_free net/core/sock.c:1640 [inline]
 __sk_destruct+0x4f7/0x6e0 net/core/sock.c:1726
 sk_destruct+0x86/0xa0 net/core/sock.c:1734
 __sk_free+0xfb/0x360 net/core/sock.c:1745
 sk_free+0x42/0x50 net/core/sock.c:1756
 sock_put include/net/sock.h:1725 [inline]
 nr_destroy_socket+0x3ea/0x4a0 net/netrom/af_netrom.c:288
 nr_release+0x347/0x3e0 net/netrom/af_netrom.c:530
 __sock_release+0xce/0x280 net/socket.c:590
 sock_close+0x1e/0x30 net/socket.c:1268
 __fput+0x2ff/0x890 fs/file_table.c:280
 ____fput+0x16/0x20 fs/file_table.c:313
 task_work_run+0x145/0x1c0 kernel/task_work.c:113
 exit_task_work include/linux/task_work.h:22 [inline]
 do_exit+0x92f/0x2e50 kernel/exit.c:879
 do_group_exit+0x135/0x360 kernel/exit.c:983
 get_signal+0x47c/0x2500 kernel/signal.c:2729
 do_signal+0x87/0x1700 arch/x86/kernel/signal.c:815
 exit_to_usermode_loop+0x286/0x380 arch/x86/entry/common.c:159
 prepare_exit_to_usermode arch/x86/entry/common.c:194 [inline]
 syscall_return_slowpath arch/x86/entry/common.c:274 [inline]
 do_syscall_64+0x5a9/0x6a0 arch/x86/entry/common.c:299
 entry_SYSCALL_64_after_hwframe+0x49/0xbe

The buggy address belongs to the object at ffff888097419200
 which belongs to the cache kmalloc-2k of size 2048
The buggy address is located 140 bytes inside of
 2048-byte region [ffff888097419200, ffff888097419a00)
The buggy address belongs to the page:
page:ffffea00025d0600 refcount:1 mapcount:0 mapping:ffff8880aa400e00 index:0x0 compound_mapcount: 0
flags: 0x1fffc0000010200(slab|head)
raw: 01fffc0000010200 ffffea00022a6988 ffffea000261c588 ffff8880aa400e00
raw: 0000000000000000 ffff888097418100 0000000100000003 0000000000000000
page dumped because: kasan: bad access detected

Memory state around the buggy address:
 ffff888097419180: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
 ffff888097419200: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
>ffff888097419280: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
                      ^
 ffff888097419300: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
 ffff888097419380: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
==================================================================

Crashes (10):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2019/07/31 10:10 upstream 629f8205a6cc 7c7ded69 .config console log report syz C ci-upstream-kasan-gce-selinux-root
2019/07/31 08:37 upstream 629f8205a6cc 7c7ded69 .config console log report syz C ci-upstream-kasan-gce-smack-root
2019/07/31 06:37 upstream 629f8205a6cc 7c7ded69 .config console log report syz C ci-upstream-kasan-gce-root
2019/08/04 12:24 upstream d8778f13b73f 6affd8e8 .config console log report ci-upstream-kasan-gce-root
2019/08/03 07:37 upstream 755f1fed27f4 6affd8e8 .config console log report ci-upstream-kasan-gce-root
2019/07/31 04:49 upstream 629f8205a6cc 7c7ded69 .config console log report ci-upstream-kasan-gce-root
2019/07/30 04:10 upstream 2a11c76e5301 f67095ee .config console log report ci-upstream-kasan-gce-smack-root
2019/07/27 21:15 upstream 5168afe6ef59 c85e1c5b .config console log report ci-upstream-kasan-gce-root
2019/07/27 21:14 upstream 5168afe6ef59 c85e1c5b .config console log report ci-upstream-kasan-gce-smack-root
2019/07/25 22:49 upstream 6789f873ed37 732bc5a0 .config console log report ci-upstream-kasan-gce-root
* Struck through repros no longer work on HEAD.