syzbot


WARNING in notify_change

Status: fixed on 2019/12/01 09:13
Reported-by: syzbot+9f5c5260bdf6205c8a58@syzkaller.appspotmail.com
Fix commit: e8e448b08450 Abort file_remove_privs() for non-reg. files
First crash: 1162d, last: 1105d

Fix bisection: fixed by (bisect log) :
commit e8e448b08450b05d54cf99eb4e3473b708c8fcc0
Author: Alexander Lochmann <alexander.lochmann@tu-dortmund.de>
Date: Fri Dec 14 10:55:52 2018 +0000

  Abort file_remove_privs() for non-reg. files

similar bugs (2):
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
linux-4.14 WARNING in notify_change C done 14 1105d 1171d 1/1 fixed on 2019/11/30 21:02
upstream WARNING in notify_change C 566 1154d 1543d 13/22 fixed on 2019/07/24 12:46

Sample crash report:
WARNING: CPU: 0 PID: 8625 at fs/attr.c:234 notify_change+0xca0/0xfb0 fs/attr.c:234
Kernel panic - not syncing: panic_on_warn set ...

CPU: 0 PID: 8625 Comm: syz-executor307 Not tainted 4.19.50 #22
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x172/0x1f0 lib/dump_stack.c:113
 panic+0x263/0x507 kernel/panic.c:185
 __warn.cold+0x20/0x4a kernel/panic.c:540
 report_bug+0x263/0x2b0 lib/bug.c:186
 fixup_bug arch/x86/kernel/traps.c:178 [inline]
 fixup_bug arch/x86/kernel/traps.c:173 [inline]
 do_error_trap+0x204/0x360 arch/x86/kernel/traps.c:296
 do_invalid_op+0x1b/0x20 arch/x86/kernel/traps.c:316
 invalid_op+0x14/0x20 arch/x86/entry/entry_64.S:1013
RIP: 0010:notify_change+0xca0/0xfb0 fs/attr.c:234
Code: f6 e6 09 00 e8 91 55 b9 ff 4c 8b 7c 24 20 4c 89 ff e8 04 f7 42 01 89 de 4c 89 ff e8 ea 12 43 01 e9 35 fa ff ff e8 70 55 b9 ff <0f> 0b e9 44 f4 ff ff e8 64 55 b9 ff 44 89 f3 4c 89 ea 48 b8 00 00
RSP: 0018:ffff8880971274d0 EFLAGS: 00010293
RAX: ffff8880884e6000 RBX: 0000000000004200 RCX: ffffffff81b1a5b2
RDX: 0000000000000000 RSI: ffffffff81b1b170 RDI: 0000000000000007
RBP: ffff888097127520 R08: ffff8880884e6000 R09: ffffed10148e198e
R10: ffffed10148e198d R11: ffff8880a470cc6f R12: ffff888097127570
R13: ffff8880a470cb90 R14: 0000000000000000 R15: ffff888097127600
 __remove_privs fs/inode.c:1806 [inline]
 file_remove_privs+0x2a9/0x480 fs/inode.c:1828
 __generic_file_write_iter+0x15e/0x630 mm/filemap.c:3210
 blkdev_write_iter fs/block_dev.c:1924 [inline]
 blkdev_write_iter+0x233/0x440 fs/block_dev.c:1901
 call_write_iter include/linux/fs.h:1820 [inline]
 do_iter_readv_writev+0x558/0x830 fs/read_write.c:681
 do_iter_write fs/read_write.c:960 [inline]
 do_iter_write+0x184/0x5f0 fs/read_write.c:941
 vfs_iter_write+0x77/0xb0 fs/read_write.c:973
 iter_file_splice_write+0x661/0xbd0 fs/splice.c:750
 do_splice_from fs/splice.c:852 [inline]
 direct_splice_actor+0x123/0x190 fs/splice.c:1019
 splice_direct_to_actor+0x2e7/0x890 fs/splice.c:974
 do_splice_direct+0x1da/0x2a0 fs/splice.c:1062
 do_sendfile+0x597/0xce0 fs/read_write.c:1447
 __do_sys_sendfile64 fs/read_write.c:1508 [inline]
 __se_sys_sendfile64 fs/read_write.c:1494 [inline]
 __x64_sys_sendfile64+0x1dd/0x220 fs/read_write.c:1494
 do_syscall_64+0xfd/0x620 arch/x86/entry/common.c:293
 entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x44abe9
Code: 4d cb fb ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 1b cb fb ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007f2d5bc2bce8 EFLAGS: 00000246 ORIG_RAX: 0000000000000028
RAX: ffffffffffffffda RBX: 00000000006dcc28 RCX: 000000000044abe9
RDX: 0000000000000000 RSI: 0000000000000004 RDI: 0000000000000004
RBP: 00000000006dcc20 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000024000000 R11: 0000000000000246 R12: 00000000006dcc2c
R13: 00007fff65584ebf R14: 00007f2d5bc2c9c0 R15: 0000000000000000
Kernel Offset: disabled
Rebooting in 86400 seconds..

Crashes (12):
Manager Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Title
ci2-linux-4-19 2019/06/14 20:58 linux-4.19.y 768292d05361 442206d7 .config log report syz C
ci2-linux-4-19 2019/04/26 15:01 linux-4.19.y c98875d930e9 b617407b .config log report syz C
ci2-linux-4-19 2019/06/21 21:39 linux-4.19.y 9f31eb60d7a2 34bf9440 .config log report
ci2-linux-4-19 2019/06/21 12:11 linux-4.19.y 9f31eb60d7a2 34bf9440 .config log report
ci2-linux-4-19 2019/06/21 09:30 linux-4.19.y 9f31eb60d7a2 34bf9440 .config log report
ci2-linux-4-19 2019/06/15 19:13 linux-4.19.y 7aa823a959e1 442206d7 .config log report
ci2-linux-4-19 2019/06/14 17:52 linux-4.19.y 768292d05361 442206d7 .config log report
ci2-linux-4-19 2019/06/14 11:51 linux-4.19.y 768292d05361 998ccc76 .config log report
ci2-linux-4-19 2019/06/10 23:10 linux-4.19.y bb7b450e61a1 0159583c .config log report
ci2-linux-4-19 2019/06/10 18:27 linux-4.19.y bb7b450e61a1 0159583c .config log report
ci2-linux-4-19 2019/06/04 22:49 linux-4.19.y e109a984cf38 e41a20c5 .config log report
ci2-linux-4-19 2019/04/26 01:28 linux-4.19.y c98875d930e9 f46aabc8 .config log report