BUG: corrupted list in uvc_scan_chain

BUG: corrupted list in uvc_scan_chain_forward
Status: closed as dup on 2020/01/10 15:50
Reported-by: syzbot+636c17630dbe1250025a@syzkaller.appspotmail.com
First crash: 413d, last: 401d

Duplicate of (1):
Title	Repro	Cause bisect	Fix bisect	Count	Last	Reported
WARNING in uvc_scan_chain_forward	C			6	413d	438d

Sample crash report:

usb 1-1: New USB device strings: Mfr=1, Product=2, SerialNumber=3
usb 1-1: Product: syz
usb 1-1: Manufacturer: syz
usb 1-1: SerialNumber: syz
usb 1-1: config 0 descriptor??
uvcvideo: Found UVC 0.00 device syz (18cd:cafe)
list_add double add: new=ffff8881cdd57010, prev=ffff8881cdd57010, next=ffff8881d4dc3a18.
------------[ cut here ]------------
kernel BUG at lib/list_debug.c:29!
invalid opcode: 0000 [#1] SMP KASAN
CPU: 1 PID: 83 Comm: kworker/1:2 Not tainted 5.5.0-rc6-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Workqueue: usb_hub_wq hub_event
RIP: 0010:__list_add_valid.cold+0x26/0x3c lib/list_debug.c:29
Code: 57 ff ff ff 4c 89 e1 48 c7 c7 60 fb fb 85 e8 1b 17 40 ff 0f 0b 48 89 f2 4c 89 e1 48 89 ee 48 c7 c7 a0 fc fb 85 e8 04 17 40 ff <0f> 0b 48 89 f1 48 c7 c7 20 fc fb 85 4c 89 e6 e8 f0 16 40 ff 0f 0b
RSP: 0018:ffff8881d8b0f080 EFLAGS: 00010286
RAX: 0000000000000058 RBX: ffff8881cdd57010 RCX: 0000000000000000
RDX: 0000000000000000 RSI: ffffffff8129598d RDI: ffffed103b161e02
RBP: ffff8881cdd57010 R08: 0000000000000058 R09: fffffbfff1269cae
R10: fffffbfff1269cad R11: ffffffff8934e56f R12: ffff8881d4dc3a18
R13: ffff8881cdd57000 R14: dffffc0000000000 R15: ffff8881d4dc3a18
FS:  0000000000000000(0000) GS:ffff8881db300000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007f5b92c06000 CR3: 00000001ced22000 CR4: 00000000001406e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 __list_add include/linux/list.h:60 [inline]
 list_add_tail include/linux/list.h:93 [inline]
 uvc_scan_chain_forward.isra.0+0x4df/0x637 drivers/media/usb/uvc/uvc_driver.c:1526
 uvc_scan_chain drivers/media/usb/uvc/uvc_driver.c:1640 [inline]
 uvc_scan_device drivers/media/usb/uvc/uvc_driver.c:1824 [inline]
 uvc_probe.cold+0x1aee/0x29de drivers/media/usb/uvc/uvc_driver.c:2197
 usb_probe_interface+0x310/0x800 drivers/usb/core/driver.c:361
 really_probe+0x290/0xad0 drivers/base/dd.c:548
 driver_probe_device+0x223/0x350 drivers/base/dd.c:721
 __device_attach_driver+0x1d1/0x290 drivers/base/dd.c:828
 bus_for_each_drv+0x162/0x1e0 drivers/base/bus.c:430
 __device_attach+0x217/0x390 drivers/base/dd.c:894
 bus_probe_device+0x1e4/0x290 drivers/base/bus.c:490
 device_add+0x1459/0x1bf0 drivers/base/core.c:2487
 usb_set_configuration+0xe47/0x17d0 drivers/usb/core/message.c:2023
 generic_probe+0x9d/0xd5 drivers/usb/core/generic.c:210
 usb_probe_device+0xaf/0x140 drivers/usb/core/driver.c:266
 really_probe+0x290/0xad0 drivers/base/dd.c:548
 driver_probe_device+0x223/0x350 drivers/base/dd.c:721
 __device_attach_driver+0x1d1/0x290 drivers/base/dd.c:828
 bus_for_each_drv+0x162/0x1e0 drivers/base/bus.c:430
 __device_attach+0x217/0x390 drivers/base/dd.c:894
 bus_probe_device+0x1e4/0x290 drivers/base/bus.c:490
 device_add+0x1459/0x1bf0 drivers/base/core.c:2487
 usb_new_device.cold+0x540/0xcd0 drivers/usb/core/hub.c:2537
 hub_port_connect drivers/usb/core/hub.c:5184 [inline]
 hub_port_connect_change drivers/usb/core/hub.c:5324 [inline]
 port_event drivers/usb/core/hub.c:5470 [inline]
 hub_event+0x21cb/0x4300 drivers/usb/core/hub.c:5552
 process_one_work+0x945/0x15c0 kernel/workqueue.c:2264
 worker_thread+0x96/0xe20 kernel/workqueue.c:2410
 kthread+0x318/0x420 kernel/kthread.c:255
 ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:352
Modules linked in:

Crashes (2):
Manager	Time	Kernel	Commit	Syzkaller	Config	Log	Report	Syz repro	C repro	VM info	Title
ci2-upstream-usb	2020/01/22 20:35	https://github.com/google/kasan.git usb-fuzzer	4cc301ee	3334d684	.config	log	report	syz	C
ci2-upstream-usb	2020/01/10 15:18	https://github.com/google/kasan.git usb-fuzzer	ae179410	532ec44e	.config	log	report	syz	C