syzbot


KASAN: use-after-free Write in l2tp_session_create

Status: public: reported syz repro on 2019/04/14 08:51
Reported-by: syzbot+3fd14c17b8cace97c6b0@syzkaller.appspotmail.com
First crash: 2075d, last: 2064d

Sample crash report:
IPv6: ADDRCONF(NETDEV_UP): veth0: link is not ready
IPv6: ADDRCONF(NETDEV_CHANGE): veth0: link becomes ready
IPv6: ADDRCONF(NETDEV_CHANGE): veth0: link becomes ready
==================================================================
BUG: KASAN: use-after-free in hlist_add_head_rcu include/linux/rculist.h:397 [inline]
BUG: KASAN: use-after-free in l2tp_session_create+0xfd7/0x1030 net/l2tp/l2tp_core.c:1822
Write of size 8 at addr ffff8800b16e4b50 by task syz-executor3/10775

CPU: 0 PID: 10775 Comm: syz-executor3 Not tainted 4.4.149-gf76bdbd #18
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
 0000000000000000 008d278f30e71043 ffff8801d67d7a30 ffffffff81e1440d
 ffffea0002c5b900 ffff8800b16e4b50 0000000000000001 ffff8800b16e4b50
 ffff8801d4f39148 ffff8801d67d7a68 ffffffff81519a00 ffff8800b16e4b50
Call Trace:
 [<ffffffff81e1440d>] __dump_stack lib/dump_stack.c:15 [inline]
 [<ffffffff81e1440d>] dump_stack+0xc1/0x124 lib/dump_stack.c:51
 [<ffffffff81519a00>] print_address_description+0x6c/0x216 mm/kasan/report.c:252
 [<ffffffff81519d1f>] kasan_report_error mm/kasan/report.c:351 [inline]
 [<ffffffff81519d1f>] kasan_report.cold.7+0x175/0x2f7 mm/kasan/report.c:408
 [<ffffffff814fd617>] __asan_report_store8_noabort+0x17/0x20 mm/kasan/report.c:434
 [<ffffffff835a8ff7>] hlist_add_head_rcu include/linux/rculist.h:397 [inline]
 [<ffffffff835a8ff7>] l2tp_session_create+0xfd7/0x1030 net/l2tp/l2tp_core.c:1822
 [<ffffffff835acd60>] pppol2tp_connect+0x10f0/0x1910 net/l2tp/l2tp_ppp.c:725
 [<ffffffff82f25c58>] SYSC_connect+0x1b8/0x300 net/socket.c:1558
 [<ffffffff82f28594>] SyS_connect+0x24/0x30 net/socket.c:1539
 [<ffffffff81006d94>] do_syscall_32_irqs_on arch/x86/entry/common.c:393 [inline]
 [<ffffffff81006d94>] do_fast_syscall_32+0x324/0x8b0 arch/x86/entry/common.c:460
 [<ffffffff838cbfc3>] sysenter_flags_fixed+0xd/0x1a

Allocated by task 10775:
 [<ffffffff81034676>] save_stack_trace+0x26/0x50 arch/x86/kernel/stacktrace.c:63
 [<ffffffff814fc623>] save_stack+0x43/0xd0 mm/kasan/kasan.c:512
 [<ffffffff814fc907>] set_track mm/kasan/kasan.c:524 [inline]
 [<ffffffff814fc907>] kasan_kmalloc+0xc7/0xe0 mm/kasan/kasan.c:616
 [<ffffffff814f9044>] __kmalloc+0x124/0x310 mm/slub.c:3613
 [<ffffffff835a8059>] kmalloc include/linux/slab.h:481 [inline]
 [<ffffffff835a8059>] kzalloc include/linux/slab.h:620 [inline]
 [<ffffffff835a8059>] l2tp_session_create+0x39/0x1030 net/l2tp/l2tp_core.c:1748
 [<ffffffff835acd60>] pppol2tp_connect+0x10f0/0x1910 net/l2tp/l2tp_ppp.c:725
 [<ffffffff82f25c58>] SYSC_connect+0x1b8/0x300 net/socket.c:1558
 [<ffffffff82f28594>] SyS_connect+0x24/0x30 net/socket.c:1539
 [<ffffffff81006d94>] do_syscall_32_irqs_on arch/x86/entry/common.c:393 [inline]
 [<ffffffff81006d94>] do_fast_syscall_32+0x324/0x8b0 arch/x86/entry/common.c:460
 [<ffffffff838cbfc3>] sysenter_flags_fixed+0xd/0x1a

Freed by task 10760:
 [<ffffffff81034676>] save_stack_trace+0x26/0x50 arch/x86/kernel/stacktrace.c:63
 [<ffffffff814fc623>] save_stack+0x43/0xd0 mm/kasan/kasan.c:512
 [<ffffffff814fcf52>] set_track mm/kasan/kasan.c:524 [inline]
 [<ffffffff814fcf52>] kasan_slab_free+0x72/0xc0 mm/kasan/kasan.c:589
 [<ffffffff814fa4b4>] slab_free_hook mm/slub.c:1383 [inline]
 [<ffffffff814fa4b4>] slab_free_freelist_hook mm/slub.c:1405 [inline]
 [<ffffffff814fa4b4>] slab_free mm/slub.c:2859 [inline]
 [<ffffffff814fa4b4>] kfree+0xf4/0x310 mm/slub.c:3749
 [<ffffffff835a4fc0>] l2tp_session_free+0x170/0x200 net/l2tp/l2tp_core.c:1676
 [<ffffffff835a7379>] l2tp_session_dec_refcount_1 net/l2tp/l2tp_core.h:293 [inline]
 [<ffffffff835a7379>] l2tp_tunnel_closeall+0x2b9/0x350 net/l2tp/l2tp_core.c:1279
 [<ffffffff835a7e8b>] l2tp_udp_encap_destroy+0x8b/0xf0 net/l2tp/l2tp_core.c:1300
 [<ffffffff83499e91>] udpv6_destroy_sock+0xb1/0xd0 net/ipv6/udp.c:1421
 [<ffffffff82f36b2d>] sk_common_release+0x6d/0x300 net/core/sock.c:2680
 [<ffffffff83498b45>] udp_lib_close+0x15/0x20 include/net/udp.h:190
 [<ffffffff833004af>] inet_release+0xff/0x1d0 net/ipv4/af_inet.c:435
 [<ffffffff83423140>] inet6_release+0x50/0x70 net/ipv6/af_inet6.c:424
 [<ffffffff82f21236>] sock_release+0x96/0x1c0 net/socket.c:587
 [<ffffffff82f21376>] sock_close+0x16/0x20 net/socket.c:1038
 [<ffffffff81526de5>] __fput+0x235/0x6f0 fs/file_table.c:208
 [<ffffffff81527325>] ____fput+0x15/0x20 fs/file_table.c:244
 [<ffffffff8118e8ef>] task_work_run+0x10f/0x190 kernel/task_work.c:115
 [<ffffffff8100362d>] tracehook_notify_resume include/linux/tracehook.h:191 [inline]
 [<ffffffff8100362d>] exit_to_usermode_loop+0x13d/0x160 arch/x86/entry/common.c:253
 [<ffffffff8100708e>] prepare_exit_to_usermode arch/x86/entry/common.c:284 [inline]
 [<ffffffff8100708e>] syscall_return_slowpath arch/x86/entry/common.c:349 [inline]
 [<ffffffff8100708e>] do_syscall_32_irqs_on arch/x86/entry/common.c:399 [inline]
 [<ffffffff8100708e>] do_fast_syscall_32+0x61e/0x8b0 arch/x86/entry/common.c:460
 [<ffffffff838cbfc3>] sysenter_flags_fixed+0xd/0x1a

The buggy address belongs to the object at ffff8800b16e4a00
 which belongs to the cache kmalloc-512 of size 512
The buggy address is located 336 bytes inside of
 512-byte region [ffff8800b16e4a00, ffff8800b16e4c00)
The buggy address belongs to the page:
Initializing cgroup subsys cpuset
Initializing cgroup subsys cpu
Initializing cgroup subsys cpuacct
Initializing cgroup subsys schedtune
Linux version 4.4.149-gf76bdbd (syzkaller@ci) (gcc version 8.0.1 20180413 (experimental) (GCC) ) #18 SMP PREEMPT Fri Aug 17 20:01:31 UTC 2018
Command line: BOOT_IMAGE=/vmlinuz root=/dev/sda1 console=ttyS0 earlyprintk=serial vsyscall=native rodata=n ftrace_dump_on_oops=orig_cpu oops=panic panic_on_warn=1 nmi_watchdog=panic panic=86400 workqueue.watchdog_thresh=140 nopti
KERNEL supported cpus:
  Intel GenuineIntel
  AMD AuthenticAMD
  Centaur CentaurHauls
x86/fpu: xstate_offset[2]:  576, xstate_sizes[2]:  256
x86/fpu: Supporting XSAVE feature 0x01: 'x87 floating point registers'
x86/fpu: Supporting XSAVE feature 0x02: 'SSE registers'
x86/fpu: Supporting XSAVE feature 0x04: 'AVX registers'
x86/fpu: Enabled xstate features 0x7, context size is 832 bytes, using 'standard' format.
e820: BIOS-provided physical RAM map:
BIOS-e820: [mem 0x0000000000000000-0x000000000009fbff] usable
BIOS-e820: [mem 0x000000000009fc00-0x000000000009ffff] reserved
BIOS-e820: [mem 0x00000000000f0000-0x00000000000fffff] reserved
BIOS-e820: [mem 0x0000000000100000-0x00000000bfff2fff] usable
BIOS-e820: [mem 0x00000000bfff3000-0x00000000bfffffff] reserved
BIOS-e820: [mem 0x00000000fffbc000-0x00000000ffffffff] reserved
BIOS-e820: [mem 0x0000000100000000-0x000000021fffffff] usable
bootconsole [earlyser0] enabled
NX (Execute Disable) protection: active
SMBIOS 2.4 present.
Hypervisor detected: KVM
Kernel/User page tables isolation: disabled
e820: last_pfn = 0x220000 max_arch_pfn = 0x400000000
x86/PAT: Configuration [0-7]: WB  WC  UC- UC  WB  WC  UC- WT  
e820: last_pfn = 0xbfff3 max_arch_pfn = 0x400000000
found SMP MP-table at [mem 0x000f2300-0x000f230f] mapped at [ffff8800000f2300]
Scanning 1 areas for low memory corruption
Using GB pages for direct mapping
ACPI: Early table checksum verification disabled
ACPI: RSDP 0x00000000000F22C0 000014 (v00 Google)
ACPI: RSDT 0x00000000BFFF3430 000038 (v01 Google GOOGRSDT 00000001 GOOG 00000001)
ACPI: FACP 0x00000000BFFFCF60 0000F4 (v02 Google GOOGFACP 00000001 GOOG 00000001)
ACPI: DSDT 0x00000000BFFF3470 0017B2 (v01 Google GOOGDSDT 00000001 GOOG 00000001)
ACPI: FACS 0x00000000BFFFCF00 000040
ACPI: FACS 0x00000000BFFFCF00 000040
ACPI: SSDT 0x00000000BFFF65F0 00690D (v01 Google GOOGSSDT 00000001 GOOG 00000001)
ACPI: APIC 0x00000000BFFF5D10 000076 (v01 Google GOOGAPIC 00000001 GOOG 00000001)
ACPI: WAET 0x00000000BFFF5CE0 000028 (v01 Google GOOGWAET 00000001 GOOG 00000001)
ACPI: SRAT 0x00000000BFFF4C30 0000C8 (v01 Google GOOGSRAT 00000001 GOOG 00000001)
kvm-clock: Using msrs 4b564d01 and 4b564d00
kvm-clock: cpu 0, msr 2:1fffd001, primary cpu clock
kvm-clock: using sched offset of 2524312751 cycles
clocksource: kvm-clock: mask: 0xffffffffffffffff max_cycles: 0x1cd42e4dffb, max_idle_ns: 881590591483 ns
Zone ranges:
  DMA      [mem 0x0000000000001000-0x0000000000ffffff]
  DMA32    [mem 0x0000000001000000-0x00000000ffffffff]
  Normal   [mem 0x0000000100000000-0x000000021fffffff]
Movable zone start for each node
Early memory node ranges
  node   0: [mem 0x0000000000001000-0x000000000009efff]
  node   0: [mem 0x0000000000100000-0x00000000bfff2fff]
  node   0: [mem 0x0000000100000000-0x000000021fffffff]
Initmem setup node 0 [mem 0x0000000000001000-0x000000021fffffff]
kasan: KernelAddressSanitizer initialized
ACPI: PM-Timer IO Port: 0xb008
ACPI: LAPIC_NMI (acpi_id[0xff] dfl dfl lint[0x1])
IOAPIC[0]: apic_id 0, version 17, address 0xfec00000, GSI 0-23
ACPI: INT_SRC_OVR (bus 0 bus_irq 5 global_irq 5 high level)
ACPI: INT_SRC_OVR (bus 0 bus_irq 9 global_irq 9 high level)
ACPI: INT_SRC_OVR (bus 0 bus_irq 10 global_irq 10 high level)
ACPI: INT_SRC_OVR (bus 0 bus_irq 11 global_irq 11 high level)
Using ACPI (MADT) for SMP configuration information
smpboot: Allowing 2 CPUs, 0 hotplug CPUs
PM: Registered nosave memory: [mem 0x00000000-0x00000fff]
PM: Registered nosave memory: [mem 0x0009f000-0x0009ffff]
PM: Registered nosave memory: [mem 0x000a0000-0x000effff]
PM: Registered nosave memory: [mem 0x000f0000-0x000fffff]
PM: Registered nosave memory: [mem 0xbfff3000-0xbfffffff]
PM: Registered nosave memory: [mem 0xc0000000-0xfffbbfff]
PM: Registered nosave memory: [mem 0xfffbc000-0xffffffff]
e820: [mem 0xc0000000-0xfffbbfff] available for PCI devices
Booting paravirtualized kernel on KVM
clocksource: refined-jiffies: mask: 0xffffffff max_cycles: 0xffffffff, max_idle_ns: 19112604462750000 ns
setup_percpu: NR_CPUS:64 nr_cpumask_bits:64 nr_cpu_ids:2 nr_node_ids:1
PERCPU: Embedded 42 pages/cpu @ffff8801db200000 s134152 r8192 d29688 u1048576
Built 1 zonelists in Zone order, mobility grouping on.  Total pages: 1935227
Kernel command line: BOOT_IMAGE=/vmlinuz root=/dev/sda1 console=ttyS0 earlyprintk=serial vsyscall=native rodata=n ftrace_dump_on_oops=orig_cpu oops=panic panic_on_warn=1 nmi_watchdog=panic panic=86400 workqueue.watchdog_thresh=140 nopti
PID hash table entries: 4096 (order: 3, 32768 bytes)
Dentry cache hash table entries: 1048576 (order: 11, 8388608 bytes)
Inode-cache hash table entries: 524288 (order: 10, 4194304 bytes)
Memory: 6579080K/7863876K available (41793K kernel code, 6308K rwdata, 9068K rodata, 1868K init, 23696K bss, 1284796K reserved, 0K cma-reserved)
SLUB: HWalign=64, Order=0-3, MinObjects=0, CPUs=2, Nodes=1
Running RCU self tests
Preemptible hierarchical RCU implementation.
	RCU lockdep checking is enabled.
	Build-time adjustment of leaf fanout to 64.
	RCU restricting CPUs from NR_CPUS=64 to nr_cpu_ids=2.
RCU: Adjusting geometry for rcu_fanout_leaf=64, nr_cpu_ids=2
NR_IRQS:4352 nr_irqs:440 16
console [ttyS0] enabled
console [ttyS0] enabled
bootconsole [earlyser0] disabled
bootconsole [earlyser0] disabled
Lock dependency validator: Copyright (c) 2006 Red Hat, Inc., Ingo Molnar
... MAX_LOCKDEP_SUBCLASSES:  8
... MAX_LOCK_DEPTH:          48
... MAX_LOCKDEP_KEYS:        8191
... CLASSHASH_SIZE:          4096
... MAX_LOCKDEP_ENTRIES:     32768
... MAX_LOCKDEP_CHAINS:      65536
... CHAINHASH_SIZE:          32768
 memory used by lock dependency info: 8159 kB
 per task-struct memory footprint: 1920 bytes
tsc: Detected 2300.000 MHz processor
Calibrating delay loop (skipped) preset value.. 4600.00 BogoMIPS (lpj=23000000)
pid_max: default: 32768 minimum: 301
ACPI: Core revision 20150930
ACPI: 2 ACPI AML tables successfully acquired and loaded
Security Framework initialized
SELinux:  Initializing.
AppArmor: AppArmor disabled by boot time parameter
Mount-cache hash table entries: 16384 (order: 5, 131072 bytes)
Mountpoint-cache hash table entries: 16384 (order: 5, 131072 bytes)
Initializing cgroup subsys io
Initializing cgroup subsys freezer
Initializing cgroup subsys hugetlb
Initializing cgroup subsys debug
CPU: Physical Processor ID: 0
mce: CPU supports 32 MCE banks
Last level iTLB entries: 4KB 1024, 2MB 1024, 4MB 1024
Last level dTLB entries: 4KB 1024, 2MB 1024, 4MB 1024, 1GB 4
Spectre V2 : Mitigation: Full generic retpoline
Spectre V2 : Spectre v2 / SpectreRSB mitigation: Filling RSB on context switch
Speculative Store Bypass: Vulnerable
Freeing SMP alternatives memory: 48K
..TIMER: vector=0x30 apic1=0 pin1=0 apic2=-1 pin2=-1
smpboot: CPU0: Intel(R) Xeon(R) CPU @ 2.30GHz (family: 0x6, model: 0x3f, stepping: 0x0)
Performance Events: unsupported p6 CPU model 63 no PMU driver, software events only.
x86: Booting SMP configuration:
.... node  #0, CPUs:      #1
kvm-clock: cpu 1, msr 2:1fffd041, secondary cpu clock
x86: Booted up 1 node, 2 CPUs
smpboot: Total of 2 processors activated (9200.00 BogoMIPS)
devtmpfs: initialized
clocksource: jiffies: mask: 0xffffffff max_cycles: 0xffffffff, max_idle_ns: 19112604462750000 ns
futex hash table entries: 512 (order: 4, 65536 bytes)
xor: automatically using best checksumming function:
kworker/u4:0 (21) used greatest stack depth: 27920 bytes left
   avx       : 24892.000 MB/sec
RTC time:  7:40:00, date: 08/18/18
NET: Registered protocol family 16
schedtune: init normalization constants...
schedtune: no energy model data
schedtune: disabled!
kworker/u4:0 (27) used greatest stack depth: 27520 bytes left
cpuidle: using governor ladder
cpuidle: using governor menu
ACPI: bus type PCI registered
acpiphp: ACPI Hot Plug PCI Controller Driver version: 0.5
PCI: Using configuration type 1 for base access
kworker/u4:0 (45) used greatest stack depth: 27424 bytes left
raid6: sse2x1   gen()  4599 MB/s
raid6: sse2x1   xor()  2200 MB/s
raid6: sse2x2   gen()  7255 MB/s
raid6: sse2x2   xor()  4185 MB/s
raid6: sse2x4   gen()  9499 MB/s
raid6: sse2x4   xor()  5573 MB/s
raid6: avx2x1   gen()  9667 MB/s
raid6: avx2x2   gen() 13735 MB/s
raid6: avx2x4   gen() 18508 MB/s
raid6: using algorithm avx2x4 gen() 18508 MB/s
raid6: using avx2x2 recovery algorithm
ACPI: Added _OSI(Module Device)
ACPI: Added _OSI(Processor Device)
ACPI: Added _OSI(3.0 _SCP Extensions)
ACPI: Added _OSI(Processor Aggregator Device)
ACPI: Executed 2 blocks of module-level executable AML code
ACPI: Interpreter enabled
ACPI: (supports S0 S3 S4 S5)
ACPI: Using IOAPIC for interrupt routing
PCI: Using host bridge windows from ACPI; if necessary, use "pci=nocrs" and report a bug
ACPI: PCI Root Bridge [PCI0] (domain 0000 [bus 00-ff])
acpi PNP0A03:00: _OSC: OS supports [ASPM ClockPM Segments MSI]
acpi PNP0A03:00: _OSC failed (AE_NOT_FOUND); disabling ASPM
acpi PNP0A03:00: fail to add MMCONFIG information, can't access extended PCI configuration space under this bridge.
PCI host bridge to bus 0000:00
pci_bus 0000:00: root bus resource [io  0x0000-0x0cf7 window]
pci_bus 0000:00: root bus resource [io  0x0d00-0xffff window]
pci_bus 0000:00: root bus resource [mem 0x000a0000-0x000bffff window]
pci_bus 0000:00: root bus resource [mem 0xc0000000-0xfebfffff window]
pci_bus 0000:00: root bus resource [bus 00-ff]
pci 0000:00:01.3: quirk: [io  0xb000-0xb03f] claimed by PIIX4 ACPI
ACPI: PCI Interrupt Link [LNKA] (IRQs 5 *10 11)
ACPI: PCI Interrupt Link [LNKB] (IRQs 5 *10 11)
ACPI: PCI Interrupt Link [LNKC] (IRQs 5 10 *11)
ACPI: PCI Interrupt Link [LNKD] (IRQs 5 10 *11)
ACPI: PCI Interrupt Link [LNKS] (IRQs *9)

Crashes (2):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2018/08/18 08:43 https://android.googlesource.com/kernel/common android-4.4 f76bdbdd516d db1858f6 .config console log report syz ci-android-44-kasan-gce-386
2018/08/29 08:23 https://android.googlesource.com/kernel/common android-4.4 5e24b4e4d372 53ff8784 .config console log report ci-android-44-kasan-gce
* Struck through repros no longer work on HEAD.