syzbot


KASAN: use-after-free Read in ath9k_htc_txcompletion_cb

Status: closed as dup on 2020/06/12 13:08
Reported-by: syzbot+809d3bdcdb4650cdbc83@syzkaller.appspotmail.com
First crash: 1024d, last: 961d
Duplicate of (1):
Title Repro Cause bisect Fix bisect Count Last Reported
KASAN: use-after-free Read in hif_usb_regout_cb C 1383 961d 1039d

Sample crash report:
==================================================================
BUG: KASAN: use-after-free in ath9k_htc_txcompletion_cb+0x285/0x2b0 drivers/net/wireless/ath/ath9k/htc_hst.c:341
Read of size 8 at addr ffff8881c384b0c8 by task kworker/0:6/3195

CPU: 0 PID: 3195 Comm: kworker/0:6 Not tainted 5.7.0-rc6-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Workqueue: events request_firmware_work_func
Call Trace:
 <IRQ>
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0xef/0x16e lib/dump_stack.c:118
 print_address_description.constprop.0.cold+0xd3/0x415 mm/kasan/report.c:382
 __kasan_report.cold+0x37/0x7d mm/kasan/report.c:511
 kasan_report+0x33/0x50 mm/kasan/common.c:625
 ath9k_htc_txcompletion_cb+0x285/0x2b0 drivers/net/wireless/ath/ath9k/htc_hst.c:341
 hif_usb_regout_cb+0x115/0x1c0 drivers/net/wireless/ath/ath9k/hif_usb.c:90
 __usb_hcd_giveback_urb+0x29a/0x550 drivers/usb/core/hcd.c:1650
 usb_hcd_giveback_urb+0x368/0x420 drivers/usb/core/hcd.c:1716
 dummy_timer+0x125e/0x32b4 drivers/usb/gadget/udc/dummy_hcd.c:1967
 call_timer_fn+0x1ac/0x700 kernel/time/timer.c:1405
 expire_timers kernel/time/timer.c:1450 [inline]
 __run_timers kernel/time/timer.c:1774 [inline]
 __run_timers kernel/time/timer.c:1741 [inline]
 run_timer_softirq+0x5f9/0x1500 kernel/time/timer.c:1787
 __do_softirq+0x21e/0x9aa kernel/softirq.c:292
 invoke_softirq kernel/softirq.c:373 [inline]
 irq_exit+0x178/0x1a0 kernel/softirq.c:413
 exiting_irq arch/x86/include/asm/apic.h:546 [inline]
 smp_apic_timer_interrupt+0x141/0x540 arch/x86/kernel/apic/apic.c:1140
 apic_timer_interrupt+0xf/0x20 arch/x86/entry/entry_64.S:829
 </IRQ>
RIP: 0010:arch_local_irq_restore arch/x86/include/asm/irqflags.h:85 [inline]
RIP: 0010:console_trylock_spinning kernel/printk/printk.c:1779 [inline]
RIP: 0010:vprintk_emit+0x3d0/0x3e0 kernel/printk/printk.c:2020
Code: 00 83 fb ff 75 d6 e9 d8 fc ff ff e8 7a 2f 16 00 e8 55 8c 1b 00 41 56 9d e9 aa fd ff ff e8 68 2f 16 00 e8 43 8c 1b 00 41 56 9d <e9> 2a ff ff ff 90 66 2e 0f 1f 84 00 00 00 00 00 55 48 89 f5 53 48
RSP: 0018:ffff8881c8077ab8 EFLAGS: 00000293 ORIG_RAX: ffffffffffffff13
RAX: 0000000000000007 RBX: 0000000000000200 RCX: 1ffffffff1270ae0
RDX: 0000000000000000 RSI: 0000000000000000 RDI: ffff8881cbcb887c
RBP: ffff8881c8077b00 R08: 0000000000000001 R09: fffffbfff126c8c8
R10: ffffffff8936463f R11: fffffbfff126c8c7 R12: 000000000000002a
R13: ffff8881d8d6ca40 R14: 0000000000000293 R15: 0000000000000000
 vprintk_func+0x75/0x113 kernel/printk/printk_safe.c:385
 printk+0xba/0xed kernel/printk/printk.c:2081
 ath9k_htc_hw_init.cold+0x17/0x2a drivers/net/wireless/ath/ath9k/htc_hst.c:502
 ath9k_hif_usb_firmware_cb+0x274/0x510 drivers/net/wireless/ath/ath9k/hif_usb.c:1187
 request_firmware_work_func+0x126/0x242 drivers/base/firmware_loader/main.c:1005
 process_one_work+0x965/0x1630 kernel/workqueue.c:2268
 worker_thread+0x96/0xe20 kernel/workqueue.c:2414
 kthread+0x326/0x430 kernel/kthread.c:268
 ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:351

Allocated by task 3195:
 save_stack+0x1b/0x40 mm/kasan/common.c:49
 set_track mm/kasan/common.c:57 [inline]
 __kasan_kmalloc mm/kasan/common.c:495 [inline]
 __kasan_kmalloc.constprop.0+0xbf/0xd0 mm/kasan/common.c:468
 slab_post_alloc_hook mm/slab.h:586 [inline]
 slab_alloc_node mm/slub.c:2797 [inline]
 kmem_cache_alloc_node+0xdc/0x330 mm/slub.c:2833
 __alloc_skb+0xba/0x5a0 net/core/skbuff.c:198
 alloc_skb include/linux/skbuff.h:1083 [inline]
 htc_connect_service+0x2cc/0x840 drivers/net/wireless/ath/ath9k/htc_hst.c:257
 ath9k_wmi_connect+0xd2/0x1a0 drivers/net/wireless/ath/ath9k/wmi.c:265
 ath9k_init_htc_services.constprop.0+0xb4/0x650 drivers/net/wireless/ath/ath9k/htc_drv_init.c:146
 ath9k_htc_probe_device+0x25a/0x1da0 drivers/net/wireless/ath/ath9k/htc_drv_init.c:959
 ath9k_htc_hw_init+0x31/0x60 drivers/net/wireless/ath/ath9k/htc_hst.c:501
 ath9k_hif_usb_firmware_cb+0x274/0x510 drivers/net/wireless/ath/ath9k/hif_usb.c:1187
 request_firmware_work_func+0x126/0x242 drivers/base/firmware_loader/main.c:1005
 process_one_work+0x965/0x1630 kernel/workqueue.c:2268
 worker_thread+0x96/0xe20 kernel/workqueue.c:2414
 kthread+0x326/0x430 kernel/kthread.c:268
 ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:351

Freed by task 3195:
 save_stack+0x1b/0x40 mm/kasan/common.c:49
 set_track mm/kasan/common.c:57 [inline]
 kasan_set_free_info mm/kasan/common.c:317 [inline]
 __kasan_slab_free+0x117/0x160 mm/kasan/common.c:456
 slab_free_hook mm/slub.c:1455 [inline]
 slab_free_freelist_hook mm/slub.c:1488 [inline]
 slab_free mm/slub.c:3045 [inline]
 kmem_cache_free+0x9b/0x360 mm/slub.c:3061
 kfree_skbmem net/core/skbuff.c:622 [inline]
 kfree_skbmem+0xef/0x1b0 net/core/skbuff.c:616
 __kfree_skb net/core/skbuff.c:679 [inline]
 kfree_skb net/core/skbuff.c:696 [inline]
 kfree_skb+0x102/0x3d0 net/core/skbuff.c:690
 htc_connect_service.cold+0xa9/0x109 drivers/net/wireless/ath/ath9k/htc_hst.c:282
 ath9k_wmi_connect+0xd2/0x1a0 drivers/net/wireless/ath/ath9k/wmi.c:265
 ath9k_init_htc_services.constprop.0+0xb4/0x650 drivers/net/wireless/ath/ath9k/htc_drv_init.c:146
 ath9k_htc_probe_device+0x25a/0x1da0 drivers/net/wireless/ath/ath9k/htc_drv_init.c:959
 ath9k_htc_hw_init+0x31/0x60 drivers/net/wireless/ath/ath9k/htc_hst.c:501
 ath9k_hif_usb_firmware_cb+0x274/0x510 drivers/net/wireless/ath/ath9k/hif_usb.c:1187
 request_firmware_work_func+0x126/0x242 drivers/base/firmware_loader/main.c:1005
 process_one_work+0x965/0x1630 kernel/workqueue.c:2268
 worker_thread+0x96/0xe20 kernel/workqueue.c:2414
 kthread+0x326/0x430 kernel/kthread.c:268
 ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:351

The buggy address belongs to the object at ffff8881c384b000
 which belongs to the cache skbuff_head_cache of size 224
The buggy address is located 200 bytes inside of
 224-byte region [ffff8881c384b000, ffff8881c384b0e0)
The buggy address belongs to the page:
page:ffffea00070e12c0 refcount:1 mapcount:0 mapping:000000006b523c23 index:0x0
flags: 0x200000000000200(slab)
raw: 0200000000000200 ffffea000740b340 0000000400000004 ffff8881da175400
raw: 0000000000000000 00000000000c000c 00000001ffffffff 0000000000000000
page dumped because: kasan: bad access detected

Memory state around the buggy address:
 ffff8881c384af80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
 ffff8881c384b000: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
>ffff8881c384b080: fb fb fb fb fb fb fb fb fb fb fb fb fc fc fc fc
                                              ^
 ffff8881c384b100: fc fc fc fc fc fc fc fc fb fb fb fb fb fb fb fb
 ffff8881c384b180: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
==================================================================

Crashes (8):
Manager Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets Title
ci2-upstream-usb 2020/06/12 12:51 https://github.com/google/kasan.git usb-fuzzer 2089c6ed5a17 819b58b0 .config console log report
ci2-upstream-usb 2020/06/12 00:23 https://github.com/google/kasan.git usb-fuzzer 2089c6ed5a17 1beaee21 .config console log report
ci2-upstream-usb 2020/05/27 09:49 https://github.com/google/kasan.git usb-fuzzer d19c64b3d097 9072c126 .config console log report
ci2-upstream-usb 2020/05/22 06:21 https://github.com/google/kasan.git usb-fuzzer 806d8acc2890 4afdfa20 .config console log report
ci2-upstream-usb 2020/05/19 10:25 https://github.com/google/kasan.git usb-fuzzer 806d8acc2890 684d3606 .config console log report
ci2-upstream-usb 2020/05/01 13:36 https://github.com/google/kasan.git usb-fuzzer 059e7e0ff26c 143a10e9 .config console log report
ci2-upstream-usb 2020/04/21 14:06 https://github.com/google/kasan.git usb-fuzzer 0fa84af850a4 f20434a8 .config console log report
ci2-upstream-usb 2020/04/11 02:57 https://github.com/google/kasan.git usb-fuzzer 0fa84af850a4 a8c6a3f8 .config console log report
* Struck through repros no longer work on HEAD.