8021q: adding VLAN 0 to HW filter on device team0 ============================================ WARNING: possible recursive locking detected 4.19.0-rc2+ #94 Not tainted -------------------------------------------- syz-executor4/11080 is trying to acquire lock: 00000000b0fdaf95 (&team->lock){+.+.}, at: team_vlan_rx_add_vid+0x3b/0x1e0 drivers/net/team/team.c:1864 but task is already holding lock: 00000000b0fdaf95 (&team->lock){+.+.}, at: team_add_slave+0xdb/0x1c10 drivers/net/team/team.c:1943 other info that might help us debug this: Possible unsafe locking scenario: CPU0 ---- lock(&team->lock); lock(&team->lock); *** DEADLOCK *** May be due to missing lock nesting notation 2 locks held by syz-executor4/11080: #0: 00000000128ccd66 (rtnl_mutex){+.+.}, at: rtnl_lock net/core/rtnetlink.c:77 [inline] #0: 00000000128ccd66 (rtnl_mutex){+.+.}, at: rtnetlink_rcv_msg+0x40e/0xc20 net/core/rtnetlink.c:4712 kobject: 'loop2' (00000000e56652d2): kobject_uevent_env #1: 00000000b0fdaf95 (&team->lock){+.+.}, at: team_add_slave+0xdb/0x1c10 drivers/net/team/team.c:1943 stack backtrace: CPU: 0 PID: 11080 Comm: syz-executor4 Not tainted 4.19.0-rc2+ #94 kobject: 'loop2' (00000000e56652d2): fill_kobj_path: path = '/devices/virtual/block/loop2' Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Call Trace: __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0x1c4/0x2b4 lib/dump_stack.c:113 print_deadlock_bug kernel/locking/lockdep.c:1760 [inline] check_deadlock kernel/locking/lockdep.c:1804 [inline] validate_chain kernel/locking/lockdep.c:2400 [inline] __lock_acquire.cold.61+0x1fb/0x482 kernel/locking/lockdep.c:3412 lock_acquire+0x1ed/0x520 kernel/locking/lockdep.c:3901 __mutex_lock_common kernel/locking/mutex.c:925 [inline] __mutex_lock+0x166/0x1710 kernel/locking/mutex.c:1073 mutex_lock_nested+0x16/0x20 kernel/locking/mutex.c:1088 team_vlan_rx_add_vid+0x3b/0x1e0 drivers/net/team/team.c:1864 vlan_add_rx_filter_info+0x14a/0x1d0 net/8021q/vlan_core.c:210 __vlan_vid_add net/8021q/vlan_core.c:278 [inline] vlan_vid_add+0x63e/0x9d0 net/8021q/vlan_core.c:308 vlan_device_event.cold.12+0x2a/0x2f net/8021q/vlan.c:381 notifier_call_chain+0x17e/0x380 kernel/notifier.c:93 __raw_notifier_call_chain kernel/notifier.c:394 [inline] raw_notifier_call_chain+0x2d/0x40 kernel/notifier.c:401 call_netdevice_notifiers_info+0x3f/0x90 net/core/dev.c:1733 call_netdevice_notifiers net/core/dev.c:1751 [inline] dev_open+0x173/0x1b0 net/core/dev.c:1431 team_port_add drivers/net/team/team.c:1214 [inline] team_add_slave+0xaf8/0x1c10 drivers/net/team/team.c:1944 do_set_master+0x1c9/0x220 net/core/rtnetlink.c:2298 do_setlink+0xbe6/0x3f20 net/core/rtnetlink.c:2432 rtnl_setlink+0x2a2/0x3f0 net/core/rtnetlink.c:2686 rtnetlink_rcv_msg+0x46a/0xc20 net/core/rtnetlink.c:4715 netlink_rcv_skb+0x172/0x440 net/netlink/af_netlink.c:2454 rtnetlink_rcv+0x1c/0x20 net/core/rtnetlink.c:4733 netlink_unicast_kernel net/netlink/af_netlink.c:1317 [inline] netlink_unicast+0x5a5/0x760 net/netlink/af_netlink.c:1343 netlink_sendmsg+0xa18/0xfc0 net/netlink/af_netlink.c:1908 sock_sendmsg_nosec net/socket.c:621 [inline] sock_sendmsg+0xd5/0x120 net/socket.c:631 ___sys_sendmsg+0x7fd/0x930 net/socket.c:2114 __sys_sendmsg+0x11d/0x280 net/socket.c:2152 kobject: 'loop3' (00000000ae23b89c): kobject_uevent_env __do_sys_sendmsg net/socket.c:2161 [inline] __se_sys_sendmsg net/socket.c:2159 [inline] __x64_sys_sendmsg+0x78/0xb0 net/socket.c:2159 do_syscall_64+0x1b9/0x820 arch/x86/entry/common.c:290 kobject: 'loop3' (00000000ae23b89c): fill_kobj_path: path = '/devices/virtual/block/loop3' entry_SYSCALL_64_after_hwframe+0x49/0xbe RIP: 0033:0x4572d9 Code: fd b4 fb ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 cb b4 fb ff c3 66 2e 0f 1f 84 00 00 00 00 RSP: 002b:00007fe607fb6c78 EFLAGS: 00000246 ORIG_RAX: 000000000000002e RAX: ffffffffffffffda RBX: 00007fe607fb76d4 RCX: 00000000004572d9 RDX: 0000000000000000 RSI: 0000000020000240 RDI: 0000000000000005 RBP: 00000000009300a0 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 00000000ffffffff R13: 00000000004d4eb0 R14: 00000000004c93f1 R15: 0000000000000000