====================================================== WARNING: possible circular locking dependency detected 6.16.0-rc3-syzkaller-00044-g7595b66ae9de #0 Not tainted ------------------------------------------------------ syz.4.566/11692 is trying to acquire lock: ffff888063f2e618 (sb_internal#6){.+.+}-{0:0}, at: ocfs2_acquire_dquot+0x455/0xb30 fs/ocfs2/quota_global.c:860 but task is already holding lock: ffff88805b1c5be0 (&ocfs2_quota_ip_alloc_sem_key){++++}-{4:4}, at: ocfs2_lock_global_qf+0x1e8/0x270 fs/ocfs2/quota_global.c:314 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #6 (&ocfs2_quota_ip_alloc_sem_key){++++}-{4:4}: lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5871 down_write+0x96/0x1f0 kernel/locking/rwsem.c:1577 ocfs2_lock_global_qf+0x1e8/0x270 fs/ocfs2/quota_global.c:314 ocfs2_acquire_dquot+0x2b0/0xb30 fs/ocfs2/quota_global.c:828 dqget+0x7ae/0xf10 fs/quota/dquot.c:977 __dquot_initialize+0x3b3/0xcb0 fs/quota/dquot.c:1505 ocfs2_get_init_inode+0x13b/0x1b0 fs/ocfs2/namei.c:202 ocfs2_mknod+0x863/0x2050 fs/ocfs2/namei.c:310 vfs_mknod+0x37c/0x3c0 fs/namei.c:4244 do_mknodat+0x385/0x4d0 fs/namei.c:-1 __do_sys_mknodat fs/namei.c:4322 [inline] __se_sys_mknodat fs/namei.c:4319 [inline] __x64_sys_mknodat+0xa7/0xc0 fs/namei.c:4319 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #5 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{4:4}: lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5871 down_write+0x96/0x1f0 kernel/locking/rwsem.c:1577 inode_lock include/linux/fs.h:869 [inline] ocfs2_lock_global_qf+0x1ca/0x270 fs/ocfs2/quota_global.c:313 ocfs2_acquire_dquot+0x2b0/0xb30 fs/ocfs2/quota_global.c:828 dqget+0x7ae/0xf10 fs/quota/dquot.c:977 __dquot_initialize+0x3b3/0xcb0 fs/quota/dquot.c:1505 ocfs2_get_init_inode+0x13b/0x1b0 fs/ocfs2/namei.c:202 ocfs2_mknod+0x863/0x2050 fs/ocfs2/namei.c:310 vfs_mknod+0x37c/0x3c0 fs/namei.c:4244 do_mknodat+0x385/0x4d0 fs/namei.c:-1 __do_sys_mknodat fs/namei.c:4322 [inline] __se_sys_mknodat fs/namei.c:4319 [inline] __x64_sys_mknodat+0xa7/0xc0 fs/namei.c:4319 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #4 (&dquot->dq_lock){+.+.}-{4:4}: lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5871 __mutex_lock_common kernel/locking/mutex.c:602 [inline] __mutex_lock+0x182/0xe80 kernel/locking/mutex.c:747 wait_on_dquot fs/quota/dquot.c:354 [inline] dqget+0x72a/0xf10 fs/quota/dquot.c:972 dquot_transfer+0x2f8/0x6d0 fs/quota/dquot.c:2140 ext4_setattr+0x865/0x1bc0 fs/ext4/inode.c:5817 notify_change+0xb33/0xe40 fs/attr.c:552 chown_common+0x40c/0x5c0 fs/open.c:790 vfs_fchown fs/open.c:858 [inline] ksys_fchown+0xea/0x160 fs/open.c:870 __do_sys_fchown fs/open.c:875 [inline] __se_sys_fchown fs/open.c:873 [inline] __x64_sys_fchown+0x7a/0x90 fs/open.c:873 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #3 (&ei->xattr_sem){++++}-{4:4}: lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5871 down_write+0x96/0x1f0 kernel/locking/rwsem.c:1577 ext4_write_lock_xattr fs/ext4/xattr.h:157 [inline] ext4_xattr_set_handle+0x165/0x1590 fs/ext4/xattr.c:2362 ext4_initxattrs+0x9f/0x110 fs/ext4/xattr_security.c:44 security_inode_init_security+0x2a0/0x3f0 security/security.c:1852 __ext4_new_inode+0x3257/0x3c50 fs/ext4/ialloc.c:1325 ext4_create+0x22d/0x460 fs/ext4/namei.c:2822 lookup_open fs/namei.c:3717 [inline] open_last_lookups fs/namei.c:3816 [inline] path_openat+0x14f4/0x3830 fs/namei.c:4052 do_filp_open+0x1fa/0x410 fs/namei.c:4082 do_sys_openat2+0x121/0x1c0 fs/open.c:1437 do_sys_open fs/open.c:1452 [inline] __do_sys_openat fs/open.c:1468 [inline] __se_sys_openat fs/open.c:1463 [inline] __x64_sys_openat+0x138/0x170 fs/open.c:1463 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #2 (jbd2_handle){++++}-{0:0}: lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5871 start_this_handle+0x1fa7/0x21c0 fs/jbd2/transaction.c:444 jbd2__journal_start+0x2c1/0x5b0 fs/jbd2/transaction.c:501 jbd2_journal_start+0x2a/0x40 fs/jbd2/transaction.c:540 ocfs2_start_trans+0x376/0x6d0 fs/ocfs2/journal.c:374 ocfs2_block_group_alloc fs/ocfs2/suballoc.c:685 [inline] ocfs2_reserve_suballoc_bits+0x711/0x4640 fs/ocfs2/suballoc.c:834 ocfs2_reserve_new_metadata_blocks+0x403/0x940 fs/ocfs2/suballoc.c:984 ocfs2_mknod+0xe08/0x2050 fs/ocfs2/namei.c:347 ocfs2_create+0x1a5/0x440 fs/ocfs2/namei.c:673 lookup_open fs/namei.c:3717 [inline] open_last_lookups fs/namei.c:3816 [inline] path_openat+0x14f4/0x3830 fs/namei.c:4052 do_filp_open+0x1fa/0x410 fs/namei.c:4082 do_sys_openat2+0x121/0x1c0 fs/open.c:1437 do_sys_open fs/open.c:1452 [inline] __do_sys_openat fs/open.c:1468 [inline] __se_sys_openat fs/open.c:1463 [inline] __x64_sys_openat+0x138/0x170 fs/open.c:1463 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #1 (&journal->j_trans_barrier){.+.+}-{4:4}: lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5871 down_read+0x46/0x2e0 kernel/locking/rwsem.c:1524 ocfs2_start_trans+0x36a/0x6d0 fs/ocfs2/journal.c:372 ocfs2_block_group_alloc fs/ocfs2/suballoc.c:685 [inline] ocfs2_reserve_suballoc_bits+0x711/0x4640 fs/ocfs2/suballoc.c:834 ocfs2_reserve_new_metadata_blocks+0x403/0x940 fs/ocfs2/suballoc.c:984 ocfs2_mknod+0xe08/0x2050 fs/ocfs2/namei.c:347 ocfs2_create+0x1a5/0x440 fs/ocfs2/namei.c:673 lookup_open fs/namei.c:3717 [inline] open_last_lookups fs/namei.c:3816 [inline] path_openat+0x14f4/0x3830 fs/namei.c:4052 do_filp_open+0x1fa/0x410 fs/namei.c:4082 do_sys_openat2+0x121/0x1c0 fs/open.c:1437 do_sys_open fs/open.c:1452 [inline] __do_sys_openat fs/open.c:1468 [inline] __se_sys_openat fs/open.c:1463 [inline] __x64_sys_openat+0x138/0x170 fs/open.c:1463 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #0 (sb_internal#6){.+.+}-{0:0}: check_prev_add kernel/locking/lockdep.c:3168 [inline] check_prevs_add kernel/locking/lockdep.c:3287 [inline] validate_chain+0xb9b/0x2140 kernel/locking/lockdep.c:3911 __lock_acquire+0xab9/0xd20 kernel/locking/lockdep.c:5240 lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5871 percpu_down_read_internal include/linux/percpu-rwsem.h:53 [inline] percpu_down_read_freezable include/linux/percpu-rwsem.h:83 [inline] __sb_start_write include/linux/fs.h:1795 [inline] sb_start_intwrite include/linux/fs.h:1978 [inline] ocfs2_start_trans+0x26b/0x6d0 fs/ocfs2/journal.c:370 ocfs2_acquire_dquot+0x455/0xb30 fs/ocfs2/quota_global.c:860 dqget+0x7ae/0xf10 fs/quota/dquot.c:977 __dquot_initialize+0x3b3/0xcb0 fs/quota/dquot.c:1505 ocfs2_get_init_inode+0x13b/0x1b0 fs/ocfs2/namei.c:202 ocfs2_mknod+0x863/0x2050 fs/ocfs2/namei.c:310 vfs_mknod+0x37c/0x3c0 fs/namei.c:4244 do_mknodat+0x385/0x4d0 fs/namei.c:-1 __do_sys_mknodat fs/namei.c:4322 [inline] __se_sys_mknodat fs/namei.c:4319 [inline] __x64_sys_mknodat+0xa7/0xc0 fs/namei.c:4319 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f other info that might help us debug this: Chain exists of: sb_internal#6 --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7 --> &ocfs2_quota_ip_alloc_sem_key Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ocfs2_quota_ip_alloc_sem_key); lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7); lock(&ocfs2_quota_ip_alloc_sem_key); rlock(sb_internal#6); *** DEADLOCK *** 6 locks held by syz.4.566/11692: #0: ffff888063f2e428 (sb_writers#20){.+.+}-{0:0}, at: mnt_want_write+0x41/0x90 fs/namespace.c:557 #1: ffff88804d035f40 (&type->i_mutex_dir_key#15/1){+.+.}-{4:4}, at: inode_lock_nested include/linux/fs.h:914 [inline] #1: ffff88804d035f40 (&type->i_mutex_dir_key#15/1){+.+.}-{4:4}, at: filename_create+0x1f9/0x470 fs/namei.c:4148 #2: ffff88805b091800 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:869 [inline] #2: ffff88805b091800 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{4:4}, at: ocfs2_reserve_suballoc_bits+0x15e/0x4640 fs/ocfs2/suballoc.c:788 #3: ffff8880598c80a8 (&dquot->dq_lock){+.+.}-{4:4}, at: ocfs2_acquire_dquot+0x2a3/0xb30 fs/ocfs2/quota_global.c:823 #4: ffff88805b1c5f40 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:869 [inline] #4: ffff88805b1c5f40 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{4:4}, at: ocfs2_lock_global_qf+0x1ca/0x270 fs/ocfs2/quota_global.c:313 #5: ffff88805b1c5be0 (&ocfs2_quota_ip_alloc_sem_key){++++}-{4:4}, at: ocfs2_lock_global_qf+0x1e8/0x270 fs/ocfs2/quota_global.c:314 stack backtrace: CPU: 0 UID: 0 PID: 11692 Comm: syz.4.566 Not tainted 6.16.0-rc3-syzkaller-00044-g7595b66ae9de #0 PREEMPT(full) Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/07/2025 Call Trace: dump_stack_lvl+0x189/0x250 lib/dump_stack.c:120 print_circular_bug+0x2ee/0x310 kernel/locking/lockdep.c:2046 check_noncircular+0x134/0x160 kernel/locking/lockdep.c:2178 check_prev_add kernel/locking/lockdep.c:3168 [inline] check_prevs_add kernel/locking/lockdep.c:3287 [inline] validate_chain+0xb9b/0x2140 kernel/locking/lockdep.c:3911 __lock_acquire+0xab9/0xd20 kernel/locking/lockdep.c:5240 lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5871 percpu_down_read_internal include/linux/percpu-rwsem.h:53 [inline] percpu_down_read_freezable include/linux/percpu-rwsem.h:83 [inline] __sb_start_write include/linux/fs.h:1795 [inline] sb_start_intwrite include/linux/fs.h:1978 [inline] ocfs2_start_trans+0x26b/0x6d0 fs/ocfs2/journal.c:370 ocfs2_acquire_dquot+0x455/0xb30 fs/ocfs2/quota_global.c:860 dqget+0x7ae/0xf10 fs/quota/dquot.c:977 __dquot_initialize+0x3b3/0xcb0 fs/quota/dquot.c:1505 ocfs2_get_init_inode+0x13b/0x1b0 fs/ocfs2/namei.c:202 ocfs2_mknod+0x863/0x2050 fs/ocfs2/namei.c:310 vfs_mknod+0x37c/0x3c0 fs/namei.c:4244 do_mknodat+0x385/0x4d0 fs/namei.c:-1 __do_sys_mknodat fs/namei.c:4322 [inline] __se_sys_mknodat fs/namei.c:4319 [inline] __x64_sys_mknodat+0xa7/0xc0 fs/namei.c:4319 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7fdace18e929 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007fdacbff6038 EFLAGS: 00000246 ORIG_RAX: 0000000000000103 RAX: ffffffffffffffda RBX: 00007fdace3b6080 RCX: 00007fdace18e929 RDX: 0000000000006004 RSI: 0000200000000340 RDI: ffffffffffffff9c RBP: 00007fdace210b39 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000709 R11: 0000000000000246 R12: 0000000000000000 R13: 0000000000000001 R14: 00007fdace3b6080 R15: 00007fffcdbbbea8