====================================================== WARNING: possible circular locking dependency detected 5.15.164-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor/4762 is trying to acquire lock: ffff888019a980b0 (&tree->tree_lock#2){+.+.}-{3:3}, at: hfsplus_file_truncate+0x864/0xb80 fs/hfsplus/extents.c:595 but task is already holding lock: ffff88805ebb5f88 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_truncate+0x2e1/0xb80 fs/hfsplus/extents.c:576 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743 hfsplus_file_extend+0x1d2/0x1b10 fs/hfsplus/extents.c:457 hfsplus_bmap_reserve+0x101/0x4e0 fs/hfsplus/btree.c:357 hfsplus_delete_attr+0x15d/0x4a0 fs/hfsplus/attributes.c:326 hfsplus_removexattr fs/hfsplus/xattr.c:794 [inline] __hfsplus_setxattr+0x7f3/0x22c0 fs/hfsplus/xattr.c:275 hfsplus_setxattr+0xac/0xe0 fs/hfsplus/xattr.c:434 hfsplus_user_setxattr+0x3c/0x50 fs/hfsplus/xattr_user.c:30 __vfs_removexattr+0x3ce/0x410 fs/xattr.c:470 __vfs_removexattr_locked+0x1fe/0x410 fs/xattr.c:505 vfs_removexattr+0xff/0x2a0 fs/xattr.c:527 removexattr fs/xattr.c:857 [inline] path_removexattr+0x22a/0x320 fs/xattr.c:871 __do_sys_lremovexattr fs/xattr.c:891 [inline] __se_sys_lremovexattr fs/xattr.c:888 [inline] __x64_sys_lremovexattr+0x59/0x70 fs/xattr.c:888 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 -> #1 (&tree->tree_lock#2/2){+.+.}-{3:3}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743 hfsplus_find_init+0x146/0x1c0 hfsplus_attr_exists+0xfb/0x1c0 fs/hfsplus/attributes.c:178 __hfsplus_setxattr+0x453/0x22c0 fs/hfsplus/xattr.c:336 __vfs_setxattr+0x3e7/0x420 fs/xattr.c:182 __vfs_setxattr_noperm+0x12a/0x5e0 fs/xattr.c:216 vfs_setxattr+0x21d/0x420 fs/xattr.c:303 do_setxattr fs/xattr.c:588 [inline] setxattr+0x27e/0x2e0 fs/xattr.c:611 path_setxattr+0x1bc/0x2a0 fs/xattr.c:630 __do_sys_setxattr fs/xattr.c:646 [inline] __se_sys_setxattr fs/xattr.c:642 [inline] __x64_sys_setxattr+0xb7/0xd0 fs/xattr.c:642 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 -> #0 (&tree->tree_lock#2){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743 hfsplus_file_truncate+0x864/0xb80 fs/hfsplus/extents.c:595 hfsplus_delete_inode+0x170/0x220 hfsplus_unlink+0x50d/0x7f0 fs/hfsplus/dir.c:405 vfs_unlink+0x359/0x5f0 fs/namei.c:4280 do_unlinkat+0x4a3/0x950 fs/namei.c:4348 __do_sys_unlink fs/namei.c:4396 [inline] __se_sys_unlink fs/namei.c:4394 [inline] __x64_sys_unlink+0x45/0x50 fs/namei.c:4394 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 other info that might help us debug this: Chain exists of: &tree->tree_lock#2 --> &tree->tree_lock#2/2 --> &HFSPLUS_I(inode)->extents_lock Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&HFSPLUS_I(inode)->extents_lock); lock(&tree->tree_lock#2/2); lock(&HFSPLUS_I(inode)->extents_lock); lock(&tree->tree_lock#2); *** DEADLOCK *** 5 locks held by syz-executor/4762: #0: ffff88801d228460 (sb_writers#22){.+.+}-{0:0}, at: mnt_want_write+0x3b/0x80 fs/namespace.c:377 #1: ffff88805ebb4680 (&type->i_mutex_dir_key#15/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:824 [inline] #1: ffff88805ebb4680 (&type->i_mutex_dir_key#15/1){+.+.}-{3:3}, at: do_unlinkat+0x266/0x950 fs/namei.c:4331 #2: ffff88805ebb6180 (&sb->s_type->i_mutex_key#35){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline] #2: ffff88805ebb6180 (&sb->s_type->i_mutex_key#35){+.+.}-{3:3}, at: vfs_unlink+0xe0/0x5f0 fs/namei.c:4269 #3: ffff88807c4fb998 (&sbi->vh_mutex){+.+.}-{3:3}, at: hfsplus_unlink+0x15d/0x7f0 fs/hfsplus/dir.c:370 #4: ffff88805ebb5f88 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_truncate+0x2e1/0xb80 fs/hfsplus/extents.c:576 stack backtrace: CPU: 1 PID: 4762 Comm: syz-executor Not tainted 5.15.164-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 06/27/2024 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e3/0x2d0 lib/dump_stack.c:106 check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133 check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743 hfsplus_file_truncate+0x864/0xb80 fs/hfsplus/extents.c:595 hfsplus_delete_inode+0x170/0x220 hfsplus_unlink+0x50d/0x7f0 fs/hfsplus/dir.c:405 vfs_unlink+0x359/0x5f0 fs/namei.c:4280 do_unlinkat+0x4a3/0x950 fs/namei.c:4348 __do_sys_unlink fs/namei.c:4396 [inline] __se_sys_unlink fs/namei.c:4394 [inline] __x64_sys_unlink+0x45/0x50 fs/namei.c:4394 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 RIP: 0033:0x7ff5a7b17f67 Code: 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 83 c8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 b8 57 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007ffed88ec538 EFLAGS: 00000206 ORIG_RAX: 0000000000000057 RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007ff5a7b17f67 RDX: 00007ffed88ec560 RSI: 00007ffed88ec5f0 RDI: 00007ffed88ec5f0 RBP: 00007ffed88ec5f0 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000100 R11: 0000000000000206 R12: 00007ffed88ed6e0 R13: 00007ff5a7b86764 R14: 000000000003cafe R15: 00007ffed88ee7a0