===================================================== WARNING: SOFTIRQ-safe -> SOFTIRQ-unsafe lock order detected 5.14.0-rc7-syzkaller #0 Not tainted ----------------------------------------------------- syz-executor.2/29266 [HC0[0]:SC0[0]:HE0:SE1] is trying to acquire: ffff88801d0224b0 (&new->fa_lock){.+.?}-{2:2}, at: kill_fasync_rcu fs/fcntl.c:1012 [inline] ffff88801d0224b0 (&new->fa_lock){.+.?}-{2:2}, at: kill_fasync+0x13b/0x430 fs/fcntl.c:1033 and this task is already holding: ffff8881476f4148 (&timer->lock){..-.}-{2:2}, at: snd_timer_start1+0x5b/0x640 sound/core/timer.c:541 which would create a new lock dependency: (&timer->lock){..-.}-{2:2} -> (&new->fa_lock){.+.?}-{2:2} but this new dependency connects a SOFTIRQ-irq-safe lock: (&timer->lock){..-.}-{2:2} ... which became SOFTIRQ-irq-safe at: lock_acquire+0x182/0x4a0 kernel/locking/lockdep.c:5625 __raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline] _raw_spin_lock_irqsave+0xb3/0x100 kernel/locking/spinlock.c:159 snd_timer_interrupt+0x210/0x1410 sound/core/timer.c:857 call_timer_fn+0xf6/0x210 kernel/time/timer.c:1421 expire_timers kernel/time/timer.c:1466 [inline] __run_timers+0x703/0x8f0 kernel/time/timer.c:1734 run_timer_softirq+0x63/0xf0 kernel/time/timer.c:1747 __do_softirq+0x372/0x783 kernel/softirq.c:558 invoke_softirq kernel/softirq.c:432 [inline] __irq_exit_rcu+0x21b/0x260 kernel/softirq.c:636 irq_exit_rcu+0x5/0x20 kernel/softirq.c:648 sysvec_apic_timer_interrupt+0x91/0xb0 arch/x86/kernel/apic/apic.c:1100 asm_sysvec_apic_timer_interrupt+0x12/0x20 arch/x86/include/asm/idtentry.h:638 notifier_call_chain kernel/notifier.c:74 [inline] raw_notifier_call_chain+0x87/0x170 kernel/notifier.c:410 call_netdevice_notifiers_info net/core/dev.c:2123 [inline] netdev_state_change+0x19b/0x260 net/core/dev.c:1514 do_setlink+0x353/0x3f70 net/core/rtnetlink.c:2946 rtnl_group_changelink net/core/rtnetlink.c:3244 [inline] __rtnl_newlink net/core/rtnetlink.c:3398 [inline] rtnl_newlink+0x108e/0x1cd0 net/core/rtnetlink.c:3508 rtnetlink_rcv_msg+0x91c/0xe50 net/core/rtnetlink.c:5574 netlink_rcv_skb+0x1f0/0x460 net/netlink/af_netlink.c:2504 netlink_unicast_kernel net/netlink/af_netlink.c:1314 [inline] netlink_unicast+0x7de/0x9b0 net/netlink/af_netlink.c:1340 netlink_sendmsg+0x9e7/0xe00 net/netlink/af_netlink.c:1929 sock_sendmsg_nosec net/socket.c:703 [inline] sock_sendmsg net/socket.c:723 [inline] ____sys_sendmsg+0x5a2/0x900 net/socket.c:2392 ___sys_sendmsg net/socket.c:2446 [inline] __sys_sendmsg+0x319/0x400 net/socket.c:2475 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x44/0xae to a SOFTIRQ-irq-unsafe lock: (&new->fa_lock){.+.?}-{2:2} ... which became SOFTIRQ-irq-unsafe at: ... lock_acquire+0x182/0x4a0 kernel/locking/lockdep.c:5625 __raw_read_lock include/linux/rwlock_api_smp.h:149 [inline] _raw_read_lock+0x32/0x40 kernel/locking/spinlock.c:223 kill_fasync_rcu fs/fcntl.c:1012 [inline] kill_fasync+0x13b/0x430 fs/fcntl.c:1033 fsnotify_add_event+0x35a/0x410 fs/notify/notification.c:128 inotify_handle_inode_event+0x389/0x500 fs/notify/inotify/inotify_fsnotify.c:119 fsnotify+0x9e5/0x12e0 fs/notify/fsnotify.c:541 __fsnotify_parent+0x433/0x670 fs/notify/fsnotify.c:232 fsnotify_parent include/linux/fsnotify.h:68 [inline] fsnotify_dentry include/linux/fsnotify.h:80 [inline] fsnotify_change include/linux/fsnotify.h:317 [inline] notify_change+0xd87/0x1060 fs/attr.c:403 do_truncate+0x1fb/0x2e0 fs/open.c:64 handle_truncate fs/namei.c:3030 [inline] do_open fs/namei.c:3378 [inline] path_openat+0x2ab9/0x36b0 fs/namei.c:3507 do_filp_open+0x253/0x4d0 fs/namei.c:3534 do_sys_openat2+0x124/0x460 fs/open.c:1204 do_sys_open fs/open.c:1220 [inline] __do_sys_open fs/open.c:1228 [inline] __se_sys_open fs/open.c:1224 [inline] __x64_sys_open+0x221/0x270 fs/open.c:1224 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x44/0xae other info that might help us debug this: Possible interrupt unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&new->fa_lock); local_irq_disable(); lock(&timer->lock); lock(&new->fa_lock); lock(&timer->lock); *** DEADLOCK *** 3 locks held by syz-executor.2/29266: #0: ffff888039f72d68 (&tu->ioctl_lock){+.+.}-{3:3}, at: snd_timer_user_ioctl+0x4d/0x80 sound/core/timer.c:2128 #1: ffff8881476f4148 (&timer->lock){..-.}-{2:2}, at: snd_timer_start1+0x5b/0x640 sound/core/timer.c:541 #2: ffffffff8c717ec0 (rcu_read_lock){....}-{1:2}, at: rcu_lock_acquire+0x5/0x30 include/linux/rcupdate.h:266 the dependencies between SOFTIRQ-irq-safe lock and the holding lock: -> (&timer->lock){..-.}-{2:2} { IN-SOFTIRQ-W at: lock_acquire+0x182/0x4a0 kernel/locking/lockdep.c:5625 __raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline] _raw_spin_lock_irqsave+0xb3/0x100 kernel/locking/spinlock.c:159 snd_timer_interrupt+0x210/0x1410 sound/core/timer.c:857 call_timer_fn+0xf6/0x210 kernel/time/timer.c:1421 expire_timers kernel/time/timer.c:1466 [inline] __run_timers+0x703/0x8f0 kernel/time/timer.c:1734 run_timer_softirq+0x63/0xf0 kernel/time/timer.c:1747 __do_softirq+0x372/0x783 kernel/softirq.c:558 invoke_softirq kernel/softirq.c:432 [inline] __irq_exit_rcu+0x21b/0x260 kernel/softirq.c:636 irq_exit_rcu+0x5/0x20 kernel/softirq.c:648 sysvec_apic_timer_interrupt+0x91/0xb0 arch/x86/kernel/apic/apic.c:1100 asm_sysvec_apic_timer_interrupt+0x12/0x20 arch/x86/include/asm/idtentry.h:638 notifier_call_chain kernel/notifier.c:74 [inline] raw_notifier_call_chain+0x87/0x170 kernel/notifier.c:410 call_netdevice_notifiers_info net/core/dev.c:2123 [inline] netdev_state_change+0x19b/0x260 net/core/dev.c:1514 do_setlink+0x353/0x3f70 net/core/rtnetlink.c:2946 rtnl_group_changelink net/core/rtnetlink.c:3244 [inline] __rtnl_newlink net/core/rtnetlink.c:3398 [inline] rtnl_newlink+0x108e/0x1cd0 net/core/rtnetlink.c:3508 rtnetlink_rcv_msg+0x91c/0xe50 net/core/rtnetlink.c:5574 netlink_rcv_skb+0x1f0/0x460 net/netlink/af_netlink.c:2504 netlink_unicast_kernel net/netlink/af_netlink.c:1314 [inline] netlink_unicast+0x7de/0x9b0 net/netlink/af_netlink.c:1340 netlink_sendmsg+0x9e7/0xe00 net/netlink/af_netlink.c:1929 sock_sendmsg_nosec net/socket.c:703 [inline] sock_sendmsg net/socket.c:723 [inline] ____sys_sendmsg+0x5a2/0x900 net/socket.c:2392 ___sys_sendmsg net/socket.c:2446 [inline] __sys_sendmsg+0x319/0x400 net/socket.c:2475 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x44/0xae INITIAL USE at: lock_acquire+0x182/0x4a0 kernel/locking/lockdep.c:5625 __raw_spin_lock_irq include/linux/spinlock_api_smp.h:128 [inline] _raw_spin_lock_irq+0xae/0xf0 kernel/locking/spinlock.c:167 spin_lock_irq include/linux/spinlock.h:379 [inline] snd_pcm_detach_substream+0x14b/0x280 sound/core/pcm.c:995 snd_pcm_release+0xbd/0x160 sound/core/pcm_native.c:2818 __fput+0x352/0x7b0 fs/file_table.c:280 task_work_run+0x146/0x1c0 kernel/task_work.c:164 tracehook_notify_resume include/linux/tracehook.h:189 [inline] exit_to_user_mode_loop kernel/entry/common.c:175 [inline] exit_to_user_mode_prepare+0x201/0x220 kernel/entry/common.c:209 __syscall_exit_to_user_mode_work kernel/entry/common.c:291 [inline] syscall_exit_to_user_mode+0x26/0x60 kernel/entry/common.c:302 do_syscall_64+0x4c/0xb0 arch/x86/entry/common.c:86 entry_SYSCALL_64_after_hwframe+0x44/0xae } ... key at: [] snd_timer_new.__key+0x0/0x40 the dependencies between the lock to be acquired and SOFTIRQ-irq-unsafe lock: -> (&new->fa_lock){.+.?}-{2:2} { HARDIRQ-ON-R at: lock_acquire+0x182/0x4a0 kernel/locking/lockdep.c:5625 __raw_read_lock include/linux/rwlock_api_smp.h:149 [inline] _raw_read_lock+0x32/0x40 kernel/locking/spinlock.c:223 kill_fasync_rcu fs/fcntl.c:1012 [inline] kill_fasync+0x13b/0x430 fs/fcntl.c:1033 fsnotify_add_event+0x35a/0x410 fs/notify/notification.c:128 inotify_handle_inode_event+0x389/0x500 fs/notify/inotify/inotify_fsnotify.c:119 fsnotify+0x9e5/0x12e0 fs/notify/fsnotify.c:541 __fsnotify_parent+0x433/0x670 fs/notify/fsnotify.c:232 fsnotify_parent include/linux/fsnotify.h:68 [inline] fsnotify_dentry include/linux/fsnotify.h:80 [inline] fsnotify_change include/linux/fsnotify.h:317 [inline] notify_change+0xd87/0x1060 fs/attr.c:403 do_truncate+0x1fb/0x2e0 fs/open.c:64 handle_truncate fs/namei.c:3030 [inline] do_open fs/namei.c:3378 [inline] path_openat+0x2ab9/0x36b0 fs/namei.c:3507 do_filp_open+0x253/0x4d0 fs/namei.c:3534 do_sys_openat2+0x124/0x460 fs/open.c:1204 do_sys_open fs/open.c:1220 [inline] __do_sys_open fs/open.c:1228 [inline] __se_sys_open fs/open.c:1224 [inline] __x64_sys_open+0x221/0x270 fs/open.c:1224 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x44/0xae IN-SOFTIRQ-R at: lock_acquire+0x182/0x4a0 kernel/locking/lockdep.c:5625 __raw_read_lock include/linux/rwlock_api_smp.h:149 [inline] _raw_read_lock+0x32/0x40 kernel/locking/spinlock.c:223 kill_fasync_rcu fs/fcntl.c:1012 [inline] kill_fasync+0x13b/0x430 fs/fcntl.c:1033 sock_wake_async+0x133/0x150 net/socket.c:1354 rcu_read_unlock include/linux/rcupdate.h:716 [inline] sk_wake_async+0x12e/0x200 include/net/sock.h:2328 tcp_check_urg net/ipv4/tcp_input.c:5518 [inline] tcp_urg+0x2af/0xb00 net/ipv4/tcp_input.c:5559 tcp_rcv_established+0x9ec/0x22b0 net/ipv4/tcp_input.c:5893 tcp_v4_do_rcv+0x3a1/0x880 net/ipv4/tcp_ipv4.c:1694 tcp_v4_rcv+0x3aa1/0x4880 net/ipv4/tcp_ipv4.c:2087 ip_protocol_deliver_rcu+0x1ed/0x3b0 net/ipv4/ip_input.c:204 ip_local_deliver_finish net/ipv4/ip_input.c:231 [inline] NF_HOOK include/linux/netfilter.h:307 [inline] ip_local_deliver+0x316/0x490 net/ipv4/ip_input.c:252 __netif_receive_skb_one_core net/core/dev.c:5498 [inline] __netif_receive_skb+0x1d1/0x500 net/core/dev.c:5612 process_backlog+0x4d8/0x940 net/core/dev.c:6492 __napi_poll+0xba/0x4f0 net/core/dev.c:7047 napi_poll net/core/dev.c:7114 [inline] net_rx_action+0x62c/0xf30 net/core/dev.c:7201 __do_softirq+0x372/0x783 kernel/softirq.c:558 run_ksoftirqd+0xa2/0x100 kernel/softirq.c:920 smpboot_thread_fn+0x533/0x9d0 kernel/smpboot.c:164 kthread+0x453/0x480 kernel/kthread.c:319 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:295 SOFTIRQ-ON-R at: lock_acquire+0x182/0x4a0 kernel/locking/lockdep.c:5625 __raw_read_lock include/linux/rwlock_api_smp.h:149 [inline] _raw_read_lock+0x32/0x40 kernel/locking/spinlock.c:223 kill_fasync_rcu fs/fcntl.c:1012 [inline] kill_fasync+0x13b/0x430 fs/fcntl.c:1033 fsnotify_add_event+0x35a/0x410 fs/notify/notification.c:128 inotify_handle_inode_event+0x389/0x500 fs/notify/inotify/inotify_fsnotify.c:119 fsnotify+0x9e5/0x12e0 fs/notify/fsnotify.c:541 __fsnotify_parent+0x433/0x670 fs/notify/fsnotify.c:232 fsnotify_parent include/linux/fsnotify.h:68 [inline] fsnotify_dentry include/linux/fsnotify.h:80 [inline] fsnotify_change include/linux/fsnotify.h:317 [inline] notify_change+0xd87/0x1060 fs/attr.c:403 do_truncate+0x1fb/0x2e0 fs/open.c:64 handle_truncate fs/namei.c:3030 [inline] do_open fs/namei.c:3378 [inline] path_openat+0x2ab9/0x36b0 fs/namei.c:3507 do_filp_open+0x253/0x4d0 fs/namei.c:3534 do_sys_openat2+0x124/0x460 fs/open.c:1204 do_sys_open fs/open.c:1220 [inline] __do_sys_open fs/open.c:1228 [inline] __se_sys_open fs/open.c:1224 [inline] __x64_sys_open+0x221/0x270 fs/open.c:1224 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x44/0xae INITIAL USE at: lock_acquire+0x182/0x4a0 kernel/locking/lockdep.c:5625 __raw_write_lock_irq include/linux/rwlock_api_smp.h:196 [inline] _raw_write_lock_irq+0xae/0xf0 kernel/locking/spinlock.c:311 fasync_remove_entry+0xff/0x1d0 fs/fcntl.c:890 fsnotify_fasync+0x4d/0x70 fs/notify/group.c:162 __fput+0x65b/0x7b0 fs/file_table.c:277 task_work_run+0x146/0x1c0 kernel/task_work.c:164 tracehook_notify_resume include/linux/tracehook.h:189 [inline] exit_to_user_mode_loop kernel/entry/common.c:175 [inline] exit_to_user_mode_prepare+0x201/0x220 kernel/entry/common.c:209 __syscall_exit_to_user_mode_work kernel/entry/common.c:291 [inline] syscall_exit_to_user_mode+0x26/0x60 kernel/entry/common.c:302 do_syscall_64+0x4c/0xb0 arch/x86/entry/common.c:86 entry_SYSCALL_64_after_hwframe+0x44/0xae INITIAL READ USE at: lock_acquire+0x182/0x4a0 kernel/locking/lockdep.c:5625 __raw_read_lock include/linux/rwlock_api_smp.h:149 [inline] _raw_read_lock+0x32/0x40 kernel/locking/spinlock.c:223 kill_fasync_rcu fs/fcntl.c:1012 [inline] kill_fasync+0x13b/0x430 fs/fcntl.c:1033 fsnotify_add_event+0x35a/0x410 fs/notify/notification.c:128 inotify_handle_inode_event+0x389/0x500 fs/notify/inotify/inotify_fsnotify.c:119 fsnotify+0x9e5/0x12e0 fs/notify/fsnotify.c:541 __fsnotify_parent+0x433/0x670 fs/notify/fsnotify.c:232 fsnotify_parent include/linux/fsnotify.h:68 [inline] fsnotify_dentry include/linux/fsnotify.h:80 [inline] fsnotify_change include/linux/fsnotify.h:317 [inline] notify_change+0xd87/0x1060 fs/attr.c:403 do_truncate+0x1fb/0x2e0 fs/open.c:64 handle_truncate fs/namei.c:3030 [inline] do_open fs/namei.c:3378 [inline] path_openat+0x2ab9/0x36b0 fs/namei.c:3507 do_filp_open+0x253/0x4d0 fs/namei.c:3534 do_sys_openat2+0x124/0x460 fs/open.c:1204 do_sys_open fs/open.c:1220 [inline] __do_sys_open fs/open.c:1228 [inline] __se_sys_open fs/open.c:1224 [inline] __x64_sys_open+0x221/0x270 fs/open.c:1224 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x44/0xae } ... key at: [] fasync_insert_entry.__key+0x0/0x40 ... acquired at: lock_acquire+0x182/0x4a0 kernel/locking/lockdep.c:5625 __raw_read_lock include/linux/rwlock_api_smp.h:149 [inline] _raw_read_lock+0x32/0x40 kernel/locking/spinlock.c:223 kill_fasync_rcu fs/fcntl.c:1012 [inline] kill_fasync+0x13b/0x430 fs/fcntl.c:1033 snd_timer_user_ccallback+0x3ee/0x710 sound/core/timer.c:1387 snd_timer_notify1+0x19e/0x340 sound/core/timer.c:516 snd_timer_start1+0x53d/0x640 sound/core/timer.c:578 snd_timer_start sound/core/timer.c:697 [inline] snd_timer_user_start sound/core/timer.c:1985 [inline] __snd_timer_user_ioctl+0xe18/0x5ed0 sound/core/timer.c:2108 snd_timer_user_ioctl+0x5d/0x80 sound/core/timer.c:2129 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:1069 [inline] __se_sys_ioctl+0xfb/0x170 fs/ioctl.c:1055 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x44/0xae stack backtrace: CPU: 0 PID: 29266 Comm: syz-executor.2 Not tainted 5.14.0-rc7-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1ae/0x29f lib/dump_stack.c:105 print_bad_irq_dependency kernel/locking/lockdep.c:2565 [inline] check_irq_usage kernel/locking/lockdep.c:2804 [inline] check_prev_add kernel/locking/lockdep.c:3055 [inline] check_prevs_add+0x4eaa/0x5b30 kernel/locking/lockdep.c:3174 validate_chain kernel/locking/lockdep.c:3789 [inline] __lock_acquire+0x4476/0x6100 kernel/locking/lockdep.c:5015 lock_acquire+0x182/0x4a0 kernel/locking/lockdep.c:5625 __raw_read_lock include/linux/rwlock_api_smp.h:149 [inline] _raw_read_lock+0x32/0x40 kernel/locking/spinlock.c:223 kill_fasync_rcu fs/fcntl.c:1012 [inline] kill_fasync+0x13b/0x430 fs/fcntl.c:1033 snd_timer_user_ccallback+0x3ee/0x710 sound/core/timer.c:1387 snd_timer_notify1+0x19e/0x340 sound/core/timer.c:516 snd_timer_start1+0x53d/0x640 sound/core/timer.c:578 snd_timer_start sound/core/timer.c:697 [inline] snd_timer_user_start sound/core/timer.c:1985 [inline] __snd_timer_user_ioctl+0xe18/0x5ed0 sound/core/timer.c:2108 snd_timer_user_ioctl+0x5d/0x80 sound/core/timer.c:2129 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:1069 [inline] __se_sys_ioctl+0xfb/0x170 fs/ioctl.c:1055 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x44/0xae RIP: 0033:0x4665e9 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 bc ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007faf0f8e5188 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 RAX: ffffffffffffffda RBX: 000000000056c038 RCX: 00000000004665e9 RDX: 0000000000000000 RSI: 00000000000054a0 RDI: 0000000000000003 RBP: 00000000004bfcc4 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 000000000056c038 R13: 00007ffd1a1ac9cf R14: 00007faf0f8e5300 R15: 0000000000022000