====================================================== WARNING: possible circular locking dependency detected 6.12.0-rc3-syzkaller-00007-g6485cf5ea253 #0 Not tainted ------------------------------------------------------ syz.5.1004/7985 is trying to acquire lock: ffff88807c8787c8 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_extend+0x21b/0x1b70 fs/hfsplus/extents.c:458 but task is already holding lock: ffff8880615e40b0 (&tree->tree_lock#2/1){+.+.}-{3:3}, at: hfsplus_find_init+0x14a/0x1c0 fs/hfsplus/bfind.c:28 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&tree->tree_lock#2/1){+.+.}-{3:3}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5825 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x136/0xd70 kernel/locking/mutex.c:752 hfsplus_find_init+0x14a/0x1c0 fs/hfsplus/bfind.c:28 hfsplus_file_truncate+0x45f/0xc70 fs/hfsplus/extents.c:583 hfsplus_delete_inode+0x174/0x220 hfsplus_unlink+0x512/0x790 fs/hfsplus/dir.c:405 vfs_unlink+0x367/0x650 fs/namei.c:4469 do_unlinkat+0x4ae/0x830 fs/namei.c:4533 __do_sys_unlinkat fs/namei.c:4576 [inline] __se_sys_unlinkat fs/namei.c:4569 [inline] __x64_sys_unlinkat+0xcc/0xf0 fs/namei.c:4569 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #0 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3161 [inline] check_prevs_add kernel/locking/lockdep.c:3280 [inline] validate_chain+0x18ef/0x5920 kernel/locking/lockdep.c:3904 __lock_acquire+0x1384/0x2050 kernel/locking/lockdep.c:5202 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5825 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x136/0xd70 kernel/locking/mutex.c:752 hfsplus_file_extend+0x21b/0x1b70 fs/hfsplus/extents.c:458 hfsplus_bmap_reserve+0x105/0x4e0 fs/hfsplus/btree.c:358 __hfsplus_ext_write_extent+0x2a4/0x5c0 fs/hfsplus/extents.c:104 __hfsplus_ext_cache_extent+0x84/0xe10 fs/hfsplus/extents.c:186 hfsplus_ext_read_extent fs/hfsplus/extents.c:218 [inline] hfsplus_file_extend+0x48c/0x1b70 fs/hfsplus/extents.c:462 hfsplus_get_block+0x406/0x14f0 fs/hfsplus/extents.c:245 __block_write_begin_int+0x50e/0x1a70 fs/buffer.c:2121 block_write_begin fs/buffer.c:2231 [inline] cont_write_begin+0x6e2/0x9d0 fs/buffer.c:2582 hfsplus_write_begin+0x68/0xb0 fs/hfsplus/inode.c:46 generic_perform_write+0x346/0x6d0 mm/filemap.c:4054 generic_file_write_iter+0xae/0x310 mm/filemap.c:4181 new_sync_write fs/read_write.c:590 [inline] vfs_write+0xa6f/0xc90 fs/read_write.c:683 ksys_write+0x183/0x2b0 fs/read_write.c:736 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&tree->tree_lock#2/1); lock(&HFSPLUS_I(inode)->extents_lock); lock(&tree->tree_lock#2/1); lock(&HFSPLUS_I(inode)->extents_lock); *** DEADLOCK *** 5 locks held by syz.5.1004/7985: #0: ffff88802f87deb8 (&f->f_pos_lock){+.+.}-{3:3}, at: fdget_pos+0x24e/0x320 fs/file.c:1160 #1: ffff88805b462420 (sb_writers#21){.+.+}-{0:0}, at: file_start_write include/linux/fs.h:2931 [inline] #1: ffff88805b462420 (sb_writers#21){.+.+}-{0:0}, at: vfs_write+0x224/0xc90 fs/read_write.c:679 #2: ffff88807c879df8 (&sb->s_type->i_mutex_key#30){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:815 [inline] #2: ffff88807c879df8 (&sb->s_type->i_mutex_key#30){+.+.}-{3:3}, at: generic_file_write_iter+0x82/0x310 mm/filemap.c:4178 #3: ffff88807c879c08 (&hip->extents_lock){+.+.}-{3:3}, at: hfsplus_file_extend+0x21b/0x1b70 fs/hfsplus/extents.c:458 #4: ffff8880615e40b0 (&tree->tree_lock#2/1){+.+.}-{3:3}, at: hfsplus_find_init+0x14a/0x1c0 fs/hfsplus/bfind.c:28 stack backtrace: CPU: 1 UID: 0 PID: 7985 Comm: syz.5.1004 Not tainted 6.12.0-rc3-syzkaller-00007-g6485cf5ea253 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024 Call Trace: __dump_stack lib/dump_stack.c:94 [inline] dump_stack_lvl+0x241/0x360 lib/dump_stack.c:120 print_circular_bug+0x13a/0x1b0 kernel/locking/lockdep.c:2074 check_noncircular+0x36a/0x4a0 kernel/locking/lockdep.c:2206 check_prev_add kernel/locking/lockdep.c:3161 [inline] check_prevs_add kernel/locking/lockdep.c:3280 [inline] validate_chain+0x18ef/0x5920 kernel/locking/lockdep.c:3904 __lock_acquire+0x1384/0x2050 kernel/locking/lockdep.c:5202 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5825 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x136/0xd70 kernel/locking/mutex.c:752 hfsplus_file_extend+0x21b/0x1b70 fs/hfsplus/extents.c:458 hfsplus_bmap_reserve+0x105/0x4e0 fs/hfsplus/btree.c:358 __hfsplus_ext_write_extent+0x2a4/0x5c0 fs/hfsplus/extents.c:104 __hfsplus_ext_cache_extent+0x84/0xe10 fs/hfsplus/extents.c:186 hfsplus_ext_read_extent fs/hfsplus/extents.c:218 [inline] hfsplus_file_extend+0x48c/0x1b70 fs/hfsplus/extents.c:462 hfsplus_get_block+0x406/0x14f0 fs/hfsplus/extents.c:245 __block_write_begin_int+0x50e/0x1a70 fs/buffer.c:2121 block_write_begin fs/buffer.c:2231 [inline] cont_write_begin+0x6e2/0x9d0 fs/buffer.c:2582 hfsplus_write_begin+0x68/0xb0 fs/hfsplus/inode.c:46 generic_perform_write+0x346/0x6d0 mm/filemap.c:4054 generic_file_write_iter+0xae/0x310 mm/filemap.c:4181 new_sync_write fs/read_write.c:590 [inline] vfs_write+0xa6f/0xc90 fs/read_write.c:683 ksys_write+0x183/0x2b0 fs/read_write.c:736 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7fb79297dff9 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007fb793775038 EFLAGS: 00000246 ORIG_RAX: 0000000000000001 RAX: ffffffffffffffda RBX: 00007fb792b35f80 RCX: 00007fb79297dff9 RDX: 000000000208e24b RSI: 0000000020000240 RDI: 0000000000000004 RBP: 00007fb7929f0296 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 0000000000000000 R14: 00007fb792b35f80 R15: 00007ffcafb16298