hfsplus: failed to load root directory ====================================================== WARNING: possible circular locking dependency detected 4.19.211-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.1/2499 is trying to acquire lock: 000000000113f058 (&tree->tree_lock#2){+.+.}, at: hfsplus_file_truncate+0xde7/0x1040 fs/hfsplus/extents.c:595 netlink: 16 bytes leftover after parsing attributes in process `syz-executor.2'. but task is already holding lock: 00000000de9a8aff (&HFSPLUS_I(inode)->extents_lock){+.+.}, at: hfsplus_file_truncate+0x1e2/0x1040 fs/hfsplus/extents.c:576 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&HFSPLUS_I(inode)->extents_lock){+.+.}: hfsplus_get_block+0x292/0x960 fs/hfsplus/extents.c:260 block_read_full_page+0x288/0xd10 fs/buffer.c:2259 do_read_cache_page+0x533/0x1170 mm/filemap.c:2828 read_mapping_page include/linux/pagemap.h:402 [inline] __hfs_bnode_create+0x5b7/0xb60 fs/hfsplus/bnode.c:447 hfsplus_bnode_find+0x2aa/0xb80 fs/hfsplus/bnode.c:497 hfsplus_brec_find+0x2af/0x500 fs/hfsplus/bfind.c:183 hfsplus_brec_read+0x28/0x120 fs/hfsplus/bfind.c:222 hfsplus_find_cat+0x1d0/0x480 fs/hfsplus/catalog.c:202 hfsplus_iget+0x400/0x790 fs/hfsplus/super.c:81 hfsplus_fill_super+0xc5f/0x19e0 fs/hfsplus/super.c:503 mount_bdev+0x2fc/0x3b0 fs/super.c:1158 mount_fs+0xa3/0x310 fs/super.c:1261 vfs_kern_mount.part.0+0x68/0x470 fs/namespace.c:961 vfs_kern_mount fs/namespace.c:951 [inline] do_new_mount fs/namespace.c:2492 [inline] do_mount+0x115c/0x2f50 fs/namespace.c:2822 ksys_mount+0xcf/0x130 fs/namespace.c:3038 __do_sys_mount fs/namespace.c:3052 [inline] __se_sys_mount fs/namespace.c:3049 [inline] __x64_sys_mount+0xba/0x150 fs/namespace.c:3049 do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293 entry_SYSCALL_64_after_hwframe+0x49/0xbe -> #0 (&tree->tree_lock#2){+.+.}: __mutex_lock_common kernel/locking/mutex.c:937 [inline] __mutex_lock+0xd7/0x1190 kernel/locking/mutex.c:1078 hfsplus_file_truncate+0xde7/0x1040 fs/hfsplus/extents.c:595 hfsplus_setattr+0x1e7/0x310 fs/hfsplus/inode.c:263 notify_change+0x70b/0xfc0 fs/attr.c:334 do_truncate+0x134/0x1f0 fs/open.c:63 handle_truncate fs/namei.c:3009 [inline] do_last fs/namei.c:3427 [inline] path_openat+0x2308/0x2df0 fs/namei.c:3537 do_filp_open+0x18c/0x3f0 fs/namei.c:3567 do_sys_open+0x3b3/0x520 fs/open.c:1085 do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293 entry_SYSCALL_64_after_hwframe+0x49/0xbe other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&HFSPLUS_I(inode)->extents_lock); lock(&tree->tree_lock#2); lock(&HFSPLUS_I(inode)->extents_lock); lock(&tree->tree_lock#2); *** DEADLOCK *** 3 locks held by syz-executor.1/2499: #0: 0000000099f10195 (sb_writers#31){.+.+}, at: sb_start_write include/linux/fs.h:1579 [inline] #0: 0000000099f10195 (sb_writers#31){.+.+}, at: mnt_want_write+0x3a/0xb0 fs/namespace.c:360 #1: 00000000b53bd9e9 (&sb->s_type->i_mutex_key#37){+.+.}, at: inode_lock include/linux/fs.h:748 [inline] #1: 00000000b53bd9e9 (&sb->s_type->i_mutex_key#37){+.+.}, at: do_truncate+0x125/0x1f0 fs/open.c:61 #2: 00000000de9a8aff (&HFSPLUS_I(inode)->extents_lock){+.+.}, at: hfsplus_file_truncate+0x1e2/0x1040 fs/hfsplus/extents.c:576 stack backtrace: CPU: 0 PID: 2499 Comm: syz-executor.1 Not tainted 4.19.211-syzkaller #0 hfsplus: failed to load root directory Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/16/2023 Call Trace: __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0x1fc/0x2ef lib/dump_stack.c:118 print_circular_bug.constprop.0.cold+0x2d7/0x41e kernel/locking/lockdep.c:1222 check_prev_add kernel/locking/lockdep.c:1866 [inline] check_prevs_add kernel/locking/lockdep.c:1979 [inline] validate_chain kernel/locking/lockdep.c:2420 [inline] __lock_acquire+0x30c9/0x3ff0 kernel/locking/lockdep.c:3416 lock_acquire+0x170/0x3c0 kernel/locking/lockdep.c:3908 __mutex_lock_common kernel/locking/mutex.c:937 [inline] __mutex_lock+0xd7/0x1190 kernel/locking/mutex.c:1078 hfsplus_file_truncate+0xde7/0x1040 fs/hfsplus/extents.c:595 hfsplus_setattr+0x1e7/0x310 fs/hfsplus/inode.c:263 notify_change+0x70b/0xfc0 fs/attr.c:334 do_truncate+0x134/0x1f0 fs/open.c:63 handle_truncate fs/namei.c:3009 [inline] do_last fs/namei.c:3427 [inline] path_openat+0x2308/0x2df0 fs/namei.c:3537 do_filp_open+0x18c/0x3f0 fs/namei.c:3567 do_sys_open+0x3b3/0x520 fs/open.c:1085 do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293 entry_SYSCALL_64_after_hwframe+0x49/0xbe RIP: 0033:0x7ff8994330f9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 19 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007ff8979a5168 EFLAGS: 00000246 ORIG_RAX: 0000000000000002 9pnet: Insufficient options for proto=fd RAX: ffffffffffffffda RBX: 00007ff899552f80 RCX: 00007ff8994330f9 RDX: 0000000000000000 RSI: 0000000000143242 RDI: 0000000020000000 RBP: 00007ff89948eae9 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 00007ffe3b15443f R14: 00007ff8979a5300 R15: 0000000000022000 XFS (loop3): Mounting V4 Filesystem hfsplus: failed to load root directory XFS (loop3): Ending clean mount 9pnet: Insufficient options for proto=fd XFS (loop3): Unmounting Filesystem netlink: 16 bytes leftover after parsing attributes in process `syz-executor.2'. hfsplus: failed to load root directory hfsplus: failed to load root directory XFS (loop3): Mounting V4 Filesystem XFS (loop1): Mounting V4 Filesystem XFS (loop3): Ending clean mount XFS (loop1): Ending clean mount XFS (loop3): Unmounting Filesystem XFS (loop1): Unmounting Filesystem hfsplus: failed to load root directory XFS (loop3): Mounting V4 Filesystem XFS (loop3): Ending clean mount XFS (loop3): Unmounting Filesystem hfsplus: failed to load root directory hfsplus: failed to load root directory hfsplus: failed to load root directory XFS (loop1): Mounting V4 Filesystem XFS (loop1): Ending clean mount XFS (loop3): Mounting V4 Filesystem XFS (loop3): Ending clean mount XFS (loop3): Unmounting Filesystem XFS (loop1): Unmounting Filesystem hfsplus: failed to load root directory hfsplus: failed to load root directory hfsplus: failed to load root directory XFS (loop3): Mounting V4 Filesystem XFS (loop3): Ending clean mount XFS (loop3): Unmounting Filesystem XFS (loop1): Mounting V4 Filesystem XFS (loop1): Ending clean mount XFS (loop1): Unmounting Filesystem hfsplus: failed to load root directory hfsplus: failed to load root directory hfsplus: failed to load root directory XFS (loop3): Mounting V4 Filesystem XFS (loop3): Ending clean mount XFS (loop3): Unmounting Filesystem hfsplus: failed to load root directory XFS (loop1): Mounting V4 Filesystem XFS (loop1): Ending clean mount XFS (loop1): Unmounting Filesystem hfsplus: failed to load root directory hfsplus: failed to load root directory hfsplus: failed to load root directory XFS (loop1): Mounting V4 Filesystem XFS (loop1): Ending clean mount XFS (loop1): Unmounting Filesystem XFS (loop3): Mounting V4 Filesystem XFS (loop3): Ending clean mount XFS (loop3): Unmounting Filesystem hfsplus: failed to load root directory hfsplus: failed to load root directory XFS (loop3): Mounting V4 Filesystem XFS (loop3): Ending clean mount XFS (loop3): Unmounting Filesystem XFS (loop1): Mounting V4 Filesystem XFS (loop1): Ending clean mount XFS (loop1): Unmounting Filesystem hfsplus: failed to load root directory hfsplus: failed to load root directory hfsplus: failed to load root directory XFS (loop3): Mounting V4 Filesystem XFS (loop3): Ending clean mount XFS (loop3): Unmounting Filesystem hfsplus: failed to load root directory hfsplus: failed to load root directory XFS (loop3): Mounting V4 Filesystem XFS (loop3): Ending clean mount XFS (loop3): Unmounting Filesystem hfsplus: failed to load root directory hfsplus: failed to load root directory XFS (loop3): Mounting V4 Filesystem XFS (loop3): Ending clean mount XFS (loop3): Unmounting Filesystem hfsplus: failed to load root directory hfsplus: failed to load root directory hfsplus: failed to load root directory hfsplus: failed to load root directory hfsplus: failed to load root directory hfsplus: failed to load root directory hfsplus: failed to load root directory hfsplus: failed to load root directory hfsplus: failed to load root directory hfsplus: failed to load root directory hfsplus: failed to load root directory hfsplus: failed to load root directory hfsplus: failed to load root directory