====================================================== WARNING: possible circular locking dependency detected 6.2.0-rc6-next-20230202-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.5/27889 is trying to acquire lock: ffff88807759d680 (&u->lock/1){+.+.}-{2:2}, at: sk_diag_dump_icons net/unix/diag.c:87 [inline] ffff88807759d680 (&u->lock/1){+.+.}-{2:2}, at: sk_diag_fill+0x9f5/0xfc0 net/unix/diag.c:157 but task is already holding lock: ffff88807759f1e8 (rlock-AF_UNIX){+.+.}-{2:2}, at: spin_lock include/linux/spinlock.h:350 [inline] ffff88807759f1e8 (rlock-AF_UNIX){+.+.}-{2:2}, at: sk_diag_dump_icons net/unix/diag.c:69 [inline] ffff88807759f1e8 (rlock-AF_UNIX){+.+.}-{2:2}, at: sk_diag_fill+0x909/0xfc0 net/unix/diag.c:157 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (rlock-AF_UNIX){+.+.}-{2:2}: __raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline] _raw_spin_lock_irqsave+0x3d/0x60 kernel/locking/spinlock.c:162 skb_queue_tail+0x25/0x150 net/core/skbuff.c:3615 unix_dgram_sendmsg+0xf6a/0x1c30 net/unix/af_unix.c:2082 sock_sendmsg_nosec net/socket.c:722 [inline] sock_sendmsg+0xde/0x190 net/socket.c:745 sock_write_iter+0x295/0x3d0 net/socket.c:1133 call_write_iter include/linux/fs.h:1851 [inline] io_write+0x38b/0x15a0 io_uring/rw.c:921 io_issue_sqe+0x15d/0x1250 io_uring/io_uring.c:1907 io_queue_sqe io_uring/io_uring.c:2079 [inline] io_submit_sqe io_uring/io_uring.c:2340 [inline] io_submit_sqes+0x96b/0x1f20 io_uring/io_uring.c:2450 __do_sys_io_uring_enter+0x975/0x2810 io_uring/io_uring.c:3458 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #0 (&u->lock/1){+.+.}-{2:2}: check_prev_add kernel/locking/lockdep.c:3108 [inline] check_prevs_add kernel/locking/lockdep.c:3227 [inline] validate_chain kernel/locking/lockdep.c:3842 [inline] __lock_acquire+0x2f21/0x5df0 kernel/locking/lockdep.c:5074 lock_acquire.part.0+0x11c/0x370 kernel/locking/lockdep.c:5691 _raw_spin_lock_nested+0x34/0x40 kernel/locking/spinlock.c:378 sk_diag_dump_icons net/unix/diag.c:87 [inline] sk_diag_fill+0x9f5/0xfc0 net/unix/diag.c:157 sk_diag_dump net/unix/diag.c:196 [inline] unix_diag_dump+0x456/0x730 net/unix/diag.c:220 netlink_dump+0x570/0xc50 net/netlink/af_netlink.c:2296 __netlink_dump_start+0x64b/0x910 net/netlink/af_netlink.c:2401 netlink_dump_start include/linux/netlink.h:298 [inline] unix_diag_handler_dump net/unix/diag.c:319 [inline] unix_diag_handler_dump+0x654/0x9a0 net/unix/diag.c:308 __sock_diag_cmd net/core/sock_diag.c:238 [inline] sock_diag_rcv_msg+0x31e/0x440 net/core/sock_diag.c:269 netlink_rcv_skb+0x165/0x440 net/netlink/af_netlink.c:2574 sock_diag_rcv+0x2a/0x40 net/core/sock_diag.c:280 netlink_unicast_kernel net/netlink/af_netlink.c:1339 [inline] netlink_unicast+0x547/0x7f0 net/netlink/af_netlink.c:1365 netlink_sendmsg+0x925/0xe30 net/netlink/af_netlink.c:1942 sock_sendmsg_nosec net/socket.c:722 [inline] sock_sendmsg+0xde/0x190 net/socket.c:745 sock_write_iter+0x295/0x3d0 net/socket.c:1133 call_write_iter include/linux/fs.h:1851 [inline] do_iter_readv_writev+0x20b/0x3b0 fs/read_write.c:735 do_iter_write+0x182/0x700 fs/read_write.c:861 vfs_writev+0x1aa/0x670 fs/read_write.c:934 do_writev+0x279/0x2f0 fs/read_write.c:977 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(rlock-AF_UNIX); lock(&u->lock/1); lock(rlock-AF_UNIX); lock(&u->lock/1); *** DEADLOCK *** 5 locks held by syz-executor.5/27889: #0: ffffffff8e0e14c8 (sock_diag_mutex){+.+.}-{3:3}, at: sock_diag_rcv+0x1b/0x40 net/core/sock_diag.c:279 #1: ffffffff8e0e1648 (sock_diag_table_mutex){+.+.}-{3:3}, at: __sock_diag_cmd net/core/sock_diag.c:233 [inline] #1: ffffffff8e0e1648 (sock_diag_table_mutex){+.+.}-{3:3}, at: sock_diag_rcv_msg+0x19f/0x440 net/core/sock_diag.c:269 #2: ffff88804c3bf688 (nlk_cb_mutex-SOCK_DIAG){+.+.}-{3:3}, at: netlink_dump+0xbe/0xc50 net/netlink/af_netlink.c:2244 #3: ffff88804452a858 (&net->unx.table.locks[i]){+.+.}-{2:2}, at: spin_lock include/linux/spinlock.h:350 [inline] #3: ffff88804452a858 (&net->unx.table.locks[i]){+.+.}-{2:2}, at: unix_diag_dump+0x1c3/0x730 net/unix/diag.c:214 #4: ffff88807759f1e8 (rlock-AF_UNIX){+.+.}-{2:2}, at: spin_lock include/linux/spinlock.h:350 [inline] #4: ffff88807759f1e8 (rlock-AF_UNIX){+.+.}-{2:2}, at: sk_diag_dump_icons net/unix/diag.c:69 [inline] #4: ffff88807759f1e8 (rlock-AF_UNIX){+.+.}-{2:2}, at: sk_diag_fill+0x909/0xfc0 net/unix/diag.c:157 stack backtrace: CPU: 1 PID: 27889 Comm: syz-executor.5 Not tainted 6.2.0-rc6-next-20230202-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/12/2023 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0xd9/0x150 lib/dump_stack.c:106 check_noncircular+0x25f/0x2e0 kernel/locking/lockdep.c:2188 check_prev_add kernel/locking/lockdep.c:3108 [inline] check_prevs_add kernel/locking/lockdep.c:3227 [inline] validate_chain kernel/locking/lockdep.c:3842 [inline] __lock_acquire+0x2f21/0x5df0 kernel/locking/lockdep.c:5074 lock_acquire.part.0+0x11c/0x370 kernel/locking/lockdep.c:5691 _raw_spin_lock_nested+0x34/0x40 kernel/locking/spinlock.c:378 sk_diag_dump_icons net/unix/diag.c:87 [inline] sk_diag_fill+0x9f5/0xfc0 net/unix/diag.c:157 sk_diag_dump net/unix/diag.c:196 [inline] unix_diag_dump+0x456/0x730 net/unix/diag.c:220 netlink_dump+0x570/0xc50 net/netlink/af_netlink.c:2296 __netlink_dump_start+0x64b/0x910 net/netlink/af_netlink.c:2401 netlink_dump_start include/linux/netlink.h:298 [inline] unix_diag_handler_dump net/unix/diag.c:319 [inline] unix_diag_handler_dump+0x654/0x9a0 net/unix/diag.c:308 __sock_diag_cmd net/core/sock_diag.c:238 [inline] sock_diag_rcv_msg+0x31e/0x440 net/core/sock_diag.c:269 netlink_rcv_skb+0x165/0x440 net/netlink/af_netlink.c:2574 sock_diag_rcv+0x2a/0x40 net/core/sock_diag.c:280 netlink_unicast_kernel net/netlink/af_netlink.c:1339 [inline] netlink_unicast+0x547/0x7f0 net/netlink/af_netlink.c:1365 netlink_sendmsg+0x925/0xe30 net/netlink/af_netlink.c:1942 sock_sendmsg_nosec net/socket.c:722 [inline] sock_sendmsg+0xde/0x190 net/socket.c:745 sock_write_iter+0x295/0x3d0 net/socket.c:1133 call_write_iter include/linux/fs.h:1851 [inline] do_iter_readv_writev+0x20b/0x3b0 fs/read_write.c:735 do_iter_write+0x182/0x700 fs/read_write.c:861 vfs_writev+0x1aa/0x670 fs/read_write.c:934 do_writev+0x279/0x2f0 fs/read_write.c:977 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd RIP: 0033:0x7f4ab548c0c9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 19 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f4ab3ffe168 EFLAGS: 00000246 ORIG_RAX: 0000000000000014 RAX: ffffffffffffffda RBX: 00007f4ab55abf80 RCX: 00007f4ab548c0c9 RDX: 0000000000000001 RSI: 00000000200000c0 RDI: 0000000000000006 RBP: 00007f4ab54e7ae9 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 00007ffcbb02533f R14: 00007f4ab3ffe300 R15: 0000000000022000