======================================================
WARNING: possible circular locking dependency detected
6.15.0-rc1-syzkaller-g0af2f6be1b42 #0 Not tainted
------------------------------------------------------
syz-executor/6471 is trying to acquire lock:
ffff0000d4b30948 ((wq_completion)ocfs2_wq){+.+.}-{0:0}, at: touch_wq_lockdep_map+0x70/0x164 kernel/workqueue.c:3904

but task is already holding lock:
ffff0000d30720e0 (&type->s_umount_key#50){++++}-{4:4}, at: __super_lock fs/super.c:56 [inline]
ffff0000d30720e0 (&type->s_umount_key#50){++++}-{4:4}, at: __super_lock_excl fs/super.c:71 [inline]
ffff0000d30720e0 (&type->s_umount_key#50){++++}-{4:4}, at: deactivate_super+0xd8/0x100 fs/super.c:505

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (&type->s_umount_key#50){++++}-{4:4}:
       down_read+0x58/0x2fc kernel/locking/rwsem.c:1524
       ocfs2_finish_quota_recovery+0x198/0x1f94 fs/ocfs2/quota_local.c:603
       ocfs2_complete_recovery+0x15fc/0x2354 fs/ocfs2/journal.c:1357
       process_one_work+0x810/0x1638 kernel/workqueue.c:3238
       process_scheduled_works kernel/workqueue.c:3319 [inline]
       worker_thread+0x97c/0xf08 kernel/workqueue.c:3400
       kthread+0x674/0x7dc kernel/kthread.c:464
       ret_from_fork+0x10/0x20 arch/arm64/kernel/entry.S:862

-> #1 ((work_completion)(&journal->j_recovery_work)){+.+.}-{0:0}:
       process_one_work+0x730/0x1638 kernel/workqueue.c:3214
       process_scheduled_works kernel/workqueue.c:3319 [inline]
       worker_thread+0x97c/0xf08 kernel/workqueue.c:3400
       kthread+0x674/0x7dc kernel/kthread.c:464
       ret_from_fork+0x10/0x20 arch/arm64/kernel/entry.S:862

-> #0 ((wq_completion)ocfs2_wq){+.+.}-{0:0}:
       check_prev_add kernel/locking/lockdep.c:3166 [inline]
       check_prevs_add kernel/locking/lockdep.c:3285 [inline]
       validate_chain kernel/locking/lockdep.c:3909 [inline]
       __lock_acquire+0x17b8/0x32c4 kernel/locking/lockdep.c:5235
       lock_acquire+0x150/0x2e8 kernel/locking/lockdep.c:5866
       touch_wq_lockdep_map+0xa8/0x164 kernel/workqueue.c:3907
       __flush_workqueue+0x120/0x1234 kernel/workqueue.c:3949
       ocfs2_shutdown_local_alloc+0x104/0x8d8 fs/ocfs2/localalloc.c:380
       ocfs2_dismount_volume+0x1f4/0x920 fs/ocfs2/super.c:1822
       ocfs2_put_super+0xec/0x368 fs/ocfs2/super.c:1553
       generic_shutdown_super+0x12c/0x2bc fs/super.c:642
       kill_block_super+0x44/0x90 fs/super.c:1710
       deactivate_locked_super+0xc4/0x12c fs/super.c:473
       deactivate_super+0xe0/0x100 fs/super.c:506
       cleanup_mnt+0x34c/0x3dc fs/namespace.c:1435
       __cleanup_mnt+0x20/0x30 fs/namespace.c:1442
       task_work_run+0x230/0x2e0 kernel/task_work.c:227
       resume_user_mode_work include/linux/resume_user_mode.h:50 [inline]
       do_notify_resume+0x178/0x1f4 arch/arm64/kernel/entry-common.c:151
       exit_to_user_mode_prepare arch/arm64/kernel/entry-common.c:169 [inline]
       exit_to_user_mode arch/arm64/kernel/entry-common.c:178 [inline]
       el0_svc+0xac/0x168 arch/arm64/kernel/entry-common.c:745
       el0t_64_sync_handler+0x84/0x108 arch/arm64/kernel/entry-common.c:762
       el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600

other info that might help us debug this:

Chain exists of:
  (wq_completion)ocfs2_wq --> (work_completion)(&journal->j_recovery_work) --> &type->s_umount_key#50

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&type->s_umount_key#50);
                               lock((work_completion)(&journal->j_recovery_work));
                               lock(&type->s_umount_key#50);
  lock((wq_completion)ocfs2_wq);

 *** DEADLOCK ***

1 lock held by syz-executor/6471:
 #0: ffff0000d30720e0 (&type->s_umount_key#50){++++}-{4:4}, at: __super_lock fs/super.c:56 [inline]
 #0: ffff0000d30720e0 (&type->s_umount_key#50){++++}-{4:4}, at: __super_lock_excl fs/super.c:71 [inline]
 #0: ffff0000d30720e0 (&type->s_umount_key#50){++++}-{4:4}, at: deactivate_super+0xd8/0x100 fs/super.c:505

stack backtrace:
CPU: 0 UID: 0 PID: 6471 Comm: syz-executor Not tainted 6.15.0-rc1-syzkaller-g0af2f6be1b42 #0 PREEMPT 
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/12/2025
Call trace:
 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:466 (C)
 __dump_stack lib/dump_stack.c:94 [inline]
 dump_stack_lvl+0xe4/0x150 lib/dump_stack.c:120
 dump_stack+0x1c/0x28 lib/dump_stack.c:129
 print_circular_bug+0x32c/0x334 kernel/locking/lockdep.c:2079
 check_noncircular+0x15c/0x178 kernel/locking/lockdep.c:2211
 check_prev_add kernel/locking/lockdep.c:3166 [inline]
 check_prevs_add kernel/locking/lockdep.c:3285 [inline]
 validate_chain kernel/locking/lockdep.c:3909 [inline]
 __lock_acquire+0x17b8/0x32c4 kernel/locking/lockdep.c:5235
 lock_acquire+0x150/0x2e8 kernel/locking/lockdep.c:5866
 touch_wq_lockdep_map+0xa8/0x164 kernel/workqueue.c:3907
 __flush_workqueue+0x120/0x1234 kernel/workqueue.c:3949
 ocfs2_shutdown_local_alloc+0x104/0x8d8 fs/ocfs2/localalloc.c:380
 ocfs2_dismount_volume+0x1f4/0x920 fs/ocfs2/super.c:1822
 ocfs2_put_super+0xec/0x368 fs/ocfs2/super.c:1553
 generic_shutdown_super+0x12c/0x2bc fs/super.c:642
 kill_block_super+0x44/0x90 fs/super.c:1710
 deactivate_locked_super+0xc4/0x12c fs/super.c:473
 deactivate_super+0xe0/0x100 fs/super.c:506
 cleanup_mnt+0x34c/0x3dc fs/namespace.c:1435
 __cleanup_mnt+0x20/0x30 fs/namespace.c:1442
 task_work_run+0x230/0x2e0 kernel/task_work.c:227
 resume_user_mode_work include/linux/resume_user_mode.h:50 [inline]
 do_notify_resume+0x178/0x1f4 arch/arm64/kernel/entry-common.c:151
 exit_to_user_mode_prepare arch/arm64/kernel/entry-common.c:169 [inline]
 exit_to_user_mode arch/arm64/kernel/entry-common.c:178 [inline]
 el0_svc+0xac/0x168 arch/arm64/kernel/entry-common.c:745
 el0t_64_sync_handler+0x84/0x108 arch/arm64/kernel/entry-common.c:762
 el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600
ocfs2: Unmounting device (7,0) on (node local)
XFS (loop0): Unmounting Filesystem c496e05e-540d-4c72-b591-04d79d8b4eeb