====================================================== WARNING: possible circular locking dependency detected 6.2.0-syzkaller-13563-gf915322fe014 #0 Not tainted ------------------------------------------------------ syz-executor.5/8608 is trying to acquire lock: ffff88802c0ce170 (&journal->j_barrier){+.+.}-{3:3}, at: jbd2_journal_lock_updates+0x2b4/0x380 fs/jbd2/transaction.c:904 but task is already holding lock: ffff88802c0ccb98 (&sbi->s_writepages_rwsem){++++}-{0:0}, at: ext4_change_inode_journal_flag+0x19e/0x6c0 fs/ext4/inode.c:6155 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #3 (&sbi->s_writepages_rwsem){++++}-{0:0}: lock_acquire+0x23e/0x630 kernel/locking/lockdep.c:5669 percpu_down_read+0x44/0x1a0 include/linux/percpu-rwsem.h:51 ext4_writepages+0x1dd/0x290 fs/ext4/inode.c:2963 do_writepages+0x3a6/0x670 mm/page-writeback.c:2551 filemap_fdatawrite_wbc+0x125/0x180 mm/filemap.c:390 __filemap_fdatawrite_range mm/filemap.c:423 [inline] filemap_write_and_wait_range+0x1d4/0x2c0 mm/filemap.c:678 __iomap_dio_rw+0xae6/0x20d0 fs/iomap/direct-io.c:566 iomap_dio_rw+0x46/0xa0 fs/iomap/direct-io.c:683 ext4_dio_read_iter fs/ext4/file.c:94 [inline] ext4_file_read_iter+0x50f/0x670 fs/ext4/file.c:145 call_read_iter include/linux/fs.h:1845 [inline] generic_file_splice_read+0x240/0x640 fs/splice.c:402 do_splice_to fs/splice.c:885 [inline] splice_direct_to_actor+0x40c/0xbd0 fs/splice.c:957 do_splice_direct+0x283/0x3d0 fs/splice.c:1066 do_sendfile+0x620/0xff0 fs/read_write.c:1255 __do_sys_sendfile64 fs/read_write.c:1323 [inline] __se_sys_sendfile64+0x17c/0x1e0 fs/read_write.c:1309 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #2 (&sb->s_type->i_mutex_key#7){++++}-{3:3}: lock_acquire+0x23e/0x630 kernel/locking/lockdep.c:5669 down_read+0x3d/0x50 kernel/locking/rwsem.c:1520 inode_lock_shared include/linux/fs.h:768 [inline] ext4_bmap+0x4f/0x410 fs/ext4/inode.c:3242 bmap+0xa5/0xe0 fs/inode.c:1799 jbd2_journal_bmap fs/jbd2/journal.c:976 [inline] __jbd2_journal_erase fs/jbd2/journal.c:1788 [inline] jbd2_journal_flush+0x5b9/0xc40 fs/jbd2/journal.c:2491 ext4_ioctl_checkpoint fs/ext4/ioctl.c:1079 [inline] __ext4_ioctl fs/ext4/ioctl.c:1587 [inline] ext4_ioctl+0x3abc/0x6260 fs/ext4/ioctl.c:1607 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:870 [inline] __se_sys_ioctl+0xf1/0x160 fs/ioctl.c:856 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #1 (&journal->j_checkpoint_mutex){+.+.}-{3:3}: lock_acquire+0x23e/0x630 kernel/locking/lockdep.c:5669 __mutex_lock_common+0x1d8/0x2530 kernel/locking/mutex.c:603 mutex_lock_io_nested+0x47/0x60 kernel/locking/mutex.c:833 jbd2_journal_flush+0x29f/0xc40 fs/jbd2/journal.c:2463 ext4_ioctl_checkpoint fs/ext4/ioctl.c:1079 [inline] __ext4_ioctl fs/ext4/ioctl.c:1587 [inline] ext4_ioctl+0x3abc/0x6260 fs/ext4/ioctl.c:1607 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:870 [inline] __se_sys_ioctl+0xf1/0x160 fs/ioctl.c:856 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #0 (&journal->j_barrier){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3098 [inline] check_prevs_add kernel/locking/lockdep.c:3217 [inline] validate_chain+0x166b/0x58e0 kernel/locking/lockdep.c:3832 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5056 lock_acquire+0x23e/0x630 kernel/locking/lockdep.c:5669 __mutex_lock_common+0x1d8/0x2530 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x1b/0x20 kernel/locking/mutex.c:799 jbd2_journal_lock_updates+0x2b4/0x380 fs/jbd2/transaction.c:904 ext4_change_inode_journal_flag+0x1a6/0x6c0 fs/ext4/inode.c:6156 ext4_ioctl_setflags fs/ext4/ioctl.c:684 [inline] ext4_fileattr_set+0xe17/0x1790 fs/ext4/ioctl.c:1001 vfs_fileattr_set+0x8f7/0xd40 fs/ioctl.c:696 ioctl_setflags fs/ioctl.c:728 [inline] do_vfs_ioctl+0x1e47/0x2b10 fs/ioctl.c:839 __do_sys_ioctl fs/ioctl.c:868 [inline] __se_sys_ioctl+0x81/0x160 fs/ioctl.c:856 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd other info that might help us debug this: Chain exists of: &journal->j_barrier --> &sb->s_type->i_mutex_key#7 --> &sbi->s_writepages_rwsem Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&sbi->s_writepages_rwsem); lock(&sb->s_type->i_mutex_key#7); lock(&sbi->s_writepages_rwsem); lock(&journal->j_barrier); *** DEADLOCK *** 4 locks held by syz-executor.5/8608: #0: ffff88802c0ca460 (sb_writers#4){.+.+}-{0:0}, at: mnt_want_write_file+0x5e/0x1f0 fs/namespace.c:438 #1: ffff88803577de48 (&sb->s_type->i_mutex_key#7){++++}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline] #1: ffff88803577de48 (&sb->s_type->i_mutex_key#7){++++}-{3:3}, at: vfs_fileattr_set+0x139/0xd40 fs/ioctl.c:681 #2: ffff88803577dfe8 (mapping.invalidate_lock){++++}-{3:3}, at: filemap_invalidate_lock include/linux/fs.h:803 [inline] #2: ffff88803577dfe8 (mapping.invalidate_lock){++++}-{3:3}, at: ext4_change_inode_journal_flag+0x110/0x6c0 fs/ext4/inode.c:6147 #3: ffff88802c0ccb98 (&sbi->s_writepages_rwsem){++++}-{0:0}, at: ext4_change_inode_journal_flag+0x19e/0x6c0 fs/ext4/inode.c:6155 stack backtrace: CPU: 0 PID: 8608 Comm: syz-executor.5 Not tainted 6.2.0-syzkaller-13563-gf915322fe014 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/02/2023 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e7/0x2d0 lib/dump_stack.c:106 check_noncircular+0x2fe/0x3b0 kernel/locking/lockdep.c:2178 check_prev_add kernel/locking/lockdep.c:3098 [inline] check_prevs_add kernel/locking/lockdep.c:3217 [inline] validate_chain+0x166b/0x58e0 kernel/locking/lockdep.c:3832 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5056 lock_acquire+0x23e/0x630 kernel/locking/lockdep.c:5669 __mutex_lock_common+0x1d8/0x2530 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x1b/0x20 kernel/locking/mutex.c:799 jbd2_journal_lock_updates+0x2b4/0x380 fs/jbd2/transaction.c:904 ext4_change_inode_journal_flag+0x1a6/0x6c0 fs/ext4/inode.c:6156 ext4_ioctl_setflags fs/ext4/ioctl.c:684 [inline] ext4_fileattr_set+0xe17/0x1790 fs/ext4/ioctl.c:1001 vfs_fileattr_set+0x8f7/0xd40 fs/ioctl.c:696 ioctl_setflags fs/ioctl.c:728 [inline] do_vfs_ioctl+0x1e47/0x2b10 fs/ioctl.c:839 __do_sys_ioctl fs/ioctl.c:868 [inline] __se_sys_ioctl+0x81/0x160 fs/ioctl.c:856 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd RIP: 0033:0x7fc76308c0f9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 19 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007fc763dde168 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 RAX: ffffffffffffffda RBX: 00007fc7631abf80 RCX: 00007fc76308c0f9 RDX: 0000000020000380 RSI: 0000000040086602 RDI: 0000000000000003 RBP: 00007fc7630e7ae9 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 00007ffc4e591e2f R14: 00007fc763dde300 R15: 0000000000022000