====================================================== WARNING: possible circular locking dependency detected 5.15.167-syzkaller #0 Not tainted ------------------------------------------------------ syz.2.426/6652 is trying to acquire lock: ffff0000e5d7e0e0 (&ni->ni_lock/4){+.+.}-{3:3}, at: ni_lock fs/ntfs3/ntfs_fs.h:1100 [inline] ffff0000e5d7e0e0 (&ni->ni_lock/4){+.+.}-{3:3}, at: mi_read+0x26c/0x4d8 fs/ntfs3/record.c:148 but task is already holding lock: ffff0000e5d79e80 (&ni->ni_lock){+.+.}-{3:3}, at: ni_trylock fs/ntfs3/ntfs_fs.h:1115 [inline] ffff0000e5d79e80 (&ni->ni_lock){+.+.}-{3:3}, at: ni_write_inode+0x12c/0xe38 fs/ntfs3/frecord.c:3198 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&ni->ni_lock){+.+.}-{3:3}: __mutex_lock_common+0x194/0x2154 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0xa4/0xf8 kernel/locking/mutex.c:743 ntfs_set_state+0x1a4/0x584 fs/ntfs3/fsntfs.c:925 ni_remove_name+0x230/0x7a4 fs/ntfs3/frecord.c:2880 ntfs_unlink_inode+0x31c/0x670 fs/ntfs3/inode.c:1753 ntfs_unlink+0x3c/0x60 fs/ntfs3/namei.c:184 vfs_unlink+0x2f0/0x508 fs/namei.c:4280 do_unlinkat+0x4cc/0x830 fs/namei.c:4348 __do_sys_unlinkat fs/namei.c:4391 [inline] __se_sys_unlinkat fs/namei.c:4384 [inline] __arm64_sys_unlinkat+0xcc/0xfc fs/namei.c:4384 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 -> #0 (&ni->ni_lock/4){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain kernel/locking/lockdep.c:3788 [inline] __lock_acquire+0x32d4/0x7638 kernel/locking/lockdep.c:5012 lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5623 __mutex_lock_common+0x194/0x2154 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0xa4/0xf8 kernel/locking/mutex.c:743 ni_lock fs/ntfs3/ntfs_fs.h:1100 [inline] mi_read+0x26c/0x4d8 fs/ntfs3/record.c:148 ntfs_read_mft fs/ntfs3/inode.c:69 [inline] ntfs_iget5+0x358/0x2be0 fs/ntfs3/inode.c:525 ni_update_parent+0x6f0/0xac8 fs/ntfs3/frecord.c:3154 ni_write_inode+0x8a0/0xe38 fs/ntfs3/frecord.c:3252 ntfs3_write_inode+0x70/0x98 fs/ntfs3/inode.c:1037 write_inode fs/fs-writeback.c:1495 [inline] __writeback_single_inode+0x584/0x13a4 fs/fs-writeback.c:1705 writeback_single_inode+0x1c0/0x79c fs/fs-writeback.c:1760 sync_inode_metadata+0xc0/0x124 fs/fs-writeback.c:2820 __generic_file_fsync+0x13c/0x19c fs/libfs.c:1115 generic_file_fsync+0x7c/0xf8 fs/libfs.c:1145 vfs_fsync_range+0x168/0x188 fs/sync.c:188 generic_write_sync include/linux/fs.h:2989 [inline] ntfs_file_write_iter+0x3d4/0x49c fs/ntfs3/file.c:1149 do_iter_readv_writev+0x420/0x5f8 do_iter_write+0x1b8/0x66c fs/read_write.c:855 vfs_iter_write+0x88/0xac fs/read_write.c:896 iter_file_splice_write+0x618/0xc48 fs/splice.c:689 do_splice_from fs/splice.c:767 [inline] direct_splice_actor+0xe4/0x1c0 fs/splice.c:936 splice_direct_to_actor+0x408/0x9a0 fs/splice.c:891 do_splice_direct+0x1f4/0x334 fs/splice.c:979 do_sendfile+0x4c0/0xcb0 fs/read_write.c:1249 __do_sys_sendfile64 fs/read_write.c:1317 [inline] __se_sys_sendfile64 fs/read_write.c:1303 [inline] __arm64_sys_sendfile64+0x160/0x408 fs/read_write.c:1303 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ni->ni_lock); lock(&ni->ni_lock/4); lock(&ni->ni_lock); lock(&ni->ni_lock/4); *** DEADLOCK *** 3 locks held by syz.2.426/6652: #0: ffff0000dd4b4460 (sb_writers#21){.+.+}-{0:0}, at: do_sendfile+0x4a4/0xcb0 fs/read_write.c:1248 #1: ffff0000e5d7a120 (&sb->s_type->i_mutex_key#26){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline] #1: ffff0000e5d7a120 (&sb->s_type->i_mutex_key#26){+.+.}-{3:3}, at: __generic_file_fsync+0xa4/0x19c fs/libfs.c:1108 #2: ffff0000e5d79e80 (&ni->ni_lock){+.+.}-{3:3}, at: ni_trylock fs/ntfs3/ntfs_fs.h:1115 [inline] #2: ffff0000e5d79e80 (&ni->ni_lock){+.+.}-{3:3}, at: ni_write_inode+0x12c/0xe38 fs/ntfs3/frecord.c:3198 stack backtrace: CPU: 0 PID: 6652 Comm: syz.2.426 Not tainted 5.15.167-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 08/06/2024 Call trace: dump_backtrace+0x0/0x530 arch/arm64/kernel/stacktrace.c:152 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:216 __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106 dump_stack+0x1c/0x58 lib/dump_stack.c:113 print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2011 check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2133 check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain kernel/locking/lockdep.c:3788 [inline] __lock_acquire+0x32d4/0x7638 kernel/locking/lockdep.c:5012 lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5623 __mutex_lock_common+0x194/0x2154 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0xa4/0xf8 kernel/locking/mutex.c:743 ni_lock fs/ntfs3/ntfs_fs.h:1100 [inline] mi_read+0x26c/0x4d8 fs/ntfs3/record.c:148 ntfs_read_mft fs/ntfs3/inode.c:69 [inline] ntfs_iget5+0x358/0x2be0 fs/ntfs3/inode.c:525 ni_update_parent+0x6f0/0xac8 fs/ntfs3/frecord.c:3154 ni_write_inode+0x8a0/0xe38 fs/ntfs3/frecord.c:3252 ntfs3_write_inode+0x70/0x98 fs/ntfs3/inode.c:1037 write_inode fs/fs-writeback.c:1495 [inline] __writeback_single_inode+0x584/0x13a4 fs/fs-writeback.c:1705 writeback_single_inode+0x1c0/0x79c fs/fs-writeback.c:1760 sync_inode_metadata+0xc0/0x124 fs/fs-writeback.c:2820 __generic_file_fsync+0x13c/0x19c fs/libfs.c:1115 generic_file_fsync+0x7c/0xf8 fs/libfs.c:1145 vfs_fsync_range+0x168/0x188 fs/sync.c:188 generic_write_sync include/linux/fs.h:2989 [inline] ntfs_file_write_iter+0x3d4/0x49c fs/ntfs3/file.c:1149 do_iter_readv_writev+0x420/0x5f8 do_iter_write+0x1b8/0x66c fs/read_write.c:855 vfs_iter_write+0x88/0xac fs/read_write.c:896 iter_file_splice_write+0x618/0xc48 fs/splice.c:689 do_splice_from fs/splice.c:767 [inline] direct_splice_actor+0xe4/0x1c0 fs/splice.c:936 splice_direct_to_actor+0x408/0x9a0 fs/splice.c:891 do_splice_direct+0x1f4/0x334 fs/splice.c:979 do_sendfile+0x4c0/0xcb0 fs/read_write.c:1249 __do_sys_sendfile64 fs/read_write.c:1317 [inline] __se_sys_sendfile64 fs/read_write.c:1303 [inline] __arm64_sys_sendfile64+0x160/0x408 fs/read_write.c:1303 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 ntfs3: loop2: ino=1e, "file1" failed to open parent directory r=30005 to update