ntfs3: loop2: Mark volume as dirty due to NTFS errors ====================================================== WARNING: possible circular locking dependency detected 6.1.93-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.2/6950 is trying to acquire lock: ffff0000f1a09e80 (&ni->ni_lock/4){+.+.}-{3:3}, at: ni_lock fs/ntfs3/ntfs_fs.h:1099 [inline] ffff0000f1a09e80 (&ni->ni_lock/4){+.+.}-{3:3}, at: mi_read+0x26c/0x4d8 fs/ntfs3/record.c:148 but task is already holding lock: ffff0000f1a0e0e0 (&ni->ni_lock){+.+.}-{3:3}, at: ni_trylock fs/ntfs3/ntfs_fs.h:1114 [inline] ffff0000f1a0e0e0 (&ni->ni_lock){+.+.}-{3:3}, at: ni_write_inode+0x12c/0xe3c fs/ntfs3/frecord.c:3252 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&ni->ni_lock){+.+.}-{3:3}: __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799 ntfs_set_state+0x1a4/0x584 fs/ntfs3/fsntfs.c:920 ni_find_attr+0x5f8/0x7b8 fs/ntfs3/frecord.c:239 attr_set_size+0x3b4/0x3430 fs/ntfs3/attrib.c:433 ntfs_set_ea+0x7ac/0x1280 fs/ntfs3/xattr.c:455 ntfs_setxattr+0x17c/0x724 fs/ntfs3/xattr.c:951 __vfs_setxattr+0x388/0x3a4 fs/xattr.c:182 __vfs_setxattr_noperm+0x110/0x528 fs/xattr.c:216 __vfs_setxattr_locked+0x1ec/0x218 fs/xattr.c:277 vfs_setxattr+0x1a8/0x344 fs/xattr.c:309 do_setxattr fs/xattr.c:594 [inline] setxattr+0x230/0x294 fs/xattr.c:617 path_setxattr+0x17c/0x258 fs/xattr.c:636 __do_sys_lsetxattr fs/xattr.c:659 [inline] __se_sys_lsetxattr fs/xattr.c:655 [inline] __arm64_sys_lsetxattr+0xbc/0xd8 fs/xattr.c:655 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 -> #0 (&ni->ni_lock/4){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain kernel/locking/lockdep.c:3825 [inline] __lock_acquire+0x3338/0x7680 kernel/locking/lockdep.c:5049 lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5662 __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799 ni_lock fs/ntfs3/ntfs_fs.h:1099 [inline] mi_read+0x26c/0x4d8 fs/ntfs3/record.c:148 ntfs_read_mft fs/ntfs3/inode.c:69 [inline] ntfs_iget5+0x360/0x2be8 fs/ntfs3/inode.c:525 ni_update_parent+0x6f0/0xac8 fs/ntfs3/frecord.c:3208 ni_write_inode+0x8a0/0xe3c fs/ntfs3/frecord.c:3306 ntfs3_write_inode+0x70/0x98 fs/ntfs3/inode.c:1031 write_inode fs/fs-writeback.c:1460 [inline] __writeback_single_inode+0x614/0x1770 fs/fs-writeback.c:1677 writeback_single_inode+0x1c0/0x79c fs/fs-writeback.c:1733 sync_inode_metadata+0xd4/0x144 fs/fs-writeback.c:2789 __generic_file_fsync+0x13c/0x19c fs/libfs.c:1143 generic_file_fsync+0x7c/0xf8 fs/libfs.c:1173 vfs_fsync_range+0x168/0x188 fs/sync.c:188 generic_write_sync include/linux/fs.h:2957 [inline] ntfs_file_write_iter+0x49c/0x580 fs/ntfs3/file.c:1172 do_iter_write+0x534/0x964 fs/read_write.c:861 vfs_writev fs/read_write.c:934 [inline] do_pwritev+0x1ec/0x334 fs/read_write.c:1031 __do_sys_pwritev2 fs/read_write.c:1090 [inline] __se_sys_pwritev2 fs/read_write.c:1081 [inline] __arm64_sys_pwritev2+0xd4/0x108 fs/read_write.c:1081 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ni->ni_lock); lock(&ni->ni_lock/4); lock(&ni->ni_lock); lock(&ni->ni_lock/4); *** DEADLOCK *** 3 locks held by syz-executor.2/6950: #0: ffff0000f1d7a460 (sb_writers#12){.+.+}-{0:0}, at: vfs_writev fs/read_write.c:933 [inline] #0: ffff0000f1d7a460 (sb_writers#12){.+.+}-{0:0}, at: do_pwritev+0x1d8/0x334 fs/read_write.c:1031 #1: ffff0000f1a0e380 (&sb->s_type->i_mutex_key#29){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline] #1: ffff0000f1a0e380 (&sb->s_type->i_mutex_key#29){+.+.}-{3:3}, at: __generic_file_fsync+0xa4/0x19c fs/libfs.c:1136 #2: ffff0000f1a0e0e0 (&ni->ni_lock){+.+.}-{3:3}, at: ni_trylock fs/ntfs3/ntfs_fs.h:1114 [inline] #2: ffff0000f1a0e0e0 (&ni->ni_lock){+.+.}-{3:3}, at: ni_write_inode+0x12c/0xe3c fs/ntfs3/frecord.c:3252 stack backtrace: CPU: 1 PID: 6950 Comm: syz-executor.2 Not tainted 6.1.93-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 04/02/2024 Call trace: dump_backtrace+0x1c8/0x1f4 arch/arm64/kernel/stacktrace.c:158 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:165 __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106 dump_stack+0x1c/0x58 lib/dump_stack.c:113 print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2048 check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2170 check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain kernel/locking/lockdep.c:3825 [inline] __lock_acquire+0x3338/0x7680 kernel/locking/lockdep.c:5049 lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5662 __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799 ni_lock fs/ntfs3/ntfs_fs.h:1099 [inline] mi_read+0x26c/0x4d8 fs/ntfs3/record.c:148 ntfs_read_mft fs/ntfs3/inode.c:69 [inline] ntfs_iget5+0x360/0x2be8 fs/ntfs3/inode.c:525 ni_update_parent+0x6f0/0xac8 fs/ntfs3/frecord.c:3208 ni_write_inode+0x8a0/0xe3c fs/ntfs3/frecord.c:3306 ntfs3_write_inode+0x70/0x98 fs/ntfs3/inode.c:1031 write_inode fs/fs-writeback.c:1460 [inline] __writeback_single_inode+0x614/0x1770 fs/fs-writeback.c:1677 writeback_single_inode+0x1c0/0x79c fs/fs-writeback.c:1733 sync_inode_metadata+0xd4/0x144 fs/fs-writeback.c:2789 __generic_file_fsync+0x13c/0x19c fs/libfs.c:1143 generic_file_fsync+0x7c/0xf8 fs/libfs.c:1173 vfs_fsync_range+0x168/0x188 fs/sync.c:188 generic_write_sync include/linux/fs.h:2957 [inline] ntfs_file_write_iter+0x49c/0x580 fs/ntfs3/file.c:1172 do_iter_write+0x534/0x964 fs/read_write.c:861 vfs_writev fs/read_write.c:934 [inline] do_pwritev+0x1ec/0x334 fs/read_write.c:1031 __do_sys_pwritev2 fs/read_write.c:1090 [inline] __se_sys_pwritev2 fs/read_write.c:1081 [inline] __arm64_sys_pwritev2+0xd4/0x108 fs/read_write.c:1081 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637