hfsplus: inconsistency in B*Tree (1792,1,255,1,0) hfsplus: xattr searching failed hfsplus: inconsistency in B*Tree (1792,1,255,1,0) ====================================================== WARNING: possible circular locking dependency detected 6.6.0-rc7-syzkaller-g8de1e7afcc1c #0 Not tainted ------------------------------------------------------ syz-executor204/6092 is trying to acquire lock: ffff0000d5728e88 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_extend+0x1d0/0x1544 fs/hfsplus/extents.c:457 but task is already holding lock: ffff0000d5d720b0 (&tree->tree_lock/2){+.+.}-{3:3}, at: hfsplus_find_init+0x144/0x1bc which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&tree->tree_lock/2){+.+.}-{3:3}: __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x2c/0x38 kernel/locking/mutex.c:799 hfsplus_find_init+0x144/0x1bc hfsplus_attr_exists+0xf8/0x1c8 fs/hfsplus/attributes.c:178 __hfsplus_setxattr+0x384/0x1d00 fs/hfsplus/xattr.c:336 hfsplus_setxattr+0xb4/0xec fs/hfsplus/xattr.c:434 hfsplus_trusted_setxattr+0x54/0x6c fs/hfsplus/xattr_trusted.c:30 __vfs_setxattr+0x3d8/0x400 fs/xattr.c:201 __vfs_setxattr_noperm+0x110/0x528 fs/xattr.c:235 __vfs_setxattr_locked+0x1ec/0x218 fs/xattr.c:296 vfs_setxattr+0x1a8/0x344 fs/xattr.c:322 do_setxattr fs/xattr.c:630 [inline] setxattr+0x208/0x29c fs/xattr.c:653 path_setxattr+0x17c/0x258 fs/xattr.c:672 __do_sys_lsetxattr fs/xattr.c:695 [inline] __se_sys_lsetxattr fs/xattr.c:691 [inline] __arm64_sys_lsetxattr+0xbc/0xd8 fs/xattr.c:691 __invoke_syscall arch/arm64/kernel/syscall.c:37 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:51 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:136 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:155 el0_svc+0x54/0x158 arch/arm64/kernel/entry-common.c:678 el0t_64_sync_handler+0x84/0xfc arch/arm64/kernel/entry-common.c:696 el0t_64_sync+0x190/0x194 arch/arm64/kernel/entry.S:595 -> #1 (&tree->tree_lock){+.+.}-{3:3}: __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x2c/0x38 kernel/locking/mutex.c:799 hfsplus_file_truncate+0x6d0/0x9b8 fs/hfsplus/extents.c:595 hfsplus_setattr+0x18c/0x248 fs/hfsplus/inode.c:269 notify_change+0x9d4/0xc8c fs/attr.c:499 do_truncate+0x1c0/0x28c fs/open.c:66 handle_truncate fs/namei.c:3299 [inline] do_open fs/namei.c:3644 [inline] path_openat+0x2130/0x27f8 fs/namei.c:3797 do_filp_open+0x1bc/0x3cc fs/namei.c:3824 do_sys_openat2+0x124/0x1b8 fs/open.c:1422 do_sys_open fs/open.c:1437 [inline] __do_sys_openat fs/open.c:1453 [inline] __se_sys_openat fs/open.c:1448 [inline] __arm64_sys_openat+0x1f0/0x240 fs/open.c:1448 __invoke_syscall arch/arm64/kernel/syscall.c:37 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:51 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:136 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:155 el0_svc+0x54/0x158 arch/arm64/kernel/entry-common.c:678 el0t_64_sync_handler+0x84/0xfc arch/arm64/kernel/entry-common.c:696 el0t_64_sync+0x190/0x194 arch/arm64/kernel/entry.S:595 -> #0 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain kernel/locking/lockdep.c:3868 [inline] __lock_acquire+0x3370/0x75e8 kernel/locking/lockdep.c:5136 lock_acquire+0x23c/0x71c kernel/locking/lockdep.c:5753 __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x2c/0x38 kernel/locking/mutex.c:799 hfsplus_file_extend+0x1d0/0x1544 fs/hfsplus/extents.c:457 hfsplus_bmap_reserve+0xec/0x474 fs/hfsplus/btree.c:358 hfsplus_create_attr+0x1b0/0x568 fs/hfsplus/attributes.c:221 __hfsplus_setxattr+0x980/0x1d00 fs/hfsplus/xattr.c:354 hfsplus_setxattr+0xb4/0xec fs/hfsplus/xattr.c:434 hfsplus_trusted_setxattr+0x54/0x6c fs/hfsplus/xattr_trusted.c:30 __vfs_setxattr+0x3d8/0x400 fs/xattr.c:201 __vfs_setxattr_noperm+0x110/0x528 fs/xattr.c:235 __vfs_setxattr_locked+0x1ec/0x218 fs/xattr.c:296 vfs_setxattr+0x1a8/0x344 fs/xattr.c:322 do_setxattr fs/xattr.c:630 [inline] setxattr+0x208/0x29c fs/xattr.c:653 path_setxattr+0x17c/0x258 fs/xattr.c:672 __do_sys_lsetxattr fs/xattr.c:695 [inline] __se_sys_lsetxattr fs/xattr.c:691 [inline] __arm64_sys_lsetxattr+0xbc/0xd8 fs/xattr.c:691 __invoke_syscall arch/arm64/kernel/syscall.c:37 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:51 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:136 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:155 el0_svc+0x54/0x158 arch/arm64/kernel/entry-common.c:678 el0t_64_sync_handler+0x84/0xfc arch/arm64/kernel/entry-common.c:696 el0t_64_sync+0x190/0x194 arch/arm64/kernel/entry.S:595 other info that might help us debug this: Chain exists of: &HFSPLUS_I(inode)->extents_lock --> &tree->tree_lock --> &tree->tree_lock/2 Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&tree->tree_lock/2); lock(&tree->tree_lock); lock(&tree->tree_lock/2); lock(&HFSPLUS_I(inode)->extents_lock); *** DEADLOCK *** 4 locks held by syz-executor204/6092: #0: ffff0000d6044410 (sb_writers#8){.+.+}-{0:0}, at: mnt_want_write+0x44/0x9c fs/namespace.c:403 #1: ffff0000d572a4c0 (&sb->s_type->i_mutex_key#16){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:802 [inline] #1: ffff0000d572a4c0 (&sb->s_type->i_mutex_key#16){+.+.}-{3:3}, at: vfs_setxattr+0x17c/0x344 fs/xattr.c:321 #2: ffff0000d5d760b0 (&tree->tree_lock){+.+.}-{3:3}, at: hfsplus_find_init+0x144/0x1bc #3: ffff0000d5d720b0 (&tree->tree_lock/2){+.+.}-{3:3}, at: hfsplus_find_init+0x144/0x1bc stack backtrace: CPU: 0 PID: 6092 Comm: syz-executor204 Not tainted 6.6.0-rc7-syzkaller-g8de1e7afcc1c #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/06/2023 Call trace: dump_backtrace+0x1b8/0x1e4 arch/arm64/kernel/stacktrace.c:233 show_stack+0x2c/0x44 arch/arm64/kernel/stacktrace.c:240 __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0xd0/0x124 lib/dump_stack.c:106 dump_stack+0x1c/0x28 lib/dump_stack.c:113 print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2060 check_noncircular+0x310/0x404 kernel/locking/lockdep.c:2187 check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain kernel/locking/lockdep.c:3868 [inline] __lock_acquire+0x3370/0x75e8 kernel/locking/lockdep.c:5136 lock_acquire+0x23c/0x71c kernel/locking/lockdep.c:5753 __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x2c/0x38 kernel/locking/mutex.c:799 hfsplus_file_extend+0x1d0/0x1544 fs/hfsplus/extents.c:457 hfsplus_bmap_reserve+0xec/0x474 fs/hfsplus/btree.c:358 hfsplus_create_attr+0x1b0/0x568 fs/hfsplus/attributes.c:221 __hfsplus_setxattr+0x980/0x1d00 fs/hfsplus/xattr.c:354 hfsplus_setxattr+0xb4/0xec fs/hfsplus/xattr.c:434 hfsplus_trusted_setxattr+0x54/0x6c fs/hfsplus/xattr_trusted.c:30 __vfs_setxattr+0x3d8/0x400 fs/xattr.c:201 __vfs_setxattr_noperm+0x110/0x528 fs/xattr.c:235 __vfs_setxattr_locked+0x1ec/0x218 fs/xattr.c:296 vfs_setxattr+0x1a8/0x344 fs/xattr.c:322 do_setxattr fs/xattr.c:630 [inline] setxattr+0x208/0x29c fs/xattr.c:653 path_setxattr+0x17c/0x258 fs/xattr.c:672 __do_sys_lsetxattr fs/xattr.c:695 [inline] __se_sys_lsetxattr fs/xattr.c:691 [inline] __arm64_sys_lsetxattr+0xbc/0xd8 fs/xattr.c:691 __invoke_syscall arch/arm64/kernel/syscall.c:37 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:51 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:136 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:155 el0_svc+0x54/0x158 arch/arm64/kernel/entry-common.c:678 el0t_64_sync_handler+0x84/0xfc arch/arm64/kernel/entry-common.c:696 el0t_64_sync+0x190/0x194 arch/arm64/kernel/entry.S:595 hfsplus: inconsistency in B*Tree (2,0,1,0,1)