====================================================== WARNING: possible circular locking dependency detected 5.19.0-next-20220808-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.0/14002 is trying to acquire lock: ffff88814af0e3f8 (&journal->j_checkpoint_mutex){+.+.}-{3:3}, at: __jbd2_log_wait_for_space+0x234/0x460 fs/jbd2/checkpoint.c:110 but task is already holding lock: ffff8880518c7258 (&sb->s_type->i_mutex_key#8){++++}-{3:3}, at: inode_lock include/linux/fs.h:761 [inline] ffff8880518c7258 (&sb->s_type->i_mutex_key#8){++++}-{3:3}, at: ext4_buffered_write_iter+0xb0/0x460 fs/ext4/file.c:264 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&sb->s_type->i_mutex_key#8){++++}-{3:3}: down_read+0x98/0x450 kernel/locking/rwsem.c:1499 inode_lock_shared include/linux/fs.h:771 [inline] ext4_bmap+0x4e/0x460 fs/ext4/inode.c:3157 bmap+0xaa/0x120 fs/inode.c:1799 jbd2_journal_bmap+0xa8/0x180 fs/jbd2/journal.c:971 __jbd2_journal_erase fs/jbd2/journal.c:1784 [inline] jbd2_journal_flush+0x84f/0xc00 fs/jbd2/journal.c:2490 ext4_ioctl_checkpoint fs/ext4/ioctl.c:1082 [inline] __ext4_ioctl+0x28fd/0x4ab0 fs/ext4/ioctl.c:1586 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:870 [inline] __se_sys_ioctl fs/ioctl.c:856 [inline] __x64_sys_ioctl+0x193/0x200 fs/ioctl.c:856 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #0 (&journal->j_checkpoint_mutex){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3095 [inline] check_prevs_add kernel/locking/lockdep.c:3214 [inline] validate_chain kernel/locking/lockdep.c:3829 [inline] __lock_acquire+0x2a43/0x56d0 kernel/locking/lockdep.c:5053 lock_acquire kernel/locking/lockdep.c:5666 [inline] lock_acquire+0x1ab/0x570 kernel/locking/lockdep.c:5631 __mutex_lock_common kernel/locking/mutex.c:603 [inline] mutex_lock_io_nested+0x13f/0x1190 kernel/locking/mutex.c:833 __jbd2_log_wait_for_space+0x234/0x460 fs/jbd2/checkpoint.c:110 add_transaction_credits+0xa2d/0xb70 fs/jbd2/transaction.c:298 start_this_handle+0x3ae/0x14a0 fs/jbd2/transaction.c:422 jbd2__journal_start+0x38c/0x910 fs/jbd2/transaction.c:520 __ext4_journal_start_sb+0x3a3/0x490 fs/ext4/ext4_jbd2.c:105 __ext4_journal_start fs/ext4/ext4_jbd2.h:326 [inline] ext4_dirty_inode+0x9d/0x110 fs/ext4/inode.c:5963 __mark_inode_dirty+0x48b/0x1040 fs/fs-writeback.c:2381 mark_inode_dirty include/linux/fs.h:2467 [inline] generic_write_end+0x350/0x440 fs/buffer.c:2199 ext4_da_write_end+0x16e/0x9a0 fs/ext4/inode.c:3089 generic_perform_write+0x306/0x560 mm/filemap.c:3749 ext4_buffered_write_iter+0x15b/0x460 fs/ext4/file.c:270 ext4_file_write_iter+0x44a/0x1660 fs/ext4/file.c:679 call_write_iter include/linux/fs.h:2192 [inline] do_iter_readv_writev+0x20b/0x3b0 fs/read_write.c:729 do_iter_write+0x182/0x700 fs/read_write.c:855 vfs_iter_write+0x70/0xa0 fs/read_write.c:896 iter_file_splice_write+0x741/0xc90 fs/splice.c:686 do_splice_from fs/splice.c:764 [inline] direct_splice_actor+0x110/0x180 fs/splice.c:931 splice_direct_to_actor+0x331/0x8a0 fs/splice.c:886 do_splice_direct+0x1a7/0x270 fs/splice.c:974 do_sendfile+0xb19/0x1270 fs/read_write.c:1249 __do_sys_sendfile64 fs/read_write.c:1311 [inline] __se_sys_sendfile64 fs/read_write.c:1303 [inline] __x64_sys_sendfile64+0x149/0x210 fs/read_write.c:1303 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&sb->s_type->i_mutex_key#8); lock(&journal->j_checkpoint_mutex); lock(&sb->s_type->i_mutex_key#8); lock(&journal->j_checkpoint_mutex); *** DEADLOCK *** 2 locks held by syz-executor.0/14002: #0: ffff88814af0a460 (sb_writers#4){.+.+}-{0:0}, at: __do_sys_sendfile64 fs/read_write.c:1311 [inline] #0: ffff88814af0a460 (sb_writers#4){.+.+}-{0:0}, at: __se_sys_sendfile64 fs/read_write.c:1303 [inline] #0: ffff88814af0a460 (sb_writers#4){.+.+}-{0:0}, at: __x64_sys_sendfile64+0x149/0x210 fs/read_write.c:1303 #1: ffff8880518c7258 (&sb->s_type->i_mutex_key#8){++++}-{3:3}, at: inode_lock include/linux/fs.h:761 [inline] #1: ffff8880518c7258 (&sb->s_type->i_mutex_key#8){++++}-{3:3}, at: ext4_buffered_write_iter+0xb0/0x460 fs/ext4/file.c:264 stack backtrace: CPU: 0 PID: 14002 Comm: syz-executor.0 Not tainted 5.19.0-next-20220808-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/22/2022 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0xcd/0x134 lib/dump_stack.c:106 check_noncircular+0x25f/0x2e0 kernel/locking/lockdep.c:2175 check_prev_add kernel/locking/lockdep.c:3095 [inline] check_prevs_add kernel/locking/lockdep.c:3214 [inline] validate_chain kernel/locking/lockdep.c:3829 [inline] __lock_acquire+0x2a43/0x56d0 kernel/locking/lockdep.c:5053 lock_acquire kernel/locking/lockdep.c:5666 [inline] lock_acquire+0x1ab/0x570 kernel/locking/lockdep.c:5631 __mutex_lock_common kernel/locking/mutex.c:603 [inline] mutex_lock_io_nested+0x13f/0x1190 kernel/locking/mutex.c:833 __jbd2_log_wait_for_space+0x234/0x460 fs/jbd2/checkpoint.c:110 add_transaction_credits+0xa2d/0xb70 fs/jbd2/transaction.c:298 start_this_handle+0x3ae/0x14a0 fs/jbd2/transaction.c:422 jbd2__journal_start+0x38c/0x910 fs/jbd2/transaction.c:520 __ext4_journal_start_sb+0x3a3/0x490 fs/ext4/ext4_jbd2.c:105 __ext4_journal_start fs/ext4/ext4_jbd2.h:326 [inline] ext4_dirty_inode+0x9d/0x110 fs/ext4/inode.c:5963 __mark_inode_dirty+0x48b/0x1040 fs/fs-writeback.c:2381 mark_inode_dirty include/linux/fs.h:2467 [inline] generic_write_end+0x350/0x440 fs/buffer.c:2199 ext4_da_write_end+0x16e/0x9a0 fs/ext4/inode.c:3089 generic_perform_write+0x306/0x560 mm/filemap.c:3749 ext4_buffered_write_iter+0x15b/0x460 fs/ext4/file.c:270 ext4_file_write_iter+0x44a/0x1660 fs/ext4/file.c:679 call_write_iter include/linux/fs.h:2192 [inline] do_iter_readv_writev+0x20b/0x3b0 fs/read_write.c:729 do_iter_write+0x182/0x700 fs/read_write.c:855 vfs_iter_write+0x70/0xa0 fs/read_write.c:896 iter_file_splice_write+0x741/0xc90 fs/splice.c:686 do_splice_from fs/splice.c:764 [inline] direct_splice_actor+0x110/0x180 fs/splice.c:931 splice_direct_to_actor+0x331/0x8a0 fs/splice.c:886 do_splice_direct+0x1a7/0x270 fs/splice.c:974 do_sendfile+0xb19/0x1270 fs/read_write.c:1249 __do_sys_sendfile64 fs/read_write.c:1311 [inline] __se_sys_sendfile64 fs/read_write.c:1303 [inline] __x64_sys_sendfile64+0x149/0x210 fs/read_write.c:1303 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd RIP: 0033:0x7fbf9f889279 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007fbfa0a3a168 EFLAGS: 00000246 ORIG_RAX: 0000000000000028 RAX: ffffffffffffffda RBX: 00007fbf9f99bf80 RCX: 00007fbf9f889279 RDX: 0000000020000240 RSI: 0000000000000006 RDI: 0000000000000006 RBP: 00007fbf9f8e3189 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000007ffc R11: 0000000000000246 R12: 0000000000000000 R13: 00007ffdfbfde95f R14: 00007fbfa0a3a300 R15: 0000000000022000