====================================================== WARNING: possible circular locking dependency detected 6.8.0-syzkaller-08951-gfe46a7dd189e #0 Not tainted ------------------------------------------------------ syz-executor.0/6713 is trying to acquire lock: ffff888029b1d540 (&p->lock){+.+.}-{3:3}, at: seq_read_iter+0xb7/0xd60 fs/seq_file.c:182 but task is already holding lock: ffff88802e24f068 (&pipe->mutex){+.+.}-{3:3}, at: splice_file_to_pipe+0x2e/0x500 fs/splice.c:1292 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #5 (&pipe->mutex){+.+.}-{3:3}: lock_acquire+0x1e4/0x530 kernel/locking/lockdep.c:5754 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x136/0xd70 kernel/locking/mutex.c:752 iter_file_splice_write+0x335/0x14e0 fs/splice.c:687 do_splice_from fs/splice.c:941 [inline] do_splice+0xd77/0x1880 fs/splice.c:1354 __do_splice fs/splice.c:1436 [inline] __do_sys_splice fs/splice.c:1652 [inline] __se_sys_splice+0x331/0x4a0 fs/splice.c:1634 do_syscall_64+0xfb/0x240 entry_SYSCALL_64_after_hwframe+0x6d/0x75 -> #4 (sb_writers#4){.+.+}-{0:0}: lock_acquire+0x1e4/0x530 kernel/locking/lockdep.c:5754 percpu_down_read include/linux/percpu-rwsem.h:51 [inline] __sb_start_write include/linux/fs.h:1662 [inline] sb_start_write include/linux/fs.h:1798 [inline] ovl_start_write+0x11d/0x290 fs/overlayfs/util.c:31 ovl_copy_up_tmpfile fs/overlayfs/copy_up.c:854 [inline] ovl_do_copy_up fs/overlayfs/copy_up.c:976 [inline] ovl_copy_up_one fs/overlayfs/copy_up.c:1168 [inline] ovl_copy_up_flags+0x1952/0x4450 fs/overlayfs/copy_up.c:1223 ovl_rename+0x62a/0x1750 fs/overlayfs/dir.c:1123 vfs_rename+0xbdb/0xf00 fs/namei.c:4883 do_renameat2+0xd94/0x13f0 fs/namei.c:5040 __do_sys_rename fs/namei.c:5087 [inline] __se_sys_rename fs/namei.c:5085 [inline] __x64_sys_rename+0x86/0xa0 fs/namei.c:5085 do_syscall_64+0xfb/0x240 entry_SYSCALL_64_after_hwframe+0x6d/0x75 -> #3 (&ovl_i_lock_key[depth]){+.+.}-{3:3}: lock_acquire+0x1e4/0x530 kernel/locking/lockdep.c:5754 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x136/0xd70 kernel/locking/mutex.c:752 ovl_inode_lock_interruptible fs/overlayfs/overlayfs.h:654 [inline] ovl_copy_up_start+0x53/0x310 fs/overlayfs/util.c:719 ovl_copy_up_one fs/overlayfs/copy_up.c:1161 [inline] ovl_copy_up_flags+0xbb6/0x4450 fs/overlayfs/copy_up.c:1223 ovl_nlink_start+0x9f/0x390 fs/overlayfs/util.c:1157 ovl_do_remove+0x1fa/0xd90 fs/overlayfs/dir.c:893 vfs_rmdir+0x367/0x4c0 fs/namei.c:4209 do_rmdir+0x3b5/0x580 fs/namei.c:4268 __do_sys_rmdir fs/namei.c:4287 [inline] __se_sys_rmdir fs/namei.c:4285 [inline] __x64_sys_rmdir+0x49/0x60 fs/namei.c:4285 do_syscall_64+0xfb/0x240 entry_SYSCALL_64_after_hwframe+0x6d/0x75 -> #2 (&ovl_i_mutex_dir_key[depth]){++++}-{3:3}: lock_acquire+0x1e4/0x530 kernel/locking/lockdep.c:5754 down_read+0xb1/0xa40 kernel/locking/rwsem.c:1526 inode_lock_shared include/linux/fs.h:803 [inline] lookup_slow+0x45/0x70 fs/namei.c:1708 walk_component+0x2e1/0x410 fs/namei.c:2004 lookup_last fs/namei.c:2461 [inline] path_lookupat+0x16f/0x450 fs/namei.c:2485 filename_lookup+0x256/0x610 fs/namei.c:2514 kern_path+0x35/0x50 fs/namei.c:2622 lookup_bdev+0xc5/0x290 block/bdev.c:1072 resume_store+0x1a0/0x710 kernel/power/hibernate.c:1235 kernfs_fop_write_iter+0x3a4/0x500 fs/kernfs/file.c:334 call_write_iter include/linux/fs.h:2108 [inline] new_sync_write fs/read_write.c:497 [inline] vfs_write+0xa84/0xcb0 fs/read_write.c:590 ksys_write+0x1a0/0x2c0 fs/read_write.c:643 do_syscall_64+0xfb/0x240 entry_SYSCALL_64_after_hwframe+0x6d/0x75 -> #1 (&of->mutex){+.+.}-{3:3}: lock_acquire+0x1e4/0x530 kernel/locking/lockdep.c:5754 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x136/0xd70 kernel/locking/mutex.c:752 kernfs_seq_start+0x53/0x3b0 fs/kernfs/file.c:154 seq_read_iter+0x3d0/0xd60 fs/seq_file.c:225 call_read_iter include/linux/fs.h:2102 [inline] new_sync_read fs/read_write.c:395 [inline] vfs_read+0x97b/0xb70 fs/read_write.c:476 ksys_read+0x1a0/0x2c0 fs/read_write.c:619 do_syscall_64+0xfb/0x240 entry_SYSCALL_64_after_hwframe+0x6d/0x75 -> #0 (&p->lock){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain+0x18cb/0x58e0 kernel/locking/lockdep.c:3869 __lock_acquire+0x1346/0x1fd0 kernel/locking/lockdep.c:5137 lock_acquire+0x1e4/0x530 kernel/locking/lockdep.c:5754 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x136/0xd70 kernel/locking/mutex.c:752 seq_read_iter+0xb7/0xd60 fs/seq_file.c:182 call_read_iter include/linux/fs.h:2102 [inline] copy_splice_read+0x662/0xb60 fs/splice.c:365 do_splice_read fs/splice.c:985 [inline] splice_file_to_pipe+0x299/0x500 fs/splice.c:1295 do_sendfile+0x515/0xdc0 fs/read_write.c:1301 __do_sys_sendfile64 fs/read_write.c:1362 [inline] __se_sys_sendfile64+0x17c/0x1e0 fs/read_write.c:1348 do_syscall_64+0xfb/0x240 entry_SYSCALL_64_after_hwframe+0x6d/0x75 other info that might help us debug this: Chain exists of: &p->lock --> sb_writers#4 --> &pipe->mutex Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&pipe->mutex); lock(sb_writers#4); lock(&pipe->mutex); lock(&p->lock); *** DEADLOCK *** 1 lock held by syz-executor.0/6713: #0: ffff88802e24f068 (&pipe->mutex){+.+.}-{3:3}, at: splice_file_to_pipe+0x2e/0x500 fs/splice.c:1292 stack backtrace: CPU: 1 PID: 6713 Comm: syz-executor.0 Not tainted 6.8.0-syzkaller-08951-gfe46a7dd189e #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/27/2024 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x241/0x360 lib/dump_stack.c:114 check_noncircular+0x36a/0x4a0 kernel/locking/lockdep.c:2187 check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain+0x18cb/0x58e0 kernel/locking/lockdep.c:3869 __lock_acquire+0x1346/0x1fd0 kernel/locking/lockdep.c:5137 lock_acquire+0x1e4/0x530 kernel/locking/lockdep.c:5754 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x136/0xd70 kernel/locking/mutex.c:752 seq_read_iter+0xb7/0xd60 fs/seq_file.c:182 call_read_iter include/linux/fs.h:2102 [inline] copy_splice_read+0x662/0xb60 fs/splice.c:365 do_splice_read fs/splice.c:985 [inline] splice_file_to_pipe+0x299/0x500 fs/splice.c:1295 do_sendfile+0x515/0xdc0 fs/read_write.c:1301 __do_sys_sendfile64 fs/read_write.c:1362 [inline] __se_sys_sendfile64+0x17c/0x1e0 fs/read_write.c:1348 do_syscall_64+0xfb/0x240 entry_SYSCALL_64_after_hwframe+0x6d/0x75 RIP: 0033:0x7f753d87de69 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f753e6810c8 EFLAGS: 00000246 ORIG_RAX: 0000000000000028 RAX: ffffffffffffffda RBX: 00007f753d9ac050 RCX: 00007f753d87de69 RDX: 0000000000000000 RSI: 0000000000000005 RDI: 0000000000000003 RBP: 00007f753d8ca47a R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000004 R11: 0000000000000246 R12: 0000000000000000 R13: 000000000000006e R14: 00007f753d9ac050 R15: 00007fffd452c188