====================================================== WARNING: possible circular locking dependency detected 6.1.20-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.0/11386 is trying to acquire lock: ffff0000d79f7948 (&mm->mmap_lock){++++}-{3:3}, at: __might_fault+0x9c/0x124 mm/memory.c:5640 but task is already holding lock: ffff0001200a20b0 (&tree->tree_lock#2){+.+.}-{3:3}, at: hfsplus_find_init+0x144/0x1bc which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #3 (&tree->tree_lock#2){+.+.}-{3:3}: __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799 hfsplus_file_truncate+0x6d0/0x9b8 fs/hfsplus/extents.c:595 hfsplus_delete_inode+0x154/0x200 hfsplus_unlink+0x414/0x6a0 fs/hfsplus/dir.c:405 vfs_unlink+0x2f0/0x508 fs/namei.c:4252 do_unlinkat+0x4c8/0x82c fs/namei.c:4320 __do_sys_unlinkat fs/namei.c:4363 [inline] __se_sys_unlinkat fs/namei.c:4356 [inline] __arm64_sys_unlinkat+0xcc/0xfc fs/namei.c:4356 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:581 -> #2 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}: __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799 hfsplus_get_block+0x2c4/0x1168 fs/hfsplus/extents.c:260 block_read_full_folio+0x2f4/0x98c fs/buffer.c:2271 hfsplus_read_folio+0x28/0x38 fs/hfsplus/inode.c:28 read_pages+0x4c0/0x6a0 mm/readahead.c:181 page_cache_ra_unbounded+0x46c/0x58c mm/readahead.c:270 do_page_cache_ra mm/readahead.c:300 [inline] page_cache_ra_order+0x7fc/0x994 mm/readahead.c:560 ondemand_readahead+0x5f8/0xb04 mm/readahead.c:682 page_cache_sync_ra+0x350/0x3d0 mm/readahead.c:709 page_cache_sync_readahead include/linux/pagemap.h:1213 [inline] filemap_get_pages mm/filemap.c:2582 [inline] filemap_read+0x598/0x2260 mm/filemap.c:2676 generic_file_read_iter+0xa0/0x450 mm/filemap.c:2822 __kernel_read+0x30c/0x6b4 fs/read_write.c:428 kernel_read+0xd8/0x1d4 fs/read_write.c:446 prepare_binprm fs/exec.c:1657 [inline] search_binary_handler fs/exec.c:1711 [inline] exec_binprm fs/exec.c:1768 [inline] bprm_execve+0x760/0x1798 fs/exec.c:1837 do_execveat_common+0x668/0x814 fs/exec.c:1942 do_execve fs/exec.c:2016 [inline] __do_sys_execve fs/exec.c:2092 [inline] __se_sys_execve fs/exec.c:2087 [inline] __arm64_sys_execve+0x98/0xb0 fs/exec.c:2087 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:581 -> #1 (mapping.invalidate_lock#4){.+.+}-{3:3}: down_read+0x5c/0x78 kernel/locking/rwsem.c:1520 filemap_invalidate_lock_shared include/linux/fs.h:811 [inline] filemap_fault+0x58c/0xf7c mm/filemap.c:3128 __do_fault+0x11c/0x3d8 mm/memory.c:4198 do_read_fault mm/memory.c:4549 [inline] do_fault mm/memory.c:4678 [inline] handle_pte_fault mm/memory.c:4950 [inline] __handle_mm_fault mm/memory.c:5092 [inline] handle_mm_fault+0x1f20/0x3d18 mm/memory.c:5213 __do_page_fault arch/arm64/mm/fault.c:512 [inline] do_page_fault+0x634/0xac4 arch/arm64/mm/fault.c:612 do_translation_fault+0x94/0xc8 arch/arm64/mm/fault.c:695 do_mem_abort+0x74/0x200 arch/arm64/mm/fault.c:831 el1_abort+0x3c/0x5c arch/arm64/kernel/entry-common.c:367 el1h_64_sync_handler+0x60/0xac arch/arm64/kernel/entry-common.c:427 el1h_64_sync+0x64/0x68 arch/arm64/kernel/entry.S:576 do_strncpy_from_user lib/strncpy_from_user.c:41 [inline] strncpy_from_user+0x224/0x54c lib/strncpy_from_user.c:139 getname_flags+0x104/0x480 fs/namei.c:150 getname+0x28/0x38 fs/namei.c:218 do_sys_openat2+0xd4/0x3d8 fs/open.c:1304 do_sys_open fs/open.c:1326 [inline] __do_sys_openat fs/open.c:1342 [inline] __se_sys_openat fs/open.c:1337 [inline] __arm64_sys_openat+0x1f0/0x240 fs/open.c:1337 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:581 -> #0 (&mm->mmap_lock){++++}-{3:3}: check_prev_add kernel/locking/lockdep.c:3098 [inline] check_prevs_add kernel/locking/lockdep.c:3217 [inline] validate_chain kernel/locking/lockdep.c:3832 [inline] __lock_acquire+0x3338/0x764c kernel/locking/lockdep.c:5056 lock_acquire+0x300/0x8e4 kernel/locking/lockdep.c:5669 __might_fault+0xc4/0x124 mm/memory.c:5641 filldir64+0x2d4/0x948 fs/readdir.c:335 dir_emit_dot include/linux/fs.h:3583 [inline] hfsplus_readdir+0x398/0xf28 fs/hfsplus/dir.c:159 iterate_dir+0x1f4/0x4e4 __do_sys_getdents64 fs/readdir.c:369 [inline] __se_sys_getdents64 fs/readdir.c:354 [inline] __arm64_sys_getdents64+0x1c4/0x4a0 fs/readdir.c:354 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:581 other info that might help us debug this: Chain exists of: &mm->mmap_lock --> &HFSPLUS_I(inode)->extents_lock --> &tree->tree_lock#2 Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&tree->tree_lock#2); lock(&HFSPLUS_I(inode)->extents_lock); lock(&tree->tree_lock#2); lock(&mm->mmap_lock); *** DEADLOCK *** 3 locks held by syz-executor.0/11386: #0: ffff0000c18d79e8 (&f->f_pos_lock){+.+.}-{3:3}, at: __fdget_pos+0xd8/0x104 fs/file.c:1047 #1: ffff0000d96a9740 (&type->i_mutex_dir_key#11){++++}-{3:3}, at: iterate_dir+0x108/0x4e4 fs/readdir.c:55 #2: ffff0001200a20b0 (&tree->tree_lock#2){+.+.}-{3:3}, at: hfsplus_find_init+0x144/0x1bc stack backtrace: CPU: 0 PID: 11386 Comm: syz-executor.0 Not tainted 6.1.20-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/02/2023 Call trace: dump_backtrace+0x1c8/0x1f4 arch/arm64/kernel/stacktrace.c:158 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:165 __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106 dump_stack+0x1c/0x5c lib/dump_stack.c:113 print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2056 check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2178 check_prev_add kernel/locking/lockdep.c:3098 [inline] check_prevs_add kernel/locking/lockdep.c:3217 [inline] validate_chain kernel/locking/lockdep.c:3832 [inline] __lock_acquire+0x3338/0x764c kernel/locking/lockdep.c:5056 lock_acquire+0x300/0x8e4 kernel/locking/lockdep.c:5669 __might_fault+0xc4/0x124 mm/memory.c:5641 filldir64+0x2d4/0x948 fs/readdir.c:335 dir_emit_dot include/linux/fs.h:3583 [inline] hfsplus_readdir+0x398/0xf28 fs/hfsplus/dir.c:159 iterate_dir+0x1f4/0x4e4 __do_sys_getdents64 fs/readdir.c:369 [inline] __se_sys_getdents64 fs/readdir.c:354 [inline] __arm64_sys_getdents64+0x1c4/0x4a0 fs/readdir.c:354 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:581 hfsplus: bad catalog entry type