====================================================== WARNING: possible circular locking dependency detected 6.1.114-syzkaller #0 Not tainted ------------------------------------------------------ syz.4.168/4939 is trying to acquire lock: ffff0000f210c2c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline] ffff0000f210c2c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{3:3}, at: ocfs2_reserve_local_alloc_bits+0xfc/0x25dc fs/ocfs2/localalloc.c:635 but task is already holding lock: ffff0000f2153120 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_lock_global_qf+0x1d4/0x260 fs/ocfs2/quota_global.c:314 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #7 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}: down_write+0x5c/0x88 kernel/locking/rwsem.c:1573 ocfs2_lock_global_qf+0x1d4/0x260 fs/ocfs2/quota_global.c:314 ocfs2_acquire_dquot+0x27c/0xb1c fs/ocfs2/quota_global.c:811 dqget+0x660/0xcec fs/quota/dquot.c:986 ocfs2_setattr+0xc48/0x1b3c fs/ocfs2/file.c:1230 notify_change+0xb58/0xe1c fs/attr.c:499 chown_common+0x4e8/0x7d8 fs/open.c:736 vfs_fchown fs/open.c:804 [inline] ksys_fchown+0xe0/0x158 fs/open.c:815 __do_sys_fchown fs/open.c:823 [inline] __se_sys_fchown fs/open.c:821 [inline] __arm64_sys_fchown+0x7c/0x94 fs/open.c:821 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140 do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:204 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 -> #6 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}: down_write+0x5c/0x88 kernel/locking/rwsem.c:1573 inode_lock include/linux/fs.h:758 [inline] ocfs2_lock_global_qf+0x1b8/0x260 fs/ocfs2/quota_global.c:313 ocfs2_acquire_dquot+0x27c/0xb1c fs/ocfs2/quota_global.c:811 dqget+0x660/0xcec fs/quota/dquot.c:986 ocfs2_setattr+0xc48/0x1b3c fs/ocfs2/file.c:1230 notify_change+0xb58/0xe1c fs/attr.c:499 chown_common+0x4e8/0x7d8 fs/open.c:736 vfs_fchown fs/open.c:804 [inline] ksys_fchown+0xe0/0x158 fs/open.c:815 __do_sys_fchown fs/open.c:823 [inline] __se_sys_fchown fs/open.c:821 [inline] __arm64_sys_fchown+0x7c/0x94 fs/open.c:821 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140 do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:204 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 -> #5 (&dquot->dq_lock){+.+.}-{3:3}: __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799 dquot_commit+0x54/0x240 fs/quota/dquot.c:507 ext4_write_dquot+0x1b4/0x314 fs/ext4/super.c:6777 ext4_mark_dquot_dirty+0xe8/0x140 fs/ext4/super.c:6837 mark_dquot_dirty fs/quota/dquot.c:372 [inline] mark_all_dquot_dirty+0x108/0x424 fs/quota/dquot.c:412 __dquot_free_space+0x840/0xce4 fs/quota/dquot.c:1940 dquot_free_space_nodirty include/linux/quotaops.h:379 [inline] dquot_free_space include/linux/quotaops.h:384 [inline] dquot_free_block include/linux/quotaops.h:395 [inline] ext4_mb_clear_bb fs/ext4/mballoc.c:6143 [inline] ext4_free_blocks+0x1b14/0x2b64 fs/ext4/mballoc.c:6273 ext4_remove_blocks fs/ext4/extents.c:2507 [inline] ext4_ext_rm_leaf fs/ext4/extents.c:2691 [inline] ext4_ext_remove_space+0x1ad0/0x4544 fs/ext4/extents.c:2939 ext4_ext_truncate+0x168/0x210 fs/ext4/extents.c:4469 ext4_truncate+0xa08/0x1178 fs/ext4/inode.c:4288 ext4_setattr+0xda0/0x14e8 fs/ext4/inode.c:5601 notify_change+0xb58/0xe1c fs/attr.c:499 do_truncate+0x1c0/0x28c fs/open.c:65 vfs_truncate+0x2c4/0x36c fs/open.c:111 do_sys_truncate+0xec/0x1b4 fs/open.c:134 __do_sys_truncate fs/open.c:146 [inline] __se_sys_truncate fs/open.c:144 [inline] __arm64_sys_truncate+0x5c/0x70 fs/open.c:144 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140 do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:204 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 -> #4 (&ei->i_data_sem){++++}-{3:3}: down_write+0x5c/0x88 kernel/locking/rwsem.c:1573 ext4_truncate+0x7e0/0x1178 fs/ext4/inode.c:4283 ext4_setattr+0xda0/0x14e8 fs/ext4/inode.c:5601 notify_change+0xb58/0xe1c fs/attr.c:499 do_truncate+0x1c0/0x28c fs/open.c:65 do_sys_ftruncate+0x288/0x31c fs/open.c:193 __do_sys_ftruncate fs/open.c:204 [inline] __se_sys_ftruncate fs/open.c:202 [inline] __arm64_sys_ftruncate+0x60/0x74 fs/open.c:202 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140 do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:204 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 -> #3 (jbd2_handle){++++}-{0:0}: start_this_handle+0x1140/0x13ac fs/jbd2/transaction.c:463 jbd2__journal_start+0x298/0x544 fs/jbd2/transaction.c:520 jbd2_journal_start+0x3c/0x4c fs/jbd2/transaction.c:559 ocfs2_start_trans+0x3e8/0x73c fs/ocfs2/journal.c:354 ocfs2_mknod+0xe64/0x2560 fs/ocfs2/namei.c:359 vfs_mknod+0x3c8/0x448 fs/namei.c:3985 do_mknodat+0x3f8/0x610 __do_sys_mknodat fs/namei.c:4063 [inline] __se_sys_mknodat fs/namei.c:4060 [inline] __arm64_sys_mknodat+0xb0/0xcc fs/namei.c:4060 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140 do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:204 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 -> #2 (&journal->j_trans_barrier){.+.+}-{3:3}: down_read+0x64/0x308 kernel/locking/rwsem.c:1520 ocfs2_start_trans+0x3dc/0x73c fs/ocfs2/journal.c:352 ocfs2_mknod+0xe64/0x2560 fs/ocfs2/namei.c:359 vfs_mknod+0x3c8/0x448 fs/namei.c:3985 do_mknodat+0x3f8/0x610 __do_sys_mknodat fs/namei.c:4063 [inline] __se_sys_mknodat fs/namei.c:4060 [inline] __arm64_sys_mknodat+0xb0/0xcc fs/namei.c:4060 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140 do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:204 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 -> #1 (sb_internal#7){.+.+}-{0:0}: percpu_down_read include/linux/percpu-rwsem.h:51 [inline] __sb_start_write include/linux/fs.h:1891 [inline] sb_start_intwrite include/linux/fs.h:2013 [inline] ocfs2_start_trans+0x260/0x73c fs/ocfs2/journal.c:350 ocfs2_mknod+0xe64/0x2560 fs/ocfs2/namei.c:359 vfs_mknod+0x3c8/0x448 fs/namei.c:3985 do_mknodat+0x3f8/0x610 __do_sys_mknodat fs/namei.c:4063 [inline] __se_sys_mknodat fs/namei.c:4060 [inline] __arm64_sys_mknodat+0xb0/0xcc fs/namei.c:4060 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140 do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:204 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 -> #0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain kernel/locking/lockdep.c:3825 [inline] __lock_acquire+0x3338/0x7680 kernel/locking/lockdep.c:5049 lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5662 down_write+0x5c/0x88 kernel/locking/rwsem.c:1573 inode_lock include/linux/fs.h:758 [inline] ocfs2_reserve_local_alloc_bits+0xfc/0x25dc fs/ocfs2/localalloc.c:635 ocfs2_reserve_clusters_with_limit+0x194/0xabc fs/ocfs2/suballoc.c:1162 ocfs2_reserve_clusters fs/ocfs2/suballoc.c:1223 [inline] ocfs2_lock_allocators+0x294/0x584 fs/ocfs2/suballoc.c:2669 ocfs2_extend_allocation+0x474/0x1a04 fs/ocfs2/file.c:585 ocfs2_extend_no_holes+0x1b0/0x45c fs/ocfs2/file.c:1027 ocfs2_acquire_dquot+0x620/0xb1c fs/ocfs2/quota_global.c:836 dqget+0x660/0xcec fs/quota/dquot.c:986 ocfs2_setattr+0xc48/0x1b3c fs/ocfs2/file.c:1230 notify_change+0xb58/0xe1c fs/attr.c:499 chown_common+0x4e8/0x7d8 fs/open.c:736 vfs_fchown fs/open.c:804 [inline] ksys_fchown+0xe0/0x158 fs/open.c:815 __do_sys_fchown fs/open.c:823 [inline] __se_sys_fchown fs/open.c:821 [inline] __arm64_sys_fchown+0x7c/0x94 fs/open.c:821 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140 do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:204 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 other info that might help us debug this: Chain exists of: &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4 --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7 --> &ocfs2_quota_ip_alloc_sem_key Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ocfs2_quota_ip_alloc_sem_key); lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7); lock(&ocfs2_quota_ip_alloc_sem_key); lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4); *** DEADLOCK *** 5 locks held by syz.4.168/4939: #0: ffff0000d693a460 (sb_writers#21){.+.+}-{0:0}, at: mnt_want_write_file+0x64/0x1e8 fs/namespace.c:437 #1: ffff0000e10b42c8 (&type->i_mutex_dir_key#18){++++}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline] #1: ffff0000e10b42c8 (&type->i_mutex_dir_key#18){++++}-{3:3}, at: chown_common+0x358/0x7d8 fs/open.c:726 #2: ffff0000f22a20a8 (&dquot->dq_lock){+.+.}-{3:3}, at: ocfs2_acquire_dquot+0x270/0xb1c fs/ocfs2/quota_global.c:806 #3: ffff0000f2153488 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline] #3: ffff0000f2153488 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}, at: ocfs2_lock_global_qf+0x1b8/0x260 fs/ocfs2/quota_global.c:313 #4: ffff0000f2153120 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_lock_global_qf+0x1d4/0x260 fs/ocfs2/quota_global.c:314 stack backtrace: CPU: 1 PID: 4939 Comm: syz.4.168 Not tainted 6.1.114-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024 Call trace: dump_backtrace+0x1c8/0x1f4 arch/arm64/kernel/stacktrace.c:158 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:165 __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106 dump_stack+0x1c/0x58 lib/dump_stack.c:113 print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2048 check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2170 check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain kernel/locking/lockdep.c:3825 [inline] __lock_acquire+0x3338/0x7680 kernel/locking/lockdep.c:5049 lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5662 down_write+0x5c/0x88 kernel/locking/rwsem.c:1573 inode_lock include/linux/fs.h:758 [inline] ocfs2_reserve_local_alloc_bits+0xfc/0x25dc fs/ocfs2/localalloc.c:635 ocfs2_reserve_clusters_with_limit+0x194/0xabc fs/ocfs2/suballoc.c:1162 ocfs2_reserve_clusters fs/ocfs2/suballoc.c:1223 [inline] ocfs2_lock_allocators+0x294/0x584 fs/ocfs2/suballoc.c:2669 ocfs2_extend_allocation+0x474/0x1a04 fs/ocfs2/file.c:585 ocfs2_extend_no_holes+0x1b0/0x45c fs/ocfs2/file.c:1027 ocfs2_acquire_dquot+0x620/0xb1c fs/ocfs2/quota_global.c:836 dqget+0x660/0xcec fs/quota/dquot.c:986 ocfs2_setattr+0xc48/0x1b3c fs/ocfs2/file.c:1230 notify_change+0xb58/0xe1c fs/attr.c:499 chown_common+0x4e8/0x7d8 fs/open.c:736 vfs_fchown fs/open.c:804 [inline] ksys_fchown+0xe0/0x158 fs/open.c:815 __do_sys_fchown fs/open.c:823 [inline] __se_sys_fchown fs/open.c:821 [inline] __arm64_sys_fchown+0x7c/0x94 fs/open.c:821 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140 do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:204 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 (syz.4.168,4939,1):ocfs2_block_check_validate:402 ERROR: CRC32 failed: stored: 0x4e60244d, computed 0x36fa8088. Applying ECC. (syz.4.168,4939,1):ocfs2_block_check_validate:416 ERROR: Fixed CRC32 failed: stored: 0x4e60244d, computed 0x26885ba0 (syz.4.168,4939,1):ocfs2_search_chain:1761 ERROR: status = -5 (syz.4.168,4939,1):ocfs2_search_chain:1871 ERROR: status = -5 (syz.4.168,4939,1):ocfs2_claim_suballoc_bits:1940 ERROR: status = -5 (syz.4.168,4939,1):ocfs2_claim_suballoc_bits:1983 ERROR: status = -5 (syz.4.168,4939,1):__ocfs2_claim_clusters:2355 ERROR: status = -5 (syz.4.168,4939,1):__ocfs2_claim_clusters:2363 ERROR: status = -5 (syz.4.168,4939,1):ocfs2_local_alloc_new_window:1222 ERROR: status = -5 (syz.4.168,4939,1):ocfs2_local_alloc_new_window:1247 ERROR: status = -5 (syz.4.168,4939,1):ocfs2_local_alloc_slide_window:1321 ERROR: status = -5 (syz.4.168,4939,1):ocfs2_local_alloc_slide_window:1340 ERROR: status = -5 (syz.4.168,4939,1):ocfs2_reserve_local_alloc_bits:671 ERROR: status = -5 (syz.4.168,4939,1):ocfs2_reserve_local_alloc_bits:709 ERROR: status = -5 (syz.4.168,4939,1):ocfs2_reserve_clusters_with_limit:1166 ERROR: status = -5 (syz.4.168,4939,1):ocfs2_reserve_clusters_with_limit:1215 ERROR: status = -5 (syz.4.168,4939,1):ocfs2_lock_allocators:2672 ERROR: status = -5 (syz.4.168,4939,1):ocfs2_extend_allocation:588 ERROR: status = -5 (syz.4.168,4939,1):ocfs2_extend_no_holes:1030 ERROR: status = -5 (syz.4.168,4939,1):ocfs2_acquire_dquot:873 ERROR: status = -5