vxcan0: j1939_tp_rxtimer: 0xffff888047c56c00: rx timeout, send abort
======================================================
WARNING: possible circular locking dependency detected
6.1.0-rc5-syzkaller-00018-g59d0d52c30d4 #0 Not tainted
------------------------------------------------------
syz-executor.1/5808 is trying to acquire lock:
ffff88802a1d90d0 (&priv->j1939_socks_lock){+.-.}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:355 [inline]
ffff88802a1d90d0 (&priv->j1939_socks_lock){+.-.}-{2:2}, at: j1939_sk_errqueue+0xa3/0x1a0 net/can/j1939/socket.c:1081
but task is already holding lock:
ffff88802a1d9088 (&priv->active_session_list_lock){+.-.}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:355 [inline]
ffff88802a1d9088 (&priv->active_session_list_lock){+.-.}-{2:2}, at: j1939_session_list_lock net/can/j1939/transport.c:238 [inline]
ffff88802a1d9088 (&priv->active_session_list_lock){+.-.}-{2:2}, at: j1939_tp_rxtimer+0xe9/0x220 net/can/j1939/transport.c:1248
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #2 (&priv->active_session_list_lock){+.-.}-{2:2}:
__raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline]
_raw_spin_lock_bh+0x33/0x40 kernel/locking/spinlock.c:178
spin_lock_bh include/linux/spinlock.h:355 [inline]
j1939_session_list_lock net/can/j1939/transport.c:238 [inline]
j1939_session_activate+0x47/0x4b0 net/can/j1939/transport.c:1561
j1939_sk_queue_activate_next_locked net/can/j1939/socket.c:181 [inline]
j1939_sk_queue_activate_next+0x1b6/0x450 net/can/j1939/socket.c:208
j1939_session_deactivate_activate_next net/can/j1939/transport.c:1109 [inline]
j1939_session_completed+0x19a/0x1f0 net/can/j1939/transport.c:1222
j1939_xtp_rx_eoma_one net/can/j1939/transport.c:1392 [inline]
j1939_xtp_rx_eoma+0x2a1/0x5e0 net/can/j1939/transport.c:1407
j1939_tp_cmd_recv net/can/j1939/transport.c:2096 [inline]
j1939_tp_recv+0x71c/0xcd0 net/can/j1939/transport.c:2141
j1939_can_recv net/can/j1939/main.c:112 [inline]
j1939_can_recv+0x78e/0xa30 net/can/j1939/main.c:38
deliver net/can/af_can.c:573 [inline]
can_rcv_filter+0x5d4/0x8d0 net/can/af_can.c:607
can_receive+0x31d/0x580 net/can/af_can.c:664
can_rcv+0x166/0x1a0 net/can/af_can.c:688
__netif_receive_skb_one_core+0x114/0x180 net/core/dev.c:5489
__netif_receive_skb+0x1f/0x1c0 net/core/dev.c:5603
process_backlog+0x3e4/0x810 net/core/dev.c:5931
__napi_poll+0xb8/0x770 net/core/dev.c:6498
napi_poll net/core/dev.c:6565 [inline]
net_rx_action+0xa00/0xde0 net/core/dev.c:6676
__do_softirq+0x1fb/0xadc kernel/softirq.c:571
run_ksoftirqd kernel/softirq.c:934 [inline]
run_ksoftirqd+0x31/0x60 kernel/softirq.c:926
smpboot_thread_fn+0x659/0xa20 kernel/smpboot.c:164
kthread+0x2e8/0x3a0 kernel/kthread.c:376
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:306
-> #1 (&jsk->sk_session_queue_lock){+.-.}-{2:2}:
__raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline]
_raw_spin_lock_bh+0x33/0x40 kernel/locking/spinlock.c:178
spin_lock_bh include/linux/spinlock.h:355 [inline]
j1939_sk_queue_drop_all+0x3b/0x2f0 net/can/j1939/socket.c:139
j1939_sk_netdev_event_netdown+0x7f/0x160 net/can/j1939/socket.c:1275
j1939_netdev_notify+0x19d/0x1d0 net/can/j1939/main.c:379
notifier_call_chain+0xb5/0x200 kernel/notifier.c:87
call_netdevice_notifiers_info+0xb5/0x130 net/core/dev.c:1945
call_netdevice_notifiers_extack net/core/dev.c:1983 [inline]
call_netdevice_notifiers net/core/dev.c:1997 [inline]
__dev_notify_flags+0x1de/0x2c0 net/core/dev.c:8583
dev_change_flags+0x116/0x170 net/core/dev.c:8619
do_setlink+0x9f1/0x3bb0 net/core/rtnetlink.c:2788
__rtnl_newlink+0xd6a/0x17e0 net/core/rtnetlink.c:3547
rtnl_newlink+0x68/0xa0 net/core/rtnetlink.c:3594
rtnetlink_rcv_msg+0x43e/0xca0 net/core/rtnetlink.c:6091
netlink_rcv_skb+0x157/0x430 net/netlink/af_netlink.c:2540
netlink_unicast_kernel net/netlink/af_netlink.c:1319 [inline]
netlink_unicast+0x547/0x7f0 net/netlink/af_netlink.c:1345
netlink_sendmsg+0x91b/0xe10 net/netlink/af_netlink.c:1921
sock_sendmsg_nosec net/socket.c:714 [inline]
sock_sendmsg+0xd3/0x120 net/socket.c:734
____sys_sendmsg+0x712/0x8c0 net/socket.c:2482
___sys_sendmsg+0x110/0x1b0 net/socket.c:2536
__sys_sendmsg+0xf7/0x1c0 net/socket.c:2565
do_syscall_32_irqs_on arch/x86/entry/common.c:112 [inline]
__do_fast_syscall_32+0x65/0xf0 arch/x86/entry/common.c:178
do_fast_syscall_32+0x33/0x70 arch/x86/entry/common.c:203
entry_SYSENTER_compat_after_hwframe+0x70/0x82
-> #0 (&priv->j1939_socks_lock){+.-.}-{2:2}:
check_prev_add kernel/locking/lockdep.c:3097 [inline]
check_prevs_add kernel/locking/lockdep.c:3216 [inline]
validate_chain kernel/locking/lockdep.c:3831 [inline]
__lock_acquire+0x2a43/0x56d0 kernel/locking/lockdep.c:5055
lock_acquire kernel/locking/lockdep.c:5668 [inline]
lock_acquire+0x1e3/0x630 kernel/locking/lockdep.c:5633
__raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline]
_raw_spin_lock_bh+0x33/0x40 kernel/locking/spinlock.c:178
spin_lock_bh include/linux/spinlock.h:355 [inline]
j1939_sk_errqueue+0xa3/0x1a0 net/can/j1939/socket.c:1081
__j1939_session_cancel+0x3b9/0x460 net/can/j1939/transport.c:1132
j1939_tp_rxtimer.cold+0x1f6/0x24f net/can/j1939/transport.c:1257
__run_hrtimer kernel/time/hrtimer.c:1685 [inline]
__hrtimer_run_queues+0x690/0xfb0 kernel/time/hrtimer.c:1749
hrtimer_run_softirq+0x17f/0x360 kernel/time/hrtimer.c:1766
__do_softirq+0x1fb/0xadc kernel/softirq.c:571
invoke_softirq kernel/softirq.c:445 [inline]
__irq_exit_rcu+0x123/0x180 kernel/softirq.c:650
irq_exit_rcu+0x9/0x20 kernel/softirq.c:662
sysvec_apic_timer_interrupt+0x97/0xc0 arch/x86/kernel/apic/apic.c:1107
asm_sysvec_apic_timer_interrupt+0x1a/0x20 arch/x86/include/asm/idtentry.h:649
__raw_spin_unlock_irqrestore include/linux/spinlock_api_smp.h:152 [inline]
_raw_spin_unlock_irqrestore+0x3c/0x70 kernel/locking/spinlock.c:194
spin_unlock_irqrestore include/linux/spinlock.h:405 [inline]
rmqueue_pcplist mm/page_alloc.c:3804 [inline]
rmqueue mm/page_alloc.c:3846 [inline]
get_page_from_freelist+0x75f/0x2d50 mm/page_alloc.c:4285
__alloc_pages+0x1cb/0x5b0 mm/page_alloc.c:5555
__folio_alloc+0x16/0x40 mm/page_alloc.c:5587
vma_alloc_folio+0xfd/0x780 mm/mempolicy.c:2246
shmem_alloc_folio+0x107/0x1d0 mm/shmem.c:1561
shmem_alloc_and_acct_folio+0x15e/0x5d0 mm/shmem.c:1585
shmem_get_folio_gfp+0xb49/0x1a60 mm/shmem.c:1913
shmem_fault+0x1cc/0x8c0 mm/shmem.c:2128
__do_fault+0x107/0x600 mm/memory.c:4203
do_read_fault mm/memory.c:4554 [inline]
do_fault mm/memory.c:4683 [inline]
handle_pte_fault mm/memory.c:4955 [inline]
__handle_mm_fault+0x2184/0x3a40 mm/memory.c:5097
handle_mm_fault+0x1cc/0x780 mm/memory.c:5218
faultin_page mm/gup.c:1009 [inline]
__get_user_pages+0x497/0xf10 mm/gup.c:1230
populate_vma_page_range+0x241/0x320 mm/gup.c:1587
__mm_populate+0x105/0x3b0 mm/gup.c:1701
mm_populate include/linux/mm.h:2744 [inline]
vm_mmap_pgoff+0x201/0x280 mm/util.c:525
ksys_mmap_pgoff+0x7d/0x5a0 mm/mmap.c:1458
do_syscall_32_irqs_on arch/x86/entry/common.c:112 [inline]
__do_fast_syscall_32+0x65/0xf0 arch/x86/entry/common.c:178
do_fast_syscall_32+0x33/0x70 arch/x86/entry/common.c:203
entry_SYSENTER_compat_after_hwframe+0x70/0x82
other info that might help us debug this:
Chain exists of:
&priv->j1939_socks_lock --> &jsk->sk_session_queue_lock --> &priv->active_session_list_lock
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(&priv->active_session_list_lock);
lock(&jsk->sk_session_queue_lock);
lock(&priv->active_session_list_lock);
lock(&priv->j1939_socks_lock);
*** DEADLOCK ***
2 locks held by syz-executor.1/5808:
#0: ffff88807e6c4298 (&mm->mmap_lock#2){++++}-{3:3}, at: mmap_read_lock include/linux/mmap_lock.h:117 [inline]
#0: ffff88807e6c4298 (&mm->mmap_lock#2){++++}-{3:3}, at: __mm_populate+0x228/0x3b0 mm/gup.c:1680
#1: ffff88802a1d9088 (&priv->active_session_list_lock){+.-.}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:355 [inline]
#1: ffff88802a1d9088 (&priv->active_session_list_lock){+.-.}-{2:2}, at: j1939_session_list_lock net/can/j1939/transport.c:238 [inline]
#1: ffff88802a1d9088 (&priv->active_session_list_lock){+.-.}-{2:2}, at: j1939_tp_rxtimer+0xe9/0x220 net/can/j1939/transport.c:1248
stack backtrace:
CPU: 0 PID: 5808 Comm: syz-executor.1 Not tainted 6.1.0-rc5-syzkaller-00018-g59d0d52c30d4 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/26/2022
Call Trace:
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0xd1/0x138 lib/dump_stack.c:106
check_noncircular+0x25f/0x2e0 kernel/locking/lockdep.c:2177
check_prev_add kernel/locking/lockdep.c:3097 [inline]
check_prevs_add kernel/locking/lockdep.c:3216 [inline]
validate_chain kernel/locking/lockdep.c:3831 [inline]
__lock_acquire+0x2a43/0x56d0 kernel/locking/lockdep.c:5055
lock_acquire kernel/locking/lockdep.c:5668 [inline]
lock_acquire+0x1e3/0x630 kernel/locking/lockdep.c:5633
__raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline]
_raw_spin_lock_bh+0x33/0x40 kernel/locking/spinlock.c:178
spin_lock_bh include/linux/spinlock.h:355 [inline]
j1939_sk_errqueue+0xa3/0x1a0 net/can/j1939/socket.c:1081
__j1939_session_cancel+0x3b9/0x460 net/can/j1939/transport.c:1132
j1939_tp_rxtimer.cold+0x1f6/0x24f net/can/j1939/transport.c:1257
__run_hrtimer kernel/time/hrtimer.c:1685 [inline]
__hrtimer_run_queues+0x690/0xfb0 kernel/time/hrtimer.c:1749
hrtimer_run_softirq+0x17f/0x360 kernel/time/hrtimer.c:1766
__do_softirq+0x1fb/0xadc kernel/softirq.c:571
invoke_softirq kernel/softirq.c:445 [inline]
__irq_exit_rcu+0x123/0x180 kernel/softirq.c:650
irq_exit_rcu+0x9/0x20 kernel/softirq.c:662
sysvec_apic_timer_interrupt+0x97/0xc0 arch/x86/kernel/apic/apic.c:1107
asm_sysvec_apic_timer_interrupt+0x1a/0x20 arch/x86/include/asm/idtentry.h:649
RIP: 0010:__raw_spin_unlock_irqrestore include/linux/spinlock_api_smp.h:152 [inline]
RIP: 0010:_raw_spin_unlock_irqrestore+0x3c/0x70 kernel/locking/spinlock.c:194
Code: 74 24 10 e8 b6 85 6e f7 48 89 ef e8 5e f2 6e f7 81 e3 00 02 00 00 75 25 9c 58 f6 c4 02 75 2d 48 85 db 74 01 fb bf 01 00 00 00 6f 7a 61 f7 65 8b 05 d8 fe 0d 76 85 c0 74 0a 5b 5d c3 e8 5c 19
RSP: 0000:ffffc900153172a0 EFLAGS: 00000206
RAX: 0000000000000002 RBX: 0000000000000200 RCX: 1ffffffff22248be
RDX: 0000000000000000 RSI: 0000000000000002 RDI: 0000000000000001
RBP: ffff8880b9a41940 R08: 0000000000000001 R09: ffffffff91110a77
R10: 0000000000000001 R11: 0000000000000000 R12: ffffea0001647540
R13: dffffc0000000000 R14: 0000000000000000 R15: ffff88813fffa700
spin_unlock_irqrestore include/linux/spinlock.h:405 [inline]
rmqueue_pcplist mm/page_alloc.c:3804 [inline]
rmqueue mm/page_alloc.c:3846 [inline]
get_page_from_freelist+0x75f/0x2d50 mm/page_alloc.c:4285
__alloc_pages+0x1cb/0x5b0 mm/page_alloc.c:5555
__folio_alloc+0x16/0x40 mm/page_alloc.c:5587
vma_alloc_folio+0xfd/0x780 mm/mempolicy.c:2246
shmem_alloc_folio+0x107/0x1d0 mm/shmem.c:1561
shmem_alloc_and_acct_folio+0x15e/0x5d0 mm/shmem.c:1585
shmem_get_folio_gfp+0xb49/0x1a60 mm/shmem.c:1913
shmem_fault+0x1cc/0x8c0 mm/shmem.c:2128
__do_fault+0x107/0x600 mm/memory.c:4203
do_read_fault mm/memory.c:4554 [inline]
do_fault mm/memory.c:4683 [inline]
handle_pte_fault mm/memory.c:4955 [inline]
__handle_mm_fault+0x2184/0x3a40 mm/memory.c:5097
handle_mm_fault+0x1cc/0x780 mm/memory.c:5218
faultin_page mm/gup.c:1009 [inline]
__get_user_pages+0x497/0xf10 mm/gup.c:1230
populate_vma_page_range+0x241/0x320 mm/gup.c:1587
__mm_populate+0x105/0x3b0 mm/gup.c:1701
mm_populate include/linux/mm.h:2744 [inline]
vm_mmap_pgoff+0x201/0x280 mm/util.c:525
ksys_mmap_pgoff+0x7d/0x5a0 mm/mmap.c:1458
do_syscall_32_irqs_on arch/x86/entry/common.c:112 [inline]
__do_fast_syscall_32+0x65/0xf0 arch/x86/entry/common.c:178
do_fast_syscall_32+0x33/0x70 arch/x86/entry/common.c:203
entry_SYSENTER_compat_after_hwframe+0x70/0x82
RIP: 0023:0xf7fad549
Code: 03 74 c0 01 10 05 03 74 b8 01 10 06 03 74 b4 01 10 07 03 74 b0 01 10 08 03 74 d8 01 00 00 00 00 00 51 52 55 89 e5 0f 34 cd 80 <5d> 5a 59 c3 90 90 90 90 8d b4 26 00 00 00 00 8d b4 26 00 00 00 00
RSP: 002b:00000000f7fa85cc EFLAGS: 00000296 ORIG_RAX: 00000000000000c0
RAX: ffffffffffffffda RBX: 0000000020000000 RCX: 0000000000b36000
RDX: 0000000003000006 RSI: 0000000000009031 RDI: 00000000ffffffff
RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000
vxcan0: j1939_tp_rxtimer: 0xffff888047c56c00: abort rx timeout. Force session deactivation
----------------
Code disassembly (best guess):
0: 74 24 je 0x26
2: 10 e8 adc %ch,%al
4: b6 85 mov $0x85,%dh
6: 6e outsb %ds:(%rsi),(%dx)
7: f7 48 89 ef e8 5e f2 testl $0xf25ee8ef,-0x77(%rax)
e: 6e outsb %ds:(%rsi),(%dx)
f: f7 81 e3 00 02 00 00 testl $0x9c257500,0x200e3(%rcx)
16: 75 25 9c
19: 58 pop %rax
1a: f6 c4 02 test $0x2,%ah
1d: 75 2d jne 0x4c
1f: 48 85 db test %rbx,%rbx
22: 74 01 je 0x25
24: fb sti
25: bf 01 00 00 00 mov $0x1,%edi
* 2a: e8 6f 7a 61 f7 callq 0xf7617a9e <-- trapping instruction
2f: 65 8b 05 d8 fe 0d 76 mov %gs:0x760dfed8(%rip),%eax # 0x760dff0e
36: 85 c0 test %eax,%eax
38: 74 0a je 0x44
3a: 5b pop %rbx
3b: 5d pop %rbp
3c: c3 retq
3d: e8 .byte 0xe8
3e: 5c pop %rsp
3f: 19 .byte 0x19