====================================================== WARNING: possible circular locking dependency detected 6.1.92-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.3/3582 is trying to acquire lock: ffff88807b86d0f8 (&sbi->alloc_mutex){+.+.}-{3:3}, at: hfsplus_block_free+0xb7/0x4d0 fs/hfsplus/bitmap.c:182 but task is already holding lock: ffff888075264b48 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_truncate+0x2d6/0xb40 fs/hfsplus/extents.c:576 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}: lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x132/0xd80 kernel/locking/mutex.c:747 hfsplus_get_block+0x37f/0x14e0 fs/hfsplus/extents.c:260 block_read_full_folio+0x403/0xf60 fs/buffer.c:2271 filemap_read_folio+0x199/0x780 mm/filemap.c:2461 do_read_cache_folio+0x2ee/0x810 mm/filemap.c:3598 do_read_cache_page+0x32/0x220 mm/filemap.c:3640 read_mapping_page include/linux/pagemap.h:791 [inline] hfsplus_block_allocate+0xea/0x8b0 fs/hfsplus/bitmap.c:37 hfsplus_file_extend+0xa4c/0x1b10 fs/hfsplus/extents.c:468 hfsplus_get_block+0x402/0x14e0 fs/hfsplus/extents.c:245 __block_write_begin_int+0x544/0x1a30 fs/buffer.c:1991 __block_write_begin fs/buffer.c:2041 [inline] block_write_begin+0x98/0x1f0 fs/buffer.c:2102 cont_write_begin+0x63f/0x880 fs/buffer.c:2456 hfsplus_write_begin+0x86/0xd0 fs/hfsplus/inode.c:52 page_symlink+0x2c1/0x4e0 fs/namei.c:5220 hfsplus_symlink+0xc6/0x260 fs/hfsplus/dir.c:449 vfs_symlink+0x247/0x3d0 fs/namei.c:4473 do_symlinkat+0x21e/0x390 fs/namei.c:4502 __do_sys_symlinkat fs/namei.c:4519 [inline] __se_sys_symlinkat fs/namei.c:4516 [inline] __x64_sys_symlinkat+0x95/0xa0 fs/namei.c:4516 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 -> #0 (&sbi->alloc_mutex){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049 lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x132/0xd80 kernel/locking/mutex.c:747 hfsplus_block_free+0xb7/0x4d0 fs/hfsplus/bitmap.c:182 hfsplus_free_extents+0x17a/0xae0 fs/hfsplus/extents.c:363 hfsplus_file_truncate+0x7cc/0xb40 fs/hfsplus/extents.c:591 hfsplus_delete_inode+0x170/0x220 hfsplus_unlink+0x50d/0x7f0 fs/hfsplus/dir.c:405 vfs_unlink+0x359/0x5f0 fs/namei.c:4324 do_unlinkat+0x4a5/0x820 fs/namei.c:4392 __do_sys_unlink fs/namei.c:4440 [inline] __se_sys_unlink fs/namei.c:4438 [inline] __x64_sys_unlink+0x45/0x50 fs/namei.c:4438 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&HFSPLUS_I(inode)->extents_lock); lock(&sbi->alloc_mutex); lock(&HFSPLUS_I(inode)->extents_lock); lock(&sbi->alloc_mutex); *** DEADLOCK *** 5 locks held by syz-executor.3/3582: #0: ffff8880545b2460 (sb_writers#19){.+.+}-{0:0}, at: mnt_want_write+0x3b/0x80 fs/namespace.c:393 #1: ffff88801f224d40 (&type->i_mutex_dir_key#12/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:793 [inline] #1: ffff88801f224d40 (&type->i_mutex_dir_key#12/1){+.+.}-{3:3}, at: do_unlinkat+0x266/0x820 fs/namei.c:4375 #2: ffff888075264d40 (&sb->s_type->i_mutex_key#31){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline] #2: ffff888075264d40 (&sb->s_type->i_mutex_key#31){+.+.}-{3:3}, at: vfs_unlink+0xe0/0x5f0 fs/namei.c:4313 #3: ffff88807b86d198 (&sbi->vh_mutex){+.+.}-{3:3}, at: hfsplus_unlink+0x15d/0x7f0 fs/hfsplus/dir.c:370 #4: ffff888075264b48 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_truncate+0x2d6/0xb40 fs/hfsplus/extents.c:576 stack backtrace: CPU: 0 PID: 3582 Comm: syz-executor.3 Not tainted 6.1.92-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 04/02/2024 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106 check_noncircular+0x2fa/0x3b0 kernel/locking/lockdep.c:2170 check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049 lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x132/0xd80 kernel/locking/mutex.c:747 hfsplus_block_free+0xb7/0x4d0 fs/hfsplus/bitmap.c:182 hfsplus_free_extents+0x17a/0xae0 fs/hfsplus/extents.c:363 hfsplus_file_truncate+0x7cc/0xb40 fs/hfsplus/extents.c:591 hfsplus_delete_inode+0x170/0x220 hfsplus_unlink+0x50d/0x7f0 fs/hfsplus/dir.c:405 vfs_unlink+0x359/0x5f0 fs/namei.c:4324 do_unlinkat+0x4a5/0x820 fs/namei.c:4392 __do_sys_unlink fs/namei.c:4440 [inline] __se_sys_unlink fs/namei.c:4438 [inline] __x64_sys_unlink+0x45/0x50 fs/namei.c:4438 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 RIP: 0033:0x7fa19d27c717 Code: 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48 83 c8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 b8 57 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007ffd78befc78 EFLAGS: 00000206 ORIG_RAX: 0000000000000057 RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007fa19d27c717 RDX: 00007ffd78befca0 RSI: 00007ffd78befd30 RDI: 00007ffd78befd30 RBP: 00007ffd78befd30 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000100 R11: 0000000000000206 R12: 00007ffd78bf0e20 R13: 00007fa19d2d9636 R14: 000000000003308b R15: 0000000000000004 hfsplus: unable to mark blocks free: error -4 hfsplus: can't free extent