device veth131 left promiscuous mode ====================================================== WARNING: possible circular locking dependency detected 5.8.0-rc2-syzkaller #0 Not tainted ------------------------------------------------------ kworker/u4:0/29717 is trying to acquire lock: ffff888086062280 (&vlan_netdev_addr_lock_key/1){+...}-{2:2}, at: netif_addr_lock_nested include/linux/netdevice.h:4243 [inline] ffff888086062280 (&vlan_netdev_addr_lock_key/1){+...}-{2:2}, at: dev_uc_sync_multiple+0xdc/0x190 net/core/dev_addr_lists.c:670 but task is already holding lock: ffff8880947d4280 (&dev_addr_list_lock_key#2/2){+...}-{2:2}, at: netif_addr_lock_nested include/linux/netdevice.h:4243 [inline] ffff8880947d4280 (&dev_addr_list_lock_key#2/2){+...}-{2:2}, at: dev_mc_unsync net/core/dev_addr_lists.c:915 [inline] ffff8880947d4280 (&dev_addr_list_lock_key#2/2){+...}-{2:2}, at: dev_mc_unsync+0xf4/0x190 net/core/dev_addr_lists.c:909 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&dev_addr_list_lock_key#2/2){+...}-{2:2}: _raw_spin_lock_nested+0x30/0x40 kernel/locking/spinlock.c:361 netif_addr_lock_nested include/linux/netdevice.h:4243 [inline] dev_mc_sync+0xdc/0x190 net/core/dev_addr_lists.c:861 vlan_dev_set_rx_mode+0x38/0x80 net/8021q/vlan_dev.c:487 __dev_set_rx_mode+0x1ea/0x300 net/core/dev.c:8207 dev_set_rx_mode net/core/dev.c:8213 [inline] __dev_open+0x321/0x470 net/core/dev.c:1529 __dev_change_flags+0x505/0x660 net/core/dev.c:8286 rtnl_configure_link+0xee/0x230 net/core/rtnetlink.c:3021 __rtnl_newlink+0x10bb/0x1730 net/core/rtnetlink.c:3357 rtnl_newlink+0x64/0xa0 net/core/rtnetlink.c:3397 rtnetlink_rcv_msg+0x44e/0xad0 net/core/rtnetlink.c:5460 netlink_rcv_skb+0x15a/0x430 net/netlink/af_netlink.c:2469 netlink_unicast_kernel net/netlink/af_netlink.c:1303 [inline] netlink_unicast+0x533/0x7d0 net/netlink/af_netlink.c:1329 netlink_sendmsg+0x856/0xd90 net/netlink/af_netlink.c:1918 sock_sendmsg_nosec net/socket.c:652 [inline] sock_sendmsg+0xcf/0x120 net/socket.c:672 ____sys_sendmsg+0x6e8/0x810 net/socket.c:2363 ___sys_sendmsg+0xf3/0x170 net/socket.c:2417 __sys_sendmsg+0xe5/0x1b0 net/socket.c:2450 do_syscall_64+0x60/0xe0 arch/x86/entry/common.c:359 entry_SYSCALL_64_after_hwframe+0x44/0xa9 -> #0 (&vlan_netdev_addr_lock_key/1){+...}-{2:2}: check_prev_add kernel/locking/lockdep.c:2496 [inline] check_prevs_add kernel/locking/lockdep.c:2601 [inline] validate_chain kernel/locking/lockdep.c:3218 [inline] __lock_acquire+0x2acb/0x56e0 kernel/locking/lockdep.c:4380 lock_acquire+0x1f1/0xad0 kernel/locking/lockdep.c:4959 _raw_spin_lock_nested+0x30/0x40 kernel/locking/spinlock.c:361 netif_addr_lock_nested include/linux/netdevice.h:4243 [inline] dev_uc_sync_multiple+0xdc/0x190 net/core/dev_addr_lists.c:670 team_set_rx_mode+0xce/0x220 drivers/net/team/team.c:1779 __dev_set_rx_mode+0x1ea/0x300 net/core/dev.c:8207 dev_mc_unsync net/core/dev_addr_lists.c:917 [inline] dev_mc_unsync+0x139/0x190 net/core/dev_addr_lists.c:909 macsec_dev_stop+0xf1/0x2e0 drivers/net/macsec.c:3557 __dev_close_many+0x1b3/0x2e0 net/core/dev.c:1605 dev_close_many+0x238/0x650 net/core/dev.c:1630 rollback_registered_many+0x3af/0xf60 net/core/dev.c:8953 unregister_netdevice_many.part.0+0x1a/0x2f0 net/core/dev.c:10121 unregister_netdevice_many net/core/dev.c:10120 [inline] default_device_exit_batch+0x30c/0x3d0 net/core/dev.c:10604 ops_exit_list+0x10d/0x160 net/core/net_namespace.c:189 cleanup_net+0x4ea/0xa00 net/core/net_namespace.c:603 process_one_work+0x94c/0x1670 kernel/workqueue.c:2269 worker_thread+0x64c/0x1120 kernel/workqueue.c:2415 kthread+0x3b5/0x4a0 kernel/kthread.c:291 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:293 other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&dev_addr_list_lock_key#2/2); lock(&vlan_netdev_addr_lock_key/1); lock(&dev_addr_list_lock_key#2/2); lock(&vlan_netdev_addr_lock_key/1); *** DEADLOCK *** 7 locks held by kworker/u4:0/29717: #0: ffff8880a97ad138 ((wq_completion)netns){+.+.}-{0:0}, at: arch_atomic64_set arch/x86/include/asm/atomic64_64.h:34 [inline] #0: ffff8880a97ad138 ((wq_completion)netns){+.+.}-{0:0}, at: atomic64_set include/asm-generic/atomic-instrumented.h:856 [inline] #0: ffff8880a97ad138 ((wq_completion)netns){+.+.}-{0:0}, at: atomic_long_set include/asm-generic/atomic-long.h:41 [inline] #0: ffff8880a97ad138 ((wq_completion)netns){+.+.}-{0:0}, at: set_work_data kernel/workqueue.c:616 [inline] #0: ffff8880a97ad138 ((wq_completion)netns){+.+.}-{0:0}, at: set_work_pool_and_clear_pending kernel/workqueue.c:643 [inline] #0: ffff8880a97ad138 ((wq_completion)netns){+.+.}-{0:0}, at: process_one_work+0x82b/0x1670 kernel/workqueue.c:2240 #1: ffffc9000731fda8 (net_cleanup_work){+.+.}-{0:0}, at: process_one_work+0x85f/0x1670 kernel/workqueue.c:2244 #2: ffffffff8a7a48b0 (pernet_ops_rwsem){++++}-{3:3}, at: cleanup_net+0x9b/0xa00 net/core/net_namespace.c:565 #3: ffffffff8a7b1728 (rtnl_mutex){+.+.}-{3:3}, at: rtnl_lock_unregistering net/core/dev.c:10557 [inline] #3: ffffffff8a7b1728 (rtnl_mutex){+.+.}-{3:3}, at: default_device_exit_batch+0xea/0x3d0 net/core/dev.c:10595 #4: ffff888093040280 (&macsec_netdev_addr_lock_key/1){+...}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:358 [inline] #4: ffff888093040280 (&macsec_netdev_addr_lock_key/1){+...}-{2:2}, at: netif_addr_lock_bh include/linux/netdevice.h:4248 [inline] #4: ffff888093040280 (&macsec_netdev_addr_lock_key/1){+...}-{2:2}, at: dev_mc_unsync net/core/dev_addr_lists.c:914 [inline] #4: ffff888093040280 (&macsec_netdev_addr_lock_key/1){+...}-{2:2}, at: dev_mc_unsync+0xb0/0x190 net/core/dev_addr_lists.c:909 #5: ffff8880947d4280 (&dev_addr_list_lock_key#2/2){+...}-{2:2}, at: netif_addr_lock_nested include/linux/netdevice.h:4243 [inline] #5: ffff8880947d4280 (&dev_addr_list_lock_key#2/2){+...}-{2:2}, at: dev_mc_unsync net/core/dev_addr_lists.c:915 [inline] #5: ffff8880947d4280 (&dev_addr_list_lock_key#2/2){+...}-{2:2}, at: dev_mc_unsync+0xf4/0x190 net/core/dev_addr_lists.c:909 #6: ffffffff89bbe640 (rcu_read_lock){....}-{1:2}, at: team_set_rx_mode+0x0/0x220 drivers/net/team/team.c:857 stack backtrace: CPU: 0 PID: 29717 Comm: kworker/u4:0 Not tainted 5.8.0-rc2-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Workqueue: netns cleanup_net Call Trace: __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0x18f/0x20d lib/dump_stack.c:118 check_noncircular+0x324/0x3e0 kernel/locking/lockdep.c:1827 check_prev_add kernel/locking/lockdep.c:2496 [inline] check_prevs_add kernel/locking/lockdep.c:2601 [inline] validate_chain kernel/locking/lockdep.c:3218 [inline] __lock_acquire+0x2acb/0x56e0 kernel/locking/lockdep.c:4380 lock_acquire+0x1f1/0xad0 kernel/locking/lockdep.c:4959 _raw_spin_lock_nested+0x30/0x40 kernel/locking/spinlock.c:361 netif_addr_lock_nested include/linux/netdevice.h:4243 [inline] dev_uc_sync_multiple+0xdc/0x190 net/core/dev_addr_lists.c:670 team_set_rx_mode+0xce/0x220 drivers/net/team/team.c:1779 __dev_set_rx_mode+0x1ea/0x300 net/core/dev.c:8207 dev_mc_unsync net/core/dev_addr_lists.c:917 [inline] dev_mc_unsync+0x139/0x190 net/core/dev_addr_lists.c:909 macsec_dev_stop+0xf1/0x2e0 drivers/net/macsec.c:3557 __dev_close_many+0x1b3/0x2e0 net/core/dev.c:1605 dev_close_many+0x238/0x650 net/core/dev.c:1630 rollback_registered_many+0x3af/0xf60 net/core/dev.c:8953 unregister_netdevice_many.part.0+0x1a/0x2f0 net/core/dev.c:10121 unregister_netdevice_many net/core/dev.c:10120 [inline] default_device_exit_batch+0x30c/0x3d0 net/core/dev.c:10604 ops_exit_list+0x10d/0x160 net/core/net_namespace.c:189 cleanup_net+0x4ea/0xa00 net/core/net_namespace.c:603 process_one_work+0x94c/0x1670 kernel/workqueue.c:2269 worker_thread+0x64c/0x1120 kernel/workqueue.c:2415 kthread+0x3b5/0x4a0 kernel/kthread.c:291 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:293 device team0 left promiscuous mode device vlan3 left promiscuous mode device team_slave_0 left promiscuous mode device team_slave_1 left promiscuous mode device veth1_macvtap left promiscuous mode device veth0_macvtap left promiscuous mode device veth0_vlan left promiscuous mode bond14 (unregistering): Released all slaves team0 (unregistering): Port device vlan3 removed team0 (unregistering): Port device veth129 removed bond13 (unregistering): (slave bridge15): Releasing backup interface device bridge15 left promiscuous mode bond13 (unregistering): Released all slaves bond12 (unregistering): Released all slaves bond11 (unregistering): Released all slaves bond10 (unregistering): Released all slaves bond0 (unregistering): (slave bond9): Releasing backup interface bond9 (unregistering): Released all slaves bond8 (unregistering): (slave bridge8): Releasing backup interface bond8 (unregistering): Released all slaves bond7 (unregistering): Released all slaves bond6 (unregistering): Released all slaves bond5 (unregistering): Released all slaves bond4 (unregistering): (slave bridge3): Releasing backup interface bond4 (unregistering): Released all slaves bond3 (unregistering): Released all slaves bond2 (unregistering): Released all slaves bond1 (unregistering): Released all slaves