====================================================== WARNING: possible circular locking dependency detected 4.19.211-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.2/10615 is trying to acquire lock: 0000000056106411 (&HFSPLUS_I(inode)->extents_lock){+.+.}, at: hfsplus_file_extend+0x1bb/0xf40 fs/hfsplus/extents.c:457 but task is already holding lock: 000000008e95db18 (&tree->tree_lock){+.+.}, at: hfsplus_find_init+0x1b7/0x220 fs/hfsplus/bfind.c:30 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&tree->tree_lock){+.+.}: hfsplus_file_truncate+0xde7/0x1040 fs/hfsplus/extents.c:595 hfsplus_setattr+0x1e7/0x310 fs/hfsplus/inode.c:263 notify_change+0x70b/0xfc0 fs/attr.c:334 do_truncate+0x134/0x1f0 fs/open.c:63 handle_truncate fs/namei.c:3009 [inline] do_last fs/namei.c:3427 [inline] path_openat+0x2308/0x2df0 fs/namei.c:3537 do_filp_open+0x18c/0x3f0 fs/namei.c:3567 do_sys_open+0x3b3/0x520 fs/open.c:1085 do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293 entry_SYSCALL_64_after_hwframe+0x49/0xbe -> #0 (&HFSPLUS_I(inode)->extents_lock){+.+.}: __mutex_lock_common kernel/locking/mutex.c:937 [inline] __mutex_lock+0xd7/0x1190 kernel/locking/mutex.c:1078 hfsplus_file_extend+0x1bb/0xf40 fs/hfsplus/extents.c:457 hfsplus_bmap_reserve+0x298/0x440 fs/hfsplus/btree.c:357 hfsplus_rename_cat+0x272/0x1490 fs/hfsplus/catalog.c:456 hfsplus_unlink+0x49c/0x820 fs/hfsplus/dir.c:376 vfs_unlink+0x27d/0x4e0 fs/namei.c:4002 do_unlinkat+0x3b8/0x660 fs/namei.c:4065 do_coredump+0x1f9c/0x2d60 fs/coredump.c:687 get_signal+0xed9/0x1f70 kernel/signal.c:2583 do_signal+0x8f/0x1670 arch/x86/kernel/signal.c:799 exit_to_usermode_loop+0x204/0x2a0 arch/x86/entry/common.c:163 prepare_exit_to_usermode+0x277/0x2d0 arch/x86/entry/common.c:198 retint_user+0x8/0x18 other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&tree->tree_lock); lock(&HFSPLUS_I(inode)->extents_lock); lock(&tree->tree_lock); lock(&HFSPLUS_I(inode)->extents_lock); *** DEADLOCK *** 5 locks held by syz-executor.2/10615: #0: 00000000dd5e938a (sb_writers#18){.+.+}, at: sb_start_write include/linux/fs.h:1579 [inline] #0: 00000000dd5e938a (sb_writers#18){.+.+}, at: mnt_want_write+0x3a/0xb0 fs/namespace.c:360 #1: 00000000040a1efa (&type->i_mutex_dir_key#9/1){+.+.}, at: inode_lock_nested include/linux/fs.h:783 [inline] #1: 00000000040a1efa (&type->i_mutex_dir_key#9/1){+.+.}, at: do_unlinkat+0x27d/0x660 fs/namei.c:4051 #2: 00000000eb4262bd (&sb->s_type->i_mutex_key#23){+.+.}, at: inode_lock include/linux/fs.h:748 [inline] #2: 00000000eb4262bd (&sb->s_type->i_mutex_key#23){+.+.}, at: vfs_unlink+0xca/0x4e0 fs/namei.c:3993 #3: 000000003d1c5ec9 (&sbi->vh_mutex){+.+.}, at: hfsplus_unlink+0x140/0x820 fs/hfsplus/dir.c:370 #4: 000000008e95db18 (&tree->tree_lock){+.+.}, at: hfsplus_find_init+0x1b7/0x220 fs/hfsplus/bfind.c:30 stack backtrace: CPU: 0 PID: 10615 Comm: syz-executor.2 Not tainted 4.19.211-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/21/2023 Call Trace: __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0x1fc/0x2ef lib/dump_stack.c:118 print_circular_bug.constprop.0.cold+0x2d7/0x41e kernel/locking/lockdep.c:1222 check_prev_add kernel/locking/lockdep.c:1866 [inline] check_prevs_add kernel/locking/lockdep.c:1979 [inline] validate_chain kernel/locking/lockdep.c:2420 [inline] __lock_acquire+0x30c9/0x3ff0 kernel/locking/lockdep.c:3416 lock_acquire+0x170/0x3c0 kernel/locking/lockdep.c:3908 __mutex_lock_common kernel/locking/mutex.c:937 [inline] __mutex_lock+0xd7/0x1190 kernel/locking/mutex.c:1078 hfsplus_file_extend+0x1bb/0xf40 fs/hfsplus/extents.c:457 hfsplus_bmap_reserve+0x298/0x440 fs/hfsplus/btree.c:357 hfsplus_rename_cat+0x272/0x1490 fs/hfsplus/catalog.c:456 hfsplus_unlink+0x49c/0x820 fs/hfsplus/dir.c:376 vfs_unlink+0x27d/0x4e0 fs/namei.c:4002 do_unlinkat+0x3b8/0x660 fs/namei.c:4065 do_coredump+0x1f9c/0x2d60 fs/coredump.c:687 get_signal+0xed9/0x1f70 kernel/signal.c:2583 do_signal+0x8f/0x1670 arch/x86/kernel/signal.c:799 exit_to_usermode_loop+0x204/0x2a0 arch/x86/entry/common.c:163 prepare_exit_to_usermode+0x277/0x2d0 arch/x86/entry/common.c:198 retint_user+0x8/0x18 RIP: 0033: (null) Code: Bad RIP value. RSP: 002b:0000000020000188 EFLAGS: 00010217 RAX: 0000000000000000 RBX: 00007f36a9caf120 RCX: 00007f36a9b8f0f9 RDX: 0000000000000000 RSI: 0000000020000180 RDI: 0000000000000000 RBP: 00007f36a9beaae9 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 00007fff7056baaf R14: 00007f36a80bf300 R15: 0000000000022000 XFS (loop4): Mounting V4 Filesystem XFS (loop4): Ending clean mount kauditd_printk_skb: 1 callbacks suppressed audit: type=1804 audit(1677041381.589:13): pid=10575 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=invalid_pcr cause=open_writers comm="syz-executor.4" name="/root/syzkaller-testdir1211152068/syzkaller.cs9dXt/26/file0/bus" dev="loop4" ino=41 res=1 syz-executor.4 (10575) used greatest stack depth: 21736 bytes left XFS (loop4): Unmounting Filesystem audit: type=1800 audit(1677041381.599:14): pid=10575 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=collect_data cause=failed(directio) comm="syz-executor.4" name="bus" dev="loop4" ino=41 res=0 audit: type=1804 audit(1677041381.679:15): pid=10665 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=invalid_pcr cause=ToMToU comm="syz-executor.4" name="/root/syzkaller-testdir1211152068/syzkaller.cs9dXt/26/file0/bus" dev="loop4" ino=41 res=1 XFS (loop4): Mounting V4 Filesystem XFS (loop4): Ending clean mount XFS (loop3): Mounting V4 Filesystem XFS (loop3): Ending clean mount audit: type=1804 audit(1677041382.780:16): pid=10686 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=invalid_pcr cause=open_writers comm="syz-executor.4" name="/root/syzkaller-testdir1211152068/syzkaller.cs9dXt/27/file0/bus" dev="loop4" ino=41 res=1 XFS (loop5): Mounting V4 Filesystem XFS (loop5): Ending clean mount audit: type=1800 audit(1677041382.780:17): pid=10686 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=collect_data cause=failed(directio) comm="syz-executor.4" name="bus" dev="loop4" ino=41 res=0 audit: type=1804 audit(1677041382.840:18): pid=10688 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=invalid_pcr cause=open_writers comm="syz-executor.3" name="/root/syzkaller-testdir1124660669/syzkaller.V2aVjh/15/file0/bus" dev="loop3" ino=41 res=1 audit: type=1800 audit(1677041382.860:19): pid=10688 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=collect_data cause=failed(directio) comm="syz-executor.3" name="bus" dev="loop3" ino=41 res=0 audit: type=1804 audit(1677041382.900:20): pid=10769 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=invalid_pcr cause=ToMToU comm="syz-executor.4" name="/root/syzkaller-testdir1211152068/syzkaller.cs9dXt/27/file0/bus" dev="loop4" ino=41 res=1 audit: type=1804 audit(1677041382.910:21): pid=10764 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=invalid_pcr cause=ToMToU comm="syz-executor.4" name="/root/syzkaller-testdir1211152068/syzkaller.cs9dXt/27/file0/bus" dev="loop4" ino=41 res=1 audit: type=1804 audit(1677041382.990:22): pid=10783 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=invalid_pcr cause=ToMToU comm="syz-executor.3" name="/root/syzkaller-testdir1124660669/syzkaller.V2aVjh/15/file0/bus" dev="loop3" ino=41 res=1 XFS (loop4): Unmounting Filesystem XFS (loop0): Mounting V4 Filesystem XFS (loop0): Ending clean mount syz-executor.3 (10688) used greatest stack depth: 21688 bytes left XFS (loop3): Unmounting Filesystem syz-executor.5 (10697) used greatest stack depth: 21680 bytes left XFS (loop5): Unmounting Filesystem syz-executor.0 (10695) used greatest stack depth: 21488 bytes left XFS (loop0): Unmounting Filesystem XFS (loop3): Mounting V4 Filesystem XFS (loop3): Ending clean mount XFS (loop5): Mounting V4 Filesystem XFS (loop5): Ending clean mount XFS (loop3): Unmounting Filesystem XFS (loop4): Mounting V4 Filesystem XFS (loop4): Ending clean mount XFS (loop4): Unmounting Filesystem XFS (loop0): Mounting V4 Filesystem XFS (loop5): Unmounting Filesystem XFS (loop0): Ending clean mount XFS (loop0): Unmounting Filesystem XFS (loop3): Mounting V4 Filesystem XFS (loop3): Ending clean mount XFS (loop5): Mounting V4 Filesystem XFS (loop5): Ending clean mount XFS (loop0): Mounting V4 Filesystem XFS (loop0): Ending clean mount XFS (loop3): Unmounting Filesystem XFS (loop5): Unmounting Filesystem XFS (loop0): Unmounting Filesystem XFS (loop5): Mounting V4 Filesystem XFS (loop3): Mounting V4 Filesystem XFS (loop5): Ending clean mount XFS (loop3): Ending clean mount kauditd_printk_skb: 27 callbacks suppressed audit: type=1804 audit(1677041386.990:50): pid=11008 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=invalid_pcr cause=open_writers comm="syz-executor.5" name="/root/syzkaller-testdir1849522343/syzkaller.dn9Y2z/22/file0/bus" dev="loop5" ino=41 res=1 XFS (loop3): Unmounting Filesystem audit: type=1800 audit(1677041387.000:51): pid=11008 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=collect_data cause=failed(directio) comm="syz-executor.5" name="bus" dev="loop5" ino=41 res=0 audit: type=1804 audit(1677041387.080:52): pid=11010 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=invalid_pcr cause=open_writers comm="syz-executor.3" name="/root/syzkaller-testdir1124660669/syzkaller.V2aVjh/18/file0/bus" dev="loop3" ino=41 res=1 XFS (loop0): Mounting V4 Filesystem XFS (loop0): Ending clean mount audit: type=1800 audit(1677041387.080:53): pid=11010 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=collect_data cause=failed(directio) comm="syz-executor.3" name="bus" dev="loop3" ino=41 res=0 XFS (loop5): Unmounting Filesystem audit: type=1804 audit(1677041387.100:54): pid=11010 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=invalid_pcr cause=ToMToU comm="syz-executor.3" name="/root/syzkaller-testdir1124660669/syzkaller.V2aVjh/18/file0/bus" dev="loop3" ino=41 res=1 audit: type=1804 audit(1677041387.370:55): pid=11016 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=invalid_pcr cause=open_writers comm="syz-executor.0" name="/root/syzkaller-testdir3687901467/syzkaller.wxRR88/20/file0/bus" dev="loop0" ino=41 res=1 XFS (loop0): Unmounting Filesystem audit: type=1800 audit(1677041387.370:56): pid=11016 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=collect_data cause=failed(directio) comm="syz-executor.0" name="bus" dev="loop0" ino=41 res=0 XFS (loop3): Mounting V4 Filesystem XFS (loop3): Ending clean mount audit: type=1804 audit(1677041388.290:57): pid=11099 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=invalid_pcr cause=open_writers comm="syz-executor.3" name="/root/syzkaller-testdir1124660669/syzkaller.V2aVjh/19/file0/bus" dev="loop3" ino=41 res=1 XFS (loop5): Mounting V4 Filesystem audit: type=1800 audit(1677041388.320:58): pid=11099 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=collect_data cause=failed(directio) comm="syz-executor.3" name="bus" dev="loop3" ino=41 res=0 XFS (loop5): Ending clean mount XFS (loop3): Unmounting Filesystem audit: type=1804 audit(1677041388.380:59): pid=11099 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=invalid_pcr cause=ToMToU comm="syz-executor.3" name="/root/syzkaller-testdir1124660669/syzkaller.V2aVjh/19/file0/bus" dev="loop3" ino=41 res=1 XFS (loop5): Unmounting Filesystem XFS (loop0): Mounting V4 Filesystem XFS (loop0): Ending clean mount XFS (loop0): Unmounting Filesystem XFS (loop5): Mounting V4 Filesystem XFS (loop3): Mounting V4 Filesystem XFS (loop5): Ending clean mount XFS (loop3): Ending clean mount XFS (loop3): Unmounting Filesystem XFS (loop5): Unmounting Filesystem XFS (loop0): Mounting V4 Filesystem XFS (loop0): Ending clean mount XFS (loop3): Mounting V4 Filesystem XFS (loop3): Ending clean mount XFS (loop3): Unmounting Filesystem XFS (loop0): Unmounting Filesystem