audit: type=1800 audit(1677902091.806:2): pid=9572 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.4" name=".pending_reads" dev="sda1" ino=13913 res=0
overlayfs: fs on './file0' does not support file handles, falling back to index=off.
overlayfs: fs on './file0' does not support file handles, falling back to index=off.
overlayfs: fs on 'file0' does not support file handles, falling back to index=off.
======================================================
WARNING: possible circular locking dependency detected
overlayfs: fs on './file0' does not support file handles, falling back to index=off.
4.14.307-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor.5/9566 is trying to acquire lock:
 (sb_writers#6){.+.+}, at: [<ffffffff818e203a>] sb_start_write include/linux/fs.h:1551 [inline]
 (sb_writers#6){.+.+}, at: [<ffffffff818e203a>] mnt_want_write+0x3a/0xb0 fs/namespace.c:386

but task is already holding lock:
 (&ovl_i_mutex_dir_key[depth]#2){++++}, at: [<ffffffff818f5381>] inode_lock include/linux/fs.h:719 [inline]
 (&ovl_i_mutex_dir_key[depth]#2){++++}, at: [<ffffffff818f5381>] vfs_setxattr+0xb1/0x230 fs/xattr.c:255
overlayfs: fs on './file0' does not support file handles, falling back to index=off.

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&ovl_i_mutex_dir_key[depth]#2){++++}:
       down_write_killable+0x37/0xb0 kernel/locking/rwsem.c:68
       iterate_dir+0x387/0x5e0 fs/readdir.c:43
       ovl_dir_read fs/overlayfs/readdir.c:306 [inline]
       ovl_dir_read_merged+0x2c5/0x430 fs/overlayfs/readdir.c:365
       ovl_check_empty_dir+0x6e/0x200 fs/overlayfs/readdir.c:870
       ovl_check_empty_and_clear+0x72/0xe0 fs/overlayfs/dir.c:306
       ovl_rename+0x57d/0xe50 fs/overlayfs/dir.c:959
       vfs_rename+0x560/0x1820 fs/namei.c:4498
       SYSC_renameat2 fs/namei.c:4646 [inline]
       SyS_renameat2+0x95b/0xad0 fs/namei.c:4535
       do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
       entry_SYSCALL_64_after_hwframe+0x5e/0xd3

-> #0 (sb_writers#6){.+.+}:
       lock_acquire+0x170/0x3f0 kernel/locking/lockdep.c:3998
       percpu_down_read_preempt_disable include/linux/percpu-rwsem.h:36 [inline]
       percpu_down_read include/linux/percpu-rwsem.h:59 [inline]
       __sb_start_write+0x64/0x260 fs/super.c:1342
       sb_start_write include/linux/fs.h:1551 [inline]
       mnt_want_write+0x3a/0xb0 fs/namespace.c:386
       ovl_xattr_set+0x4d/0x290 fs/overlayfs/inode.c:214
       ovl_posix_acl_xattr_set+0x2b7/0x830 fs/overlayfs/super.c:762
       __vfs_setxattr+0xdc/0x130 fs/xattr.c:150
       __vfs_setxattr_noperm+0xfd/0x3d0 fs/xattr.c:181
       __vfs_setxattr_locked+0x14d/0x250 fs/xattr.c:239
       vfs_setxattr+0xcf/0x230 fs/xattr.c:256
       setxattr+0x1a9/0x300 fs/xattr.c:523
       path_setxattr+0x118/0x130 fs/xattr.c:542
       SYSC_lsetxattr fs/xattr.c:564 [inline]
       SyS_lsetxattr+0x33/0x40 fs/xattr.c:560
       do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
       entry_SYSCALL_64_after_hwframe+0x5e/0xd3

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ovl_i_mutex_dir_key[depth]#2);
                               lock(sb_writers#6);
                               lock(&ovl_i_mutex_dir_key[depth]#2);
  lock(sb_writers#6);

 *** DEADLOCK ***

2 locks held by syz-executor.5/9566:
 #0:  (sb_writers#13){.+.+}, at: [<ffffffff818e203a>] sb_start_write include/linux/fs.h:1551 [inline]
 #0:  (sb_writers#13){.+.+}, at: [<ffffffff818e203a>] mnt_want_write+0x3a/0xb0 fs/namespace.c:386
 #1:  (&ovl_i_mutex_dir_key[depth]#2){++++}, at: [<ffffffff818f5381>] inode_lock include/linux/fs.h:719 [inline]
 #1:  (&ovl_i_mutex_dir_key[depth]#2){++++}, at: [<ffffffff818f5381>] vfs_setxattr+0xb1/0x230 fs/xattr.c:255

stack backtrace:
CPU: 0 PID: 9566 Comm: syz-executor.5 Not tainted 4.14.307-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/16/2023
Call Trace:
 __dump_stack lib/dump_stack.c:17 [inline]
 dump_stack+0x1b2/0x281 lib/dump_stack.c:58
 print_circular_bug.constprop.0.cold+0x2d7/0x41e kernel/locking/lockdep.c:1258
 check_prev_add kernel/locking/lockdep.c:1905 [inline]
 check_prevs_add kernel/locking/lockdep.c:2022 [inline]
 validate_chain kernel/locking/lockdep.c:2464 [inline]
 __lock_acquire+0x2e0e/0x3f20 kernel/locking/lockdep.c:3491
 lock_acquire+0x170/0x3f0 kernel/locking/lockdep.c:3998
 percpu_down_read_preempt_disable include/linux/percpu-rwsem.h:36 [inline]
 percpu_down_read include/linux/percpu-rwsem.h:59 [inline]
 __sb_start_write+0x64/0x260 fs/super.c:1342
 sb_start_write include/linux/fs.h:1551 [inline]
 mnt_want_write+0x3a/0xb0 fs/namespace.c:386
 ovl_xattr_set+0x4d/0x290 fs/overlayfs/inode.c:214
 ovl_posix_acl_xattr_set+0x2b7/0x830 fs/overlayfs/super.c:762
 __vfs_setxattr+0xdc/0x130 fs/xattr.c:150
 __vfs_setxattr_noperm+0xfd/0x3d0 fs/xattr.c:181
 __vfs_setxattr_locked+0x14d/0x250 fs/xattr.c:239
 vfs_setxattr+0xcf/0x230 fs/xattr.c:256
 setxattr+0x1a9/0x300 fs/xattr.c:523
 path_setxattr+0x118/0x130 fs/xattr.c:542
 SYSC_lsetxattr fs/xattr.c:564 [inline]
 SyS_lsetxattr+0x33/0x40 fs/xattr.c:560
 do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
 entry_SYSCALL_64_after_hwframe+0x5e/0xd3
RIP: 0033:0x7f629b70c0f9
RSP: 002b:00007f6299c7e168 EFLAGS: 00000246 ORIG_RAX: 00000000000000bd
RAX: ffffffffffffffda RBX: 00007f629b82bf80 RCX: 00007f629b70c0f9
RDX: 0000000020000980 RSI: 0000000020000300 RDI: 00000000200002c0
RBP: 00007f629b767ae9 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000054 R11: 0000000000000246 R12: 0000000000000000
R13: 00007ffcc12c95ff R14: 00007f6299c7e300 R15: 0000000000022000
overlayfs: fs on 'file0' does not support file handles, falling back to index=off.
overlayfs: fs on './file0' does not support file handles, falling back to index=off.
overlayfs: fs on 'file0' does not support file handles, falling back to index=off.
overlayfs: fs on './file0' does not support file handles, falling back to index=off.
base_sock_release(ffff88804280ca40) sk=ffff888095088ac0
base_sock_release(ffff88804abf50c0) sk=ffff888095089340
vhci_hcd vhci_hcd.0: pdev(1) rhport(0) sockfd(3)
vhci_hcd vhci_hcd.0: devid(0) speed(2) speed_str(full-speed)
vhci_hcd vhci_hcd.0: Device attached
vhci_hcd: connection closed
vhci_hcd: stop threads
vhci_hcd: release socket
vhci_hcd: disconnect device
IPVS: ftp: loaded support on port[0] = 21
Can not set IPV6_FL_F_REFLECT if flowlabel_consistency sysctl is enable
audit: type=1800 audit(1677902096.227:3): pid=10261 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.0" name="file0" dev="sda1" ino=13958 res=0
NILFS (loop5): segctord starting. Construction interval = 5 seconds, CP frequency < 30 seconds
EXT4-fs (loop4): Unrecognized mount option "O6^ÅEs" or missing value
 loop1: p4 < >
 loop1: p4 < >
base_sock_release(ffff88804a86c540) sk=ffff888048b98e00
NILFS (loop5): segctord starting. Construction interval = 5 seconds, CP frequency < 30 seconds
 loop1: p4 < >
print_req_error: I/O error, dev loop1, sector 0
EXT4-fs (loop4): Unrecognized mount option "O6^ÅEs" or missing value
NILFS (loop5): segctord starting. Construction interval = 5 seconds, CP frequency < 30 seconds
 loop1: p4 < >
base_sock_release(ffff88804a9250c0) sk=ffff88809cbed200
attempt to access beyond end of device
loop3: rw=1, want=1041, limit=128
EXT4-fs (loop4): Unrecognized mount option "O6^ÅEs" or missing value
autofs4:pid:10435:autofs4_fill_super: called with bogus options
base_sock_release(ffff88804a996480) sk=ffff88809794cb80
NILFS (loop2): segctord starting. Construction interval = 5 seconds, CP frequency < 30 seconds
autofs4:pid:10450:autofs4_fill_super: called with bogus options
F2FS-fs (loop5): Found nat_bits in checkpoint
F2FS-fs (loop5): Mounted with checkpoint version = 48b305e5
audit: type=1800 audit(1677902098.147:4): pid=10420 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.5" name="bus" dev="loop5" ino=10 res=0
attempt to access beyond end of device
loop5: rw=2049, want=45104, limit=40427
autofs4:pid:10482:autofs4_fill_super: called with bogus options
NILFS (loop2): segctord starting. Construction interval = 5 seconds, CP frequency < 30 seconds
autofs4:pid:10505:autofs4_fill_super: called with bogus options
NILFS (loop1): segctord starting. Construction interval = 5 seconds, CP frequency < 30 seconds
IPv6: ADDRCONF(NETDEV_CHANGE): vcan0: link becomes ready
IPv6: ADDRCONF(NETDEV_CHANGE): vcan0: link becomes ready
chnl_net:chnl_net_open(): err: Unable to register and open device, Err:-19
caif:caif_disconnect_client(): nothing to disconnect
chnl_net:chnl_flowctrl_cb(): NET flowctrl func called flow: CLOSE/DEINIT
chnl_net:chnl_net_open(): state disconnected
A link change request failed with some changes committed already. Interface caif0 may have been left with an inconsistent configuration, please check.
F2FS-fs (loop5): Found nat_bits in checkpoint
NILFS (loop2): segctord starting. Construction interval = 5 seconds, CP frequency < 30 seconds
NILFS (loop1): segctord starting. Construction interval = 5 seconds, CP frequency < 30 seconds
F2FS-fs (loop5): Mounted with checkpoint version = 48b305e5
audit: type=1800 audit(1677902099.337:5): pid=10488 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.5" name="bus" dev="loop5" ino=10 res=0
audit: type=1804 audit(1677902099.437:6): pid=10566 uid=0 auid=4294967295 ses=4294967295 op="invalid_pcr" cause="open_writers" comm="syz-executor.0" name="/root/syzkaller-testdir2387631403/syzkaller.Mjt1ad/65/bus" dev="sda1" ino=14031 res=1
attempt to access beyond end of device
loop5: rw=2049, want=45104, limit=40427
audit: type=1804 audit(1677902099.497:7): pid=10570 uid=0 auid=4294967295 ses=4294967295 op="invalid_pcr" cause="open_writers" comm="syz-executor.4" name="/root/syzkaller-testdir2756019367/syzkaller.vndfax/61/bus" dev="sda1" ino=14011 res=1
NILFS (loop2): segctord starting. Construction interval = 5 seconds, CP frequency < 30 seconds
NILFS (loop1): segctord starting. Construction interval = 5 seconds, CP frequency < 30 seconds
F2FS-fs (loop5): Found nat_bits in checkpoint
REISERFS (device loop0): found reiserfs format "3.6" with non-standard journal
REISERFS (device loop0): using ordered data mode
F2FS-fs (loop5): Mounted with checkpoint version = 48b305e5
reiserfs: using flush barriers
REISERFS (device loop0): journal params: device loop0, size 512, journal first block 18, max trans len 256, max batch 225, max commit age 30, max trans age 30
audit: type=1800 audit(1677902100.437:8): pid=10588 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.5" name="bus" dev="loop5" ino=10 res=0
REISERFS (device loop0): checking transaction log (loop0)
netlink: 8 bytes leftover after parsing attributes in process `syz-executor.2'.
Zero length message leads to an empty skb
REISERFS (device loop0): Using r5 hash to sort names
REISERFS (device loop0): Created .reiserfs_priv - reserved for xattr storage.
attempt to access beyond end of device
loop5: rw=2049, want=45104, limit=40427
netlink: 4 bytes leftover after parsing attributes in process `syz-executor.4'.
syz-executor.2 (10645) used greatest stack depth: 25296 bytes left
F2FS-fs (loop5): Found nat_bits in checkpoint
F2FS-fs (loop5): Mounted with checkpoint version = 48b305e5
audit: type=1800 audit(1677902100.907:9): pid=10687 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.5" name="bus" dev="loop5" ino=10 res=0
caif:caif_disconnect_client(): nothing to disconnect
caif:caif_disconnect_client(): nothing to disconnect
can: request_module (can-proto-0) failed.
attempt to access beyond end of device
loop5: rw=2049, want=45104, limit=40427
input: syz1 as /devices/virtual/input/input5
vhci_hcd vhci_hcd.0: pdev(5) rhport(0) sockfd(4)
vhci_hcd vhci_hcd.0: devid(0) speed(5) speed_str(super-speed)
vhci_hcd vhci_hcd.0: Device attached
vhci_hcd: connection closed
vhci_hcd: stop threads
vhci_hcd: release socket
vhci_hcd: disconnect device