====================================================== WARNING: possible circular locking dependency detected 5.15.173-syzkaller #0 Not tainted ------------------------------------------------------ syz.1.288/5414 is trying to acquire lock: ffff0000ea17d488 (&osb->system_file_mutex){+.+.}-{3:3}, at: ocfs2_get_system_file_inode+0x180/0x6b8 fs/ocfs2/sysfile.c:101 but task is already holding lock: ffff0000e86e14a0 (&ocfs2_file_ip_alloc_sem_key){++++}-{3:3}, at: __ocfs2_change_file_space+0x6e4/0xd38 fs/ocfs2/file.c:2018 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&ocfs2_file_ip_alloc_sem_key){++++}-{3:3}: down_read+0xc0/0x398 kernel/locking/rwsem.c:1498 ocfs2_read_virt_blocks+0x298/0x960 fs/ocfs2/extent_map.c:976 ocfs2_read_dir_block fs/ocfs2/dir.c:508 [inline] ocfs2_find_entry_el fs/ocfs2/dir.c:715 [inline] ocfs2_find_entry+0x3ac/0x2450 fs/ocfs2/dir.c:1080 ocfs2_find_files_on_disk+0x10c/0x3d0 fs/ocfs2/dir.c:1982 ocfs2_lookup_ino_from_name+0xb8/0x1d4 fs/ocfs2/dir.c:2004 _ocfs2_get_system_file_inode fs/ocfs2/sysfile.c:136 [inline] ocfs2_get_system_file_inode+0x2c8/0x6b8 fs/ocfs2/sysfile.c:112 ocfs2_init_global_system_inodes+0x2bc/0x618 fs/ocfs2/super.c:458 ocfs2_initialize_super fs/ocfs2/super.c:2276 [inline] ocfs2_fill_super+0x394c/0x498c fs/ocfs2/super.c:995 mount_bdev+0x274/0x370 fs/super.c:1400 ocfs2_mount+0x44/0x58 fs/ocfs2/super.c:1187 legacy_get_tree+0xd4/0x16c fs/fs_context.c:611 vfs_get_tree+0x90/0x274 fs/super.c:1530 do_new_mount+0x278/0x8fc fs/namespace.c:3012 path_mount+0x594/0x101c fs/namespace.c:3342 do_mount fs/namespace.c:3355 [inline] __do_sys_mount fs/namespace.c:3563 [inline] __se_sys_mount fs/namespace.c:3540 [inline] __arm64_sys_mount+0x510/0x5e0 fs/namespace.c:3540 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 -> #0 (&osb->system_file_mutex){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain kernel/locking/lockdep.c:3788 [inline] __lock_acquire+0x32d4/0x7638 kernel/locking/lockdep.c:5012 lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5623 __mutex_lock_common+0x194/0x2154 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0xa4/0xf8 kernel/locking/mutex.c:743 ocfs2_get_system_file_inode+0x180/0x6b8 fs/ocfs2/sysfile.c:101 ocfs2_reserve_suballoc_bits+0x14c/0x416c fs/ocfs2/suballoc.c:776 ocfs2_reserve_cluster_bitmap_bits fs/ocfs2/suballoc.c:1128 [inline] ocfs2_reserve_clusters_with_limit+0x2ac/0xabc fs/ocfs2/suballoc.c:1173 ocfs2_reserve_clusters fs/ocfs2/suballoc.c:1223 [inline] ocfs2_lock_allocators+0x294/0x584 fs/ocfs2/suballoc.c:2669 ocfs2_extend_allocation+0x474/0x18e4 fs/ocfs2/file.c:588 ocfs2_allocate_unwritten_extents+0x2f8/0x8b0 fs/ocfs2/file.c:1499 __ocfs2_change_file_space+0x7c4/0xd38 fs/ocfs2/file.c:2026 ocfs2_fallocate+0x288/0x2e4 fs/ocfs2/file.c:2141 vfs_fallocate+0x478/0x5b4 fs/open.c:308 ksys_fallocate fs/open.c:331 [inline] __do_sys_fallocate fs/open.c:339 [inline] __se_sys_fallocate fs/open.c:337 [inline] __arm64_sys_fallocate+0xc0/0x110 fs/open.c:337 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ocfs2_file_ip_alloc_sem_key); lock(&osb->system_file_mutex); lock(&ocfs2_file_ip_alloc_sem_key); lock(&osb->system_file_mutex); *** DEADLOCK *** 3 locks held by syz.1.288/5414: #0: ffff0000d9f6e460 (sb_writers#21){.+.+}-{0:0}, at: file_start_write include/linux/fs.h:3044 [inline] #0: ffff0000d9f6e460 (sb_writers#21){.+.+}-{0:0}, at: vfs_fallocate+0x404/0x5b4 fs/open.c:307 #1: ffff0000e86e1808 (&sb->s_type->i_mutex_key#28){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline] #1: ffff0000e86e1808 (&sb->s_type->i_mutex_key#28){+.+.}-{3:3}, at: __ocfs2_change_file_space+0x1c4/0xd38 fs/ocfs2/file.c:1952 #2: ffff0000e86e14a0 (&ocfs2_file_ip_alloc_sem_key){++++}-{3:3}, at: __ocfs2_change_file_space+0x6e4/0xd38 fs/ocfs2/file.c:2018 stack backtrace: CPU: 1 PID: 5414 Comm: syz.1.288 Not tainted 5.15.173-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/30/2024 Call trace: dump_backtrace+0x0/0x530 arch/arm64/kernel/stacktrace.c:152 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:216 __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106 dump_stack+0x1c/0x58 lib/dump_stack.c:113 print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2011 check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2133 check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain kernel/locking/lockdep.c:3788 [inline] __lock_acquire+0x32d4/0x7638 kernel/locking/lockdep.c:5012 lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5623 __mutex_lock_common+0x194/0x2154 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0xa4/0xf8 kernel/locking/mutex.c:743 ocfs2_get_system_file_inode+0x180/0x6b8 fs/ocfs2/sysfile.c:101 ocfs2_reserve_suballoc_bits+0x14c/0x416c fs/ocfs2/suballoc.c:776 ocfs2_reserve_cluster_bitmap_bits fs/ocfs2/suballoc.c:1128 [inline] ocfs2_reserve_clusters_with_limit+0x2ac/0xabc fs/ocfs2/suballoc.c:1173 ocfs2_reserve_clusters fs/ocfs2/suballoc.c:1223 [inline] ocfs2_lock_allocators+0x294/0x584 fs/ocfs2/suballoc.c:2669 ocfs2_extend_allocation+0x474/0x18e4 fs/ocfs2/file.c:588 ocfs2_allocate_unwritten_extents+0x2f8/0x8b0 fs/ocfs2/file.c:1499 __ocfs2_change_file_space+0x7c4/0xd38 fs/ocfs2/file.c:2026 ocfs2_fallocate+0x288/0x2e4 fs/ocfs2/file.c:2141 vfs_fallocate+0x478/0x5b4 fs/open.c:308 ksys_fallocate fs/open.c:331 [inline] __do_sys_fallocate fs/open.c:339 [inline] __se_sys_fallocate fs/open.c:337 [inline] __arm64_sys_fallocate+0xc0/0x110 fs/open.c:337 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584