====================================================== WARNING: possible circular locking dependency detected 4.19.211-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.3/7401 is trying to acquire lock: 0000000009327d83 (&HFSPLUS_I(inode)->extents_lock){+.+.}, at: hfsplus_get_block+0x292/0x960 fs/hfsplus/extents.c:260 but task is already holding lock: 000000009fd00aa7 (&tree->tree_lock){+.+.}, at: hfsplus_find_init+0x1b7/0x220 fs/hfsplus/bfind.c:30 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&tree->tree_lock){+.+.}: hfsplus_file_truncate+0xde7/0x1040 fs/hfsplus/extents.c:595 hfsplus_delete_inode+0x18d/0x220 fs/hfsplus/inode.c:419 hfsplus_unlink+0x595/0x820 fs/hfsplus/dir.c:405 hfsplus_rename+0xbe/0x200 fs/hfsplus/dir.c:545 vfs_rename+0x67e/0x1bc0 fs/namei.c:4479 do_renameat2+0xb59/0xc70 fs/namei.c:4629 __do_sys_rename fs/namei.c:4675 [inline] __se_sys_rename fs/namei.c:4673 [inline] __x64_sys_rename+0x5d/0x80 fs/namei.c:4673 do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293 entry_SYSCALL_64_after_hwframe+0x49/0xbe -> #0 (&HFSPLUS_I(inode)->extents_lock){+.+.}: __mutex_lock_common kernel/locking/mutex.c:937 [inline] __mutex_lock+0xd7/0x1190 kernel/locking/mutex.c:1078 hfsplus_get_block+0x292/0x960 fs/hfsplus/extents.c:260 block_read_full_page+0x288/0xd10 fs/buffer.c:2259 do_read_cache_page+0x533/0x1170 mm/filemap.c:2828 read_mapping_page include/linux/pagemap.h:402 [inline] __hfs_bnode_create+0x5b7/0xb60 fs/hfsplus/bnode.c:447 hfsplus_bnode_find+0x2aa/0xb80 fs/hfsplus/bnode.c:497 hfsplus_brec_find+0x2af/0x500 fs/hfsplus/bfind.c:183 hfsplus_brec_read+0x28/0x120 fs/hfsplus/bfind.c:222 hfsplus_find_cat+0x1d0/0x480 fs/hfsplus/catalog.c:202 hfsplus_iget+0x400/0x790 fs/hfsplus/super.c:81 hfsplus_fill_super+0xc5f/0x19e0 fs/hfsplus/super.c:503 mount_bdev+0x2fc/0x3b0 fs/super.c:1158 mount_fs+0xa3/0x310 fs/super.c:1261 vfs_kern_mount.part.0+0x68/0x470 fs/namespace.c:961 vfs_kern_mount fs/namespace.c:951 [inline] do_new_mount fs/namespace.c:2492 [inline] do_mount+0x115c/0x2f50 fs/namespace.c:2822 ksys_mount+0xcf/0x130 fs/namespace.c:3038 __do_sys_mount fs/namespace.c:3052 [inline] __se_sys_mount fs/namespace.c:3049 [inline] __x64_sys_mount+0xba/0x150 fs/namespace.c:3049 do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293 entry_SYSCALL_64_after_hwframe+0x49/0xbe other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&tree->tree_lock); lock(&HFSPLUS_I(inode)->extents_lock); lock(&tree->tree_lock); lock(&HFSPLUS_I(inode)->extents_lock); *** DEADLOCK *** 2 locks held by syz-executor.3/7401: #0: 000000006e0e3e3c (&type->s_umount_key#47/1){+.+.}, at: alloc_super fs/super.c:226 [inline] #0: 000000006e0e3e3c (&type->s_umount_key#47/1){+.+.}, at: sget_userns+0x20b/0xcd0 fs/super.c:519 #1: 000000009fd00aa7 (&tree->tree_lock){+.+.}, at: hfsplus_find_init+0x1b7/0x220 fs/hfsplus/bfind.c:30 stack backtrace: CPU: 1 PID: 7401 Comm: syz-executor.3 Not tainted 4.19.211-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/21/2023 Call Trace: __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0x1fc/0x2ef lib/dump_stack.c:118 print_circular_bug.constprop.0.cold+0x2d7/0x41e kernel/locking/lockdep.c:1222 check_prev_add kernel/locking/lockdep.c:1866 [inline] check_prevs_add kernel/locking/lockdep.c:1979 [inline] validate_chain kernel/locking/lockdep.c:2420 [inline] __lock_acquire+0x30c9/0x3ff0 kernel/locking/lockdep.c:3416 lock_acquire+0x170/0x3c0 kernel/locking/lockdep.c:3908 __mutex_lock_common kernel/locking/mutex.c:937 [inline] __mutex_lock+0xd7/0x1190 kernel/locking/mutex.c:1078 hfsplus_get_block+0x292/0x960 fs/hfsplus/extents.c:260 block_read_full_page+0x288/0xd10 fs/buffer.c:2259 do_read_cache_page+0x533/0x1170 mm/filemap.c:2828 read_mapping_page include/linux/pagemap.h:402 [inline] __hfs_bnode_create+0x5b7/0xb60 fs/hfsplus/bnode.c:447 hfsplus_bnode_find+0x2aa/0xb80 fs/hfsplus/bnode.c:497 hfsplus_brec_find+0x2af/0x500 fs/hfsplus/bfind.c:183 hfsplus_brec_read+0x28/0x120 fs/hfsplus/bfind.c:222 hfsplus_find_cat+0x1d0/0x480 fs/hfsplus/catalog.c:202 hfsplus_iget+0x400/0x790 fs/hfsplus/super.c:81 hfsplus_fill_super+0xc5f/0x19e0 fs/hfsplus/super.c:503 mount_bdev+0x2fc/0x3b0 fs/super.c:1158 mount_fs+0xa3/0x310 fs/super.c:1261 vfs_kern_mount.part.0+0x68/0x470 fs/namespace.c:961 vfs_kern_mount fs/namespace.c:951 [inline] do_new_mount fs/namespace.c:2492 [inline] do_mount+0x115c/0x2f50 fs/namespace.c:2822 ksys_mount+0xcf/0x130 fs/namespace.c:3038 __do_sys_mount fs/namespace.c:3052 [inline] __se_sys_mount fs/namespace.c:3049 [inline] __x64_sys_mount+0xba/0x150 fs/namespace.c:3049 do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293 entry_SYSCALL_64_after_hwframe+0x49/0xbe RIP: 0033:0x7fa3efeb162a Code: 48 c7 c2 b8 ff ff ff f7 d8 64 89 02 b8 ff ff ff ff eb d2 e8 b8 04 00 00 0f 1f 84 00 00 00 00 00 49 89 ca b8 a5 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007fa3ee421f88 EFLAGS: 00000202 ORIG_RAX: 00000000000000a5 RAX: ffffffffffffffda RBX: 0000000000000626 RCX: 00007fa3efeb162a RDX: 0000000020000600 RSI: 0000000020000040 RDI: 00007fa3ee421fe0 RBP: 00007fa3ee422020 R08: 00007fa3ee422020 R09: 000000000000000a R10: 000000000000000a R11: 0000000000000202 R12: 0000000020000600 R13: 0000000020000040 R14: 00007fa3ee421fe0 R15: 0000000020000080 hfsplus: failed to load root directory can: request_module (can-proto-4) failed. ieee80211 phy109: Selected rate control algorithm 'minstrel_ht' hfsplus: failed to load root directory hfsplus: failed to load root directory ieee80211 phy110: Selected rate control algorithm 'minstrel_ht' ieee80211 phy111: Selected rate control algorithm 'minstrel_ht' ieee80211 phy112: Selected rate control algorithm 'minstrel_ht' ieee80211 phy113: Selected rate control algorithm 'minstrel_ht' ieee80211 phy114: Selected rate control algorithm 'minstrel_ht' ieee80211 phy115: Selected rate control algorithm 'minstrel_ht' ieee80211 phy116: Selected rate control algorithm 'minstrel_ht' ieee80211 phy117: Selected rate control algorithm 'minstrel_ht' ieee80211 phy118: Selected rate control algorithm 'minstrel_ht' ieee80211 phy119: Selected rate control algorithm 'minstrel_ht' ieee80211 phy120: Selected rate control algorithm 'minstrel_ht' ieee80211 phy121: Selected rate control algorithm 'minstrel_ht' ieee80211 phy122: Selected rate control algorithm 'minstrel_ht' ieee80211 phy123: Selected rate control algorithm 'minstrel_ht' ieee80211 phy124: Selected rate control algorithm 'minstrel_ht' ieee80211 phy125: Selected rate control algorithm 'minstrel_ht' ieee80211 phy126: Selected rate control algorithm 'minstrel_ht' ieee80211 phy127: Selected rate control algorithm 'minstrel_ht' ieee80211 phy128: Selected rate control algorithm 'minstrel_ht' ieee80211 phy129: Selected rate control algorithm 'minstrel_ht' ieee80211 phy130: Selected rate control algorithm 'minstrel_ht' ieee80211 phy131: Selected rate control algorithm 'minstrel_ht' ieee80211 phy132: Selected rate control algorithm 'minstrel_ht' ieee80211 phy133: Selected rate control algorithm 'minstrel_ht' ieee80211 phy134: Selected rate control algorithm 'minstrel_ht' ieee80211 phy135: Selected rate control algorithm 'minstrel_ht' hfsplus: failed to load root directory ieee80211 phy136: Selected rate control algorithm 'minstrel_ht' can: request_module (can-proto-4) failed. ieee80211 phy137: Selected rate control algorithm 'minstrel_ht' ieee80211 phy138: Selected rate control algorithm 'minstrel_ht' ieee80211 phy139: Selected rate control algorithm 'minstrel_ht' ieee80211 phy140: Selected rate control algorithm 'minstrel_ht' ieee80211 phy141: Selected rate control algorithm 'minstrel_ht' ieee80211 phy142: Selected rate control algorithm 'minstrel_ht' ieee80211 phy143: Selected rate control algorithm 'minstrel_ht' ieee80211 phy144: Selected rate control algorithm 'minstrel_ht' ieee80211 phy145: Selected rate control algorithm 'minstrel_ht' ieee80211 phy146: Selected rate control algorithm 'minstrel_ht' hfsplus: invalid attributes max_key_len 0 hfsplus: failed to load attributes file ieee80211 phy147: Selected rate control algorithm 'minstrel_ht' ieee80211 phy148: Selected rate control algorithm 'minstrel_ht' ieee80211 phy149: Selected rate control algorithm 'minstrel_ht' ieee80211 phy150: Selected rate control algorithm 'minstrel_ht' ieee80211 phy151: Selected rate control algorithm 'minstrel_ht' ieee80211 phy152: Selected rate control algorithm 'minstrel_ht' ieee80211 phy153: Selected rate control algorithm 'minstrel_ht' caif:caif_disconnect_client(): nothing to disconnect ieee80211 phy154: Selected rate control algorithm 'minstrel_ht' caif:caif_disconnect_client(): nothing to disconnect caif:caif_disconnect_client(): nothing to disconnect