ntfs3: loop2: Mark volume as dirty due to NTFS errors ====================================================== WARNING: possible circular locking dependency detected 6.1.90-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.2/6707 is trying to acquire lock: ffff88807b79b5d8 (&mm->mmap_lock){++++}-{3:3}, at: __might_fault+0xa1/0x110 mm/memory.c:5835 but task is already holding lock: ffff888052835980 (&ni->ni_lock/4){+.+.}-{3:3}, at: ni_lock fs/ntfs3/ntfs_fs.h:1099 [inline] ffff888052835980 (&ni->ni_lock/4){+.+.}-{3:3}, at: ntfs_fiemap+0xfb/0x170 fs/ntfs3/file.c:1245 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&ni->ni_lock/4){+.+.}-{3:3}: lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x132/0xd80 kernel/locking/mutex.c:747 ni_lock fs/ntfs3/ntfs_fs.h:1099 [inline] attr_data_get_block+0x429/0x2520 fs/ntfs3/attrib.c:921 ntfs_get_block_vbo+0x373/0xe60 fs/ntfs3/inode.c:590 do_mpage_readpage+0x8d2/0x2040 fs/mpage.c:208 mpage_readahead+0x450/0x920 fs/mpage.c:361 read_pages+0x17f/0x830 mm/readahead.c:161 page_cache_ra_unbounded+0x182/0x7b0 mm/readahead.c:242 do_sync_mmap_readahead+0x7ae/0x980 mm/filemap.c:3107 filemap_fault+0x813/0x17e0 mm/filemap.c:3199 __do_fault+0x136/0x4f0 mm/memory.c:4261 do_read_fault mm/memory.c:4612 [inline] do_fault mm/memory.c:4741 [inline] handle_pte_fault mm/memory.c:5013 [inline] __handle_mm_fault mm/memory.c:5155 [inline] handle_mm_fault+0x3412/0x5340 mm/memory.c:5276 do_user_addr_fault arch/x86/mm/fault.c:1371 [inline] handle_page_fault arch/x86/mm/fault.c:1462 [inline] exc_page_fault+0x26f/0x660 arch/x86/mm/fault.c:1518 asm_exc_page_fault+0x22/0x30 arch/x86/include/asm/idtentry.h:570 fault_in_readable+0x166/0x340 mm/gup.c:1890 fault_in_iov_iter_readable+0xdb/0x270 lib/iov_iter.c:356 generic_perform_write+0x207/0x5e0 mm/filemap.c:3807 __generic_file_write_iter+0x176/0x400 mm/filemap.c:3945 ntfs_file_write_iter+0x5fa/0x6d0 fs/ntfs3/file.c:1166 call_write_iter include/linux/fs.h:2265 [inline] new_sync_write fs/read_write.c:491 [inline] vfs_write+0x7ae/0xba0 fs/read_write.c:584 ksys_write+0x19c/0x2c0 fs/read_write.c:637 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 -> #1 (mapping.invalidate_lock#4){.+.+}-{3:3}: lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 down_read+0xad/0xa30 kernel/locking/rwsem.c:1520 filemap_invalidate_lock_shared include/linux/fs.h:813 [inline] filemap_fault+0x640/0x17e0 mm/filemap.c:3191 __do_fault+0x136/0x4f0 mm/memory.c:4261 do_read_fault mm/memory.c:4612 [inline] do_fault mm/memory.c:4741 [inline] handle_pte_fault mm/memory.c:5013 [inline] __handle_mm_fault mm/memory.c:5155 [inline] handle_mm_fault+0x3412/0x5340 mm/memory.c:5276 faultin_page mm/gup.c:1009 [inline] __get_user_pages+0x4f3/0x1190 mm/gup.c:1233 __get_user_pages_locked mm/gup.c:1437 [inline] get_user_pages_unlocked+0x568/0x8a0 mm/gup.c:2346 __gup_longterm_unlocked mm/gup.c:2957 [inline] internal_get_user_pages_fast+0x2826/0x2cf0 mm/gup.c:3047 __iov_iter_get_pages_alloc+0x3b1/0xa70 lib/iov_iter.c:1460 iov_iter_get_pages2+0xcb/0x120 lib/iov_iter.c:1503 dio_refill_pages fs/direct-io.c:172 [inline] dio_get_page fs/direct-io.c:215 [inline] do_direct_IO fs/direct-io.c:932 [inline] __blockdev_direct_IO+0x13d6/0x4810 fs/direct-io.c:1266 blockdev_direct_IO include/linux/fs.h:3290 [inline] ntfs_direct_IO+0x193/0x360 fs/ntfs3/inode.c:795 generic_file_direct_write+0x204/0x460 mm/filemap.c:3741 __generic_file_write_iter+0x1c4/0x400 mm/filemap.c:3901 ntfs_file_write_iter+0x5fa/0x6d0 fs/ntfs3/file.c:1166 call_write_iter include/linux/fs.h:2265 [inline] new_sync_write fs/read_write.c:491 [inline] vfs_write+0x7ae/0xba0 fs/read_write.c:584 ksys_write+0x19c/0x2c0 fs/read_write.c:637 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 -> #0 (&mm->mmap_lock){++++}-{3:3}: check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049 lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 __might_fault+0xbd/0x110 mm/memory.c:5835 _copy_to_user+0x26/0x130 lib/usercopy.c:36 copy_to_user include/linux/uaccess.h:169 [inline] fiemap_fill_next_extent+0x231/0x410 fs/ioctl.c:144 ni_fiemap+0x1007/0x1230 fs/ntfs3/frecord.c:1949 ntfs_fiemap+0x12e/0x170 fs/ntfs3/file.c:1247 ioctl_fiemap fs/ioctl.c:219 [inline] do_vfs_ioctl+0x18e9/0x2a90 fs/ioctl.c:810 __do_sys_ioctl fs/ioctl.c:868 [inline] __se_sys_ioctl+0x81/0x160 fs/ioctl.c:856 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 other info that might help us debug this: Chain exists of: &mm->mmap_lock --> mapping.invalidate_lock#4 --> &ni->ni_lock/4 Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ni->ni_lock/4); lock(mapping.invalidate_lock#4); lock(&ni->ni_lock/4); lock(&mm->mmap_lock); *** DEADLOCK *** 1 lock held by syz-executor.2/6707: #0: ffff888052835980 (&ni->ni_lock/4){+.+.}-{3:3}, at: ni_lock fs/ntfs3/ntfs_fs.h:1099 [inline] #0: ffff888052835980 (&ni->ni_lock/4){+.+.}-{3:3}, at: ntfs_fiemap+0xfb/0x170 fs/ntfs3/file.c:1245 stack backtrace: CPU: 1 PID: 6707 Comm: syz-executor.2 Not tainted 6.1.90-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 04/02/2024 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106 check_noncircular+0x2fa/0x3b0 kernel/locking/lockdep.c:2170 check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049 lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 __might_fault+0xbd/0x110 mm/memory.c:5835 _copy_to_user+0x26/0x130 lib/usercopy.c:36 copy_to_user include/linux/uaccess.h:169 [inline] fiemap_fill_next_extent+0x231/0x410 fs/ioctl.c:144 ni_fiemap+0x1007/0x1230 fs/ntfs3/frecord.c:1949 ntfs_fiemap+0x12e/0x170 fs/ntfs3/file.c:1247 ioctl_fiemap fs/ioctl.c:219 [inline] do_vfs_ioctl+0x18e9/0x2a90 fs/ioctl.c:810 __do_sys_ioctl fs/ioctl.c:868 [inline] __se_sys_ioctl+0x81/0x160 fs/ioctl.c:856 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 RIP: 0033:0x7f364967dd69 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f364a43e0c8 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 RAX: ffffffffffffffda RBX: 00007f36497abf80 RCX: 00007f364967dd69 RDX: 0000000020000140 RSI: 00000000c020660b RDI: 0000000000000004 RBP: 00007f36496ca49e R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 000000000000000b R14: 00007f36497abf80 R15: 00007ffdebb6e538